Re: [PATCH lttng-tools] Fix: Add missing pthread.h include

Re: [PATCH lttng-tools] Fix: Add missing pthread.h include

[Michael Jeanson]

This should be backported to stable-2.9.

On 2016-12-05 15:39, Michael Jeanson wrote:
> Some libc like musl and uClibc requires explicit includes of pthread.h
> 
> Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
> ---
>  src/common/defaults.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/common/defaults.h b/src/common/defaults.h
> index 27f1ddc..37d222a 100644
> --- a/src/common/defaults.h
> +++ b/src/common/defaults.h
> @@ -20,6 +20,7 @@
>  #ifndef _DEFAULTS_H
>  #define _DEFAULTS_H
>  
> +#include <pthread.h>
>  #include <src/common/macros.h>
>  
>  /* Default unix group name for tracing. */
> 

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [PATCH lttng-tools] Fix: Add missing pthread.h include

[Thomas Petazzoni]

Hello,

On Mon,  5 Dec 2016 15:39:26 -0500, Michael Jeanson wrote:
> Some libc like musl and uClibc requires explicit includes of pthread.h
> 
> Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

This is indeed needed to fix the build on musl, I've integrated your
patch in Buildroot for the time being.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [PATCH lttng-tools] Fix: Add missing pthread.h include

[Jérémie Galarneau]

Merged, thanks!

Jérémie

On 5 December 2016 at 15:39, Michael Jeanson <mjeanson@efficios.com> wrote:
> Some libc like musl and uClibc requires explicit includes of pthread.h
>
> Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
> ---
>  src/common/defaults.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/common/defaults.h b/src/common/defaults.h
> index 27f1ddc..37d222a 100644
> --- a/src/common/defaults.h
> +++ b/src/common/defaults.h
> @@ -20,6 +20,7 @@
>  #ifndef _DEFAULTS_H
>  #define _DEFAULTS_H
>
> +#include <pthread.h>
>  #include <src/common/macros.h>
>
>  /* Default unix group name for tracing. */
> --
> 2.7.4
>



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[PATCH lttng-tools] Fix: Add missing pthread.h include

[Michael Jeanson]

Some libc like musl and uClibc requires explicit includes of pthread.h

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
---
 src/common/defaults.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/common/defaults.h b/src/common/defaults.h
index 27f1ddc..37d222a 100644
--- a/src/common/defaults.h
+++ b/src/common/defaults.h
@@ -20,6 +20,7 @@
 #ifndef _DEFAULTS_H
 #define _DEFAULTS_H
 
+#include <pthread.h>
 #include <src/common/macros.h>
 
 /* Default unix group name for tracing. */
-- 
2.7.4

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev