Re: [PATCH lttng-tools] x is never reused, no need to shift it

From: "Jérémie Galarneau" <jeremie.galarneau@efficios.com>
To: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Cc: "lttng-dev@lists.lttng.org" <lttng-dev@lists.lttng.org>,
	Jeremie Galarneau <jgalar@efficios.com>
Subject: Re: [PATCH lttng-tools] x is never reused, no need to shift it
Date: Wed, 25 Jan 2017 19:32:50 -0500	[thread overview]
Message-ID: <CA+jJMxvPi54_17XUUf9OfjUv1+OdQ64W4Lwri5vuoLQZMkwE5A__16058.4625359208$1485390873$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <1484665651-23987-1-git-send-email-jonathan.rajotte-julien@efficios.com>

Merged in master.

Thanks!
Jérémie

On 17 January 2017 at 10:07, Jonathan Rajotte
<jonathan.rajotte-julien@efficios.com> wrote:
> Also remove noise in scanbuild report.
>
> Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
> ---
>  src/bin/lttng-sessiond/ust-metadata.c | 1 -
>  src/common/compat/string.h            | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/src/bin/lttng-sessiond/ust-metadata.c b/src/bin/lttng-sessiond/ust-metadata.c
> index c1a80c7..fb1f115 100644
> --- a/src/bin/lttng-sessiond/ust-metadata.c
> +++ b/src/bin/lttng-sessiond/ust-metadata.c
> @@ -74,7 +74,6 @@ int fls(unsigned int x)
>                 r -= 2;
>         }
>         if (!(x & 0x80000000U)) {
> -               x <<= 1;
>                 r -= 1;
>         }
>         return r;
> diff --git a/src/common/compat/string.h b/src/common/compat/string.h
> index 7c426ef..db3db80 100644
> --- a/src/common/compat/string.h
> +++ b/src/common/compat/string.h
> @@ -117,7 +117,6 @@ static inline int lttng_fls(int val)
>                 r -= 2;
>         }
>         if (!(x & 0x80000000U)) {
> -               x <<= 1;
>                 r -= 1;
>         }
>         return r;
> --
> 2.7.4
>

-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev