* Re: [PATCH lttng-tools] x is never reused, no need to shift it
[not found] <1484665651-23987-1-git-send-email-jonathan.rajotte-julien@efficios.com>
@ 2017-01-26 0:32 ` Jérémie Galarneau
0 siblings, 0 replies; 2+ messages in thread
From: Jérémie Galarneau @ 2017-01-26 0:32 UTC (permalink / raw)
To: Jonathan Rajotte; +Cc: lttng-dev, Jeremie Galarneau
Merged in master.
Thanks!
Jérémie
On 17 January 2017 at 10:07, Jonathan Rajotte
<jonathan.rajotte-julien@efficios.com> wrote:
> Also remove noise in scanbuild report.
>
> Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
> ---
> src/bin/lttng-sessiond/ust-metadata.c | 1 -
> src/common/compat/string.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/src/bin/lttng-sessiond/ust-metadata.c b/src/bin/lttng-sessiond/ust-metadata.c
> index c1a80c7..fb1f115 100644
> --- a/src/bin/lttng-sessiond/ust-metadata.c
> +++ b/src/bin/lttng-sessiond/ust-metadata.c
> @@ -74,7 +74,6 @@ int fls(unsigned int x)
> r -= 2;
> }
> if (!(x & 0x80000000U)) {
> - x <<= 1;
> r -= 1;
> }
> return r;
> diff --git a/src/common/compat/string.h b/src/common/compat/string.h
> index 7c426ef..db3db80 100644
> --- a/src/common/compat/string.h
> +++ b/src/common/compat/string.h
> @@ -117,7 +117,6 @@ static inline int lttng_fls(int val)
> r -= 2;
> }
> if (!(x & 0x80000000U)) {
> - x <<= 1;
> r -= 1;
> }
> return r;
> --
> 2.7.4
>
--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH lttng-tools] x is never reused, no need to shift it
@ 2017-01-17 15:07 Jonathan Rajotte
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Rajotte @ 2017-01-17 15:07 UTC (permalink / raw)
To: lttng-dev; +Cc: jgalar
Also remove noise in scanbuild report.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
---
src/bin/lttng-sessiond/ust-metadata.c | 1 -
src/common/compat/string.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/src/bin/lttng-sessiond/ust-metadata.c b/src/bin/lttng-sessiond/ust-metadata.c
index c1a80c7..fb1f115 100644
--- a/src/bin/lttng-sessiond/ust-metadata.c
+++ b/src/bin/lttng-sessiond/ust-metadata.c
@@ -74,7 +74,6 @@ int fls(unsigned int x)
r -= 2;
}
if (!(x & 0x80000000U)) {
- x <<= 1;
r -= 1;
}
return r;
diff --git a/src/common/compat/string.h b/src/common/compat/string.h
index 7c426ef..db3db80 100644
--- a/src/common/compat/string.h
+++ b/src/common/compat/string.h
@@ -117,7 +117,6 @@ static inline int lttng_fls(int val)
r -= 2;
}
if (!(x & 0x80000000U)) {
- x <<= 1;
r -= 1;
}
return r;
--
2.7.4
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-26 0:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1484665651-23987-1-git-send-email-jonathan.rajotte-julien@efficios.com>
2017-01-26 0:32 ` [PATCH lttng-tools] x is never reused, no need to shift it Jérémie Galarneau
2017-01-17 15:07 Jonathan Rajotte
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.