* Problem with VirtIO TRIM/DISCARD?
@ 2021-09-24 21:22 Jeppe Øland
0 siblings, 0 replies; only message in thread
From: Jeppe Øland @ 2021-09-24 21:22 UTC (permalink / raw)
To: linux-kernel
I'm experimenting with running VMs on a 4Kn sector array, but I'm
having some issues.
Specifically it seems VirtIO TRIM/DISCARD support may be broken for
non 512B sector sizes.
I started digging, and landed on this commit:
https://github.com/torvalds/linux/commit/af822aa68fbdf0a480a17462ed70232998127453
On line 143 the TRIM/DISCARD size is converted to a sector count - but
it's using a hardcoded sector size of 512.
Shouldn't that be using the actual block size gotten earlier?
Did that code just wipe out a ton of data following the TRIM/DISCARD area?
Regards,
-Jeppe
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-24 21:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24 21:22 Problem with VirtIO TRIM/DISCARD? Jeppe Øland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.