* [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
@ 2022-12-22 19:43 ` Michael S. Tsirkin
0 siblings, 0 replies; 21+ messages in thread
From: Michael S. Tsirkin @ 2022-12-22 19:43 UTC (permalink / raw)
To: Linus Torvalds
Cc: bobby.eshleman, kvm, mst, yuancan, virtualization, weiyongjun1,
elic, set_pte_at, m.szyprowski, almasrymina, sfr, dave,
anders.roxell, lulu, ruanjinjie, sunnanyong, rafaelmendsr,
pizhenwei, eperezma, angus.chen, lkft, colin.i.king, sammler,
nathan, leiyang, harshit.m.mogalapalli, wangjianli, gautam.dawar,
pabeni, dengshaomin, netdev, linux-kernel, stable,
dmitry.fomichev, wangrong68
The following changes since commit 830b3c68c1fb1e9176028d02ef86f3cf76aa2476:
Linux 6.1 (2022-12-11 14:15:18 -0800)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
for you to fetch changes up to 98dd6b2ef50d6f7876606a86c8d8a767c9fef6f5:
virtio_blk: mark all zone fields LE (2022-12-22 14:32:36 -0500)
Note: merging this upstream results in a conflict
between commit:
de4eda9de2d9 ("use less confusing names for iov_iter direction initializers")
from Linus' tree and commit:
("virtio/vsock: replace virtio_vsock_pkt with sk_buff")
from this tree.
This resolution below fixes it up, due to Stephen Rothwell
diff --cc drivers/vhost/vsock.c
index cd6f7776013a,830bc823addc..000000000000
--- a/drivers/vhost/vsock.c
+++ b/drivers/vhost/vsock.c
@@@ -165,8 -157,9 +157,9 @@@ vhost_transport_do_send_pkt(struct vhos
break;
}
- iov_iter_init(&iov_iter, READ, &vq->iov[out], in, iov_len);
+ iov_iter_init(&iov_iter, ITER_DEST, &vq->iov[out], in, iov_len);
- payload_len = pkt->len - pkt->off;
+ payload_len = skb->len;
+ hdr = virtio_vsock_hdr(skb);
/* If the packet is greater than the space available in the
* buffer, we split it using multiple buffers.
@@@ -366,18 -340,21 +340,22 @@@ vhost_vsock_alloc_skb(struct vhost_virt
return NULL;
}
- pkt = kzalloc(sizeof(*pkt), GFP_KERNEL);
- if (!pkt)
+ len = iov_length(vq->iov, out);
+
+ /* len contains both payload and hdr */
+ skb = virtio_vsock_alloc_skb(len, GFP_KERNEL);
+ if (!skb)
return NULL;
- iov_iter_init(&iov_iter, WRITE, vq->iov, out, len);
+ len = iov_length(vq->iov, out);
+ iov_iter_init(&iov_iter, ITER_SOURCE, vq->iov, out, len);
- nbytes = copy_from_iter(&pkt->hdr, sizeof(pkt->hdr), &iov_iter);
- if (nbytes != sizeof(pkt->hdr)) {
+ hdr = virtio_vsock_hdr(skb);
+ nbytes = copy_from_iter(hdr, sizeof(*hdr), &iov_iter);
+ if (nbytes != sizeof(*hdr)) {
vq_err(vq, "Expected %zu bytes for pkt->hdr, got %zu bytes\n",
- sizeof(pkt->hdr), nbytes);
- kfree(pkt);
+ sizeof(*hdr), nbytes);
+ kfree_skb(skb);
return NULL;
}
It can also be found in linux-next, see next-20221220.
----------------------------------------------------------------
virtio,vhost,vdpa: features, fixes, cleanups
zoned block device support
lifetime stats support (for virtio devices backed by memory supporting that)
vsock rework to use skbuffs
ifcvf features provisioning
new SolidNET DPU driver
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
----------------------------------------------------------------
Alvaro Karsz (5):
Add SolidRun vendor id
New PCI quirk for SolidRun SNET DPU.
virtio: vdpa: new SolidNET DPU driver.
virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support
virtio: vdpa: fix snprintf size argument in snet_vdpa driver
Angus Chen (2):
virtio_pci: modify ENOENT to EINVAL
virtio_blk: use UINT_MAX instead of -1U
Bobby Eshleman (1):
virtio/vsock: replace virtio_vsock_pkt with sk_buff
Cindy Lu (2):
vhost_vdpa: fix the crash in unmap a large memory
vdpa_sim_net: should not drop the multicast/broadcast packet
Colin Ian King (1):
RDMA/mlx5: remove variable i
Davidlohr Bueso (2):
tools/virtio: remove stray characters
tools/virtio: remove smp_read_barrier_depends()
Dawei Li (1):
virtio: Implementing attribute show with sysfs_emit
Dmitry Fomichev (2):
virtio-blk: use a helper to handle request queuing errors
virtio-blk: add support for zoned block devices
Eli Cohen (8):
vdpa/mlx5: Fix rule forwarding VLAN to TIR
vdpa/mlx5: Return error on vlan ctrl commands if not supported
vdpa/mlx5: Fix wrong mac address deletion
vdpa/mlx5: Avoid using reslock in event_handler
vdpa/mlx5: Avoid overwriting CVQ iotlb
vdpa/mlx5: Move some definitions to a new header file
vdpa/mlx5: Add debugfs subtree
vdpa/mlx5: Add RX counters to debugfs
Eugenio Pérez (1):
vdpa_sim_net: Offer VIRTIO_NET_F_STATUS
Harshit Mogalapalli (1):
vduse: Validate vq_num in vduse_validate_config()
Jason Wang (2):
vdpa: conditionally fill max max queue pair for stats
vdpasim: fix memory leak when freeing IOTLBs
Michael S. Tsirkin (3):
virtio_blk: temporary variable type tweak
virtio_blk: zone append in header type tweak
virtio_blk: mark all zone fields LE
Michael Sammler (1):
virtio_pmem: populate numa information
Rafael Mendonca (1):
virtio_blk: Fix signedness bug in virtblk_prep_rq()
Ricardo Cañuelo (2):
tools/virtio: initialize spinlocks in vring_test.c
docs: driver-api: virtio: virtio on Linux
Rong Wang (1):
vdpa/vp_vdpa: fix kfree a wrong pointer in vp_vdpa_remove
Shaomin Deng (1):
tools: Delete the unneeded semicolon after curly braces
Shaoqin Huang (2):
virtio_pci: use helper function is_power_of_2()
virtio_ring: use helper function is_power_of_2()
Si-Wei Liu (1):
vdpa: merge functionally duplicated dev_features attributes
Stefano Garzarella (4):
vringh: fix range used in iotlb_translate()
vhost: fix range used in translate_desc()
vhost-vdpa: fix an iotlb memory leak
vdpa_sim: fix vringh initialization in vdpasim_queue_ready()
Wei Yongjun (1):
virtio-crypto: fix memory leak in virtio_crypto_alg_skcipher_close_session()
Yuan Can (1):
vhost/vsock: Fix error handling in vhost_vsock_init()
Zhu Lingshan (12):
vDPA/ifcvf: decouple hw features manipulators from the adapter
vDPA/ifcvf: decouple config space ops from the adapter
vDPA/ifcvf: alloc the mgmt_dev before the adapter
vDPA/ifcvf: decouple vq IRQ releasers from the adapter
vDPA/ifcvf: decouple config IRQ releaser from the adapter
vDPA/ifcvf: decouple vq irq requester from the adapter
vDPA/ifcvf: decouple config/dev IRQ requester and vectors allocator from the adapter
vDPA/ifcvf: ifcvf_request_irq works on ifcvf_hw
vDPA/ifcvf: manage ifcvf_hw in the mgmt_dev
vDPA/ifcvf: allocate the adapter in dev_add()
vDPA/ifcvf: retire ifcvf_private_to_vf
vDPA/ifcvf: implement features provisioning
ruanjinjie (1):
vdpa_sim: fix possible memory leak in vdpasim_net_init() and vdpasim_blk_init()
wangjianli (1):
tools/virtio: Variable type completion
Documentation/driver-api/index.rst | 1 +
Documentation/driver-api/virtio/index.rst | 11 +
Documentation/driver-api/virtio/virtio.rst | 144 +++
.../driver-api/virtio/writing_virtio_drivers.rst | 197 ++++
MAINTAINERS | 6 +
drivers/block/virtio_blk.c | 522 ++++++++-
.../crypto/virtio/virtio_crypto_skcipher_algs.c | 3 +-
drivers/nvdimm/virtio_pmem.c | 11 +-
drivers/pci/quirks.c | 8 +
drivers/vdpa/Kconfig | 22 +
drivers/vdpa/Makefile | 1 +
drivers/vdpa/ifcvf/ifcvf_base.c | 32 +-
drivers/vdpa/ifcvf/ifcvf_base.h | 10 +-
drivers/vdpa/ifcvf/ifcvf_main.c | 162 ++-
drivers/vdpa/mlx5/Makefile | 2 +-
drivers/vdpa/mlx5/core/mlx5_vdpa.h | 5 +-
drivers/vdpa/mlx5/core/mr.c | 46 +-
drivers/vdpa/mlx5/net/debug.c | 152 +++
drivers/vdpa/mlx5/net/mlx5_vnet.c | 252 +++--
drivers/vdpa/mlx5/net/mlx5_vnet.h | 94 ++
drivers/vdpa/solidrun/Makefile | 6 +
drivers/vdpa/solidrun/snet_hwmon.c | 188 ++++
drivers/vdpa/solidrun/snet_main.c | 1111 ++++++++++++++++++++
drivers/vdpa/solidrun/snet_vdpa.h | 196 ++++
drivers/vdpa/vdpa.c | 11 +-
drivers/vdpa/vdpa_sim/vdpa_sim.c | 7 +-
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 4 +-
drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 8 +-
drivers/vdpa/vdpa_user/vduse_dev.c | 3 +
drivers/vdpa/virtio_pci/vp_vdpa.c | 2 +-
drivers/vhost/vdpa.c | 52 +-
drivers/vhost/vhost.c | 4 +-
drivers/vhost/vringh.c | 5 +-
drivers/vhost/vsock.c | 224 ++--
drivers/virtio/virtio.c | 12 +-
drivers/virtio/virtio_pci_modern.c | 4 +-
drivers/virtio/virtio_ring.c | 2 +-
include/linux/pci_ids.h | 2 +
include/linux/virtio_config.h | 8 +-
include/linux/virtio_vsock.h | 126 ++-
include/uapi/linux/vdpa.h | 4 +-
include/uapi/linux/virtio_blk.h | 133 +++
include/uapi/linux/virtio_blk_ioctl.h | 44 +
net/vmw_vsock/virtio_transport.c | 149 +--
net/vmw_vsock/virtio_transport_common.c | 420 ++++----
net/vmw_vsock/vsock_loopback.c | 51 +-
tools/virtio/ringtest/main.h | 37 +-
tools/virtio/virtio-trace/trace-agent-ctl.c | 2 +-
tools/virtio/virtio_test.c | 2 +-
tools/virtio/vringh_test.c | 2 +
50 files changed, 3661 insertions(+), 839 deletions(-)
create mode 100644 Documentation/driver-api/virtio/index.rst
create mode 100644 Documentation/driver-api/virtio/virtio.rst
create mode 100644 Documentation/driver-api/virtio/writing_virtio_drivers.rst
create mode 100644 drivers/vdpa/mlx5/net/debug.c
create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h
create mode 100644 drivers/vdpa/solidrun/Makefile
create mode 100644 drivers/vdpa/solidrun/snet_hwmon.c
create mode 100644 drivers/vdpa/solidrun/snet_main.c
create mode 100644 drivers/vdpa/solidrun/snet_vdpa.h
create mode 100644 include/uapi/linux/virtio_blk_ioctl.h
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 21+ messages in thread
* [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
@ 2022-12-22 19:43 ` Michael S. Tsirkin
0 siblings, 0 replies; 21+ messages in thread
From: Michael S. Tsirkin @ 2022-12-22 19:43 UTC (permalink / raw)
To: Linus Torvalds
Cc: kvm, virtualization, netdev, linux-kernel, almasrymina,
alvaro.karsz, anders.roxell, angus.chen, bobby.eshleman,
colin.i.king, dave, dengshaomin, dmitry.fomichev, elic, eperezma,
gautam.dawar, harshit.m.mogalapalli, jasowang, leiyang,
lingshan.zhu, lkft, lulu, mst, m.szyprowski, nathan, pabeni,
pizhenwei, rafaelmendsr, ricardo.canuelo, ruanjinjie, sammler,
set_pte_at, sfr, sgarzare, shaoqin.huang, si-wei.liu, stable,
stefanha, sunnanyong, wangjianli, wangrong68, weiyongjun1,
xuanzhuo, yuancan
The following changes since commit 830b3c68c1fb1e9176028d02ef86f3cf76aa2476:
Linux 6.1 (2022-12-11 14:15:18 -0800)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
for you to fetch changes up to 98dd6b2ef50d6f7876606a86c8d8a767c9fef6f5:
virtio_blk: mark all zone fields LE (2022-12-22 14:32:36 -0500)
Note: merging this upstream results in a conflict
between commit:
de4eda9de2d9 ("use less confusing names for iov_iter direction initializers")
from Linus' tree and commit:
("virtio/vsock: replace virtio_vsock_pkt with sk_buff")
from this tree.
This resolution below fixes it up, due to Stephen Rothwell
diff --cc drivers/vhost/vsock.c
index cd6f7776013a,830bc823addc..000000000000
--- a/drivers/vhost/vsock.c
+++ b/drivers/vhost/vsock.c
@@@ -165,8 -157,9 +157,9 @@@ vhost_transport_do_send_pkt(struct vhos
break;
}
- iov_iter_init(&iov_iter, READ, &vq->iov[out], in, iov_len);
+ iov_iter_init(&iov_iter, ITER_DEST, &vq->iov[out], in, iov_len);
- payload_len = pkt->len - pkt->off;
+ payload_len = skb->len;
+ hdr = virtio_vsock_hdr(skb);
/* If the packet is greater than the space available in the
* buffer, we split it using multiple buffers.
@@@ -366,18 -340,21 +340,22 @@@ vhost_vsock_alloc_skb(struct vhost_virt
return NULL;
}
- pkt = kzalloc(sizeof(*pkt), GFP_KERNEL);
- if (!pkt)
+ len = iov_length(vq->iov, out);
+
+ /* len contains both payload and hdr */
+ skb = virtio_vsock_alloc_skb(len, GFP_KERNEL);
+ if (!skb)
return NULL;
- iov_iter_init(&iov_iter, WRITE, vq->iov, out, len);
+ len = iov_length(vq->iov, out);
+ iov_iter_init(&iov_iter, ITER_SOURCE, vq->iov, out, len);
- nbytes = copy_from_iter(&pkt->hdr, sizeof(pkt->hdr), &iov_iter);
- if (nbytes != sizeof(pkt->hdr)) {
+ hdr = virtio_vsock_hdr(skb);
+ nbytes = copy_from_iter(hdr, sizeof(*hdr), &iov_iter);
+ if (nbytes != sizeof(*hdr)) {
vq_err(vq, "Expected %zu bytes for pkt->hdr, got %zu bytes\n",
- sizeof(pkt->hdr), nbytes);
- kfree(pkt);
+ sizeof(*hdr), nbytes);
+ kfree_skb(skb);
return NULL;
}
It can also be found in linux-next, see next-20221220.
----------------------------------------------------------------
virtio,vhost,vdpa: features, fixes, cleanups
zoned block device support
lifetime stats support (for virtio devices backed by memory supporting that)
vsock rework to use skbuffs
ifcvf features provisioning
new SolidNET DPU driver
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
----------------------------------------------------------------
Alvaro Karsz (5):
Add SolidRun vendor id
New PCI quirk for SolidRun SNET DPU.
virtio: vdpa: new SolidNET DPU driver.
virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support
virtio: vdpa: fix snprintf size argument in snet_vdpa driver
Angus Chen (2):
virtio_pci: modify ENOENT to EINVAL
virtio_blk: use UINT_MAX instead of -1U
Bobby Eshleman (1):
virtio/vsock: replace virtio_vsock_pkt with sk_buff
Cindy Lu (2):
vhost_vdpa: fix the crash in unmap a large memory
vdpa_sim_net: should not drop the multicast/broadcast packet
Colin Ian King (1):
RDMA/mlx5: remove variable i
Davidlohr Bueso (2):
tools/virtio: remove stray characters
tools/virtio: remove smp_read_barrier_depends()
Dawei Li (1):
virtio: Implementing attribute show with sysfs_emit
Dmitry Fomichev (2):
virtio-blk: use a helper to handle request queuing errors
virtio-blk: add support for zoned block devices
Eli Cohen (8):
vdpa/mlx5: Fix rule forwarding VLAN to TIR
vdpa/mlx5: Return error on vlan ctrl commands if not supported
vdpa/mlx5: Fix wrong mac address deletion
vdpa/mlx5: Avoid using reslock in event_handler
vdpa/mlx5: Avoid overwriting CVQ iotlb
vdpa/mlx5: Move some definitions to a new header file
vdpa/mlx5: Add debugfs subtree
vdpa/mlx5: Add RX counters to debugfs
Eugenio Pérez (1):
vdpa_sim_net: Offer VIRTIO_NET_F_STATUS
Harshit Mogalapalli (1):
vduse: Validate vq_num in vduse_validate_config()
Jason Wang (2):
vdpa: conditionally fill max max queue pair for stats
vdpasim: fix memory leak when freeing IOTLBs
Michael S. Tsirkin (3):
virtio_blk: temporary variable type tweak
virtio_blk: zone append in header type tweak
virtio_blk: mark all zone fields LE
Michael Sammler (1):
virtio_pmem: populate numa information
Rafael Mendonca (1):
virtio_blk: Fix signedness bug in virtblk_prep_rq()
Ricardo Cañuelo (2):
tools/virtio: initialize spinlocks in vring_test.c
docs: driver-api: virtio: virtio on Linux
Rong Wang (1):
vdpa/vp_vdpa: fix kfree a wrong pointer in vp_vdpa_remove
Shaomin Deng (1):
tools: Delete the unneeded semicolon after curly braces
Shaoqin Huang (2):
virtio_pci: use helper function is_power_of_2()
virtio_ring: use helper function is_power_of_2()
Si-Wei Liu (1):
vdpa: merge functionally duplicated dev_features attributes
Stefano Garzarella (4):
vringh: fix range used in iotlb_translate()
vhost: fix range used in translate_desc()
vhost-vdpa: fix an iotlb memory leak
vdpa_sim: fix vringh initialization in vdpasim_queue_ready()
Wei Yongjun (1):
virtio-crypto: fix memory leak in virtio_crypto_alg_skcipher_close_session()
Yuan Can (1):
vhost/vsock: Fix error handling in vhost_vsock_init()
Zhu Lingshan (12):
vDPA/ifcvf: decouple hw features manipulators from the adapter
vDPA/ifcvf: decouple config space ops from the adapter
vDPA/ifcvf: alloc the mgmt_dev before the adapter
vDPA/ifcvf: decouple vq IRQ releasers from the adapter
vDPA/ifcvf: decouple config IRQ releaser from the adapter
vDPA/ifcvf: decouple vq irq requester from the adapter
vDPA/ifcvf: decouple config/dev IRQ requester and vectors allocator from the adapter
vDPA/ifcvf: ifcvf_request_irq works on ifcvf_hw
vDPA/ifcvf: manage ifcvf_hw in the mgmt_dev
vDPA/ifcvf: allocate the adapter in dev_add()
vDPA/ifcvf: retire ifcvf_private_to_vf
vDPA/ifcvf: implement features provisioning
ruanjinjie (1):
vdpa_sim: fix possible memory leak in vdpasim_net_init() and vdpasim_blk_init()
wangjianli (1):
tools/virtio: Variable type completion
Documentation/driver-api/index.rst | 1 +
Documentation/driver-api/virtio/index.rst | 11 +
Documentation/driver-api/virtio/virtio.rst | 144 +++
.../driver-api/virtio/writing_virtio_drivers.rst | 197 ++++
MAINTAINERS | 6 +
drivers/block/virtio_blk.c | 522 ++++++++-
.../crypto/virtio/virtio_crypto_skcipher_algs.c | 3 +-
drivers/nvdimm/virtio_pmem.c | 11 +-
drivers/pci/quirks.c | 8 +
drivers/vdpa/Kconfig | 22 +
drivers/vdpa/Makefile | 1 +
drivers/vdpa/ifcvf/ifcvf_base.c | 32 +-
drivers/vdpa/ifcvf/ifcvf_base.h | 10 +-
drivers/vdpa/ifcvf/ifcvf_main.c | 162 ++-
drivers/vdpa/mlx5/Makefile | 2 +-
drivers/vdpa/mlx5/core/mlx5_vdpa.h | 5 +-
drivers/vdpa/mlx5/core/mr.c | 46 +-
drivers/vdpa/mlx5/net/debug.c | 152 +++
drivers/vdpa/mlx5/net/mlx5_vnet.c | 252 +++--
drivers/vdpa/mlx5/net/mlx5_vnet.h | 94 ++
drivers/vdpa/solidrun/Makefile | 6 +
drivers/vdpa/solidrun/snet_hwmon.c | 188 ++++
drivers/vdpa/solidrun/snet_main.c | 1111 ++++++++++++++++++++
drivers/vdpa/solidrun/snet_vdpa.h | 196 ++++
drivers/vdpa/vdpa.c | 11 +-
drivers/vdpa/vdpa_sim/vdpa_sim.c | 7 +-
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 4 +-
drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 8 +-
drivers/vdpa/vdpa_user/vduse_dev.c | 3 +
drivers/vdpa/virtio_pci/vp_vdpa.c | 2 +-
drivers/vhost/vdpa.c | 52 +-
drivers/vhost/vhost.c | 4 +-
drivers/vhost/vringh.c | 5 +-
drivers/vhost/vsock.c | 224 ++--
drivers/virtio/virtio.c | 12 +-
drivers/virtio/virtio_pci_modern.c | 4 +-
drivers/virtio/virtio_ring.c | 2 +-
include/linux/pci_ids.h | 2 +
include/linux/virtio_config.h | 8 +-
include/linux/virtio_vsock.h | 126 ++-
include/uapi/linux/vdpa.h | 4 +-
include/uapi/linux/virtio_blk.h | 133 +++
include/uapi/linux/virtio_blk_ioctl.h | 44 +
net/vmw_vsock/virtio_transport.c | 149 +--
net/vmw_vsock/virtio_transport_common.c | 420 ++++----
net/vmw_vsock/vsock_loopback.c | 51 +-
tools/virtio/ringtest/main.h | 37 +-
tools/virtio/virtio-trace/trace-agent-ctl.c | 2 +-
tools/virtio/virtio_test.c | 2 +-
tools/virtio/vringh_test.c | 2 +
50 files changed, 3661 insertions(+), 839 deletions(-)
create mode 100644 Documentation/driver-api/virtio/index.rst
create mode 100644 Documentation/driver-api/virtio/virtio.rst
create mode 100644 Documentation/driver-api/virtio/writing_virtio_drivers.rst
create mode 100644 drivers/vdpa/mlx5/net/debug.c
create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h
create mode 100644 drivers/vdpa/solidrun/Makefile
create mode 100644 drivers/vdpa/solidrun/snet_hwmon.c
create mode 100644 drivers/vdpa/solidrun/snet_main.c
create mode 100644 drivers/vdpa/solidrun/snet_vdpa.h
create mode 100644 include/uapi/linux/virtio_blk_ioctl.h
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
2022-12-22 19:43 ` Michael S. Tsirkin
@ 2022-12-23 19:54 ` Linus Torvalds
-1 siblings, 0 replies; 21+ messages in thread
From: Linus Torvalds @ 2022-12-23 19:54 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: kvm, virtualization, netdev, linux-kernel, almasrymina,
alvaro.karsz, anders.roxell, angus.chen, bobby.eshleman,
colin.i.king, dave, dengshaomin, dmitry.fomichev, elic, eperezma,
gautam.dawar, harshit.m.mogalapalli, jasowang, leiyang,
lingshan.zhu, lkft, lulu, m.szyprowski, nathan, pabeni,
pizhenwei, rafaelmendsr, ricardo.canuelo, ruanjinjie, sammler,
set_pte_at, sfr, sgarzare, shaoqin.huang, si-wei.liu, stable,
stefanha, sunnanyong, wangjianli, wangrong68, weiyongjun1,
xuanzhuo, yuancan
On Thu, Dec 22, 2022 at 11:43 AM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
I see none of this in linux-next.
Linus
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
@ 2022-12-23 19:54 ` Linus Torvalds
0 siblings, 0 replies; 21+ messages in thread
From: Linus Torvalds @ 2022-12-23 19:54 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: bobby.eshleman, kvm, sunnanyong, yuancan, virtualization,
weiyongjun1, elic, set_pte_at, m.szyprowski, almasrymina, sfr,
dave, anders.roxell, lulu, ruanjinjie, rafaelmendsr, pizhenwei,
eperezma, angus.chen, lkft, colin.i.king, sammler, nathan,
leiyang, harshit.m.mogalapalli, wangjianli, gautam.dawar, pabeni,
dengshaomin, netdev, linux-kernel, stable, dmitry.fomichev,
wangrong68
On Thu, Dec 22, 2022 at 11:43 AM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
I see none of this in linux-next.
Linus
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
2022-12-23 19:54 ` Linus Torvalds
@ 2022-12-23 22:27 ` Michael S. Tsirkin
-1 siblings, 0 replies; 21+ messages in thread
From: Michael S. Tsirkin @ 2022-12-23 22:27 UTC (permalink / raw)
To: Linus Torvalds
Cc: bobby.eshleman, kvm, sunnanyong, yuancan, virtualization,
weiyongjun1, elic, set_pte_at, m.szyprowski, almasrymina, sfr,
dave, anders.roxell, lulu, ruanjinjie, rafaelmendsr, pizhenwei,
eperezma, angus.chen, lkft, colin.i.king, sammler, nathan,
leiyang, harshit.m.mogalapalli, wangjianli, gautam.dawar, pabeni,
dengshaomin, netdev, linux-kernel, stable, dmitry.fomichev,
wangrong68
On Fri, Dec 23, 2022 at 11:54:41AM -0800, Linus Torvalds wrote:
> On Thu, Dec 22, 2022 at 11:43 AM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
>
> I see none of this in linux-next.
>
> Linus
They were all there, just not as these commits, as I squashed fixups to
avoid bisect breakages with some configs. Did I do wrong?
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
@ 2022-12-23 22:27 ` Michael S. Tsirkin
0 siblings, 0 replies; 21+ messages in thread
From: Michael S. Tsirkin @ 2022-12-23 22:27 UTC (permalink / raw)
To: Linus Torvalds
Cc: kvm, virtualization, netdev, linux-kernel, almasrymina,
alvaro.karsz, anders.roxell, angus.chen, bobby.eshleman,
colin.i.king, dave, dengshaomin, dmitry.fomichev, elic, eperezma,
gautam.dawar, harshit.m.mogalapalli, jasowang, leiyang,
lingshan.zhu, lkft, lulu, m.szyprowski, nathan, pabeni,
pizhenwei, rafaelmendsr, ricardo.canuelo, ruanjinjie, sammler,
set_pte_at, sfr, sgarzare, shaoqin.huang, si-wei.liu, stable,
stefanha, sunnanyong, wangjianli, wangrong68, weiyongjun1,
xuanzhuo, yuancan
On Fri, Dec 23, 2022 at 11:54:41AM -0800, Linus Torvalds wrote:
> On Thu, Dec 22, 2022 at 11:43 AM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
>
> I see none of this in linux-next.
>
> Linus
They were all there, just not as these commits, as I squashed fixups to
avoid bisect breakages with some configs. Did I do wrong?
--
MST
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
2022-12-23 22:27 ` Michael S. Tsirkin
@ 2022-12-23 22:35 ` Michael S. Tsirkin
-1 siblings, 0 replies; 21+ messages in thread
From: Michael S. Tsirkin @ 2022-12-23 22:35 UTC (permalink / raw)
To: Linus Torvalds
Cc: kvm, virtualization, netdev, linux-kernel, almasrymina,
alvaro.karsz, anders.roxell, angus.chen, bobby.eshleman,
colin.i.king, dave, dengshaomin, dmitry.fomichev, elic, eperezma,
gautam.dawar, harshit.m.mogalapalli, jasowang, leiyang,
lingshan.zhu, lkft, lulu, m.szyprowski, nathan, pabeni,
pizhenwei, rafaelmendsr, ricardo.canuelo, ruanjinjie, sammler,
set_pte_at, sfr, sgarzare, shaoqin.huang, si-wei.liu, stable,
stefanha, sunnanyong, wangjianli, wangrong68, weiyongjun1,
xuanzhuo, yuancan
On Fri, Dec 23, 2022 at 05:27:49PM -0500, Michael S. Tsirkin wrote:
> On Fri, Dec 23, 2022 at 11:54:41AM -0800, Linus Torvalds wrote:
> > On Thu, Dec 22, 2022 at 11:43 AM Michael S. Tsirkin <mst@redhat.com> wrote:
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
> >
> > I see none of this in linux-next.
> >
> > Linus
>
> They were all there, just not as these commits, as I squashed fixups to
> avoid bisect breakages with some configs. Did I do wrong?
More specifically, everything up to
458326ec10d1233399a342263d33878cb0afe710 lines up in next-20221220, and
then I decided to rebase to squash bugfixes.
Plus these are two trivial patches on top that just tweak sparse
tags so 0 chance of regressions, and an also trivial security-related bugfix.
> --
> MST
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
@ 2022-12-23 22:35 ` Michael S. Tsirkin
0 siblings, 0 replies; 21+ messages in thread
From: Michael S. Tsirkin @ 2022-12-23 22:35 UTC (permalink / raw)
To: Linus Torvalds
Cc: bobby.eshleman, kvm, sunnanyong, yuancan, virtualization,
weiyongjun1, elic, set_pte_at, m.szyprowski, almasrymina, sfr,
dave, anders.roxell, lulu, ruanjinjie, rafaelmendsr, pizhenwei,
eperezma, angus.chen, lkft, colin.i.king, sammler, nathan,
leiyang, harshit.m.mogalapalli, wangjianli, gautam.dawar, pabeni,
dengshaomin, netdev, linux-kernel, stable, dmitry.fomichev,
wangrong68
On Fri, Dec 23, 2022 at 05:27:49PM -0500, Michael S. Tsirkin wrote:
> On Fri, Dec 23, 2022 at 11:54:41AM -0800, Linus Torvalds wrote:
> > On Thu, Dec 22, 2022 at 11:43 AM Michael S. Tsirkin <mst@redhat.com> wrote:
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
> >
> > I see none of this in linux-next.
> >
> > Linus
>
> They were all there, just not as these commits, as I squashed fixups to
> avoid bisect breakages with some configs. Did I do wrong?
More specifically, everything up to
458326ec10d1233399a342263d33878cb0afe710 lines up in next-20221220, and
then I decided to rebase to squash bugfixes.
Plus these are two trivial patches on top that just tweak sparse
tags so 0 chance of regressions, and an also trivial security-related bugfix.
> --
> MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
2022-12-23 22:27 ` Michael S. Tsirkin
@ 2022-12-23 22:36 ` Linus Torvalds
-1 siblings, 0 replies; 21+ messages in thread
From: Linus Torvalds @ 2022-12-23 22:36 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: kvm, virtualization, netdev, linux-kernel, almasrymina,
alvaro.karsz, anders.roxell, angus.chen, bobby.eshleman,
colin.i.king, dave, dengshaomin, dmitry.fomichev, elic, eperezma,
gautam.dawar, harshit.m.mogalapalli, jasowang, leiyang,
lingshan.zhu, lkft, lulu, m.szyprowski, nathan, pabeni,
pizhenwei, rafaelmendsr, ricardo.canuelo, ruanjinjie, sammler,
set_pte_at, sfr, sgarzare, shaoqin.huang, si-wei.liu, stable,
stefanha, sunnanyong, wangjianli, wangrong68, weiyongjun1,
xuanzhuo, yuancan
On Fri, Dec 23, 2022 at 2:27 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> They were all there, just not as these commits, as I squashed fixups to
> avoid bisect breakages with some configs. Did I do wrong?
I am literally looking at the next-20221214 state right now, doing
git log linus/master.. -- drivers/vhost/vsock.c
git log linus/master.. -- drivers/vdpa/mlx5/
git log --grep="temporary variable type tweak"
and seeing nothing.
So none of these commits - in *any* form - were in linux-next last
week as far as I can tell.
Linus
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
@ 2022-12-23 22:36 ` Linus Torvalds
0 siblings, 0 replies; 21+ messages in thread
From: Linus Torvalds @ 2022-12-23 22:36 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: bobby.eshleman, kvm, sunnanyong, yuancan, virtualization,
weiyongjun1, elic, set_pte_at, m.szyprowski, almasrymina, sfr,
dave, anders.roxell, lulu, ruanjinjie, rafaelmendsr, pizhenwei,
eperezma, angus.chen, lkft, colin.i.king, sammler, nathan,
leiyang, harshit.m.mogalapalli, wangjianli, gautam.dawar, pabeni,
dengshaomin, netdev, linux-kernel, stable, dmitry.fomichev,
wangrong68
On Fri, Dec 23, 2022 at 2:27 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> They were all there, just not as these commits, as I squashed fixups to
> avoid bisect breakages with some configs. Did I do wrong?
I am literally looking at the next-20221214 state right now, doing
git log linus/master.. -- drivers/vhost/vsock.c
git log linus/master.. -- drivers/vdpa/mlx5/
git log --grep="temporary variable type tweak"
and seeing nothing.
So none of these commits - in *any* form - were in linux-next last
week as far as I can tell.
Linus
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
2022-12-23 22:36 ` Linus Torvalds
@ 2022-12-24 5:35 ` Michael S. Tsirkin
-1 siblings, 0 replies; 21+ messages in thread
From: Michael S. Tsirkin @ 2022-12-24 5:35 UTC (permalink / raw)
To: Linus Torvalds
Cc: bobby.eshleman, kvm, sunnanyong, yuancan, virtualization,
weiyongjun1, elic, set_pte_at, m.szyprowski, almasrymina, sfr,
dave, anders.roxell, lulu, ruanjinjie, rafaelmendsr, pizhenwei,
eperezma, angus.chen, lkft, colin.i.king, sammler, nathan,
leiyang, harshit.m.mogalapalli, wangjianli, gautam.dawar, pabeni,
dengshaomin, netdev, linux-kernel, stable, dmitry.fomichev,
wangrong68
On Fri, Dec 23, 2022 at 02:36:46PM -0800, Linus Torvalds wrote:
> On Fri, Dec 23, 2022 at 2:27 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > They were all there, just not as these commits, as I squashed fixups to
> > avoid bisect breakages with some configs. Did I do wrong?
>
> I am literally looking at the next-20221214 state right now, doing
>
> git log linus/master.. -- drivers/vhost/vsock.c
> git log linus/master.. -- drivers/vdpa/mlx5/
> git log --grep="temporary variable type tweak"
>
> and seeing nothing.
>
> So none of these commits - in *any* form - were in linux-next last
> week as far as I can tell.
>
> Linus
They were in next-20221220 though.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
@ 2022-12-24 5:35 ` Michael S. Tsirkin
0 siblings, 0 replies; 21+ messages in thread
From: Michael S. Tsirkin @ 2022-12-24 5:35 UTC (permalink / raw)
To: Linus Torvalds
Cc: kvm, virtualization, netdev, linux-kernel, almasrymina,
alvaro.karsz, anders.roxell, angus.chen, bobby.eshleman,
colin.i.king, dave, dengshaomin, dmitry.fomichev, elic, eperezma,
gautam.dawar, harshit.m.mogalapalli, jasowang, leiyang,
lingshan.zhu, lkft, lulu, m.szyprowski, nathan, pabeni,
pizhenwei, rafaelmendsr, ricardo.canuelo, ruanjinjie, sammler,
set_pte_at, sfr, sgarzare, shaoqin.huang, si-wei.liu, stable,
stefanha, sunnanyong, wangjianli, wangrong68, weiyongjun1,
xuanzhuo, yuancan
On Fri, Dec 23, 2022 at 02:36:46PM -0800, Linus Torvalds wrote:
> On Fri, Dec 23, 2022 at 2:27 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > They were all there, just not as these commits, as I squashed fixups to
> > avoid bisect breakages with some configs. Did I do wrong?
>
> I am literally looking at the next-20221214 state right now, doing
>
> git log linus/master.. -- drivers/vhost/vsock.c
> git log linus/master.. -- drivers/vdpa/mlx5/
> git log --grep="temporary variable type tweak"
>
> and seeing nothing.
>
> So none of these commits - in *any* form - were in linux-next last
> week as far as I can tell.
>
> Linus
They were in next-20221220 though.
--
MST
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
2022-12-24 5:35 ` Michael S. Tsirkin
(?)
@ 2022-12-24 5:49 ` Slade Watkins
-1 siblings, 0 replies; 21+ messages in thread
From: Slade Watkins @ 2022-12-24 5:49 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Linus Torvalds, kvm, virtualization, netdev, linux-kernel,
almasrymina, alvaro.karsz, anders.roxell, angus.chen,
bobby.eshleman, colin.i.king, dave, dengshaomin, dmitry.fomichev,
elic, eperezma, gautam.dawar, harshit.m.mogalapalli, jasowang,
leiyang, lingshan.zhu, lkft, lulu, m.szyprowski, nathan, pabeni,
pizhenwei, rafaelmendsr, ricardo.canuelo, ruanjinjie, sammler,
set_pte_at, sfr, sgarzare, shaoqin.huang, si-wei.liu, stable,
stefanha, sunnanyong, wangjianli, wangrong68, weiyongjun1,
xuanzhuo, yuancan
On Sat, Dec 24, 2022 at 12:36 AM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Fri, Dec 23, 2022 at 02:36:46PM -0800, Linus Torvalds wrote:
> > On Fri, Dec 23, 2022 at 2:27 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> > >
> > > They were all there, just not as these commits, as I squashed fixups to
> > > avoid bisect breakages with some configs. Did I do wrong?
> >
> > I am literally looking at the next-20221214 state right now, doing
> >
> > git log linus/master.. -- drivers/vhost/vsock.c
> > git log linus/master.. -- drivers/vdpa/mlx5/
> > git log --grep="temporary variable type tweak"
> >
> > and seeing nothing.
> >
> > So none of these commits - in *any* form - were in linux-next last
> > week as far as I can tell.
> >
> > Linus
>
>
> They were in next-20221220 though.
>
+1, just checked and these appear to be in next-20221220.
-- Slade
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
2022-12-24 5:35 ` Michael S. Tsirkin
@ 2022-12-24 6:10 ` Linus Torvalds
-1 siblings, 0 replies; 21+ messages in thread
From: Linus Torvalds @ 2022-12-24 6:10 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: kvm, virtualization, netdev, linux-kernel, almasrymina,
alvaro.karsz, anders.roxell, angus.chen, bobby.eshleman,
colin.i.king, dave, dengshaomin, dmitry.fomichev, elic, eperezma,
gautam.dawar, harshit.m.mogalapalli, jasowang, leiyang,
lingshan.zhu, lkft, lulu, m.szyprowski, nathan, pabeni,
pizhenwei, rafaelmendsr, ricardo.canuelo, ruanjinjie, sammler,
set_pte_at, sfr, sgarzare, shaoqin.huang, si-wei.liu, stable,
stefanha, sunnanyong, wangjianli, wangrong68, weiyongjun1,
xuanzhuo, yuancan
On Fri, Dec 23, 2022 at 9:35 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> They were in next-20221220 though.
So, perfect for the *next* merge window.
Do you understand what the word "next" means? We don't call it
"linux-this", do we?
This is not a new rule. Things are supposed to be ready *before* the
merge window (that's what makes it "next", get it?).
I will also point you to to
https://lore.kernel.org/lkml/CAHk-=wj_HcgFZNyZHTLJ7qC2613zphKDtLh6ndciwopZRfH0aQ@mail.gmail.com/
where I'm being pretty damn clear about things.
And before you start bleating about "I needed more heads up", never
mind that this isn't even a new rule, and never mind what that "next"
word means, let me just point to the 6.1-rc6 notice too:
https://lore.kernel.org/lkml/CAHk-=wgUZwX8Sbb8Zvm7FxWVfX6CGuE7x+E16VKoqL7Ok9vv7g@mail.gmail.com/
and if the meaning of "next" has eluded you all these years, maybe it
was high time you learnt. Hmm?
Linus
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
@ 2022-12-24 6:10 ` Linus Torvalds
0 siblings, 0 replies; 21+ messages in thread
From: Linus Torvalds @ 2022-12-24 6:10 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: bobby.eshleman, kvm, sunnanyong, yuancan, virtualization,
weiyongjun1, elic, set_pte_at, m.szyprowski, almasrymina, sfr,
dave, anders.roxell, lulu, ruanjinjie, rafaelmendsr, pizhenwei,
eperezma, angus.chen, lkft, colin.i.king, sammler, nathan,
leiyang, harshit.m.mogalapalli, wangjianli, gautam.dawar, pabeni,
dengshaomin, netdev, linux-kernel, stable, dmitry.fomichev,
wangrong68
On Fri, Dec 23, 2022 at 9:35 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> They were in next-20221220 though.
So, perfect for the *next* merge window.
Do you understand what the word "next" means? We don't call it
"linux-this", do we?
This is not a new rule. Things are supposed to be ready *before* the
merge window (that's what makes it "next", get it?).
I will also point you to to
https://lore.kernel.org/lkml/CAHk-=wj_HcgFZNyZHTLJ7qC2613zphKDtLh6ndciwopZRfH0aQ@mail.gmail.com/
where I'm being pretty damn clear about things.
And before you start bleating about "I needed more heads up", never
mind that this isn't even a new rule, and never mind what that "next"
word means, let me just point to the 6.1-rc6 notice too:
https://lore.kernel.org/lkml/CAHk-=wgUZwX8Sbb8Zvm7FxWVfX6CGuE7x+E16VKoqL7Ok9vv7g@mail.gmail.com/
and if the meaning of "next" has eluded you all these years, maybe it
was high time you learnt. Hmm?
Linus
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
2022-12-24 6:10 ` Linus Torvalds
@ 2022-12-24 11:28 ` Michael S. Tsirkin
-1 siblings, 0 replies; 21+ messages in thread
From: Michael S. Tsirkin @ 2022-12-24 11:28 UTC (permalink / raw)
To: Linus Torvalds
Cc: bobby.eshleman, kvm, sunnanyong, yuancan, virtualization,
weiyongjun1, elic, set_pte_at, m.szyprowski, almasrymina, sfr,
dave, anders.roxell, lulu, ruanjinjie, rafaelmendsr, pizhenwei,
eperezma, angus.chen, lkft, colin.i.king, sammler, nathan,
leiyang, harshit.m.mogalapalli, wangjianli, gautam.dawar, pabeni,
dengshaomin, netdev, linux-kernel, stable, dmitry.fomichev,
wangrong68
On Fri, Dec 23, 2022 at 10:10:30PM -0800, Linus Torvalds wrote:
> On Fri, Dec 23, 2022 at 9:35 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > They were in next-20221220 though.
>
> So, perfect for the *next* merge window.
>
> Do you understand what the word "next" means? We don't call it
> "linux-this", do we?
>
> This is not a new rule. Things are supposed to be ready *before* the
> merge window (that's what makes it "next", get it?).
>
> I will also point you to to
>
> https://lore.kernel.org/lkml/CAHk-=wj_HcgFZNyZHTLJ7qC2613zphKDtLh6ndciwopZRfH0aQ@mail.gmail.com/
>
> where I'm being pretty damn clear about things.
>
> And before you start bleating about "I needed more heads up", never
> mind that this isn't even a new rule, and never mind what that "next"
> word means, let me just point to the 6.1-rc6 notice too:
>
> https://lore.kernel.org/lkml/CAHk-=wgUZwX8Sbb8Zvm7FxWVfX6CGuE7x+E16VKoqL7Ok9vv7g@mail.gmail.com/
>
> and if the meaning of "next" has eluded you all these years, maybe it
> was high time you learnt. Hmm?
>
> Linus
Yea I really screwed up with this one. High time I learned that "no
fallout from testing" most likely does not mean "no bugs" but instead
"you forgot to push to next". Putting procedures in place now to
check automatically.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
@ 2022-12-24 11:28 ` Michael S. Tsirkin
0 siblings, 0 replies; 21+ messages in thread
From: Michael S. Tsirkin @ 2022-12-24 11:28 UTC (permalink / raw)
To: Linus Torvalds
Cc: kvm, virtualization, netdev, linux-kernel, almasrymina,
alvaro.karsz, anders.roxell, angus.chen, bobby.eshleman,
colin.i.king, dave, dengshaomin, dmitry.fomichev, elic, eperezma,
gautam.dawar, harshit.m.mogalapalli, jasowang, leiyang,
lingshan.zhu, lkft, lulu, m.szyprowski, nathan, pabeni,
pizhenwei, rafaelmendsr, ricardo.canuelo, ruanjinjie, sammler,
set_pte_at, sfr, sgarzare, shaoqin.huang, si-wei.liu, stable,
stefanha, sunnanyong, wangjianli, wangrong68, weiyongjun1,
xuanzhuo, yuancan
On Fri, Dec 23, 2022 at 10:10:30PM -0800, Linus Torvalds wrote:
> On Fri, Dec 23, 2022 at 9:35 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > They were in next-20221220 though.
>
> So, perfect for the *next* merge window.
>
> Do you understand what the word "next" means? We don't call it
> "linux-this", do we?
>
> This is not a new rule. Things are supposed to be ready *before* the
> merge window (that's what makes it "next", get it?).
>
> I will also point you to to
>
> https://lore.kernel.org/lkml/CAHk-=wj_HcgFZNyZHTLJ7qC2613zphKDtLh6ndciwopZRfH0aQ@mail.gmail.com/
>
> where I'm being pretty damn clear about things.
>
> And before you start bleating about "I needed more heads up", never
> mind that this isn't even a new rule, and never mind what that "next"
> word means, let me just point to the 6.1-rc6 notice too:
>
> https://lore.kernel.org/lkml/CAHk-=wgUZwX8Sbb8Zvm7FxWVfX6CGuE7x+E16VKoqL7Ok9vv7g@mail.gmail.com/
>
> and if the meaning of "next" has eluded you all these years, maybe it
> was high time you learnt. Hmm?
>
> Linus
Yea I really screwed up with this one. High time I learned that "no
fallout from testing" most likely does not mean "no bugs" but instead
"you forgot to push to next". Putting procedures in place now to
check automatically.
--
MST
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
2023-04-24 21:48 ` Michael S. Tsirkin
@ 2023-04-28 0:31 ` pr-tracker-bot
-1 siblings, 0 replies; 21+ messages in thread
From: pr-tracker-bot @ 2023-04-28 0:31 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Linus Torvalds, kvm, virtualization, netdev, linux-kernel,
alvaro.karsz, christophe.jaillet, elic, eperezma, feliu,
fmdefrancesco, horms, huangjie.albert, jacob.e.keller, jasowang,
lulu, michael.christie, mie, mst, peter, rongtao, rtoax,
sgarzare, simon.horman, stable, viktor, xieyongji, xuanzhuo
The pull request you sent on Mon, 24 Apr 2023 17:48:42 -0400:
> https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/8ccd54fe45713cd458015b5b08d6098545e70543
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
@ 2023-04-28 0:31 ` pr-tracker-bot
0 siblings, 0 replies; 21+ messages in thread
From: pr-tracker-bot @ 2023-04-28 0:31 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: kvm, mst, huangjie.albert, simon.horman, virtualization, rongtao,
rtoax, elic, xuanzhuo, lulu, eperezma, viktor, jacob.e.keller,
fmdefrancesco, christophe.jaillet, peter, netdev, linux-kernel,
stable, xieyongji, mie, horms, Linus Torvalds
The pull request you sent on Mon, 24 Apr 2023 17:48:42 -0400:
> https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/8ccd54fe45713cd458015b5b08d6098545e70543
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 21+ messages in thread
* [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
@ 2023-04-24 21:48 ` Michael S. Tsirkin
0 siblings, 0 replies; 21+ messages in thread
From: Michael S. Tsirkin @ 2023-04-24 21:48 UTC (permalink / raw)
To: Linus Torvalds
Cc: kvm, virtualization, netdev, linux-kernel, alvaro.karsz,
christophe.jaillet, elic, eperezma, feliu, fmdefrancesco, horms,
huangjie.albert, jacob.e.keller, jasowang, lulu,
michael.christie, mie, mst, peter, rongtao, rtoax, sgarzare,
simon.horman, stable, viktor, xieyongji, xuanzhuo
Most exciting stuff this time around has to do with performance.
The following changes since commit 6a8f57ae2eb07ab39a6f0ccad60c760743051026:
Linux 6.3-rc7 (2023-04-16 15:23:53 -0700)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
for you to fetch changes up to c82729e06644f4e087f5ff0f91b8fb15e03b8890:
vhost_vdpa: fix unmap process in no-batch mode (2023-04-21 03:02:36 -0400)
----------------------------------------------------------------
virtio,vhost,vdpa: features, fixes, cleanups
reduction in interrupt rate in virtio
perf improvement for VDUSE
scalability for vhost-scsi
non power of 2 ring support for packed rings
better management for mlx5 vdpa
suspend for snet
VIRTIO_F_NOTIFICATION_DATA
shared backend with vdpa-sim-blk
user VA support in vdpa-sim
better struct packing for virtio
fixes, cleanups all over the place
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
----------------------------------------------------------------
Albert Huang (1):
virtio_ring: don't update event idx on get_buf
Alvaro Karsz (5):
vdpa/snet: support getting and setting VQ state
vdpa/snet: support the suspend vDPA callback
virtio-vdpa: add VIRTIO_F_NOTIFICATION_DATA feature support
vdpa/snet: implement kick_vq_with_data callback
vdpa/snet: use likely/unlikely macros in hot functions
Christophe JAILLET (1):
virtio: Reorder fields in 'struct virtqueue'
Cindy Lu (1):
vhost_vdpa: fix unmap process in no-batch mode
Eli Cohen (3):
vdpa/mlx5: Avoid losing link state updates
vdpa/mlx5: Make VIRTIO_NET_F_MRG_RXBUF off by default
vdpa/mlx5: Extend driver support for new features
Feng Liu (3):
virtio_ring: Avoid using inline for small functions
virtio_ring: Use const to annotate read-only pointer params
virtio_ring: Allow non power of 2 sizes for packed virtqueue
Jacob Keller (1):
vhost: use struct_size and size_add to compute flex array sizes
Mike Christie (5):
vhost-scsi: Delay releasing our refcount on the tpg
vhost-scsi: Drop device mutex use in vhost_scsi_do_plug
vhost-scsi: Check for a cleared backend before queueing an event
vhost-scsi: Drop vhost_scsi_mutex use in port callouts
vhost-scsi: Reduce vhost_scsi_mutex use
Rong Tao (2):
tools/virtio: virtio_test: Fix indentation
tools/virtio: virtio_test -h,--help should return directly
Shunsuke Mie (2):
virtio_ring: add a struct device forward declaration
tools/virtio: fix build caused by virtio_ring changes
Simon Horman (3):
vdpa: address kdoc warnings
vringh: address kdoc warnings
MAINTAINERS: add vringh.h to Virtio Core and Net Drivers
Stefano Garzarella (12):
vringh: fix typos in the vringh_init_* documentation
vdpa: add bind_mm/unbind_mm callbacks
vhost-vdpa: use bind_mm/unbind_mm device callbacks
vringh: replace kmap_atomic() with kmap_local_page()
vringh: define the stride used for translation
vringh: support VA with iotlb
vdpa_sim: make devices agnostic for work management
vdpa_sim: use kthread worker
vdpa_sim: replace the spinlock with a mutex to protect the state
vdpa_sim: add support for user VA
vdpa_sim: move buffer allocation in the devices
vdpa_sim_blk: support shared backend
Viktor Prutyanov (1):
virtio: add VIRTIO_F_NOTIFICATION_DATA feature support
Xie Yongji (11):
lib/group_cpus: Export group_cpus_evenly()
vdpa: Add set/get_vq_affinity callbacks in vdpa_config_ops
virtio-vdpa: Support interrupt affinity spreading mechanism
vduse: Refactor allocation for vduse virtqueues
vduse: Support set_vq_affinity callback
vduse: Support get_vq_affinity callback
vduse: Add sysfs interface for irq callback affinity
vdpa: Add eventfd for the vdpa callback
vduse: Signal vq trigger eventfd directly if possible
vduse: Delay iova domain creation
vduse: Support specifying bounce buffer size via sysfs
Xuan Zhuo (1):
MAINTAINERS: make me a reviewer of VIRTIO CORE AND NET DRIVERS
MAINTAINERS | 2 +
drivers/s390/virtio/virtio_ccw.c | 22 +-
drivers/vdpa/mlx5/net/mlx5_vnet.c | 261 +++++++++++++---------
drivers/vdpa/solidrun/Makefile | 1 +
drivers/vdpa/solidrun/snet_ctrl.c | 330 ++++++++++++++++++++++++++++
drivers/vdpa/solidrun/snet_hwmon.c | 2 +-
drivers/vdpa/solidrun/snet_main.c | 146 ++++++------
drivers/vdpa/solidrun/snet_vdpa.h | 20 +-
drivers/vdpa/vdpa_sim/vdpa_sim.c | 166 +++++++++++---
drivers/vdpa/vdpa_sim/vdpa_sim.h | 14 +-
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 93 ++++++--
drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 38 ++--
drivers/vdpa/vdpa_user/vduse_dev.c | 414 +++++++++++++++++++++++++++++------
drivers/vhost/scsi.c | 102 +++++----
drivers/vhost/vdpa.c | 44 +++-
drivers/vhost/vhost.c | 6 +-
drivers/vhost/vringh.c | 191 ++++++++++++----
drivers/virtio/virtio_mmio.c | 18 +-
drivers/virtio/virtio_pci_modern.c | 22 +-
drivers/virtio/virtio_ring.c | 89 +++++---
drivers/virtio/virtio_vdpa.c | 120 +++++++++-
include/linux/vdpa.h | 52 ++++-
include/linux/virtio.h | 16 +-
include/linux/virtio_ring.h | 3 +
include/linux/vringh.h | 26 ++-
include/uapi/linux/virtio_config.h | 6 +
lib/group_cpus.c | 1 +
tools/include/linux/types.h | 5 +
tools/virtio/linux/compiler.h | 2 +
tools/virtio/linux/kernel.h | 5 +-
tools/virtio/linux/uaccess.h | 11 +-
tools/virtio/virtio_test.c | 12 +-
32 files changed, 1760 insertions(+), 480 deletions(-)
create mode 100644 drivers/vdpa/solidrun/snet_ctrl.c
^ permalink raw reply [flat|nested] 21+ messages in thread
* [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups
@ 2023-04-24 21:48 ` Michael S. Tsirkin
0 siblings, 0 replies; 21+ messages in thread
From: Michael S. Tsirkin @ 2023-04-24 21:48 UTC (permalink / raw)
To: Linus Torvalds
Cc: kvm, mst, huangjie.albert, simon.horman, virtualization, rongtao,
rtoax, elic, xuanzhuo, lulu, eperezma, viktor, jacob.e.keller,
fmdefrancesco, christophe.jaillet, peter, netdev, linux-kernel,
stable, xieyongji, mie, horms
Most exciting stuff this time around has to do with performance.
The following changes since commit 6a8f57ae2eb07ab39a6f0ccad60c760743051026:
Linux 6.3-rc7 (2023-04-16 15:23:53 -0700)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
for you to fetch changes up to c82729e06644f4e087f5ff0f91b8fb15e03b8890:
vhost_vdpa: fix unmap process in no-batch mode (2023-04-21 03:02:36 -0400)
----------------------------------------------------------------
virtio,vhost,vdpa: features, fixes, cleanups
reduction in interrupt rate in virtio
perf improvement for VDUSE
scalability for vhost-scsi
non power of 2 ring support for packed rings
better management for mlx5 vdpa
suspend for snet
VIRTIO_F_NOTIFICATION_DATA
shared backend with vdpa-sim-blk
user VA support in vdpa-sim
better struct packing for virtio
fixes, cleanups all over the place
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
----------------------------------------------------------------
Albert Huang (1):
virtio_ring: don't update event idx on get_buf
Alvaro Karsz (5):
vdpa/snet: support getting and setting VQ state
vdpa/snet: support the suspend vDPA callback
virtio-vdpa: add VIRTIO_F_NOTIFICATION_DATA feature support
vdpa/snet: implement kick_vq_with_data callback
vdpa/snet: use likely/unlikely macros in hot functions
Christophe JAILLET (1):
virtio: Reorder fields in 'struct virtqueue'
Cindy Lu (1):
vhost_vdpa: fix unmap process in no-batch mode
Eli Cohen (3):
vdpa/mlx5: Avoid losing link state updates
vdpa/mlx5: Make VIRTIO_NET_F_MRG_RXBUF off by default
vdpa/mlx5: Extend driver support for new features
Feng Liu (3):
virtio_ring: Avoid using inline for small functions
virtio_ring: Use const to annotate read-only pointer params
virtio_ring: Allow non power of 2 sizes for packed virtqueue
Jacob Keller (1):
vhost: use struct_size and size_add to compute flex array sizes
Mike Christie (5):
vhost-scsi: Delay releasing our refcount on the tpg
vhost-scsi: Drop device mutex use in vhost_scsi_do_plug
vhost-scsi: Check for a cleared backend before queueing an event
vhost-scsi: Drop vhost_scsi_mutex use in port callouts
vhost-scsi: Reduce vhost_scsi_mutex use
Rong Tao (2):
tools/virtio: virtio_test: Fix indentation
tools/virtio: virtio_test -h,--help should return directly
Shunsuke Mie (2):
virtio_ring: add a struct device forward declaration
tools/virtio: fix build caused by virtio_ring changes
Simon Horman (3):
vdpa: address kdoc warnings
vringh: address kdoc warnings
MAINTAINERS: add vringh.h to Virtio Core and Net Drivers
Stefano Garzarella (12):
vringh: fix typos in the vringh_init_* documentation
vdpa: add bind_mm/unbind_mm callbacks
vhost-vdpa: use bind_mm/unbind_mm device callbacks
vringh: replace kmap_atomic() with kmap_local_page()
vringh: define the stride used for translation
vringh: support VA with iotlb
vdpa_sim: make devices agnostic for work management
vdpa_sim: use kthread worker
vdpa_sim: replace the spinlock with a mutex to protect the state
vdpa_sim: add support for user VA
vdpa_sim: move buffer allocation in the devices
vdpa_sim_blk: support shared backend
Viktor Prutyanov (1):
virtio: add VIRTIO_F_NOTIFICATION_DATA feature support
Xie Yongji (11):
lib/group_cpus: Export group_cpus_evenly()
vdpa: Add set/get_vq_affinity callbacks in vdpa_config_ops
virtio-vdpa: Support interrupt affinity spreading mechanism
vduse: Refactor allocation for vduse virtqueues
vduse: Support set_vq_affinity callback
vduse: Support get_vq_affinity callback
vduse: Add sysfs interface for irq callback affinity
vdpa: Add eventfd for the vdpa callback
vduse: Signal vq trigger eventfd directly if possible
vduse: Delay iova domain creation
vduse: Support specifying bounce buffer size via sysfs
Xuan Zhuo (1):
MAINTAINERS: make me a reviewer of VIRTIO CORE AND NET DRIVERS
MAINTAINERS | 2 +
drivers/s390/virtio/virtio_ccw.c | 22 +-
drivers/vdpa/mlx5/net/mlx5_vnet.c | 261 +++++++++++++---------
drivers/vdpa/solidrun/Makefile | 1 +
drivers/vdpa/solidrun/snet_ctrl.c | 330 ++++++++++++++++++++++++++++
drivers/vdpa/solidrun/snet_hwmon.c | 2 +-
drivers/vdpa/solidrun/snet_main.c | 146 ++++++------
drivers/vdpa/solidrun/snet_vdpa.h | 20 +-
drivers/vdpa/vdpa_sim/vdpa_sim.c | 166 +++++++++++---
drivers/vdpa/vdpa_sim/vdpa_sim.h | 14 +-
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 93 ++++++--
drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 38 ++--
drivers/vdpa/vdpa_user/vduse_dev.c | 414 +++++++++++++++++++++++++++++------
drivers/vhost/scsi.c | 102 +++++----
drivers/vhost/vdpa.c | 44 +++-
drivers/vhost/vhost.c | 6 +-
drivers/vhost/vringh.c | 191 ++++++++++++----
drivers/virtio/virtio_mmio.c | 18 +-
drivers/virtio/virtio_pci_modern.c | 22 +-
drivers/virtio/virtio_ring.c | 89 +++++---
drivers/virtio/virtio_vdpa.c | 120 +++++++++-
include/linux/vdpa.h | 52 ++++-
include/linux/virtio.h | 16 +-
include/linux/virtio_ring.h | 3 +
include/linux/vringh.h | 26 ++-
include/uapi/linux/virtio_config.h | 6 +
lib/group_cpus.c | 1 +
tools/include/linux/types.h | 5 +
tools/virtio/linux/compiler.h | 2 +
tools/virtio/linux/kernel.h | 5 +-
tools/virtio/linux/uaccess.h | 11 +-
tools/virtio/virtio_test.c | 12 +-
32 files changed, 1760 insertions(+), 480 deletions(-)
create mode 100644 drivers/vdpa/solidrun/snet_ctrl.c
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2023-04-28 0:31 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-22 19:43 [GIT PULL] virtio,vhost,vdpa: features, fixes, cleanups Michael S. Tsirkin
2022-12-22 19:43 ` Michael S. Tsirkin
2022-12-23 19:54 ` Linus Torvalds
2022-12-23 19:54 ` Linus Torvalds
2022-12-23 22:27 ` Michael S. Tsirkin
2022-12-23 22:27 ` Michael S. Tsirkin
2022-12-23 22:35 ` Michael S. Tsirkin
2022-12-23 22:35 ` Michael S. Tsirkin
2022-12-23 22:36 ` Linus Torvalds
2022-12-23 22:36 ` Linus Torvalds
2022-12-24 5:35 ` Michael S. Tsirkin
2022-12-24 5:35 ` Michael S. Tsirkin
2022-12-24 5:49 ` Slade Watkins
2022-12-24 6:10 ` Linus Torvalds
2022-12-24 6:10 ` Linus Torvalds
2022-12-24 11:28 ` Michael S. Tsirkin
2022-12-24 11:28 ` Michael S. Tsirkin
2023-04-24 21:48 Michael S. Tsirkin
2023-04-24 21:48 ` Michael S. Tsirkin
2023-04-28 0:31 ` pr-tracker-bot
2023-04-28 0:31 ` pr-tracker-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.