From: Seungwhan Youn <claude.youn@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Grant Likely <grant.likely@secretlab.ca>,
Jassi Brar <jassisinghbrar@gmail.com>, Liam Girdwood <lrg@ti.com>,
Boojin Kim <boojin.kim@samsung.com>
Subject: Re: [PATCH 7/7] ASoC: Samsung: Update DMA interface
Date: Tue, 5 Jul 2011 16:45:30 +0900 [thread overview]
Message-ID: <CA+s+8rf3oBFe7TcEnWqh1L51FuN59uU0F=RTgargOFGJN+f7XA@mail.gmail.com> (raw)
In-Reply-To: <20110704170259.GC28726@opensource.wolfsonmicro.com>
> Two questions here:
>
> - It looks like a lot of this code can be shared between all the drivers
> using the dmaengine API. Is there any reason not to factor it out?
> - Should this not be adding a new driver for dmaengine based Samsung
> CPUs? The ifdefs are very big.
I think that dma code looks very similar to current one, so how about
using platform_resource setting for dma type and make some inline
functions to cover these differences? We already have platform driver
for dma in arch/arm and dev-audio.c.
WARNING: multiple messages have this Message-ID (diff)
From: claude.youn@gmail.com (Seungwhan Youn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] ASoC: Samsung: Update DMA interface
Date: Tue, 5 Jul 2011 16:45:30 +0900 [thread overview]
Message-ID: <CA+s+8rf3oBFe7TcEnWqh1L51FuN59uU0F=RTgargOFGJN+f7XA@mail.gmail.com> (raw)
In-Reply-To: <20110704170259.GC28726@opensource.wolfsonmicro.com>
> Two questions here:
>
> - It looks like a lot of this code can be shared between all the drivers
> ?using the dmaengine API. ?Is there any reason not to factor it out?
> - Should this not be adding a new driver for dmaengine based Samsung
> ?CPUs? ?The ifdefs are very big.
I think that dma code looks very similar to current one, so how about
using platform_resource setting for dma type and make some inline
functions to cover these differences? We already have platform driver
for dma in arch/arm and dev-audio.c.
next prev parent reply other threads:[~2011-07-05 7:45 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 12:18 [PATCH 0/7] ARM: S5P: Use generic DMA APIs Kukjin Kim
2011-07-04 12:18 ` Kukjin Kim
2011-07-04 12:18 ` [PATCH 1/7] DMA: PL330: Add support runtime PM for PL330 DMAC Kukjin Kim
2011-07-04 12:18 ` Kukjin Kim
2011-07-05 6:11 ` Alim Akhtar
2011-07-05 6:11 ` Alim Akhtar
2011-07-05 7:26 ` Kukjin Kim
2011-07-05 7:26 ` Kukjin Kim
2011-07-05 8:04 ` Russell King - ARM Linux
2011-07-05 8:04 ` Russell King - ARM Linux
2011-07-08 10:18 ` Kukjin Kim
2011-07-08 10:18 ` Kukjin Kim
2011-07-04 12:18 ` [PATCH 2/7] DMA: PL330: Update PL330 DMA API driver Kukjin Kim
2011-07-04 12:18 ` Kukjin Kim
2011-07-05 7:36 ` Russell King - ARM Linux
2011-07-05 7:36 ` Russell King - ARM Linux
2011-07-08 7:57 ` Kukjin Kim
2011-07-08 7:57 ` Kukjin Kim
2011-07-04 12:18 ` [PATCH 3/7] DMA: PL330: Add DMA capabilities Kukjin Kim
2011-07-04 12:18 ` Kukjin Kim
2011-07-05 4:50 ` Chanho Park
2011-07-05 6:33 ` Chanho Park
2011-07-05 6:33 ` Chanho Park
2011-07-05 7:10 ` Kukjin Kim
2011-07-05 7:10 ` Kukjin Kim
2011-07-05 8:08 ` Chanho Park
2011-07-05 8:08 ` Chanho Park
2011-07-12 8:32 ` Jassi Brar
2011-07-12 8:32 ` Jassi Brar
2011-07-14 0:57 ` boojin
2011-07-14 0:57 ` boojin
2011-07-14 3:53 ` Jassi Brar
2011-07-14 3:53 ` Jassi Brar
2011-07-14 9:04 ` boojin
2011-07-14 9:04 ` boojin
2011-07-04 12:18 ` [PATCH 4/7] ARM: SAMSUNG: Update to use PL330-DMA driver Kukjin Kim
2011-07-04 12:18 ` Kukjin Kim
2011-07-04 12:18 ` [PATCH 5/7] ARM: EXYNOS4: Use generic DMA PL330 driver Kukjin Kim
2011-07-04 12:18 ` Kukjin Kim
2011-07-05 2:36 ` Chanho Park
2011-07-05 6:07 ` Alim Akhtar
2011-07-05 6:07 ` Alim Akhtar
2011-07-05 8:30 ` Sangwook Lee
2011-07-05 8:30 ` Sangwook Lee
2011-07-04 12:18 ` [PATCH 6/7] spi/s3c64xx: Add support DMA engine API Kukjin Kim
2011-07-04 12:18 ` Kukjin Kim
2011-07-04 16:42 ` Grant Likely
2011-07-04 16:42 ` Grant Likely
2011-07-04 16:56 ` Mark Brown
2011-07-04 16:56 ` Mark Brown
2011-07-04 16:59 ` Heiko Stübner
2011-07-04 16:59 ` Heiko Stübner
2011-07-04 17:02 ` Grant Likely
2011-07-04 17:02 ` Grant Likely
2011-07-04 19:51 ` Heiko Stübner
2011-07-04 19:51 ` Heiko Stübner
2011-07-04 23:27 ` Grant Likely
2011-07-04 23:27 ` Grant Likely
2011-07-05 7:05 ` Kukjin Kim
2011-07-05 7:05 ` Kukjin Kim
2011-07-05 7:53 ` Russell King - ARM Linux
2011-07-05 7:53 ` Russell King - ARM Linux
2011-07-05 10:51 ` Heiko Stübner
2011-07-05 10:51 ` Heiko Stübner
2011-07-05 11:16 ` Jassi Brar
2011-07-05 11:16 ` Jassi Brar
2011-07-05 11:27 ` Russell King - ARM Linux
2011-07-05 11:27 ` Russell King - ARM Linux
2011-07-05 11:45 ` Jassi Brar
2011-07-05 11:45 ` Jassi Brar
2011-07-08 9:26 ` Kukjin Kim
2011-07-08 9:26 ` Kukjin Kim
2011-07-05 7:48 ` Russell King - ARM Linux
2011-07-05 7:48 ` Russell King - ARM Linux
2011-07-05 8:39 ` Chanho Park
2011-07-05 8:39 ` Chanho Park
2011-07-04 12:18 ` [PATCH 7/7] ASoC: Samsung: Update DMA interface Kukjin Kim
2011-07-04 12:18 ` Kukjin Kim
2011-07-04 17:03 ` Mark Brown
2011-07-04 17:03 ` Mark Brown
2011-07-05 7:19 ` Kukjin Kim
2011-07-05 7:19 ` Kukjin Kim
2011-07-05 18:04 ` Grant Likely
2011-07-05 18:04 ` Grant Likely
2011-07-05 7:45 ` Seungwhan Youn [this message]
2011-07-05 7:45 ` Seungwhan Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+s+8rf3oBFe7TcEnWqh1L51FuN59uU0F=RTgargOFGJN+f7XA@mail.gmail.com' \
--to=claude.youn@gmail.com \
--cc=boojin.kim@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dan.j.williams@intel.com \
--cc=grant.likely@secretlab.ca \
--cc=jassisinghbrar@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@ti.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.