All of lore.kernel.org
 help / color / mirror / Atom feed
From: chi wu <wuchi.zero@gmail.com>
To: Paul Moore <paul@paul-moore.com>
Cc: eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] audit: remove obvious unnecessary header files
Date: Wed, 31 Aug 2022 09:04:04 +0800	[thread overview]
Message-ID: <CA+tQmHD1RDuur7Gt8OP9+gqNs66zb932bOwTzcB_0BvsvzY1RA@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhSPdD_tJYhynK=a3JcuU-2ez1S2VCUXLu0DJbWCn0-8zQ@mail.gmail.com>

Paul Moore <paul@paul-moore.com> 于2022年8月31日周三 08:49写道：
>
> On Tue, Aug 30, 2022 at 8:20 PM chi wu <wuchi.zero@gmail.com> wrote:
> > Paul Moore <paul@paul-moore.com> 于2022年8月31日周三 01:04写道：
> > >
> > >
> > > Hi Wuchi, can you explain what process you used to determine that
> > > these header file includes were unnecessary?
> >
> > When reading the code, if I don't found the user of the *.h in the *.c
> > file,I will think that is unnecessary. For example, #include
> > <linux/kthread.h> in the audit.c, I don't found the use of kthread* in
> > the file.
> > But, I just build that without "W=1 " , the after test robot show that I
> > was wrong. and I don't sure that if it is true to remove some header
> > files.
>
> Yes, I would recommend that you focus your time and energy on other
> tasks within the Linux Kernel.  I'm very happy to see patches which
> improve the audit subsystem, but I don't believe verifying the header
> file usage is a good use of time at this point.
>
thanks very much

> --
> paul-moore.com

WARNING: multiple messages have this Message-ID (diff)
From: chi wu <wuchi.zero@gmail.com>
To: Paul Moore <paul@paul-moore.com>
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, eparis@redhat.com
Subject: Re: [PATCH] audit: remove obvious unnecessary header files
Date: Wed, 31 Aug 2022 09:04:04 +0800	[thread overview]
Message-ID: <CA+tQmHD1RDuur7Gt8OP9+gqNs66zb932bOwTzcB_0BvsvzY1RA@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhSPdD_tJYhynK=a3JcuU-2ez1S2VCUXLu0DJbWCn0-8zQ@mail.gmail.com>

Paul Moore <paul@paul-moore.com> 于2022年8月31日周三 08:49写道：
>
> On Tue, Aug 30, 2022 at 8:20 PM chi wu <wuchi.zero@gmail.com> wrote:
> > Paul Moore <paul@paul-moore.com> 于2022年8月31日周三 01:04写道：
> > >
> > >
> > > Hi Wuchi, can you explain what process you used to determine that
> > > these header file includes were unnecessary?
> >
> > When reading the code, if I don't found the user of the *.h in the *.c
> > file,I will think that is unnecessary. For example, #include
> > <linux/kthread.h> in the audit.c, I don't found the use of kthread* in
> > the file.
> > But, I just build that without "W=1 " , the after test robot show that I
> > was wrong. and I don't sure that if it is true to remove some header
> > files.
>
> Yes, I would recommend that you focus your time and energy on other
> tasks within the Linux Kernel.  I'm very happy to see patches which
> improve the audit subsystem, but I don't believe verifying the header
> file usage is a good use of time at this point.
>
thanks very much

> --
> paul-moore.com

--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit

  reply	other threads:[~2022-08-31  1:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30 10:50 [PATCH] audit: remove obvious unnecessary header files wuchi
2022-08-30 10:50 ` wuchi
2022-08-30 17:04 ` Paul Moore
2022-08-30 17:04   ` Paul Moore
2022-08-31  0:20   ` chi wu
2022-08-31  0:20     ` chi wu
2022-08-31  0:49     ` Paul Moore
2022-08-31  0:49       ` Paul Moore
2022-08-31  1:04       ` chi wu [this message]
2022-08-31  1:04         ` chi wu
2022-08-30 21:17 ` kernel test robot
2022-08-30 21:17   ` kernel test robot
2022-08-30 21:58 ` kernel test robot
2022-08-30 21:58   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+tQmHD1RDuur7Gt8OP9+gqNs66zb932bOwTzcB_0BvsvzY1RA@mail.gmail.com \
    --to=wuchi.zero@gmail.com \
    --cc=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.