* [Buildroot] [git commit] mii-diag: link statically if configured to do so
@ 2012-06-27 20:03 Peter Korsgaard
2012-06-29 10:16 ` Thomas Petazzoni
0 siblings, 1 reply; 11+ messages in thread
From: Peter Korsgaard @ 2012-06-27 20:03 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=a0f965dda8365c538c2a868a48675265522c70c5
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
package/mii-diag/mii-diag.mk | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/package/mii-diag/mii-diag.mk b/package/mii-diag/mii-diag.mk
index 0731bf7..f74fa3d 100644
--- a/package/mii-diag/mii-diag.mk
+++ b/package/mii-diag/mii-diag.mk
@@ -8,6 +8,12 @@ MII_DIAG_SOURCE = mii-diag_$(MII_DIAG_VERSION).orig.tar.gz
MII_DIAG_PATCH = mii-diag_$(MII_DIAG_VERSION)-3.diff.gz
MII_DIAG_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/m/mii-diag
+MII_DIAG_MAKE_OPT = $(TARGET_CONFIGURE_OPTS)
+
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+MII_DIAG_MAKE_OPT += CFLAGS="$(TARGET_CFLAGS) -static"
+endif
+
define MII_DIAG_DEBIAN_PATCHES
if [ -d $(@D)/debian/patches ]; then \
support/scripts/apply-patches.sh $(@D) $(@D)/debian/patches \*.patch; \
@@ -17,7 +23,7 @@ endef
MII_DIAG_POST_PATCH_HOOKS = MII_DIAG_DEBIAN_PATCHES
define MII_DIAG_BUILD_CMDS
- $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
+ $(MAKE) $(MII_DIAG_MAKE_OPT) -C $(@D)
endef
define MII_DIAG_INSTALL_TARGET_CMDS
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [git commit] mii-diag: link statically if configured to do so
2012-06-27 20:03 [Buildroot] [git commit] mii-diag: link statically if configured to do so Peter Korsgaard
@ 2012-06-29 10:16 ` Thomas Petazzoni
2012-06-29 11:23 ` Jonas Keidel
2012-06-30 8:32 ` Peter Korsgaard
0 siblings, 2 replies; 11+ messages in thread
From: Thomas Petazzoni @ 2012-06-29 10:16 UTC (permalink / raw)
To: buildroot
Hello,
Le Wed, 27 Jun 2012 22:03:59 +0200,
Peter Korsgaard <jacmet@sunsite.dk> a ?crit :
> +MII_DIAG_MAKE_OPT = $(TARGET_CONFIGURE_OPTS)
> +
> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
> +MII_DIAG_MAKE_OPT += CFLAGS="$(TARGET_CFLAGS) -static"
> +endif
I am not fully sure I like this. Do we want to have the same stuff in
all packages, or should we think about doing this globally in some way?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [git commit] mii-diag: link statically if configured to do so
2012-06-29 10:16 ` Thomas Petazzoni
@ 2012-06-29 11:23 ` Jonas Keidel
2012-06-30 8:32 ` Peter Korsgaard
1 sibling, 0 replies; 11+ messages in thread
From: Jonas Keidel @ 2012-06-29 11:23 UTC (permalink / raw)
To: buildroot
>> +MII_DIAG_MAKE_OPT = $(TARGET_CONFIGURE_OPTS)
>> +
>> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
>> +MII_DIAG_MAKE_OPT += CFLAGS="$(TARGET_CFLAGS) -static"
>> +endif
>
> I am not fully sure I like this. Do we want to have the same stuff in
> all packages, or should we think about doing this globally in some
> way?
I think the best way is to do it globally because I noticed that many
packages don't build statically if it is set in the global config.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [git commit] mii-diag: link statically if configured to do so
2012-06-29 10:16 ` Thomas Petazzoni
2012-06-29 11:23 ` Jonas Keidel
@ 2012-06-30 8:32 ` Peter Korsgaard
2012-06-30 8:55 ` Thomas Petazzoni
1 sibling, 1 reply; 11+ messages in thread
From: Peter Korsgaard @ 2012-06-30 8:32 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Hello,
Thomas> Le Wed, 27 Jun 2012 22:03:59 +0200,
Thomas> Peter Korsgaard <jacmet@sunsite.dk> a ?crit :
>> +MII_DIAG_MAKE_OPT = $(TARGET_CONFIGURE_OPTS)
>> +
>> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
>> +MII_DIAG_MAKE_OPT += CFLAGS="$(TARGET_CFLAGS) -static"
>> +endif
Thomas> I am not fully sure I like this. Do we want to have the same
Thomas> stuff in all packages, or should we think about doing this
Thomas> globally in some way?
Agree, I've added it globally now.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [git commit] mii-diag: link statically if configured to do so
2012-06-30 8:32 ` Peter Korsgaard
@ 2012-06-30 8:55 ` Thomas Petazzoni
2012-06-30 13:02 ` Arnout Vandecappelle
0 siblings, 1 reply; 11+ messages in thread
From: Thomas Petazzoni @ 2012-06-30 8:55 UTC (permalink / raw)
To: buildroot
Le Sat, 30 Jun 2012 10:32:14 +0200,
Peter Korsgaard <jacmet@uclibc.org> a ?crit :
> Thomas> I am not fully sure I like this. Do we want to have the same
> Thomas> stuff in all packages, or should we think about doing this
> Thomas> globally in some way?
>
> Agree, I've added it globally now.
Yes, seen that, great. Does this addition of -static to TARGET_LDFLAGS
play well with --enable-static for AUTOTARGETS packages?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [git commit] mii-diag: link statically if configured to do so
2012-06-30 8:55 ` Thomas Petazzoni
@ 2012-06-30 13:02 ` Arnout Vandecappelle
2012-06-30 17:09 ` Alex Bradbury
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Arnout Vandecappelle @ 2012-06-30 13:02 UTC (permalink / raw)
To: buildroot
On 06/30/12 10:55, Thomas Petazzoni wrote:
> Le Sat, 30 Jun 2012 10:32:14 +0200,
> Peter Korsgaard<jacmet@uclibc.org> a ?crit :
>
>> Thomas> I am not fully sure I like this. Do we want to have the same
>> Thomas> stuff in all packages, or should we think about doing this
>> Thomas> globally in some way?
>>
>> Agree, I've added it globally now.
>
> Yes, seen that, great. Does this addition of -static to TARGET_LDFLAGS
> play well with --enable-static for AUTOTARGETS packages?
--enable-static should mean that static libraries should be built,
while -static says that the executable should only be linked with
static libraries. But of course, with all the non-standard autotools
stuff out there, you never know...
I expect that adding -static to LDFLAGS will break quite a few packages.
Would it be possible to add a BR2_PREFER_STATIC_LIB test to the autobuilds?
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [git commit] mii-diag: link statically if configured to do so
2012-06-30 13:02 ` Arnout Vandecappelle
@ 2012-06-30 17:09 ` Alex Bradbury
2012-07-03 17:56 ` Thomas Petazzoni
2012-06-30 22:01 ` Peter Korsgaard
2012-07-01 19:32 ` Thomas Petazzoni
2 siblings, 1 reply; 11+ messages in thread
From: Alex Bradbury @ 2012-06-30 17:09 UTC (permalink / raw)
To: buildroot
On 30 June 2012 14:02, Arnout Vandecappelle <arnout@mind.be> wrote:
> ?I expect that adding -static to LDFLAGS will break quite a few packages.
> Would it be possible to add a BR2_PREFER_STATIC_LIB test to the autobuilds?
That would be neat. Is there a list of currently tested configurations
somewhere?
There's certainly a decent amount of interest in static linking - e.g.
sta.li, bifrost, sabotage and others.
Alex
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [git commit] mii-diag: link statically if configured to do so
2012-06-30 13:02 ` Arnout Vandecappelle
2012-06-30 17:09 ` Alex Bradbury
@ 2012-06-30 22:01 ` Peter Korsgaard
2012-07-01 19:32 ` Thomas Petazzoni
2 siblings, 0 replies; 11+ messages in thread
From: Peter Korsgaard @ 2012-06-30 22:01 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Hi,
Arnout> --enable-static should mean that static libraries should be built,
Arnout> while -static says that the executable should only be linked with
Arnout> static libraries. But of course, with all the non-standard autotools
Arnout> stuff out there, you never know...
Arnout> I expect that adding -static to LDFLAGS will break quite a few
Arnout> packages. Would it be possible to add a BR2_PREFER_STATIC_LIB
Arnout> test to the autobuilds?
I haven't seen any breakage in my (admitted fairly limited) testing, but
it it certainly possible.
I'll add a static builder to the autobuilders now.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [git commit] mii-diag: link statically if configured to do so
2012-06-30 13:02 ` Arnout Vandecappelle
2012-06-30 17:09 ` Alex Bradbury
2012-06-30 22:01 ` Peter Korsgaard
@ 2012-07-01 19:32 ` Thomas Petazzoni
2 siblings, 0 replies; 11+ messages in thread
From: Thomas Petazzoni @ 2012-07-01 19:32 UTC (permalink / raw)
To: buildroot
Le Sat, 30 Jun 2012 15:02:12 +0200,
Arnout Vandecappelle <arnout@mind.be> a ?crit :
> I expect that adding -static to LDFLAGS will break quite a few packages.
> Would it be possible to add a BR2_PREFER_STATIC_LIB test to the autobuilds?
I'm planning on adding some more randomness on the builds, i.e for
certain builds, enable BR2_PREFER_STATIC_LIB, or BR2_HAVE_DEVFILES, or
BR2_HAVE_DOCUMENTATION, or some other options.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [git commit] mii-diag: link statically if configured to do so
2012-06-30 17:09 ` Alex Bradbury
@ 2012-07-03 17:56 ` Thomas Petazzoni
2012-07-03 19:08 ` Peter Korsgaard
0 siblings, 1 reply; 11+ messages in thread
From: Thomas Petazzoni @ 2012-07-03 17:56 UTC (permalink / raw)
To: buildroot
Hello,
Le Sat, 30 Jun 2012 18:09:38 +0100,
Alex Bradbury <asb@asbradbury.org> a ?crit :
> That would be neat. Is there a list of currently tested configurations
> somewhere?
Basically, the way the autobuilds work is that Peter and I have a set
of base configurations, that define the architecture and the toolchain,
and then we do a "make randpackageconfig" to generate a random
selection of packages.
Peter has a few base configurations, and if I understand correctly, on
a given build machine, he always uses the same base configuration.
On my side, I have a single build machine, but I have 39 different base
configurations (mixing architectures, internal/external toolchains with
various configurations and versions), and I select a random one for
each build, before doing the "make randpackageconfig".
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [git commit] mii-diag: link statically if configured to do so
2012-07-03 17:56 ` Thomas Petazzoni
@ 2012-07-03 19:08 ` Peter Korsgaard
0 siblings, 0 replies; 11+ messages in thread
From: Peter Korsgaard @ 2012-07-03 19:08 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Hello,
Thomas> Le Sat, 30 Jun 2012 18:09:38 +0100,
Thomas> Alex Bradbury <asb@asbradbury.org> a ?crit :
>> That would be neat. Is there a list of currently tested configurations
>> somewhere?
Thomas> Basically, the way the autobuilds work is that Peter and I have a set
Thomas> of base configurations, that define the architecture and the toolchain,
Thomas> and then we do a "make randpackageconfig" to generate a random
Thomas> selection of packages.
Thomas> Peter has a few base configurations, and if I understand correctly, on
Thomas> a given build machine, he always uses the same base configuration.
Indeed. I have a defconfig defining the toolchain configuration and my
script basically does:
cp defconfig .config
yes '' | make oldconfig
make randpackageconfig
make
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2012-07-03 19:08 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-27 20:03 [Buildroot] [git commit] mii-diag: link statically if configured to do so Peter Korsgaard
2012-06-29 10:16 ` Thomas Petazzoni
2012-06-29 11:23 ` Jonas Keidel
2012-06-30 8:32 ` Peter Korsgaard
2012-06-30 8:55 ` Thomas Petazzoni
2012-06-30 13:02 ` Arnout Vandecappelle
2012-06-30 17:09 ` Alex Bradbury
2012-07-03 17:56 ` Thomas Petazzoni
2012-07-03 19:08 ` Peter Korsgaard
2012-06-30 22:01 ` Peter Korsgaard
2012-07-01 19:32 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.