[PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup(&data) for psr_basic

[PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup(&data) for psr_basic

[Marta Lofstedt]

The "*ERROR* Potential atomic update failure on pipe A"
started to occure on some BAT machines with IGT_4063.
Looking at the dmesgs the ERROR print come when the
subtest is exiting. So, this is just a longshot to test if
we may need to do the cleanup on this subtest as well.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260

Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
---
 tests/kms_psr_sink_crc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index 83a69f0b..7ee4c2f4 100644
--- a/tests/kms_psr_sink_crc.c
+++ b/tests/kms_psr_sink_crc.c
@@ -532,6 +532,7 @@ int main(int argc, char *argv[])
 	igt_subtest("psr_basic") {
 		setup_test_plane(&data);
 		igt_assert(wait_psr_entry(&data));
+		test_cleanup(&data);
 	}
 
 	igt_subtest("psr_drrs") {
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for test/kms_psr_sink_crc - Hack to test test_cleanup(&data) for psr_basic

[Patchwork]

== Series Details ==

Series: test/kms_psr_sink_crc - Hack to test test_cleanup(&data) for psr_basic
URL   : https://patchwork.freedesktop.org/series/36000/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
58bd37d347d1369ecd272ff778057ee8004d6b15 kms_atomic_transition: Remove skip_on_unsupported_nonblocking_modeset.

with latest DRM-Tip kernel build CI_DRM_3596
5f40895798ad drm-tip: 2018y-01m-04d-00h-29m-57s UTC integration manifest

No testlist changes.

Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                fail       -> PASS       (fi-gdg-551) fdo#102575
Test kms_flip:
        Subgroup basic-flip-vs-wf_vblank:
                pass       -> FAIL       (fi-hsw-4770r) fdo#100368
Test kms_psr_sink_crc:
        Subgroup psr_basic:
                dmesg-warn -> PASS       (fi-skl-6600u) fdo#104260 +1

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#104260 https://bugs.freedesktop.org/show_bug.cgi?id=104260

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:434s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:386s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:500s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:276s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:494s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:502s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:484s
fi-elk-e7500     total:224  pass:168  dwarn:10  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:180  dwarn:0   dfail:0   fail:0   skip:108 time:261s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:523s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:405s
fi-hsw-4770r     total:288  pass:260  dwarn:0   dfail:0   fail:1   skip:27  time:409s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:425s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:487s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:426s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:475s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:513s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:460s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:513s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:593s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:445s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:525s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:540s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:508s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:511s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:446s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:537s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:412s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:576s
fi-cnl-y         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:634s
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:483s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_741/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup(&data) for psr_basic

[Lofstedt, Marta]

+Petri

PW results are looking good.
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_741/issues.html

________________________________________
From: Lofstedt, Marta
Sent: Thursday, January 04, 2018 11:54 AM
To: intel-gfx@lists.freedesktop.org
Cc: Lofstedt, Marta
Subject: [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup(&data) for psr_basic

The "*ERROR* Potential atomic update failure on pipe A"
started to occure on some BAT machines with IGT_4063.
Looking at the dmesgs the ERROR print come when the
subtest is exiting. So, this is just a longshot to test if
we may need to do the cleanup on this subtest as well.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260

Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
---
 tests/kms_psr_sink_crc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index 83a69f0b..7ee4c2f4 100644
--- a/tests/kms_psr_sink_crc.c
+++ b/tests/kms_psr_sink_crc.c
@@ -532,6 +532,7 @@ int main(int argc, char *argv[])
        igt_subtest("psr_basic") {
                setup_test_plane(&data);
                igt_assert(wait_psr_entry(&data));
+               test_cleanup(&data);
        }

        igt_subtest("psr_drrs") {
--
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup(&data) for psr_basic

[Petri Latvala]

On Thu, Jan 04, 2018 at 12:54:34PM +0200, Marta Lofstedt wrote:
> The "*ERROR* Potential atomic update failure on pipe A"
> started to occure on some BAT machines with IGT_4063.
> Looking at the dmesgs the ERROR print come when the
> subtest is exiting. So, this is just a longshot to test if
> we may need to do the cleanup on this subtest as well.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260
> 
> Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> ---
>  tests/kms_psr_sink_crc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
> index 83a69f0b..7ee4c2f4 100644
> --- a/tests/kms_psr_sink_crc.c
> +++ b/tests/kms_psr_sink_crc.c
> @@ -532,6 +532,7 @@ int main(int argc, char *argv[])
>  	igt_subtest("psr_basic") {
>  		setup_test_plane(&data);
>  		igt_assert(wait_psr_entry(&data));
> +		test_cleanup(&data);
>  	}


This looks correct indeed.


>  
>  	igt_subtest("psr_drrs") {


But the same is required here, isn't it?



-- 
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.IGT: failure for test/kms_psr_sink_crc - Hack to test test_cleanup(&data) for psr_basic

[Patchwork]

== Series Details ==

Series: test/kms_psr_sink_crc - Hack to test test_cleanup(&data) for psr_basic
URL   : https://patchwork.freedesktop.org/series/36000/
State : failure

== Summary ==

Test kms_flip:
        Subgroup flip-vs-expired-vblank:
                pass       -> FAIL       (shard-snb)
        Subgroup vblank-vs-modeset-suspend:
                pass       -> INCOMPLETE (shard-hsw)
Test gem_exec_suspend:
        Subgroup basic-s3:
                incomplete -> PASS       (shard-hsw) fdo#103540 +1
Test kms_setmode:
        Subgroup basic:
                fail       -> PASS       (shard-hsw) fdo#99912
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
                fail       -> PASS       (shard-snb) fdo#101623
Test drv_suspend:
        Subgroup sysfs-reader-hibernate:
                fail       -> SKIP       (shard-hsw) fdo#103375

fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375

shard-hsw        total:2671 pass:1510 dwarn:1   dfail:0   fail:7   skip:1152 time:9077s
shard-snb        total:2713 pass:1309 dwarn:1   dfail:0   fail:12  skip:1391 time:8103s
Blacklisted hosts:
shard-apl        total:2713 pass:1686 dwarn:2   dfail:0   fail:23  skip:1001 time:13761s
shard-kbl        total:2702 pass:1798 dwarn:2   dfail:0   fail:26  skip:875 time:10547s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_741/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup(&data) for psr_basic

[Lofstedt, Marta]

> -----Original Message-----
> From: Latvala, Petri
> Sent: Thursday, January 4, 2018 2:11 PM
> To: Lofstedt, Marta <marta.lofstedt@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test
> test_cleanup(&data) for psr_basic
> 
> On Thu, Jan 04, 2018 at 12:54:34PM +0200, Marta Lofstedt wrote:
> > The "*ERROR* Potential atomic update failure on pipe A"
> > started to occure on some BAT machines with IGT_4063.
> > Looking at the dmesgs the ERROR print come when the subtest is
> > exiting. So, this is just a longshot to test if we may need to do the
> > cleanup on this subtest as well.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260
> >
> > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> > ---
> >  tests/kms_psr_sink_crc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index
> > 83a69f0b..7ee4c2f4 100644
> > --- a/tests/kms_psr_sink_crc.c
> > +++ b/tests/kms_psr_sink_crc.c
> > @@ -532,6 +532,7 @@ int main(int argc, char *argv[])
> >  	igt_subtest("psr_basic") {
> >  		setup_test_plane(&data);
> >  		igt_assert(wait_psr_entry(&data));
> > +		test_cleanup(&data);
> >  	}
> 
> 
> This looks correct indeed.
> 
> 
> >
> >  	igt_subtest("psr_drrs") {
> 
> 
> But the same is required here, isn't it?

Probably, but it is green on GLK-shards which is the only machine currently running it. By the way it's the only green PSR related tests on GLK-shards...
I guess I could do a fastfeedback.testlist hack to BAT to see if it fails there on some machine.

> 
> 
> 
> --
> Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup(&data) for psr_basic

[Lofstedt, Marta]

Doesn't look like it is needed for the psr_drrs

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_744/all.html
________________________________________
From: Lofstedt, Marta
Sent: Thursday, January 04, 2018 1:37 PM
To: Latvala, Petri
Cc: intel-gfx@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup(&data) for psr_basic

> -----Original Message-----
> From: Latvala, Petri
> Sent: Thursday, January 4, 2018 2:11 PM
> To: Lofstedt, Marta <marta.lofstedt@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test
> test_cleanup(&data) for psr_basic
>
> On Thu, Jan 04, 2018 at 12:54:34PM +0200, Marta Lofstedt wrote:
> > The "*ERROR* Potential atomic update failure on pipe A"
> > started to occure on some BAT machines with IGT_4063.
> > Looking at the dmesgs the ERROR print come when the subtest is
> > exiting. So, this is just a longshot to test if we may need to do the
> > cleanup on this subtest as well.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260
> >
> > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> > ---
> >  tests/kms_psr_sink_crc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index
> > 83a69f0b..7ee4c2f4 100644
> > --- a/tests/kms_psr_sink_crc.c
> > +++ b/tests/kms_psr_sink_crc.c
> > @@ -532,6 +532,7 @@ int main(int argc, char *argv[])
> >     igt_subtest("psr_basic") {
> >             setup_test_plane(&data);
> >             igt_assert(wait_psr_entry(&data));
> > +           test_cleanup(&data);
> >     }
>
>
> This looks correct indeed.
>
>
> >
> >     igt_subtest("psr_drrs") {
>
>
> But the same is required here, isn't it?

Probably, but it is green on GLK-shards which is the only machine currently running it. By the way it's the only green PSR related tests on GLK-shards...
I guess I could do a fastfeedback.testlist hack to BAT to see if it fails there on some machine.

>
>
>
> --
> Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx