[igt-dev] [PATCH i-g-t 1/3] igt/kms_fbcon_fbt: Handle ENODEV when checking i915_edp_psr_status for chipset support

[igt-dev] [PATCH i-g-t 1/3] igt/kms_fbcon_fbt: Handle ENODEV when checking i915_edp_psr_status for chipset support

[Marta Lofstedt]

If the machine doesn't support PSR, it will return -ENODEV from
i915_edp_psr_status, which we want to interpret as unsupported.
This is in line with what Chris just fixed for FBC.

Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
---
 tests/kms_fbcon_fbt.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c
index 1b236f8b..6aa171e6 100644
--- a/tests/kms_fbcon_fbt.c
+++ b/tests/kms_fbcon_fbt.c
@@ -164,6 +164,8 @@ static bool psr_supported_on_chipset(int fd)
 {
 	char buf[256];
 
+	if (*buf == '\0') /* !HAS_PSR -> -ENODEV*/
+		return false;
 	igt_debugfs_read(fd, "i915_edp_psr_status", buf);
 	return strstr(buf, "Sink_Support: yes\n");
 }
-- 
2.11.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/3] igt/kms_fronbuffer_tracking: Handle ENODEV when checking i915_edp_psr_status for chipset support

[Marta Lofstedt]

If the machine doesn't support PSR, it will return -ENODEV from
i915_edp_psr_status, which we want to interpret as unsupported.
This is in line with what Chris just fixed for FBC.

Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
---
 tests/kms_frontbuffer_tracking.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 57ae047b..0a70e5e3 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -1637,6 +1637,8 @@ static bool psr_sink_has_support(void)
 {
 	char buf[256];
 
+	if (*buf == '\0') /* !HAS_PSR -> -ENODEV*/
+		return false;
 	debugfs_read("i915_edp_psr_status", buf);
 	return strstr(buf, "Sink_Support: yes\n");
 }
-- 
2.11.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 3/3] HACK to get some PSR tests run on BAT

[Marta Lofstedt]

Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 297 +---------------------------------
 1 file changed, 4 insertions(+), 293 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index f71a16bc..2cddad99 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -1,295 +1,6 @@
 # Keep alphabetically sorted by default
 
-igt@core_auth@basic-auth
-igt@core_prop_blob@basic
-igt@debugfs_test@read_all_entries
-igt@drv_getparams_basic@basic-eu-total
-igt@drv_getparams_basic@basic-subslice-total
-igt@drv_hangman@error-state-basic
-igt@gem_basic@bad-close
-igt@gem_basic@create-close
-igt@gem_basic@create-fd-close
-igt@gem_busy@basic-busy-default
-igt@gem_busy@basic-hang-default
-igt@gem_close_race@basic-process
-igt@gem_close_race@basic-threads
-igt@gem_cpu_reloc@basic
-igt@gem_cs_tlb@basic-default
-igt@gem_ctx_create@basic
-igt@gem_ctx_create@basic-files
-igt@gem_ctx_exec@basic
-igt@gem_ctx_param@basic
-igt@gem_ctx_param@basic-default
-igt@gem_ctx_switch@basic-default
-igt@gem_ctx_switch@basic-default-heavy
-igt@gem_exec_basic@basic-blt
-igt@gem_exec_basic@basic-bsd
-igt@gem_exec_basic@basic-bsd1
-igt@gem_exec_basic@basic-bsd2
-igt@gem_exec_basic@basic-default
-igt@gem_exec_basic@basic-render
-igt@gem_exec_basic@basic-vebox
-igt@gem_exec_basic@gtt-blt
-igt@gem_exec_basic@gtt-bsd
-igt@gem_exec_basic@gtt-bsd1
-igt@gem_exec_basic@gtt-bsd2
-igt@gem_exec_basic@gtt-default
-igt@gem_exec_basic@gtt-render
-igt@gem_exec_basic@gtt-vebox
-igt@gem_exec_basic@readonly-blt
-igt@gem_exec_basic@readonly-bsd
-igt@gem_exec_basic@readonly-bsd1
-igt@gem_exec_basic@readonly-bsd2
-igt@gem_exec_basic@readonly-default
-igt@gem_exec_basic@readonly-render
-igt@gem_exec_basic@readonly-vebox
-igt@gem_exec_create@basic
-igt@gem_exec_fence@basic-busy-default
-igt@gem_exec_fence@basic-wait-default
-igt@gem_exec_fence@basic-await-default
-igt@gem_exec_fence@await-hang-default
-igt@gem_exec_fence@nb-await-default
-igt@gem_exec_flush@basic-batch-kernel-default-cmd
-igt@gem_exec_flush@basic-batch-kernel-default-uc
-igt@gem_exec_flush@basic-batch-kernel-default-wb
-igt@gem_exec_flush@basic-uc-pro-default
-igt@gem_exec_flush@basic-uc-prw-default
-igt@gem_exec_flush@basic-uc-ro-default
-igt@gem_exec_flush@basic-uc-rw-default
-igt@gem_exec_flush@basic-uc-set-default
-igt@gem_exec_flush@basic-wb-pro-default
-igt@gem_exec_flush@basic-wb-prw-default
-igt@gem_exec_flush@basic-wb-ro-before-default
-igt@gem_exec_flush@basic-wb-ro-default
-igt@gem_exec_flush@basic-wb-rw-before-default
-igt@gem_exec_flush@basic-wb-rw-default
-igt@gem_exec_flush@basic-wb-set-default
-igt@gem_exec_gttfill@basic
-igt@gem_exec_nop@basic-parallel
-igt@gem_exec_nop@basic-series
-igt@gem_exec_parallel@basic
-igt@gem_exec_parse@basic-allowed
-igt@gem_exec_parse@basic-rejected
-igt@gem_exec_reloc@basic-cpu
-igt@gem_exec_reloc@basic-gtt
-igt@gem_exec_reloc@basic-cpu-gtt
-igt@gem_exec_reloc@basic-gtt-cpu
-igt@gem_exec_reloc@basic-cpu-read
-igt@gem_exec_reloc@basic-gtt-read
-igt@gem_exec_reloc@basic-write-cpu
-igt@gem_exec_reloc@basic-write-gtt
-igt@gem_exec_reloc@basic-write-read
-igt@gem_exec_reloc@basic-cpu-noreloc
-igt@gem_exec_reloc@basic-gtt-noreloc
-igt@gem_exec_reloc@basic-cpu-gtt-noreloc
-igt@gem_exec_reloc@basic-gtt-cpu-noreloc
-igt@gem_exec_reloc@basic-cpu-read-noreloc
-igt@gem_exec_reloc@basic-gtt-read-noreloc
-igt@gem_exec_reloc@basic-write-cpu-noreloc
-igt@gem_exec_reloc@basic-write-gtt-noreloc
-igt@gem_exec_reloc@basic-write-read-noreloc
-igt@gem_exec_reloc@basic-cpu-active
-igt@gem_exec_reloc@basic-gtt-active
-igt@gem_exec_reloc@basic-cpu-gtt-active
-igt@gem_exec_reloc@basic-gtt-cpu-active
-igt@gem_exec_reloc@basic-cpu-read-active
-igt@gem_exec_reloc@basic-gtt-read-active
-igt@gem_exec_reloc@basic-write-cpu-active
-igt@gem_exec_reloc@basic-write-gtt-active
-igt@gem_exec_reloc@basic-write-read-active
-igt@gem_exec_reloc@basic-softpin
-igt@gem_exec_store@basic-all
-igt@gem_exec_store@basic-blt
-igt@gem_exec_store@basic-bsd
-igt@gem_exec_store@basic-bsd1
-igt@gem_exec_store@basic-bsd2
-igt@gem_exec_store@basic-default
-igt@gem_exec_store@basic-render
-igt@gem_exec_store@basic-vebox
-igt@gem_exec_suspend@basic
-igt@gem_exec_suspend@basic-s3
-igt@gem_exec_suspend@basic-s4-devices
-igt@gem_flink_basic@bad-flink
-igt@gem_flink_basic@bad-open
-igt@gem_flink_basic@basic
-igt@gem_flink_basic@double-flink
-igt@gem_flink_basic@flink-lifetime
-igt@gem_linear_blits@basic
-igt@gem_mmap@basic
-igt@gem_mmap@basic-small-bo
-igt@gem_mmap_gtt@basic
-igt@gem_mmap_gtt@basic-copy
-igt@gem_mmap_gtt@basic-read
-igt@gem_mmap_gtt@basic-read-no-prefault
-igt@gem_mmap_gtt@basic-read-write
-igt@gem_mmap_gtt@basic-read-write-distinct
-igt@gem_mmap_gtt@basic-short
-igt@gem_mmap_gtt@basic-small-bo
-igt@gem_mmap_gtt@basic-small-bo-tiledx
-igt@gem_mmap_gtt@basic-small-bo-tiledy
-igt@gem_mmap_gtt@basic-small-copy
-igt@gem_mmap_gtt@basic-small-copy-xy
-igt@gem_mmap_gtt@basic-wc
-igt@gem_mmap_gtt@basic-write
-igt@gem_mmap_gtt@basic-write-cpu-read-gtt
-igt@gem_mmap_gtt@basic-write-gtt
-igt@gem_mmap_gtt@basic-write-gtt-no-prefault
-igt@gem_mmap_gtt@basic-write-no-prefault
-igt@gem_mmap_gtt@basic-write-read
-igt@gem_mmap_gtt@basic-write-read-distinct
-igt@gem_pread@basic
-igt@gem_pwrite@basic
-igt@gem_render_linear_blits@basic
-igt@gem_render_tiled_blits@basic
-igt@gem_ringfill@basic-default
-igt@gem_ringfill@basic-default-interruptible
-igt@gem_ringfill@basic-default-forked
-igt@gem_ringfill@basic-default-fd
-igt@gem_ringfill@basic-default-hang
-igt@gem_sync@basic-all
-igt@gem_sync@basic-each
-igt@gem_sync@basic-many-each
-igt@gem_sync@basic-store-all
-igt@gem_sync@basic-store-each
-igt@gem_tiled_blits@basic
-igt@gem_tiled_fence_blits@basic
-igt@gem_tiled_pread_basic
-igt@gem_wait@basic-busy-all
-igt@gem_wait@basic-wait-all
-igt@gem_wait@basic-await-all
-igt@gem_workarounds@basic-read
-igt@kms_addfb_basic@addfb25-bad-modifier
-igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling
-igt@kms_addfb_basic@addfb25-modifier-no-flag
-igt@kms_addfb_basic@addfb25-x-tiled
-igt@kms_addfb_basic@addfb25-x-tiled-mismatch
-igt@kms_addfb_basic@addfb25-yf-tiled
-igt@kms_addfb_basic@addfb25-y-tiled
-igt@kms_addfb_basic@addfb25-y-tiled-small
-igt@kms_addfb_basic@bad-pitch-0
-igt@kms_addfb_basic@bad-pitch-1024
-igt@kms_addfb_basic@bad-pitch-128
-igt@kms_addfb_basic@bad-pitch-256
-igt@kms_addfb_basic@bad-pitch-32
-igt@kms_addfb_basic@bad-pitch-63
-igt@kms_addfb_basic@bad-pitch-65536
-igt@kms_addfb_basic@bad-pitch-999
-igt@kms_addfb_basic@basic
-igt@kms_addfb_basic@basic-x-tiled
-igt@kms_addfb_basic@basic-y-tiled
-igt@kms_addfb_basic@bo-too-small
-igt@kms_addfb_basic@bo-too-small-due-to-tiling
-igt@kms_addfb_basic@clobberred-modifier
-igt@kms_addfb_basic@framebuffer-vs-set-tiling
-igt@kms_addfb_basic@invalid-get-prop
-igt@kms_addfb_basic@invalid-get-prop-any
-igt@kms_addfb_basic@invalid-set-prop
-igt@kms_addfb_basic@invalid-set-prop-any
-igt@kms_addfb_basic@no-handle
-igt@kms_addfb_basic@size-max
-igt@kms_addfb_basic@small-bo
-igt@kms_addfb_basic@tile-pitch-mismatch
-igt@kms_addfb_basic@too-high
-igt@kms_addfb_basic@too-wide
-igt@kms_addfb_basic@unused-handle
-igt@kms_addfb_basic@unused-modifier
-igt@kms_addfb_basic@unused-offsets
-igt@kms_addfb_basic@unused-pitches
-igt@kms_busy@basic-flip-a
-igt@kms_busy@basic-flip-b
-igt@kms_busy@basic-flip-c
-igt@kms_chamelium@dp-hpd-fast
-igt@kms_chamelium@dp-edid-read
-igt@kms_chamelium@dp-crc-fast
-igt@kms_chamelium@hdmi-hpd-fast
-igt@kms_chamelium@hdmi-edid-read
-igt@kms_chamelium@hdmi-crc-fast
-igt@kms_chamelium@vga-hpd-fast
-igt@kms_chamelium@vga-edid-read
-igt@kms_chamelium@common-hpd-after-suspend
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-after-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size
-igt@kms_cursor_legacy@basic-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size
-igt@kms_flip@basic-flip-vs-dpms
-igt@kms_flip@basic-flip-vs-modeset
-igt@kms_flip@basic-flip-vs-wf_vblank
-igt@kms_flip@basic-plain-flip
-igt@kms_force_connector_basic@force-connector-state
-igt@kms_force_connector_basic@force-edid
-igt@kms_force_connector_basic@force-load-detect
-igt@kms_force_connector_basic@prune-stale-modes
-igt@kms_frontbuffer_tracking@basic
-igt@kms_pipe_crc_basic@bad-nb-words-1
-igt@kms_pipe_crc_basic@bad-nb-words-3
-igt@kms_pipe_crc_basic@bad-pipe
-igt@kms_pipe_crc_basic@bad-source
-igt@kms_pipe_crc_basic@hang-read-crc-pipe-a
-igt@kms_pipe_crc_basic@hang-read-crc-pipe-b
-igt@kms_pipe_crc_basic@hang-read-crc-pipe-c
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c-frame-sequence
-igt@kms_pipe_crc_basic@read-crc-pipe-a
-igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence
-igt@kms_pipe_crc_basic@read-crc-pipe-b
-igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence
-igt@kms_pipe_crc_basic@read-crc-pipe-c
-igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence
-igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
-igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
-igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
-igt@kms_psr_sink_crc@psr_basic
-igt@kms_setmode@basic-clone-single-crtc
-igt@kms_sink_crc_basic
-igt@pm_backlight@basic-brightness
-igt@pm_rpm@basic-pci-d3-state
-igt@pm_rpm@basic-rte
-igt@pm_rps@basic-api
-igt@prime_busy@basic-after-default
-igt@prime_busy@basic-before-default
-igt@prime_busy@basic-wait-after-default
-igt@prime_busy@basic-wait-before-default
-igt@prime_self_import@basic-llseek-bad
-igt@prime_self_import@basic-llseek-size
-igt@prime_self_import@basic-with_fd_dup
-igt@prime_self_import@basic-with_one_bo
-igt@prime_self_import@basic-with_one_bo_two_files
-igt@prime_self_import@basic-with_two_bos
-igt@prime_vgem@basic-busy-default
-igt@prime_vgem@basic-fence-flip
-igt@prime_vgem@basic-fence-mmap
-igt@prime_vgem@basic-fence-read
-igt@prime_vgem@basic-fence-wait-default
-igt@prime_vgem@basic-gtt
-igt@prime_vgem@basic-read
-igt@prime_vgem@basic-sync-default
-igt@prime_vgem@basic-wait-default
-igt@prime_vgem@basic-write
-igt@vgem_basic@setversion
-igt@vgem_basic@create
-igt@vgem_basic@debugfs
-igt@vgem_basic@dmabuf-export
-igt@vgem_basic@dmabuf-fence
-igt@vgem_basic@dmabuf-fence-before
-igt@vgem_basic@dmabuf-mmap
-igt@vgem_basic@mmap
-igt@vgem_basic@second-client
-igt@vgem_basic@sysfs
-
-# All tests that do module unloading and reloading are executed last.
-# They will sometimes reveal issues of earlier tests leaving the
-# driver in a broken state that is not otherwise noticed in that test.
-
-igt@vgem_basic@unload
-igt@drv_module_reload@basic-reload
-igt@drv_module_reload@basic-no-display
-igt@drv_module_reload@basic-reload-inject
-igt@gvt_basic@invalid-placeholder-test
+igt@kms_fbcon_fbt@psr
+igt@kms_frontbuffer_tracking@fbc-stridechange
+igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-gtt
+igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt
-- 
2.11.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/3] igt/kms_fbcon_fbt: Handle ENODEV when checking i915_edp_psr_status for chipset support

[Chris Wilson]

Quoting Marta Lofstedt (2018-02-22 07:43:41)
> If the machine doesn't support PSR, it will return -ENODEV from
> i915_edp_psr_status, which we want to interpret as unsupported.
> This is in line with what Chris just fixed for FBC.
> 
> Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> ---
>  tests/kms_fbcon_fbt.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c
> index 1b236f8b..6aa171e6 100644
> --- a/tests/kms_fbcon_fbt.c
> +++ b/tests/kms_fbcon_fbt.c
> @@ -164,6 +164,8 @@ static bool psr_supported_on_chipset(int fd)
>  {
>         char buf[256];
>  
> +       if (*buf == '\0') /* !HAS_PSR -> -ENODEV*/
> +               return false;
>         igt_debugfs_read(fd, "i915_edp_psr_status", buf);

After the read :)

>         return strstr(buf, "Sink_Support: yes\n");
>  }
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/3] igt/kms_fbcon_fbt: Handle ENODEV when checking i915_edp_psr_status for chipset support

[Lofstedt, Marta]

> -----Original Message-----
> From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> Sent: Thursday, February 22, 2018 9:47 AM
> To: Lofstedt, Marta <marta.lofstedt@intel.com>; igt-
> dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t 1/3] igt/kms_fbcon_fbt: Handle ENODEV
> when checking i915_edp_psr_status for chipset support
> 
> Quoting Marta Lofstedt (2018-02-22 07:43:41)
> > If the machine doesn't support PSR, it will return -ENODEV from
> > i915_edp_psr_status, which we want to interpret as unsupported.
> > This is in line with what Chris just fixed for FBC.
> >
> > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> > ---
> >  tests/kms_fbcon_fbt.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c index
> > 1b236f8b..6aa171e6 100644
> > --- a/tests/kms_fbcon_fbt.c
> > +++ b/tests/kms_fbcon_fbt.c
> > @@ -164,6 +164,8 @@ static bool psr_supported_on_chipset(int fd)  {
> >         char buf[256];
> >
> > +       if (*buf == '\0') /* !HAS_PSR -> -ENODEV*/
> > +               return false;
> >         igt_debugfs_read(fd, "i915_edp_psr_status", buf);
> 
> After the read :)

Yeah, was way too trigger happy here

> 
> >         return strstr(buf, "Sink_Support: yes\n");  }
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] igt/kms_fbcon_fbt: Handle ENODEV when checking i915_edp_psr_status for chipset support

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/3] igt/kms_fbcon_fbt: Handle ENODEV when checking i915_edp_psr_status for chipset support
URL   : https://patchwork.freedesktop.org/series/38745/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
af65798b6674e28816bd13c096963c2d7fcdd856 lib/igt_perf: Find active perf CPU

with latest DRM-Tip kernel build CI_DRM_3819
42016703e66b drm-tip: 2018y-02m-21d-21h-26m-53s UTC integration manifest

No testlist changes.

fi-bdw-5557u     total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:7s
fi-bdw-gvtdvm    total:4    pass:0    dwarn:0   dfail:0   fail:1   skip:3   time:9s
fi-blb-e6850     total:4    pass:0    dwarn:0   dfail:0   fail:0   skip:4   time:8s
fi-bsw-n3050     total:4    pass:0    dwarn:0   dfail:0   fail:0   skip:4   time:21s
fi-bwr-2160      total:4    pass:0    dwarn:0   dfail:0   fail:0   skip:4   time:14s
fi-bxt-dsi       total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:12s
fi-bxt-j4205     total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:13s
fi-byt-j1900     total:4    pass:0    dwarn:0   dfail:0   fail:0   skip:4   time:19s
fi-byt-n2820     total:4    pass:0    dwarn:0   dfail:0   fail:0   skip:4   time:18s
fi-cfl-s2        total:4    pass:1    dwarn:0   dfail:0   fail:1   skip:2   time:25s
fi-elk-e7500     total:4    pass:0    dwarn:0   dfail:0   fail:0   skip:4   time:9s
fi-gdg-551       total:4    pass:0    dwarn:0   dfail:0   fail:0   skip:4   time:17s
fi-glk-1         total:4    pass:2    dwarn:0   dfail:0   fail:2   skip:0   time:50s
fi-hsw-4770      total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:6s
fi-ilk-650       total:4    pass:0    dwarn:0   dfail:0   fail:0   skip:4   time:9s
fi-ivb-3520m     total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:8s
fi-ivb-3770      total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:6s
fi-kbl-7500u     total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:5s
fi-kbl-7560u     total:4    pass:1    dwarn:0   dfail:0   fail:1   skip:2   time:25s
fi-kbl-7567u     total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:5s
fi-kbl-r         total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:23s
fi-pnv-d510      total:4    pass:0    dwarn:0   dfail:0   fail:0   skip:4   time:31s
fi-skl-6260u     total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:6s
fi-skl-6600u     total:4    pass:1    dwarn:0   dfail:0   fail:1   skip:2   time:26s
fi-skl-6700hq    total:4    pass:2    dwarn:0   dfail:0   fail:2   skip:0   time:51s
fi-skl-6700k2    total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:7s
fi-skl-6770hq    total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:7s
fi-skl-guc       total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:5s
fi-skl-gvtdvm    total:4    pass:0    dwarn:0   dfail:0   fail:0   skip:4   time:6s
fi-snb-2520m     total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:16s
fi-snb-2600      total:4    pass:1    dwarn:0   dfail:0   fail:0   skip:3   time:9s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_983/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: warning for series starting with [i-g-t,1/3] igt/kms_fbcon_fbt: Handle ENODEV when checking i915_edp_psr_status for chipset support

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/3] igt/kms_fbcon_fbt: Handle ENODEV when checking i915_edp_psr_status for chipset support
URL   : https://patchwork.freedesktop.org/series/38745/
State : warning

== Summary ==

Test kms_rotation_crc:
        Subgroup sprite-rotation-180:
                fail       -> PASS       (shard-snb) fdo#103925
Test perf:
        Subgroup oa-exponents:
                incomplete -> PASS       (shard-apl) fdo#102254
        Subgroup blocking:
                pass       -> FAIL       (shard-hsw) fdo#102252
Test kms_flip:
        Subgroup 2x-flip-vs-expired-vblank:
                pass       -> FAIL       (shard-hsw) fdo#102887
        Subgroup dpms-vs-vblank-race:
                pass       -> FAIL       (shard-snb) fdo#103060 +2
        Subgroup plain-flip-ts-check:
                pass       -> FAIL       (shard-snb) fdo#100368
Test kms_cursor_legacy:
        Subgroup 2x-long-flip-vs-cursor-atomic:
                pass       -> FAIL       (shard-hsw) fdo#104873
Test drv_suspend:
        Subgroup sysfs-reader:
                pass       -> SKIP       (shard-snb)
Test kms_chv_cursor_fail:
        Subgroup pipe-b-128x128-left-edge:
                pass       -> DMESG-WARN (shard-snb)
        Subgroup pipe-b-128x128-bottom-edge:
                pass       -> DMESG-WARN (shard-snb)
        Subgroup pipe-b-128x128-top-edge:
                dmesg-warn -> PASS       (shard-snb) fdo#105185
Test gem_softpin:
        Subgroup noreloc-s3:
                pass       -> INCOMPLETE (shard-hsw) fdo#103540
Test perf_pmu:
        Subgroup cpu-hotplug:
                incomplete -> SKIP       (shard-apl) fdo#104965
Test kms_frontbuffer_tracking:
        Subgroup fbc-badstride:
                pass       -> SKIP       (shard-snb) fdo#101623
Test kms_plane_multiple:
        Subgroup atomic-pipe-b-tiling-x:
                pass       -> SKIP       (shard-snb)

fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#102254 https://bugs.freedesktop.org/show_bug.cgi?id=102254
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#104873 https://bugs.freedesktop.org/show_bug.cgi?id=104873
fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#104965 https://bugs.freedesktop.org/show_bug.cgi?id=104965
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623

shard-apl        total:3465 pass:1821 dwarn:1   dfail:0   fail:12  skip:1631 time:12519s
shard-hsw        total:3433 pass:1748 dwarn:1   dfail:0   fail:5   skip:1677 time:11184s
shard-snb        total:3465 pass:1351 dwarn:3   dfail:0   fail:4   skip:2107 time:6638s
Blacklisted hosts:
shard-kbl        total:3414 pass:1930 dwarn:1   dfail:0   fail:15  skip:1466 time:9035s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_983/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/3] igt/kms_fbcon_fbt: Handle ENODEV when checking i915_edp_psr_status for chipset support

[Daniel Vetter]

On Thu, Feb 22, 2018 at 07:48:53AM +0000, Lofstedt, Marta wrote:
> 
> 
> > -----Original Message-----
> > From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> > Sent: Thursday, February 22, 2018 9:47 AM
> > To: Lofstedt, Marta <marta.lofstedt@intel.com>; igt-
> > dev@lists.freedesktop.org
> > Subject: Re: [igt-dev] [PATCH i-g-t 1/3] igt/kms_fbcon_fbt: Handle ENODEV
> > when checking i915_edp_psr_status for chipset support
> > 
> > Quoting Marta Lofstedt (2018-02-22 07:43:41)
> > > If the machine doesn't support PSR, it will return -ENODEV from
> > > i915_edp_psr_status, which we want to interpret as unsupported.
> > > This is in line with what Chris just fixed for FBC.
> > >
> > > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> > > ---
> > >  tests/kms_fbcon_fbt.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c index
> > > 1b236f8b..6aa171e6 100644
> > > --- a/tests/kms_fbcon_fbt.c
> > > +++ b/tests/kms_fbcon_fbt.c
> > > @@ -164,6 +164,8 @@ static bool psr_supported_on_chipset(int fd)  {
> > >         char buf[256];
> > >
> > > +       if (*buf == '\0') /* !HAS_PSR -> -ENODEV*/
> > > +               return false;
> > >         igt_debugfs_read(fd, "i915_edp_psr_status", buf);
> > 
> > After the read :)
> 
> Yeah, was way too trigger happy here

Since Chris wrote the same patch from kms_frontbuffer_tracking ... should
we extract these into helpers in lib/ somewhere?
-Daniel

> 
> > 
> > >         return strstr(buf, "Sink_Support: yes\n");  }
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/3] igt/kms_fbcon_fbt: Handle ENODEV when checking i915_edp_psr_status for chipset support

[Lofstedt, Marta]

> -----Original Message-----
> From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel
> Vetter
> Sent: Tuesday, March 6, 2018 4:56 PM
> To: Lofstedt, Marta <marta.lofstedt@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>; igt-dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t 1/3] igt/kms_fbcon_fbt: Handle ENODEV
> when checking i915_edp_psr_status for chipset support
> 
> On Thu, Feb 22, 2018 at 07:48:53AM +0000, Lofstedt, Marta wrote:
> >
> >
> > > -----Original Message-----
> > > From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> > > Sent: Thursday, February 22, 2018 9:47 AM
> > > To: Lofstedt, Marta <marta.lofstedt@intel.com>; igt-
> > > dev@lists.freedesktop.org
> > > Subject: Re: [igt-dev] [PATCH i-g-t 1/3] igt/kms_fbcon_fbt: Handle
> > > ENODEV when checking i915_edp_psr_status for chipset support
> > >
> > > Quoting Marta Lofstedt (2018-02-22 07:43:41)
> > > > If the machine doesn't support PSR, it will return -ENODEV from
> > > > i915_edp_psr_status, which we want to interpret as unsupported.
> > > > This is in line with what Chris just fixed for FBC.
> > > >
> > > > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> > > > ---
> > > >  tests/kms_fbcon_fbt.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c index
> > > > 1b236f8b..6aa171e6 100644
> > > > --- a/tests/kms_fbcon_fbt.c
> > > > +++ b/tests/kms_fbcon_fbt.c
> > > > @@ -164,6 +164,8 @@ static bool psr_supported_on_chipset(int fd)  {
> > > >         char buf[256];
> > > >
> > > > +       if (*buf == '\0') /* !HAS_PSR -> -ENODEV*/
> > > > +               return false;
> > > >         igt_debugfs_read(fd, "i915_edp_psr_status", buf);
> > >
> > > After the read :)
> >
> > Yeah, was way too trigger happy here
> 
> Since Chris wrote the same patch from kms_frontbuffer_tracking ... should
> we extract these into helpers in lib/ somewhere?
> -Daniel

Daniel, this is already merged

> 
> >
> > >
> > > >         return strstr(buf, "Sink_Support: yes\n");  }
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/3] igt/kms_fbcon_fbt: Handle ENODEV when checking i915_edp_psr_status for chipset support

[Daniel Vetter]

On Wed, Mar 07, 2018 at 06:16:14AM +0000, Lofstedt, Marta wrote:
> 
> 
> > -----Original Message-----
> > From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel
> > Vetter
> > Sent: Tuesday, March 6, 2018 4:56 PM
> > To: Lofstedt, Marta <marta.lofstedt@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>; igt-dev@lists.freedesktop.org
> > Subject: Re: [igt-dev] [PATCH i-g-t 1/3] igt/kms_fbcon_fbt: Handle ENODEV
> > when checking i915_edp_psr_status for chipset support
> > 
> > On Thu, Feb 22, 2018 at 07:48:53AM +0000, Lofstedt, Marta wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> > > > Sent: Thursday, February 22, 2018 9:47 AM
> > > > To: Lofstedt, Marta <marta.lofstedt@intel.com>; igt-
> > > > dev@lists.freedesktop.org
> > > > Subject: Re: [igt-dev] [PATCH i-g-t 1/3] igt/kms_fbcon_fbt: Handle
> > > > ENODEV when checking i915_edp_psr_status for chipset support
> > > >
> > > > Quoting Marta Lofstedt (2018-02-22 07:43:41)
> > > > > If the machine doesn't support PSR, it will return -ENODEV from
> > > > > i915_edp_psr_status, which we want to interpret as unsupported.
> > > > > This is in line with what Chris just fixed for FBC.
> > > > >
> > > > > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> > > > > ---
> > > > >  tests/kms_fbcon_fbt.c | 2 ++
> > > > >  1 file changed, 2 insertions(+)
> > > > >
> > > > > diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c index
> > > > > 1b236f8b..6aa171e6 100644
> > > > > --- a/tests/kms_fbcon_fbt.c
> > > > > +++ b/tests/kms_fbcon_fbt.c
> > > > > @@ -164,6 +164,8 @@ static bool psr_supported_on_chipset(int fd)  {
> > > > >         char buf[256];
> > > > >
> > > > > +       if (*buf == '\0') /* !HAS_PSR -> -ENODEV*/
> > > > > +               return false;
> > > > >         igt_debugfs_read(fd, "i915_edp_psr_status", buf);
> > > >
> > > > After the read :)
> > >
> > > Yeah, was way too trigger happy here
> > 
> > Since Chris wrote the same patch from kms_frontbuffer_tracking ... should
> > we extract these into helpers in lib/ somewhere?
> > -Daniel
> 
> Daniel, this is already merged

Well, even more reasons to maybe extract the same code from both places
:-)

Anyway, was just a suggestion for a possible further cleanup.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev