[igt-dev] [PATCH igt] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

[igt-dev] [PATCH igt] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

[Paulo Zanoni]

From: "Lofstedt, Marta" <marta.lofstedt@intel.com>

This is a partial revert of:
64590c7b768dc8d8dd962f812d5ff5a39e7e8b54 ("kms_frontbuffer_tracking:
reduce the FBC wait timeout to 2s")

The subtests: igt@kms_frontbuffer_tracking@fbc-*draw* have
non-consistent results, pending between fail and pass. The fails are
always due to "FBC disabled".  With this increase in timeout the
flip-flop behavior is no longer reproducible.

We did not bisect why exactly this change is now required, since the
retire handler should happen about once per second and only be delayed
if user space is "hostile". Anyway, bumping from 2s to 5s really
reduces the chance that a skipped retirement cycle would affect the
results of the test. In case this still proves to be an issue we may
want to call igt_drop_caches_set(device, DROP_RETIRE), but then we'll
probably need a test that exercises the case where we don't use this
ioctl. For more information, see the discussion of this patch on the
mailing list (Aug/Sep 2017 on intel-gfx). For now let's merge this in
the hope that CI will have less failures.

v2 (from Paulo): update commit message and rebase.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101623
Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 tests/kms_frontbuffer_tracking.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 619186a5..64a80b6d 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -935,7 +935,7 @@ static bool fbc_is_compressing(void)
 
 static bool fbc_wait_for_compression(void)
 {
-	return igt_wait(fbc_is_compressing(), 2000, 1);
+	return igt_wait(fbc_is_compressing(), 5000, 1);
 }
 
 static bool fbc_not_enough_stolen(void)
@@ -958,7 +958,7 @@ static bool fbc_wait_until_enabled(void)
 {
 	last_fbc_buf[0] = '\0';
 
-	return igt_wait(fbc_is_enabled(IGT_LOG_DEBUG), 2000, 1);
+	return igt_wait(fbc_is_enabled(IGT_LOG_DEBUG), 5000, 1);
 }
 
 static bool psr_wait_until_enabled(void)
-- 
2.14.3

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH igt] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

[Chris Wilson]

Quoting Paulo Zanoni (2018-03-21 00:29:45)
> From: "Lofstedt, Marta" <marta.lofstedt@intel.com>
> 
> This is a partial revert of:
> 64590c7b768dc8d8dd962f812d5ff5a39e7e8b54 ("kms_frontbuffer_tracking:
> reduce the FBC wait timeout to 2s")
> 
> The subtests: igt@kms_frontbuffer_tracking@fbc-*draw* have
> non-consistent results, pending between fail and pass. The fails are
> always due to "FBC disabled".  With this increase in timeout the
> flip-flop behavior is no longer reproducible.

We haven't seen this behaviour for a few months, afaict. Currently we
have FBC perma-disabled due to bad mode, underruns and whatnot, and
flip flops from CRC mismatches. But no FBC timeouts waiting for enable.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH igt] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

[Lofstedt, Marta]

> -----Original Message-----
> From: igt-dev [mailto:igt-dev-bounces@lists.freedesktop.org] On Behalf Of
> Chris Wilson
> Sent: Wednesday, March 21, 2018 3:06 AM
> To: Zanoni, Paulo R <paulo.r.zanoni@intel.com>; igt-
> dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH igt] tests/kms_frontbuffer_tracking: increase
> FBC wait timeout to 5s
> 
> Quoting Paulo Zanoni (2018-03-21 00:29:45)
> > From: "Lofstedt, Marta" <marta.lofstedt@intel.com>
> >
> > This is a partial revert of:
> > 64590c7b768dc8d8dd962f812d5ff5a39e7e8b54 ("kms_frontbuffer_tracking:
> > reduce the FBC wait timeout to 2s")
> >
> > The subtests: igt@kms_frontbuffer_tracking@fbc-*draw* have
> > non-consistent results, pending between fail and pass. The fails are
> > always due to "FBC disabled".  With this increase in timeout the
> > flip-flop behavior is no longer reproducible.
> 
> We haven't seen this behaviour for a few months, afaict. Currently we have
> FBC perma-disabled due to bad mode, underruns and whatnot, and flip flops
> from CRC mismatches. But no FBC timeouts waiting for enable.
> -Chris

I agree with Chris that there are multiple flip-flopping going on for the kms_frontbuffer_tracking tests, this really taps into the limitation of cibuglog, but the original issue is still happening. However, I don't think that the timeout increase is a good solution since it will increase the runtime significantly on the machines that continuously fail this test. See, the results from the drmtip runs https://intel-gfx-ci.01.org/tree/drm-tip/drmtip.html 

Also, after we started to feed data from the drmtip runs into cibuglog the impact of this issue has increased drastically. The reason is that I file all occurrences of and error message with:
"(kms_frontbuffer_tracking:2783) CRITICAL: FBC disabled", for example: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4350/shard-glkb2/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html, I file  on this bug: https://bugs.freedesktop.org/show_bug.cgi?id=101623

Error messages like this: " (kms_frontbuffer_tracking:2883) CRITICAL: Failed assertion: !fbc_wait_until_enabled()" ,
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3912/shard-glkb4/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-blt.html
I file on https://bugs.freedesktop.org/show_bug.cgi?id=105503 for GLK-shards and https://bugs.freedesktop.org/show_bug.cgi?id=105520 for the drmtip runs.

BR,
Marta

> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: warning for tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

[Patchwork]

== Series Details ==

Series: tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s
URL   : https://patchwork.freedesktop.org/series/40336/
State : warning

== Summary ==

IGT patchset tested on top of latest successful build
94e886203a99ef19b8319489a45cd348e76e8ccd igt: Replace 'all-engines' magic numbers with macro

with latest DRM-Tip kernel build CI_DRM_3958
9d737cebc219 drm-tip: 2018y-03m-20d-14h-56m-05s UTC integration manifest

No testlist changes.

---- Possible new issues:

Test debugfs_test:
        Subgroup read_all_entries:
                pass       -> DMESG-WARN (fi-skl-6700hq)
Test kms_flip:
        Subgroup basic-flip-vs-wf_vblank:
                pass       -> DMESG-WARN (fi-skl-6700hq)
        Subgroup basic-plain-flip:
                pass       -> DMESG-WARN (fi-skl-6700hq)

---- Known issues:

Test debugfs_test:
        Subgroup read_all_entries:
                pass       -> INCOMPLETE (fi-snb-2520m) fdo#103713
Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                pass       -> FAIL       (fi-gdg-551) fdo#102575
Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                pass       -> DMESG-WARN (fi-skl-6700hq) fdo#101144
Test kms_pipe_crc_basic:
        Subgroup read-crc-pipe-c:
                pass       -> FAIL       (fi-skl-guc) fdo#103191
        Subgroup suspend-read-crc-pipe-a:
                incomplete -> PASS       (fi-cfl-s2) fdo#105641
Test prime_vgem:
        Subgroup basic-fence-flip:
                pass       -> FAIL       (fi-ilk-650) fdo#104008

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#105641 https://bugs.freedesktop.org/show_bug.cgi?id=105641
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008

fi-bdw-5557u     total:285  pass:264  dwarn:0   dfail:0   fail:0   skip:21  time:434s
fi-bdw-gvtdvm    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:441s
fi-blb-e6850     total:285  pass:220  dwarn:1   dfail:0   fail:0   skip:64  time:381s
fi-bsw-n3050     total:285  pass:239  dwarn:0   dfail:0   fail:0   skip:46  time:537s
fi-bwr-2160      total:285  pass:180  dwarn:0   dfail:0   fail:0   skip:105 time:298s
fi-bxt-dsi       total:285  pass:255  dwarn:0   dfail:0   fail:0   skip:30  time:516s
fi-bxt-j4205     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:512s
fi-byt-j1900     total:285  pass:250  dwarn:0   dfail:0   fail:0   skip:35  time:517s
fi-byt-n2820     total:285  pass:246  dwarn:0   dfail:0   fail:0   skip:39  time:505s
fi-cfl-8700k     total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:411s
fi-cfl-s2        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:575s
fi-cfl-u         total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:511s
fi-cnl-drrs      total:285  pass:254  dwarn:3   dfail:0   fail:0   skip:28  time:540s
fi-elk-e7500     total:285  pass:225  dwarn:1   dfail:0   fail:0   skip:59  time:430s
fi-gdg-551       total:285  pass:176  dwarn:0   dfail:0   fail:1   skip:108 time:317s
fi-hsw-4770      total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:402s
fi-ilk-650       total:285  pass:224  dwarn:0   dfail:0   fail:1   skip:60  time:420s
fi-ivb-3520m     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:474s
fi-ivb-3770      total:285  pass:252  dwarn:0   dfail:0   fail:0   skip:33  time:433s
fi-kbl-7500u     total:285  pass:260  dwarn:1   dfail:0   fail:0   skip:24  time:473s
fi-kbl-7567u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:468s
fi-kbl-r         total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:516s
fi-pnv-d510      total:285  pass:219  dwarn:1   dfail:0   fail:0   skip:65  time:662s
fi-skl-6260u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:441s
fi-skl-6600u     total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:535s
fi-skl-6700hq    total:285  pass:255  dwarn:4   dfail:0   fail:0   skip:26  time:554s
fi-skl-6700k2    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:503s
fi-skl-6770hq    total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:491s
fi-skl-guc       total:285  pass:256  dwarn:0   dfail:0   fail:1   skip:28  time:426s
fi-snb-2520m     total:3    pass:2    dwarn:0   dfail:0   fail:0   skip:0  
fi-snb-2600      total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:404s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1173/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH igt] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

[Paulo Zanoni]

Em Qua, 2018-03-21 às 01:06 +0000, Chris Wilson escreveu:
> Quoting Paulo Zanoni (2018-03-21 00:29:45)
> > From: "Lofstedt, Marta" <marta.lofstedt@intel.com>
> > 
> > This is a partial revert of:
> > 64590c7b768dc8d8dd962f812d5ff5a39e7e8b54
> > ("kms_frontbuffer_tracking:
> > reduce the FBC wait timeout to 2s")
> > 
> > The subtests: igt@kms_frontbuffer_tracking@fbc-*draw* have
> > non-consistent results, pending between fail and pass. The fails
> > are
> > always due to "FBC disabled".  With this increase in timeout the
> > flip-flop behavior is no longer reproducible.
> 
> We haven't seen this behaviour for a few months, afaict. Currently we
> have FBC perma-disabled due to bad mode, underruns and whatnot, and
> flip flops from CRC mismatches. But no FBC timeouts waiting for 
> enable.

Then why is it being reported as highest-priority-needs-to-be-fixed-
immediately to me? The goal of the patch would be to try to reduce the
flip-flopping caused by the low timeout so we can better split this
type of problem from the others that may be happening.

> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev