Re: Patch for lttng tools to build on Mac OSX 10.11.6

Re: Patch for lttng tools to build on Mac OSX 10.11.6

[Jérémie Galarneau]

Hi David,

I'm just wondering what is your use-case for building the lttng client
if the session daemon is not built?
We typically also disable building the client (--disable-bin-lttng)
when building the lttng-relayd for macOS.

Thanks,
Jérémie

On 21 May 2017 at 11:30, Dávid Beck <david.beck.priv@gmail.com> wrote:
> Hello Lttng Devs,
>
> Please find a patch attached for building lttng tools with these configure
> flags (on Max OSX):
>
> ./configure --without-lttng-ust --disable-man-pages
> --disable-bin-lttng-consumerd --disable-bin-lttng-sessiond
> --disable-bin-lttng-crash --disable-kmod --disable-extras
>
>
> Best, David
>
>
>
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: Patch for lttng tools to build on Mac OSX 10.11.6

[Dávid Beck]

[-- Attachment #1.1: Type: text/plain, Size: 1801 bytes --]

Hi Jérémie,

I guess this is my lack of lttng understanding.

I wanted to play around with relayd on Mac by having a Linux box generating
the traces and give it a remote relayd for storing the traces locally on my
Mac.

I was thinking that I don't need a local sessiond on the Mac for this, do I?

To answer your question I want to play around with Rust and Lttng on Mac
because I have a few ideas of how to generate a few statistical performance
metrics from the traces. Since this is a midnight project I have the luxury
to do it in a language that I like as opposed to Java (the viewer) or
C/Python (Babeltrace). So eventually I want to build an event collector in
Rust, and to test the data flow I thought it is good to have the relayd on
Mac.

Thank you, David


2017. máj. 23. du. 2:34 ezt írta ("Jérémie Galarneau" <
jeremie.galarneau@efficios.com>):

Hi David,

I'm just wondering what is your use-case for building the lttng client
if the session daemon is not built?
We typically also disable building the client (--disable-bin-lttng)
when building the lttng-relayd for macOS.

Thanks,
Jérémie

On 21 May 2017 at 11:30, Dávid Beck <david.beck.priv@gmail.com> wrote:
> Hello Lttng Devs,
>
> Please find a patch attached for building lttng tools with these configure
> flags (on Max OSX):
>
> ./configure --without-lttng-ust --disable-man-pages
> --disable-bin-lttng-consumerd --disable-bin-lttng-sessiond
> --disable-bin-lttng-crash --disable-kmod --disable-extras
>
>
> Best, David
>
>
>
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>



--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com

[-- Attachment #1.2: Type: text/html, Size: 3020 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: Patch for lttng tools to build on Mac OSX 10.11.6

[Jérémie Galarneau]

On 23 May 2017 at 09:50, Dávid Beck <david.beck.priv@gmail.com> wrote:
> Hi Jérémie,
>
> I guess this is my lack of lttng understanding.
>
> I wanted to play around with relayd on Mac by having a Linux box generating
> the traces and give it a remote relayd for storing the traces locally on my
> Mac.
>
> I was thinking that I don't need a local sessiond on the Mac for this, do I?

Exactly. The relayd is the only daemon that is needed to receive
traces remotely.

>
> To answer your question I want to play around with Rust and Lttng on Mac
> because I have a few ideas of how to generate a few statistical performance
> metrics from the traces. Since this is a midnight project I have the luxury
> to do it in a language that I like as opposed to Java (the viewer) or
> C/Python (Babeltrace). So eventually I want to build an event collector in
> Rust, and to test the data flow I thought it is good to have the relayd on
> Mac.

Good to hear. Don't hesitate to share any progress you make, we're
always interested!

Jérémie

>
> Thank you, David
>
>
>
> 2017. máj. 23. du. 2:34 ezt írta ("Jérémie Galarneau"
> <jeremie.galarneau@efficios.com>):
>
> Hi David,
>
> I'm just wondering what is your use-case for building the lttng client
> if the session daemon is not built?
> We typically also disable building the client (--disable-bin-lttng)
> when building the lttng-relayd for macOS.
>
> Thanks,
> Jérémie
>
> On 21 May 2017 at 11:30, Dávid Beck <david.beck.priv@gmail.com> wrote:
>> Hello Lttng Devs,
>>
>> Please find a patch attached for building lttng tools with these configure
>> flags (on Max OSX):
>>
>> ./configure --without-lttng-ust --disable-man-pages
>> --disable-bin-lttng-consumerd --disable-bin-lttng-sessiond
>> --disable-bin-lttng-crash --disable-kmod --disable-extras
>>
>>
>> Best, David
>>
>>
>>
>>
>> _______________________________________________
>> lttng-dev mailing list
>> lttng-dev@lists.lttng.org
>> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>>
>
>
>
> --
> Jérémie Galarneau
> EfficiOS Inc.
> http://www.efficios.com
>
>



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: Patch for lttng tools to build on Mac OSX 10.11.6

[Michael Jeanson]

On 2017-05-24 10:52, Jérémie Galarneau wrote:
> On 23 May 2017 at 09:50, Dávid Beck <david.beck.priv@gmail.com> wrote:
>> Hi Jérémie,
>>
>> I guess this is my lack of lttng understanding.
>>
>> I wanted to play around with relayd on Mac by having a Linux box generating
>> the traces and give it a remote relayd for storing the traces locally on my
>> Mac.
>>
>> I was thinking that I don't need a local sessiond on the Mac for this, do I?
> 
> Exactly. The relayd is the only daemon that is needed to receive
> traces remotely.
> 
>>
>> To answer your question I want to play around with Rust and Lttng on Mac
>> because I have a few ideas of how to generate a few statistical performance
>> metrics from the traces. Since this is a midnight project I have the luxury
>> to do it in a language that I like as opposed to Java (the viewer) or
>> C/Python (Babeltrace). So eventually I want to build an event collector in
>> Rust, and to test the data flow I thought it is good to have the relayd on
>> Mac.
> 
> Good to hear. Don't hesitate to share any progress you make, we're
> always interested!
> 
> Jérémie
> 
>>
>> Thank you, David

I could make a patch that sets the correct defaults on macOS and other
similar platforms where we only support building the relayd. Thoughts?

Michael
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: Patch for lttng tools to build on Mac OSX 10.11.6

[Jérémie Galarneau]

On 24 May 2017 at 10:57, Michael Jeanson <mjeanson@efficios.com> wrote:
> On 2017-05-24 10:52, Jérémie Galarneau wrote:
>> On 23 May 2017 at 09:50, Dávid Beck <david.beck.priv@gmail.com> wrote:
>>> Hi Jérémie,
>>>
>>> I guess this is my lack of lttng understanding.
>>>
>>> I wanted to play around with relayd on Mac by having a Linux box generating
>>> the traces and give it a remote relayd for storing the traces locally on my
>>> Mac.
>>>
>>> I was thinking that I don't need a local sessiond on the Mac for this, do I?
>>
>> Exactly. The relayd is the only daemon that is needed to receive
>> traces remotely.
>>
>>>
>>> To answer your question I want to play around with Rust and Lttng on Mac
>>> because I have a few ideas of how to generate a few statistical performance
>>> metrics from the traces. Since this is a midnight project I have the luxury
>>> to do it in a language that I like as opposed to Java (the viewer) or
>>> C/Python (Babeltrace). So eventually I want to build an event collector in
>>> Rust, and to test the data flow I thought it is good to have the relayd on
>>> Mac.
>>
>> Good to hear. Don't hesitate to share any progress you make, we're
>> always interested!
>>
>> Jérémie
>>
>>>
>>> Thank you, David
>
> I could make a patch that sets the correct defaults on macOS and other
> similar platforms where we only support building the relayd. Thoughts?

Good idea! It will certainly be less error-prone.

Jérémie

>
> Michael
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: Patch for lttng tools to build on Mac OSX 10.11.6

[Michael Jeanson]

On 2017-05-24 11:11, Jérémie Galarneau wrote:
> 
> Good idea! It will certainly be less error-prone.
> 

I added it to this [1] pull request since it's build system related. It
was tested on macOS 10.12.4.

Michael

[1] https://github.com/lttng/lttng-tools/pull/91

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: Patch for lttng tools to build on Mac OSX 10.11.6

[Jérémie Galarneau]

Hi David,

The pull request Michael referenced was merged and your issue should
be resolved in both the master and stable-2.10 branches.

Jérémie

On 24 May 2017 at 14:06, Michael Jeanson <mjeanson@efficios.com> wrote:
> On 2017-05-24 11:11, Jérémie Galarneau wrote:
>>
>> Good idea! It will certainly be less error-prone.
>>
>
> I added it to this [1] pull request since it's build system related. It
> was tested on macOS 10.12.4.
>
> Michael
>
> [1] https://github.com/lttng/lttng-tools/pull/91
>



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: Patch for lttng tools to build on Mac OSX 10.11.6

[Dávid Beck]

Hi Jérémie,

Sounds great, thank you!

I had a quick look into this pull request and I haven’t found how this relates the issues I found:

1, HOST_NAME_MAX was not defined
2, errno.h was needed on Mac

May be it is only my lack of auto tools knowledge, I don’t know. Anyways, thank you again.

Best, David


> On 01 Jun 2017, at 22:02, Jérémie Galarneau <jeremie.galarneau@efficios.com> wrote:
> 
> Hi David,
> 
> The pull request Michael referenced was merged and your issue should
> be resolved in both the master and stable-2.10 branches.
> 
> Jérémie
> 
> On 24 May 2017 at 14:06, Michael Jeanson <mjeanson@efficios.com> wrote:
>> On 2017-05-24 11:11, Jérémie Galarneau wrote:
>>> 
>>> Good idea! It will certainly be less error-prone.
>>> 
>> 
>> I added it to this [1] pull request since it's build system related. It
>> was tested on macOS 10.12.4.
>> 
>> Michael
>> 
>> [1] https://github.com/lttng/lttng-tools/pull/91
>> 
> 
> 
> 
> -- 
> Jérémie Galarneau
> EfficiOS Inc.
> http://www.efficios.com

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: Patch for lttng tools to build on Mac OSX 10.11.6

[Jérémie Galarneau]

On 1 June 2017 at 17:30, Dávid Beck <david.beck.priv@gmail.com> wrote:
> Hi Jérémie,
>
> Sounds great, thank you!
>
> I had a quick look into this pull request and I haven’t found how this relates the issues I found:
>
> 1, HOST_NAME_MAX was not defined
> 2, errno.h was needed on Mac
>
> May be it is only my lack of auto tools knowledge, I don’t know. Anyways, thank you again.

Indeed, it doesn't fix those issues directly; it disables the build of
everything except the lttng-relayd on macOS in the default build
configuration.

I'm not sure it is worth addressing the build issues, except if
someone can confirm whether or not the rest of the toolchain actually
works on macOS.

Thanks,
Jérémie

>
> Best, David
>
>
>> On 01 Jun 2017, at 22:02, Jérémie Galarneau <jeremie.galarneau@efficios.com> wrote:
>>
>> Hi David,
>>
>> The pull request Michael referenced was merged and your issue should
>> be resolved in both the master and stable-2.10 branches.
>>
>> Jérémie
>>
>> On 24 May 2017 at 14:06, Michael Jeanson <mjeanson@efficios.com> wrote:
>>> On 2017-05-24 11:11, Jérémie Galarneau wrote:
>>>>
>>>> Good idea! It will certainly be less error-prone.
>>>>
>>>
>>> I added it to this [1] pull request since it's build system related. It
>>> was tested on macOS 10.12.4.
>>>
>>> Michael
>>>
>>> [1] https://github.com/lttng/lttng-tools/pull/91
>>>
>>
>>
>>
>> --
>> Jérémie Galarneau
>> EfficiOS Inc.
>> http://www.efficios.com
>



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: Patch for lttng tools to build on Mac OSX 10.11.6

[Dávid Beck]

[-- Attachment #1.1: Type: text/plain, Size: 740 bytes --]


>> 
>> I had a quick look into this pull request and I haven’t found how this relates the issues I found:
>> 
>> 1, HOST_NAME_MAX was not defined
>> 2, errno.h was needed on Mac
>> 
>> May be it is only my lack of auto tools knowledge, I don’t know. Anyways, thank you again.
> 
> Indeed, it doesn't fix those issues directly; it disables the build of
> everything except the lttng-relayd on macOS in the default build
> configuration.

I see. But the fixes I sent you are actually fixing the build of relayd.

I don’t understand how this PR helps then.

> I'm not sure it is worth addressing the build issues, except if
> someone can confirm whether or not the rest of the toolchain actually
> works on macOS.


[-- Attachment #1.2: Type: text/html, Size: 5947 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: Patch for lttng tools to build on Mac OSX 10.11.6

[Jérémie Galarneau]

On 1 June 2017 at 18:03, Dávid Beck <david.beck.priv@gmail.com> wrote:
>
>
> I had a quick look into this pull request and I haven’t found how this
> relates the issues I found:
>
> 1, HOST_NAME_MAX was not defined
> 2, errno.h was needed on Mac
>
> May be it is only my lack of auto tools knowledge, I don’t know. Anyways,
> thank you again.
>
>
> Indeed, it doesn't fix those issues directly; it disables the build of
> everything except the lttng-relayd on macOS in the default build
> configuration.
>
>
> I see. But the fixes I sent you are actually fixing the build of relayd.

Your patch affects two files:

src/bin/lttng/commands/view.c
which is part of the lttng client and not used elsewhere. The client
is not built on macOS anymore (as per the PR).

I won't merge that part unless someone confirms the toolchain works on macOS.

src/common/compat/time.h
This fix looks good, but I'll have to look into it since ci.lttng.org
builds the lttng-relayd on macOS. Perhaps a system header changed
since between 10.11.6 and 10.12.5 (which I think is what the CI is
running).

Jérémie

>
> I don’t understand how this PR helps then.
>
> I'm not sure it is worth addressing the build issues, except if
> someone can confirm whether or not the rest of the toolchain actually
> works on macOS.
>
>



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Patch for lttng tools to build on Mac OSX 10.11.6

[Dávid Beck]

[-- Attachment #1.1: Type: text/plain, Size: 310 bytes --]

Hello Lttng Devs,

Please find a patch attached for building lttng tools with these configure flags (on Max OSX):

./configure --without-lttng-ust --disable-man-pages --disable-bin-lttng-consumerd --disable-bin-lttng-sessiond --disable-bin-lttng-crash --disable-kmod --disable-extras


Best, David



[-- Attachment #1.2.1: Type: text/html, Size: 1053 bytes --]

[-- Attachment #1.2.2: 0001-Fix-build-on-Mac-OSX-10.11.6.patch --]
[-- Type: application/octet-stream, Size: 1258 bytes --]

From b0050fde3ff3e9e81aba8491b00489515e7fd64b Mon Sep 17 00:00:00 2001
From: David Beck <david.beck.priv@gmail.com>
Date: Sun, 21 May 2017 16:18:49 +0100
Subject: [PATCH lttng-tools] Fix build on Mac OSX 10.11.6

Signed-off-by: David Beck <david.beck.priv@gmail.com>
---
 src/bin/lttng/commands/view.c | 9 +++++++++
 src/common/compat/time.h      | 1 +
 2 files changed, 10 insertions(+)

diff --git a/src/bin/lttng/commands/view.c b/src/bin/lttng/commands/view.c
index c9a5fdc..d57f223 100644
--- a/src/bin/lttng/commands/view.c
+++ b/src/bin/lttng/commands/view.c
@@ -24,6 +24,15 @@
 #include <sys/types.h>
 #include <unistd.h>
 
+#ifdef __APPLE__
+#include <limits.h>
+#ifndef HOST_NAME_MAX
+#ifdef _POSIX_HOST_NAME_MAX
+#define HOST_NAME_MAX _POSIX_HOST_NAME_MAX
+#endif /*HOST_NAME_MAX*/
+#endif /*_POSIX_HOST_NAME_MAX*/
+#endif /*__APPLE__*/
+
 #include "../command.h"
 
 static char *opt_session_name;
diff --git a/src/common/compat/time.h b/src/common/compat/time.h
index 17447b3..cf4eb88 100644
--- a/src/common/compat/time.h
+++ b/src/common/compat/time.h
@@ -29,6 +29,7 @@
 
 typedef uint64_t timer_t;
 
+#include <errno.h>
 #include <mach/mach.h>
 #include <mach/clock.h>
 
-- 
2.8.4 (Apple Git-73)


[-- Attachment #1.2.3: Type: text/html, Size: 332 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev