All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] container_of.h: make container_of const-aware
@ 2022-02-10 17:04 Dmitry Baryshkov
  2022-02-11 22:05 ` Andrew Morton
  0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2022-02-10 17:04 UTC (permalink / raw)
  To: linux-kernel, Andrew Morton; +Cc: Andy Shevchenko

container_of() macro has one major drawback. It does not check whether
the passed ptr has a const pointer, the result will always be a
non-const pointer. Use a _Generic() construct (supported since gcc 4.9
and Clang 3.0) to teach container_of that if converting a const pointer,
the returned pointer should also have the const modifier.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 include/linux/container_of.h | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/include/linux/container_of.h b/include/linux/container_of.h
index 2f4944b791b8..269f64e27b09 100644
--- a/include/linux/container_of.h
+++ b/include/linux/container_of.h
@@ -19,7 +19,11 @@
 	static_assert(__same_type(*(ptr), ((type *)0)->member) ||	\
 		      __same_type(*(ptr), void),			\
 		      "pointer type mismatch in container_of()");	\
-	((type *)(__mptr - offsetof(type, member))); })
+	_Generic((ptr),							\
+		const typeof(((type *)0)->member)*:			\
+			((const type *)(__mptr - offsetof(type, member))), \
+		default: ((type *)(__mptr - offsetof(type, member)))	\
+	); })
 
 /**
  * container_of_safe - cast a member of a structure out to the containing structure
@@ -35,6 +39,10 @@
 		      __same_type(*(ptr), void),			\
 		      "pointer type mismatch in container_of_safe()");	\
 	IS_ERR_OR_NULL(__mptr) ? ERR_CAST(__mptr) :			\
-		((type *)(__mptr - offsetof(type, member))); })
+	_Generic((ptr),							\
+		const typeof(((type *)0)->member)*:			\
+			((const type *)(__mptr - offsetof(type, member))), \
+		default: ((type *)(__mptr - offsetof(type, member)))	\
+	); })
 
 #endif	/* _LINUX_CONTAINER_OF_H */
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-02-11 22:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10 17:04 [PATCH] container_of.h: make container_of const-aware Dmitry Baryshkov
2022-02-11 22:05 ` Andrew Morton
2022-02-11 22:10   ` Dmitry Baryshkov
2022-02-11 22:18     ` Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.