From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Bjorn Andersson <quic_bjorande@quicinc.com> Cc: Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Kalyan Thota <quic_kalyant@quicinc.com>, Jessica Zhang <quic_jesszhan@quicinc.com>, Kuogee Hsieh <quic_khsieh@quicinc.com>, Johan Hovold <johan+linaro@kernel.org>, Sankeerth Billakanti <quic_sbillaka@quicinc.com>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 11/12] arm64: dts: qcom: sc8280xp-crd: Enable EDP Date: Fri, 9 Dec 2022 13:30:05 +0200 [thread overview] Message-ID: <CAA8EJpp8oSW=yEi_QvL1PzF5yhfHsbC7WLD8Lic1R5A_o0i9SA@mail.gmail.com> (raw) In-Reply-To: <20221207220012.16529-12-quic_bjorande@quicinc.com> On Thu, 8 Dec 2022 at 00:00, Bjorn Andersson <quic_bjorande@quicinc.com> wrote: > > From: Bjorn Andersson <bjorn.andersson@linaro.org> > > The SC8280XP CRD has a EDP display on MDSS0 DP3, enable relevant nodes > and link it together with the backlight control. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > --- > > Changes since v4: > - None > > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 72 ++++++++++++++++++++++- > 1 file changed, 71 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > index f09810e3d956..a7d2384cbbe8 100644 [skipped] > @@ -230,6 +246,54 @@ vreg_l9d: ldo9 { > }; > }; > > +&dispcc0 { > + status = "okay"; > +}; > + > +&mdss0 { > + status = "okay"; > +}; > + > +&mdss0_dp3 { > + compatible = "qcom,sc8280xp-edp"; > + status = "okay"; > + > + data-lanes = <0 1 2 3>; I hope to land Kuogee patches that move data-lanes to the endpoint node, where they belong. Do we have any good way to proceed here? Or would it be easier to land this patch as is and then, maybe next cycle, move the property? > + > + aux-bus { > + panel { > + compatible = "edp-panel"; > + power-supply = <&vreg_edp_3p3>; > + > + backlight = <&backlight>; > + > + ports { > + port { > + edp_panel_in: endpoint { > + remote-endpoint = <&mdss0_dp3_out>; > + }; > + }; > + }; > + }; > + }; > + > + ports { > + port@1 { > + reg = <1>; > + mdss0_dp3_out: endpoint { > + remote-endpoint = <&edp_panel_in>; > + }; > + }; > + }; > +}; > + > +&mdss0_dp3_phy { > + status = "okay"; > + > + vdda-phy-supply = <&vreg_l6b>; > + vdda-pll-supply = <&vreg_l3b>; > +}; > + > &pcie2a { > perst-gpios = <&tlmm 143 GPIO_ACTIVE_LOW>; > wake-gpios = <&tlmm 145 GPIO_ACTIVE_LOW>; > @@ -496,6 +560,12 @@ hastings_reg_en: hastings-reg-en-state { > &tlmm { > gpio-reserved-ranges = <74 6>, <83 4>, <125 2>, <128 2>, <154 7>; > > + edp_reg_en: edp-reg-en-state { > + pins = "gpio25"; > + function = "gpio"; > + output-enable; > + }; > + > kybd_default: kybd-default-state { > disable-pins { > pins = "gpio102"; > -- > 2.37.3 > -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Bjorn Andersson <quic_bjorande@quicinc.com> Cc: Kalyan Thota <quic_kalyant@quicinc.com>, freedreno@lists.freedesktop.org, Sankeerth Billakanti <quic_sbillaka@quicinc.com>, linux-kernel@vger.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, devicetree@vger.kernel.org, Sean Paul <sean@poorly.run>, Bjorn Andersson <andersson@kernel.org>, Abhinav Kumar <quic_abhinavk@quicinc.com>, dri-devel@lists.freedesktop.org, Kuogee Hsieh <quic_khsieh@quicinc.com>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, linux-arm-msm@vger.kernel.org, Jessica Zhang <quic_jesszhan@quicinc.com>, Johan Hovold <johan+linaro@kernel.org> Subject: Re: [PATCH v5 11/12] arm64: dts: qcom: sc8280xp-crd: Enable EDP Date: Fri, 9 Dec 2022 13:30:05 +0200 [thread overview] Message-ID: <CAA8EJpp8oSW=yEi_QvL1PzF5yhfHsbC7WLD8Lic1R5A_o0i9SA@mail.gmail.com> (raw) In-Reply-To: <20221207220012.16529-12-quic_bjorande@quicinc.com> On Thu, 8 Dec 2022 at 00:00, Bjorn Andersson <quic_bjorande@quicinc.com> wrote: > > From: Bjorn Andersson <bjorn.andersson@linaro.org> > > The SC8280XP CRD has a EDP display on MDSS0 DP3, enable relevant nodes > and link it together with the backlight control. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > --- > > Changes since v4: > - None > > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 72 ++++++++++++++++++++++- > 1 file changed, 71 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > index f09810e3d956..a7d2384cbbe8 100644 [skipped] > @@ -230,6 +246,54 @@ vreg_l9d: ldo9 { > }; > }; > > +&dispcc0 { > + status = "okay"; > +}; > + > +&mdss0 { > + status = "okay"; > +}; > + > +&mdss0_dp3 { > + compatible = "qcom,sc8280xp-edp"; > + status = "okay"; > + > + data-lanes = <0 1 2 3>; I hope to land Kuogee patches that move data-lanes to the endpoint node, where they belong. Do we have any good way to proceed here? Or would it be easier to land this patch as is and then, maybe next cycle, move the property? > + > + aux-bus { > + panel { > + compatible = "edp-panel"; > + power-supply = <&vreg_edp_3p3>; > + > + backlight = <&backlight>; > + > + ports { > + port { > + edp_panel_in: endpoint { > + remote-endpoint = <&mdss0_dp3_out>; > + }; > + }; > + }; > + }; > + }; > + > + ports { > + port@1 { > + reg = <1>; > + mdss0_dp3_out: endpoint { > + remote-endpoint = <&edp_panel_in>; > + }; > + }; > + }; > +}; > + > +&mdss0_dp3_phy { > + status = "okay"; > + > + vdda-phy-supply = <&vreg_l6b>; > + vdda-pll-supply = <&vreg_l3b>; > +}; > + > &pcie2a { > perst-gpios = <&tlmm 143 GPIO_ACTIVE_LOW>; > wake-gpios = <&tlmm 145 GPIO_ACTIVE_LOW>; > @@ -496,6 +560,12 @@ hastings_reg_en: hastings-reg-en-state { > &tlmm { > gpio-reserved-ranges = <74 6>, <83 4>, <125 2>, <128 2>, <154 7>; > > + edp_reg_en: edp-reg-en-state { > + pins = "gpio25"; > + function = "gpio"; > + output-enable; > + }; > + > kybd_default: kybd-default-state { > disable-pins { > pins = "gpio102"; > -- > 2.37.3 > -- With best wishes Dmitry
next prev parent reply other threads:[~2022-12-09 11:30 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-07 22:00 [PATCH v5 00/12] drm/msm: Add SC8280XP support Bjorn Andersson 2022-12-07 22:00 ` Bjorn Andersson 2022-12-07 22:00 ` [PATCH v5 01/12] dt-bindings: display/msm: Add binding for SC8280XP MDSS Bjorn Andersson 2022-12-07 22:00 ` Bjorn Andersson 2022-12-07 22:00 ` [PATCH v5 02/12] drm/msm/dpu: Introduce SC8280XP Bjorn Andersson 2022-12-07 22:00 ` Bjorn Andersson 2022-12-07 23:30 ` Dmitry Baryshkov 2022-12-07 23:30 ` Dmitry Baryshkov 2022-12-08 23:31 ` Kuogee Hsieh 2022-12-08 23:31 ` Kuogee Hsieh 2023-01-08 21:47 ` Dmitry Baryshkov 2023-01-08 21:47 ` Dmitry Baryshkov 2022-12-07 22:00 ` [PATCH v5 03/12] drm/msm: Introduce SC8280XP MDSS Bjorn Andersson 2022-12-07 22:00 ` Bjorn Andersson 2022-12-08 23:32 ` Kuogee Hsieh 2022-12-08 23:32 ` Kuogee Hsieh 2022-12-07 22:00 ` [PATCH v5 04/12] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles Bjorn Andersson 2022-12-07 22:00 ` Bjorn Andersson 2022-12-08 23:15 ` Dmitry Baryshkov 2022-12-08 23:15 ` Dmitry Baryshkov 2022-12-07 22:00 ` [PATCH v5 05/12] drm/msm/dp: Stop using DP id as index in desc Bjorn Andersson 2022-12-07 22:00 ` Bjorn Andersson 2022-12-08 23:12 ` Kuogee Hsieh 2022-12-08 23:12 ` Kuogee Hsieh 2022-12-07 22:00 ` [PATCH v5 06/12] drm/msm/dp: Add DP and EDP compatibles for SC8280XP Bjorn Andersson 2022-12-07 22:00 ` Bjorn Andersson 2022-12-08 23:13 ` Kuogee Hsieh 2022-12-08 23:13 ` Kuogee Hsieh 2022-12-07 22:00 ` [PATCH v5 07/12] drm/msm/dp: Add SDM845 DisplayPort instance Bjorn Andersson 2022-12-07 22:00 ` Bjorn Andersson 2022-12-08 23:14 ` Kuogee Hsieh 2022-12-08 23:14 ` Kuogee Hsieh 2022-12-07 22:00 ` [PATCH v5 08/12] drm/msm/dp: Rely on hpd_enable/disable callbacks Bjorn Andersson 2022-12-07 22:00 ` Bjorn Andersson 2022-12-08 23:14 ` Kuogee Hsieh 2022-12-08 23:14 ` Kuogee Hsieh 2022-12-07 22:00 ` [PATCH v5 09/12] drm/msm/dp: Implement hpd_notify() Bjorn Andersson 2022-12-07 22:00 ` Bjorn Andersson 2022-12-08 23:15 ` Kuogee Hsieh 2022-12-08 23:15 ` Kuogee Hsieh 2022-12-07 22:00 ` [PATCH v5 10/12] arm64: dts: qcom: sc8280xp: Define some of the display blocks Bjorn Andersson 2022-12-07 22:00 ` Bjorn Andersson 2022-12-09 10:52 ` Johan Hovold 2022-12-09 10:52 ` Johan Hovold 2023-01-18 2:58 ` Dmitry Baryshkov 2023-01-18 2:58 ` Dmitry Baryshkov 2023-01-19 18:12 ` Bjorn Andersson 2023-01-19 18:12 ` Bjorn Andersson 2022-12-07 22:00 ` [PATCH v5 11/12] arm64: dts: qcom: sc8280xp-crd: Enable EDP Bjorn Andersson 2022-12-07 22:00 ` Bjorn Andersson 2022-12-09 10:35 ` Johan Hovold 2022-12-09 10:35 ` Johan Hovold 2022-12-13 15:10 ` Bjorn Andersson 2022-12-13 15:10 ` Bjorn Andersson 2022-12-13 16:26 ` Johan Hovold 2022-12-13 16:26 ` Johan Hovold 2022-12-09 11:30 ` Dmitry Baryshkov [this message] 2022-12-09 11:30 ` Dmitry Baryshkov 2022-12-07 22:00 ` [PATCH v5 12/12] arm64: dts: qcom: sa8295-adp: Enable DP instances Bjorn Andersson 2022-12-07 22:00 ` Bjorn Andersson 2022-12-09 10:44 ` Johan Hovold 2022-12-09 10:44 ` Johan Hovold 2022-12-09 2:49 ` [PATCH v5 00/12] drm/msm: Add SC8280XP support Steev Klimaszewski 2022-12-09 2:49 ` Steev Klimaszewski 2023-01-09 22:41 ` Dmitry Baryshkov 2023-01-09 23:43 ` Dmitry Baryshkov 2023-01-09 23:43 ` Dmitry Baryshkov 2023-01-09 22:41 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAA8EJpp8oSW=yEi_QvL1PzF5yhfHsbC7WLD8Lic1R5A_o0i9SA@mail.gmail.com' \ --to=dmitry.baryshkov@linaro.org \ --cc=airlied@gmail.com \ --cc=andersson@kernel.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=johan+linaro@kernel.org \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_bjorande@quicinc.com \ --cc=quic_jesszhan@quicinc.com \ --cc=quic_kalyant@quicinc.com \ --cc=quic_khsieh@quicinc.com \ --cc=quic_sbillaka@quicinc.com \ --cc=robdclark@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.