From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Sankeerth Billakanti <quic_sbillaka@quicinc.com> Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robdclark@gmail.com, seanpaul@chromium.org, swboyd@chromium.org, quic_kalyant@quicinc.com, quic_abhinavk@quicinc.com, dianders@chromium.org, quic_khsieh@quicinc.com, bjorn.andersson@linaro.org, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, quic_vproddut@quicinc.com, quic_aravindh@quicinc.com Subject: Re: [PATCH v6 4/8] drm/msm/dp: avoid handling masked interrupts Date: Thu, 31 Mar 2022 01:16:23 +0300 [thread overview] Message-ID: <CAA8EJprMvik_6xmGt2oZGpDG9FoMtC_ojuw+oTjPLTck4Hu3WA@mail.gmail.com> (raw) In-Reply-To: <1648656179-10347-5-git-send-email-quic_sbillaka@quicinc.com> On Wed, 30 Mar 2022 at 19:03, Sankeerth Billakanti <quic_sbillaka@quicinc.com> wrote: > > The interrupt register will still reflect the connect and disconnect > interrupt status without generating an actual HW interrupt. > The controller driver should not handle those masked interrupts. > > Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> > --- > drivers/gpu/drm/msm/dp/dp_catalog.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c b/drivers/gpu/drm/msm/dp/dp_catalog.c > index 3c16f95..1809ce2 100644 > --- a/drivers/gpu/drm/msm/dp/dp_catalog.c > +++ b/drivers/gpu/drm/msm/dp/dp_catalog.c > @@ -608,13 +608,14 @@ u32 dp_catalog_hpd_get_intr_status(struct dp_catalog *dp_catalog) > { > struct dp_catalog_private *catalog = container_of(dp_catalog, > struct dp_catalog_private, dp_catalog); > - int isr = 0; > + int isr, mask; > > isr = dp_read_aux(catalog, REG_DP_DP_HPD_INT_STATUS); > dp_write_aux(catalog, REG_DP_DP_HPD_INT_ACK, > (isr & DP_DP_HPD_INT_MASK)); > + mask = dp_read_aux(catalog, REG_DP_DP_HPD_INT_MASK); > > - return isr; > + return isr & (DP_DP_HPD_STATE_STATUS_MASK | mask); I suspect that the logic is inverted here. Shouldn't it be: return isr & DP_DP_HPD_STATE_STATUS_MASK & mask; ? > } > > int dp_catalog_ctrl_get_interrupt(struct dp_catalog *dp_catalog) > -- > 2.7.4 > -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Sankeerth Billakanti <quic_sbillaka@quicinc.com> Cc: quic_kalyant@quicinc.com, devicetree@vger.kernel.org, bjorn.andersson@linaro.org, dianders@chromium.org, quic_abhinavk@quicinc.com, quic_vproddut@quicinc.com, airlied@linux.ie, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, swboyd@chromium.org, sean@poorly.run, seanpaul@chromium.org, quic_aravindh@quicinc.com, quic_khsieh@quicinc.com, freedreno@lists.freedesktop.org Subject: Re: [PATCH v6 4/8] drm/msm/dp: avoid handling masked interrupts Date: Thu, 31 Mar 2022 01:16:23 +0300 [thread overview] Message-ID: <CAA8EJprMvik_6xmGt2oZGpDG9FoMtC_ojuw+oTjPLTck4Hu3WA@mail.gmail.com> (raw) In-Reply-To: <1648656179-10347-5-git-send-email-quic_sbillaka@quicinc.com> On Wed, 30 Mar 2022 at 19:03, Sankeerth Billakanti <quic_sbillaka@quicinc.com> wrote: > > The interrupt register will still reflect the connect and disconnect > interrupt status without generating an actual HW interrupt. > The controller driver should not handle those masked interrupts. > > Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> > --- > drivers/gpu/drm/msm/dp/dp_catalog.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c b/drivers/gpu/drm/msm/dp/dp_catalog.c > index 3c16f95..1809ce2 100644 > --- a/drivers/gpu/drm/msm/dp/dp_catalog.c > +++ b/drivers/gpu/drm/msm/dp/dp_catalog.c > @@ -608,13 +608,14 @@ u32 dp_catalog_hpd_get_intr_status(struct dp_catalog *dp_catalog) > { > struct dp_catalog_private *catalog = container_of(dp_catalog, > struct dp_catalog_private, dp_catalog); > - int isr = 0; > + int isr, mask; > > isr = dp_read_aux(catalog, REG_DP_DP_HPD_INT_STATUS); > dp_write_aux(catalog, REG_DP_DP_HPD_INT_ACK, > (isr & DP_DP_HPD_INT_MASK)); > + mask = dp_read_aux(catalog, REG_DP_DP_HPD_INT_MASK); > > - return isr; > + return isr & (DP_DP_HPD_STATE_STATUS_MASK | mask); I suspect that the logic is inverted here. Shouldn't it be: return isr & DP_DP_HPD_STATE_STATUS_MASK & mask; ? > } > > int dp_catalog_ctrl_get_interrupt(struct dp_catalog *dp_catalog) > -- > 2.7.4 > -- With best wishes Dmitry
next prev parent reply other threads:[~2022-03-30 22:16 UTC|newest] Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-30 16:02 [PATCH v6 0/8] Add support for the eDP panel over aux_bus Sankeerth Billakanti 2022-03-30 16:02 ` Sankeerth Billakanti 2022-03-30 16:02 ` [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus Sankeerth Billakanti 2022-03-30 16:02 ` Sankeerth Billakanti 2022-03-30 23:19 ` Dmitry Baryshkov 2022-03-30 23:19 ` Dmitry Baryshkov 2022-03-31 0:33 ` Doug Anderson 2022-03-31 0:33 ` Doug Anderson 2022-03-31 23:22 ` Doug Anderson 2022-03-31 23:22 ` Doug Anderson 2022-04-02 10:37 ` Dmitry Baryshkov 2022-04-02 10:37 ` Dmitry Baryshkov 2022-04-02 17:06 ` Doug Anderson 2022-04-02 17:06 ` Doug Anderson 2022-04-02 20:26 ` Dmitry Baryshkov 2022-04-02 20:26 ` Dmitry Baryshkov 2022-04-04 20:53 ` Doug Anderson 2022-04-04 20:53 ` Doug Anderson 2022-04-05 12:53 ` Dmitry Baryshkov 2022-04-05 12:53 ` Dmitry Baryshkov 2022-04-05 17:02 ` Doug Anderson 2022-04-05 17:02 ` Doug Anderson 2022-04-05 17:36 ` Dmitry Baryshkov 2022-04-05 17:36 ` Dmitry Baryshkov 2022-04-05 18:11 ` Doug Anderson 2022-04-05 18:11 ` Doug Anderson 2022-04-07 14:19 ` Sankeerth Billakanti (QUIC) 2022-04-07 14:19 ` Sankeerth Billakanti (QUIC) 2022-04-07 17:07 ` Doug Anderson 2022-04-07 17:07 ` Doug Anderson 2022-04-07 20:11 ` Abhinav Kumar 2022-04-07 20:11 ` Abhinav Kumar 2022-04-07 20:47 ` Doug Anderson 2022-04-07 20:47 ` Doug Anderson 2022-04-07 22:03 ` Abhinav Kumar 2022-04-07 22:03 ` Abhinav Kumar 2022-04-07 23:34 ` Doug Anderson 2022-04-07 23:34 ` Doug Anderson 2022-04-07 23:46 ` Dmitry Baryshkov 2022-04-07 23:46 ` Dmitry Baryshkov 2022-04-08 0:21 ` Doug Anderson 2022-04-08 0:21 ` Doug Anderson 2022-04-08 12:19 ` Dmitry Baryshkov 2022-04-08 12:19 ` Dmitry Baryshkov 2022-04-08 13:43 ` Doug Anderson 2022-04-08 13:43 ` Doug Anderson 2022-04-08 14:58 ` Dmitry Baryshkov 2022-04-08 14:58 ` Dmitry Baryshkov 2022-04-08 17:23 ` Abhinav Kumar 2022-04-08 17:23 ` Abhinav Kumar 2022-04-07 23:35 ` Dmitry Baryshkov 2022-04-07 23:35 ` Dmitry Baryshkov 2022-04-08 0:20 ` Doug Anderson 2022-04-08 0:20 ` Doug Anderson 2022-04-08 12:13 ` Dmitry Baryshkov 2022-04-08 12:13 ` Dmitry Baryshkov 2022-04-08 13:56 ` Doug Anderson 2022-04-08 13:56 ` Doug Anderson 2022-04-08 14:17 ` Dmitry Baryshkov 2022-04-08 14:17 ` Dmitry Baryshkov 2022-03-30 16:02 ` [PATCH v6 2/8] drm/msm/dp: wait for hpd high before aux transaction Sankeerth Billakanti 2022-03-30 16:02 ` Sankeerth Billakanti 2022-03-31 23:22 ` Doug Anderson 2022-03-31 23:22 ` Doug Anderson 2022-04-04 12:43 ` Sankeerth Billakanti (QUIC) 2022-04-04 12:43 ` Sankeerth Billakanti (QUIC) 2022-03-30 16:02 ` [PATCH v6 3/8] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP Sankeerth Billakanti 2022-03-30 16:02 ` Sankeerth Billakanti 2022-03-31 23:22 ` Doug Anderson 2022-03-31 23:22 ` Doug Anderson 2022-04-04 12:56 ` Sankeerth Billakanti (QUIC) 2022-04-04 12:56 ` Sankeerth Billakanti (QUIC) 2022-03-30 16:02 ` [PATCH v6 4/8] drm/msm/dp: avoid handling masked interrupts Sankeerth Billakanti 2022-03-30 16:02 ` Sankeerth Billakanti 2022-03-30 22:16 ` Dmitry Baryshkov [this message] 2022-03-30 22:16 ` Dmitry Baryshkov 2022-03-31 5:53 ` Sankeerth Billakanti (QUIC) 2022-03-31 5:53 ` Sankeerth Billakanti (QUIC) 2022-03-31 10:10 ` Dmitry Baryshkov 2022-03-31 10:10 ` Dmitry Baryshkov 2022-03-31 11:04 ` Sankeerth Billakanti 2022-03-31 11:04 ` Sankeerth Billakanti 2022-03-31 11:06 ` Dmitry Baryshkov 2022-03-31 11:06 ` Dmitry Baryshkov 2022-04-04 17:56 ` Sankeerth Billakanti (QUIC) 2022-04-04 17:56 ` Sankeerth Billakanti (QUIC) 2022-03-30 16:02 ` [PATCH v6 5/8] drm/msm/dp: prevent multiple votes for dp resources Sankeerth Billakanti 2022-03-30 16:02 ` Sankeerth Billakanti 2022-03-31 23:23 ` Doug Anderson 2022-03-31 23:23 ` Doug Anderson 2022-04-08 16:14 ` Dmitry Baryshkov 2022-04-08 16:14 ` Dmitry Baryshkov 2022-04-08 17:12 ` Sankeerth Billakanti 2022-04-08 17:12 ` Sankeerth Billakanti 2022-04-08 18:02 ` Dmitry Baryshkov 2022-04-08 18:02 ` Dmitry Baryshkov 2022-03-30 16:02 ` [PATCH v6 6/8] drm/msm/dp: remove unnecessary delay during boot Sankeerth Billakanti 2022-03-30 16:02 ` Sankeerth Billakanti 2022-03-31 23:23 ` Doug Anderson 2022-03-31 23:23 ` Doug Anderson 2022-04-04 13:52 ` Sankeerth Billakanti (QUIC) 2022-04-04 13:52 ` Sankeerth Billakanti (QUIC) 2022-04-04 21:13 ` Dmitry Baryshkov 2022-04-04 21:13 ` Dmitry Baryshkov 2022-04-07 12:40 ` Sankeerth Billakanti (QUIC) 2022-04-07 12:40 ` Sankeerth Billakanti (QUIC) 2022-03-30 16:02 ` [PATCH v6 7/8] drm/msm/dp: Support edp/dp without hpd Sankeerth Billakanti 2022-03-30 16:02 ` Sankeerth Billakanti 2022-03-31 23:23 ` Doug Anderson 2022-03-31 23:23 ` Doug Anderson 2022-04-04 18:32 ` Sankeerth Billakanti (QUIC) 2022-04-04 18:32 ` Sankeerth Billakanti (QUIC) 2022-04-04 21:15 ` Dmitry Baryshkov 2022-04-04 21:15 ` Dmitry Baryshkov 2022-04-07 12:41 ` Sankeerth Billakanti (QUIC) 2022-04-07 12:41 ` Sankeerth Billakanti (QUIC) 2022-03-30 16:02 ` [PATCH v6 8/8] drm/msm/dp: Handle eDP mode_valid differently from dp Sankeerth Billakanti 2022-03-30 16:02 ` Sankeerth Billakanti 2022-03-30 22:08 ` Dmitry Baryshkov 2022-03-30 22:08 ` Dmitry Baryshkov 2022-03-31 6:02 ` Sankeerth Billakanti (QUIC) 2022-03-31 6:02 ` Sankeerth Billakanti (QUIC) 2022-03-31 23:24 ` Doug Anderson 2022-03-31 23:24 ` Doug Anderson 2022-04-04 18:20 ` Sankeerth Billakanti (QUIC) 2022-04-04 18:20 ` Sankeerth Billakanti (QUIC) 2022-04-04 21:29 ` Dmitry Baryshkov 2022-04-04 21:29 ` Dmitry Baryshkov 2022-04-07 14:05 ` Sankeerth Billakanti (QUIC) 2022-04-07 14:05 ` Sankeerth Billakanti (QUIC) 2022-04-08 12:08 ` Dmitry Baryshkov 2022-04-08 12:08 ` Dmitry Baryshkov 2022-04-08 15:50 ` Sankeerth Billakanti 2022-04-08 15:50 ` Sankeerth Billakanti 2022-04-08 16:47 ` Dmitry Baryshkov 2022-04-08 16:47 ` Dmitry Baryshkov 2022-04-08 17:38 ` Sankeerth Billakanti 2022-04-08 17:38 ` Sankeerth Billakanti 2022-04-08 18:06 ` Dmitry Baryshkov 2022-04-08 18:06 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAA8EJprMvik_6xmGt2oZGpDG9FoMtC_ojuw+oTjPLTck4Hu3WA@mail.gmail.com \ --to=dmitry.baryshkov@linaro.org \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_aravindh@quicinc.com \ --cc=quic_kalyant@quicinc.com \ --cc=quic_khsieh@quicinc.com \ --cc=quic_sbillaka@quicinc.com \ --cc=quic_vproddut@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ --cc=seanpaul@chromium.org \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.