* [PATCH] soc: qcom: socinfo: Fix an off by one in qcom_show_pmic_model()
@ 2021-01-20 9:57 ` Dan Carpenter
0 siblings, 0 replies; 13+ messages in thread
From: Dan Carpenter @ 2021-01-20 9:57 UTC (permalink / raw)
To: Andy Gross, Dmitry Baryshkov
Cc: Bjorn Andersson, Stephen Boyd, Sai Prakash Ranjan,
Douglas Anderson, linux-arm-msm, linux-kernel, kernel-janitors
These need to be < ARRAY_SIZE() instead of <= ARRAY_SIZE() to prevent
accessing one element beyond the end of the array.
Fixes: e9247e2ce577 ("soc: qcom: socinfo: fix printing of pmic_model")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/soc/qcom/socinfo.c | 2 +-
1 file changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index a985ed064669..5b4ad24a022b 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -309,7 +309,7 @@ static int qcom_show_pmic_model(struct seq_file *seq, void *p)
if (model < 0)
return -EINVAL;
- if (model <= ARRAY_SIZE(pmic_models) && pmic_models[model])
+ if (model < ARRAY_SIZE(pmic_models) && pmic_models[model])
seq_printf(seq, "%s\n", pmic_models[model]);
else
seq_printf(seq, "unknown (%d)\n", model);
--
2.29.2
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] soc: qcom: socinfo: Fix an off by one in qcom_show_pmic_model()
2021-01-20 9:57 ` Dan Carpenter
@ 2021-01-20 16:25 ` Doug Anderson
-1 siblings, 0 replies; 13+ messages in thread
From: Doug Anderson @ 2021-01-20 16:25 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andy Gross, Dmitry Baryshkov, Bjorn Andersson, Stephen Boyd,
Sai Prakash Ranjan, linux-arm-msm, LKML, kernel-janitors
Hi,
On Wed, Jan 20, 2021 at 1:58 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> These need to be < ARRAY_SIZE() instead of <= ARRAY_SIZE() to prevent
> accessing one element beyond the end of the array.
>
> Fixes: e9247e2ce577 ("soc: qcom: socinfo: fix printing of pmic_model")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/soc/qcom/socinfo.c | 2 +-
> 1 file changed, 1 insertions(+), 1 deletions(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] soc: qcom: socinfo: Fix an off by one in qcom_show_pmic_model()
@ 2021-01-20 16:25 ` Doug Anderson
0 siblings, 0 replies; 13+ messages in thread
From: Doug Anderson @ 2021-01-20 16:25 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andy Gross, Dmitry Baryshkov, Bjorn Andersson, Stephen Boyd,
Sai Prakash Ranjan, linux-arm-msm, LKML, kernel-janitors
Hi,
On Wed, Jan 20, 2021 at 1:58 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> These need to be < ARRAY_SIZE() instead of <= ARRAY_SIZE() to prevent
> accessing one element beyond the end of the array.
>
> Fixes: e9247e2ce577 ("soc: qcom: socinfo: fix printing of pmic_model")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/soc/qcom/socinfo.c | 2 +-
> 1 file changed, 1 insertions(+), 1 deletions(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] soc: qcom: socinfo: Fix an off by one in qcom_show_pmic_model()
2021-01-20 9:57 ` Dan Carpenter
@ 2021-01-20 17:55 ` Dmitry Baryshkov
-1 siblings, 0 replies; 13+ messages in thread
From: Dmitry Baryshkov @ 2021-01-20 17:55 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andy Gross, Bjorn Andersson, Stephen Boyd, Sai Prakash Ranjan,
Douglas Anderson, open list:DRM DRIVER FOR MSM ADRENO GPU,
open list, kernel-janitors
On Wed, 20 Jan 2021 at 12:58, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> These need to be < ARRAY_SIZE() instead of <= ARRAY_SIZE() to prevent
> accessing one element beyond the end of the array.
>
> Fixes: e9247e2ce577 ("soc: qcom: socinfo: fix printing of pmic_model")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] soc: qcom: socinfo: Fix an off by one in qcom_show_pmic_model()
@ 2021-01-20 17:55 ` Dmitry Baryshkov
0 siblings, 0 replies; 13+ messages in thread
From: Dmitry Baryshkov @ 2021-01-20 17:55 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andy Gross, Bjorn Andersson, Stephen Boyd, Sai Prakash Ranjan,
Douglas Anderson, open list:DRM DRIVER FOR MSM ADRENO GPU,
open list, kernel-janitors
On Wed, 20 Jan 2021 at 12:58, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> These need to be < ARRAY_SIZE() instead of <= ARRAY_SIZE() to prevent
> accessing one element beyond the end of the array.
>
> Fixes: e9247e2ce577 ("soc: qcom: socinfo: fix printing of pmic_model")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] soc: qcom: socinfo: Fix an off by one in qcom_show_pmic_model()
2021-01-20 9:57 ` Dan Carpenter
@ 2021-01-20 18:32 ` Stephen Boyd
-1 siblings, 0 replies; 13+ messages in thread
From: Stephen Boyd @ 2021-01-20 18:32 UTC (permalink / raw)
To: Andy Gross, Dan Carpenter, Dmitry Baryshkov
Cc: Bjorn Andersson, Sai Prakash Ranjan, Douglas Anderson,
linux-arm-msm, linux-kernel, kernel-janitors
Quoting Dan Carpenter (2021-01-20 01:57:55)
> These need to be < ARRAY_SIZE() instead of <= ARRAY_SIZE() to prevent
> accessing one element beyond the end of the array.
>
> Fixes: e9247e2ce577 ("soc: qcom: socinfo: fix printing of pmic_model")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] soc: qcom: socinfo: Fix an off by one in qcom_show_pmic_model()
@ 2021-01-20 18:32 ` Stephen Boyd
0 siblings, 0 replies; 13+ messages in thread
From: Stephen Boyd @ 2021-01-20 18:32 UTC (permalink / raw)
To: Andy Gross, Dan Carpenter, Dmitry Baryshkov
Cc: Bjorn Andersson, Sai Prakash Ranjan, Douglas Anderson,
linux-arm-msm, linux-kernel, kernel-janitors
Quoting Dan Carpenter (2021-01-20 01:57:55)
> These need to be < ARRAY_SIZE() instead of <= ARRAY_SIZE() to prevent
> accessing one element beyond the end of the array.
>
> Fixes: e9247e2ce577 ("soc: qcom: socinfo: fix printing of pmic_model")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] soc: qcom: socinfo: Fix an off by one in qcom_show_pmic_model()
2021-01-20 9:57 ` Dan Carpenter
` (3 preceding siblings ...)
(?)
@ 2021-01-21 4:50 ` patchwork-bot+linux-arm-msm
-1 siblings, 0 replies; 13+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-01-21 4:50 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Wed, 20 Jan 2021 12:57:55 +0300 you wrote:
> These need to be < ARRAY_SIZE() instead of <= ARRAY_SIZE() to prevent
> accessing one element beyond the end of the array.
>
> Fixes: e9247e2ce577 ("soc: qcom: socinfo: fix printing of pmic_model")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/soc/qcom/socinfo.c | 2 +-
> 1 file changed, 1 insertions(+), 1 deletions(-)
Here is the summary with links:
- soc: qcom: socinfo: Fix an off by one in qcom_show_pmic_model()
https://git.kernel.org/qcom/c/5fb33d8960dc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 13+ messages in thread