* [PATCH v2] arm64: dts: qcom: sc7280: add display port audio
@ 2023-01-13 6:22 Judy Hsiao
2023-01-13 6:25 ` Dmitry Baryshkov
2023-01-13 8:19 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Judy Hsiao @ 2023-01-13 6:22 UTC (permalink / raw)
To: Andy Gross, Douglas Anderson, Matthias Kaehlcke
Cc: Bjorn Andersson, linux-kernel, linux-arm-msm, Rob Herring,
devicetree, Judy Hsiao, Konrad Dybcio, Krzysztof Kozlowski
Add DisplayPort sound node and lpass_cpu node
in sc7280-herobrine-audio-rt5682.dtsi.
Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
---
Changes Since v1:
-- Fix the commit message.
(no changes since v1)
.../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
index af685bc35e10..69e7aa7b2f6c 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
@@ -33,9 +33,22 @@ codec {
};
dai-link@1 {
- link-name = "ALC5682";
+ link-name = "DisplayPort";
reg = <1>;
+ cpu {
+ sound-dai = <&lpass_cpu LPASS_DP_RX>;
+ };
+
+ codec {
+ sound-dai = <&mdss_dp>;
+ };
+ };
+
+ dai-link@2 {
+ link-name = "ALC5682";
+ reg = <2>;
+
cpu {
sound-dai = <&lpass_cpu MI2S_PRIMARY>;
};
@@ -92,6 +105,10 @@ dai-link@1 {
reg = <MI2S_SECONDARY>;
qcom,playback-sd-lines = <0>;
};
+
+ dai-link@5 {
+ reg = <LPASS_DP_RX>;
+ };
};
/* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */
--
2.39.0.314.g84b9a713c41-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sc7280: add display port audio
2023-01-13 6:22 [PATCH v2] arm64: dts: qcom: sc7280: add display port audio Judy Hsiao
@ 2023-01-13 6:25 ` Dmitry Baryshkov
2023-01-13 8:19 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2023-01-13 6:25 UTC (permalink / raw)
To: Judy Hsiao
Cc: Andy Gross, Douglas Anderson, Matthias Kaehlcke, Bjorn Andersson,
linux-kernel, linux-arm-msm, Rob Herring, devicetree,
Konrad Dybcio, Krzysztof Kozlowski
On Fri, 13 Jan 2023 at 08:23, Judy Hsiao <judyhsiao@chromium.org> wrote:
>
> Add DisplayPort sound node and lpass_cpu node
> in sc7280-herobrine-audio-rt5682.dtsi.
Any reason for inserting it in front of the ALC rather than putting it
at the end of dai-links?
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sc7280: add display port audio
2023-01-13 6:22 [PATCH v2] arm64: dts: qcom: sc7280: add display port audio Judy Hsiao
2023-01-13 6:25 ` Dmitry Baryshkov
@ 2023-01-13 8:19 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-13 8:19 UTC (permalink / raw)
To: Judy Hsiao, Andy Gross, Douglas Anderson, Matthias Kaehlcke
Cc: Bjorn Andersson, linux-kernel, linux-arm-msm, Rob Herring,
devicetree, Konrad Dybcio, Krzysztof Kozlowski
On 13/01/2023 07:22, Judy Hsiao wrote:
> Add DisplayPort sound node and lpass_cpu node
> in sc7280-herobrine-audio-rt5682.dtsi.
This we see from diff. You should explain stuff which is not easily
visible, e.g. why you are doing it, what do you want to achieve.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
>
> ---
> Changes Since v1:
> -- Fix the commit message.
>
>
> (no changes since v1)
>
> .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> index af685bc35e10..69e7aa7b2f6c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> @@ -33,9 +33,22 @@ codec {
> };
>
> dai-link@1 {
> - link-name = "ALC5682";
> + link-name = "DisplayPort";
This change is still not explained in commit msg.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-13 8:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 6:22 [PATCH v2] arm64: dts: qcom: sc7280: add display port audio Judy Hsiao
2023-01-13 6:25 ` Dmitry Baryshkov
2023-01-13 8:19 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.