configure.ac: Always add -D_FILE_OFFSET_BITS=64.

configure.ac: Always add -D_FILE_OFFSET_BITS=64.

[Andrei Borzenkov]

> +CPPFLAGS="$CPPFLAGS -D_FILE_OFFSET_BITS=64"
> +HOST_CPPFLAGS="$HOST_CPPFLAGS -D_FILE_OFFSET_BITS=64"


We already have them unconditionally in config.h. This is confusing;
may be remove them from this file. OTOH we have AC_LARGEFILES that is
expected to figure out proper options (although I believe for now
there is just one system that needs it).


This all looks rather messy.

Re: configure.ac: Always add -D_FILE_OFFSET_BITS=64.

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

On 26.01.2015 12:29, Andrei Borzenkov wrote:
>> +CPPFLAGS="$CPPFLAGS -D_FILE_OFFSET_BITS=64"
>> +HOST_CPPFLAGS="$HOST_CPPFLAGS -D_FILE_OFFSET_BITS=64"
> 
> 
> We already have them unconditionally in config.h. This is confusing;
> may be remove them from this file. OTOH we have AC_LARGEFILES that is
> expected to figure out proper options (although I believe for now
> there is just one system that needs it).
> 
Do you mean AC_SYS_LARGEFILE ? Does it actually work? How exactly does
it make its way to HOST_CPPFLAGS?
> 
> This all looks rather messy.
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]

Re: configure.ac: Always add -D_FILE_OFFSET_BITS=64.

[Andrei Borzenkov]

On Mon, Jan 26, 2015 at 6:04 PM, Vladimir 'φ-coder/phcoder' Serbinenko
<phcoder@gmail.com> wrote:
> On 26.01.2015 12:29, Andrei Borzenkov wrote:
>>> +CPPFLAGS="$CPPFLAGS -D_FILE_OFFSET_BITS=64"
>>> +HOST_CPPFLAGS="$HOST_CPPFLAGS -D_FILE_OFFSET_BITS=64"
>>
>>
>> We already have them unconditionally in config.h. This is confusing;
>> may be remove them from this file. OTOH we have AC_LARGEFILES that is
>> expected to figure out proper options (although I believe for now
>> there is just one system that needs it).
>>
> Do you mean AC_SYS_LARGEFILE ? Does it actually work?

It apparently works for other projects ...

>                                                                                         How exactly does
> it make its way to HOST_CPPFLAGS?

It does not, that is my point. We uncoditionally force both known
knobs statically in config.h. I'm fine with forcing it in configure
(then at least check for sizeof(off_t) will match what we have at
compilation time) but then they must be removed from config.h.

But yes, for now AC_SYS_LARGEFILE is pretty much useless here.

>>
>> This all looks rather messy.
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

Re: configure.ac: Always add -D_FILE_OFFSET_BITS=64.

[Andrei Borzenkov]

В Mon, 26 Jan 2015 18:12:19 +0300
Andrei Borzenkov <arvidjaar@gmail.com> пишет:

> On Mon, Jan 26, 2015 at 6:04 PM, Vladimir 'φ-coder/phcoder' Serbinenko
> <phcoder@gmail.com> wrote:
> > On 26.01.2015 12:29, Andrei Borzenkov wrote:
> >>> +CPPFLAGS="$CPPFLAGS -D_FILE_OFFSET_BITS=64"
> >>> +HOST_CPPFLAGS="$HOST_CPPFLAGS -D_FILE_OFFSET_BITS=64"
> >>
> >>
> >> We already have them unconditionally in config.h. This is confusing;
> >> may be remove them from this file. OTOH we have AC_LARGEFILES that is
> >> expected to figure out proper options (although I believe for now
> >> there is just one system that needs it).
> >>
> > Do you mean AC_SYS_LARGEFILE ? Does it actually work?
> 
> It apparently works for other projects ...
> 
> >                                                                                         How exactly does
> > it make its way to HOST_CPPFLAGS?
> 
> It does not, that is my point.

Sorry, was wrong. It makes it way via config-util.h

AC_CONFIG_HEADER([config-util.h])

and 

/* Number of bits in a file offset, on hosts where this is settable. */
/* #undef _FILE_OFFSET_BITS */

/* Define for large files, on AIX-style hosts. */
/* #undef _LARGE_FILES */

I'm on 64 bit Linux so do not need any of these to enable large files.
So your patch seems to be redundant and I'd consider removing them from
config.h as well after release.

>                               We uncoditionally force both known
> knobs statically in config.h. I'm fine with forcing it in configure
> (then at least check for sizeof(off_t) will match what we have at
> compilation time) but then they must be removed from config.h.
> 
> But yes, for now AC_SYS_LARGEFILE is pretty much useless here.
> 
> >>
> >> This all looks rather messy.
> >>
> >> _______________________________________________
> >> Grub-devel mailing list
> >> Grub-devel@gnu.org
> >> https://lists.gnu.org/mailman/listinfo/grub-devel
> >>
> >
> >
> >
> > _______________________________________________
> > Grub-devel mailing list
> > Grub-devel@gnu.org
> > https://lists.gnu.org/mailman/listinfo/grub-devel
> >

Re: configure.ac: Always add -D_FILE_OFFSET_BITS=64.

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1669 bytes --]

On 26.01.2015 17:50, Andrei Borzenkov wrote:
> В Mon, 26 Jan 2015 18:12:19 +0300
> Andrei Borzenkov <arvidjaar@gmail.com> пишет:
> 
>> On Mon, Jan 26, 2015 at 6:04 PM, Vladimir 'φ-coder/phcoder' Serbinenko
>> <phcoder@gmail.com> wrote:
>>> On 26.01.2015 12:29, Andrei Borzenkov wrote:
>>>>> +CPPFLAGS="$CPPFLAGS -D_FILE_OFFSET_BITS=64"
>>>>> +HOST_CPPFLAGS="$HOST_CPPFLAGS -D_FILE_OFFSET_BITS=64"
>>>>
>>>>
>>>> We already have them unconditionally in config.h. This is confusing;
>>>> may be remove them from this file. OTOH we have AC_LARGEFILES that is
>>>> expected to figure out proper options (although I believe for now
>>>> there is just one system that needs it).
>>>>
>>> Do you mean AC_SYS_LARGEFILE ? Does it actually work?
>>
>> It apparently works for other projects ...
>>
>>>                                                                                         How exactly does
>>> it make its way to HOST_CPPFLAGS?
>>
>> It does not, that is my point.
> 
> Sorry, was wrong. It makes it way via config-util.h
> 
> AC_CONFIG_HEADER([config-util.h])
> 
> and 
> 
> /* Number of bits in a file offset, on hosts where this is settable. */
> /* #undef _FILE_OFFSET_BITS */
> 
> /* Define for large files, on AIX-style hosts. */
> /* #undef _LARGE_FILES */
> 
> I'm on 64 bit Linux so do not need any of these to enable large files.
> So your patch seems to be redundant and I'd consider removing them from
> config.h as well after release.
> 
fuse headers need explicit _FILE_OFFSET_BITS and so we need to include
them for fuse tests. Also we need to include them for 64-bit off_t
availability tests.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]