* [PATCH] scsi/isci/port_config: Fix a infinite loop.
@ 2013-07-17 2:54 Xinghai Yu
2013-07-31 9:35 ` Dorau, Lukasz
2014-02-06 19:59 ` Dan Williams
0 siblings, 2 replies; 3+ messages in thread
From: Xinghai Yu @ 2013-07-17 2:54 UTC (permalink / raw)
To: lukasz.dorau, maciej.patelczyk, dave.jiang; +Cc: linux-scsi, Xinghai Yu
It seems the "phy_index++;" have been placed in wrong place, without it
the while circle up will do a infinite loop.
Signed-off-by: Xinghai Yu <yuxinghai@cn.fujitsu.com>
---
drivers/scsi/isci/port_config.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/isci/port_config.c b/drivers/scsi/isci/port_config.c
index cd962da..85c77f6 100644
--- a/drivers/scsi/isci/port_config.c
+++ b/drivers/scsi/isci/port_config.c
@@ -311,9 +311,9 @@ sci_mpc_agent_validate_phy_configuration(struct isci_host *ihost,
&ihost->phys[phy_index]);
assigned_phy_mask |= (1 << phy_index);
+ phy_index++;
}
- phy_index++;
}
return sci_port_configuration_agent_validate_ports(ihost, port_agent);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] scsi/isci/port_config: Fix a infinite loop.
2013-07-17 2:54 [PATCH] scsi/isci/port_config: Fix a infinite loop Xinghai Yu
@ 2013-07-31 9:35 ` Dorau, Lukasz
2014-02-06 19:59 ` Dan Williams
1 sibling, 0 replies; 3+ messages in thread
From: Dorau, Lukasz @ 2013-07-31 9:35 UTC (permalink / raw)
To: Xinghai Yu, Patelczyk, Maciej, Jiang, Dave; +Cc: linux-scsi
On Wednesday, July 17, 2013 4:54 AM Xinghai Yu <yuxinghai@cn.fujitsu.com> wrote:
>
> It seems the "phy_index++;" have been placed in wrong place, without it
> the while circle up will do a infinite loop.
>
> Signed-off-by: Xinghai Yu <yuxinghai@cn.fujitsu.com>
Acked-by: Lukasz Dorau <lukasz.dorau@intel.com>
> ---
> drivers/scsi/isci/port_config.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/isci/port_config.c b/drivers/scsi/isci/port_config.c
> index cd962da..85c77f6 100644
> --- a/drivers/scsi/isci/port_config.c
> +++ b/drivers/scsi/isci/port_config.c
> @@ -311,9 +311,9 @@ sci_mpc_agent_validate_phy_configuration(struct
> isci_host *ihost,
> &ihost->phys[phy_index]);
>
> assigned_phy_mask |= (1 << phy_index);
> + phy_index++;
> }
>
> - phy_index++;
> }
>
> return sci_port_configuration_agent_validate_ports(ihost, port_agent);
> --
> 1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi/isci/port_config: Fix a infinite loop.
2013-07-17 2:54 [PATCH] scsi/isci/port_config: Fix a infinite loop Xinghai Yu
2013-07-31 9:35 ` Dorau, Lukasz
@ 2014-02-06 19:59 ` Dan Williams
1 sibling, 0 replies; 3+ messages in thread
From: Dan Williams @ 2014-02-06 19:59 UTC (permalink / raw)
To: Xinghai Yu; +Cc: Lukasz Dorau, Patelczyk, Maciej, dave.jiang, linux-scsi
On Tue, Jul 16, 2013 at 7:54 PM, Xinghai Yu <yuxinghai@cn.fujitsu.com> wrote:
> It seems the "phy_index++;" have been placed in wrong place, without it
> the while circle up will do a infinite loop.
>
> Signed-off-by: Xinghai Yu <yuxinghai@cn.fujitsu.com>
> ---
> drivers/scsi/isci/port_config.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/isci/port_config.c b/drivers/scsi/isci/port_config.c
> index cd962da..85c77f6 100644
> --- a/drivers/scsi/isci/port_config.c
> +++ b/drivers/scsi/isci/port_config.c
> @@ -311,9 +311,9 @@ sci_mpc_agent_validate_phy_configuration(struct isci_host *ihost,
> &ihost->phys[phy_index]);
>
> assigned_phy_mask |= (1 << phy_index);
> + phy_index++;
> }
>
> - phy_index++;
> }
>
> return sci_port_configuration_agent_validate_ports(ihost, port_agent);
Hmm, I'm not aware of anyone using mpc mode. Maybe we should just remove it?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-06 19:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-17 2:54 [PATCH] scsi/isci/port_config: Fix a infinite loop Xinghai Yu
2013-07-31 9:35 ` Dorau, Lukasz
2014-02-06 19:59 ` Dan Williams
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.