All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: CGEL <cgel.zte@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michael Straube <straube.linux@gmail.com>,
	"open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jing Yangyang <jing.yangyang@zte.com.cn>,
	Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] r8188eu: remove unneeded conversions to bool
Date: Tue, 24 Aug 2021 23:02:00 +0100	[thread overview]
Message-ID: <CAA=Fs0=yWZ58j7T_vE4SjT3Fv35Zxb2rohQF4V9F7sF78LTR8w@mail.gmail.com> (raw)
In-Reply-To: <20210824063443.59724-1-deng.changcheng@zte.com.cn>

On Tue, 24 Aug 2021 at 07:34, CGEL <cgel.zte@gmail.com> wrote:
>
> From: Jing Yangyang <jing.yangyang@zte.com.cn>
>
> Found with scripts/coccinelle/misc/boolconv.cocci.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
> ---
>  drivers/staging/r8188eu/core/rtw_mlme_ext.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index 5325fe4..20dc4d4 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -3758,7 +3758,7 @@ int issue_probereq_p2p_ex(struct adapter *adapter, u8 *da, int try_cnt, int wait
>         u32 start = jiffies;
>
>         do {
> -               ret = _issue_probereq_p2p(adapter, da, wait_ms > 0 ? true : false);
> +               ret = _issue_probereq_p2p(adapter, da, wait_ms > 0);
>
>                 i++;
>
> @@ -4890,7 +4890,7 @@ int issue_probereq_ex(struct adapter *padapter, struct ndis_802_11_ssid *pssid,
>         u32 start = jiffies;
>
>         do {
> -               ret = _issue_probereq(padapter, pssid, da, wait_ms > 0 ? true : false);
> +               ret = _issue_probereq(padapter, pssid, da, wait_ms > 0);
>
>                 i++;
>
> @@ -5605,7 +5605,7 @@ int issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned int pow
>                 da = get_my_bssid(&pmlmeinfo->network);
>
>         do {
> -               ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0 ? true : false);
> +               ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0);
>
>                 i++;
>
> @@ -5728,7 +5728,7 @@ int issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 tid, int
>                 da = get_my_bssid(&pmlmeinfo->network);
>
>         do {
> -               ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0 ? true : false);
> +               ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0);
>
>                 i++;
>
> @@ -5839,7 +5839,7 @@ int issue_deauth_ex(struct adapter *padapter, u8 *da, unsigned short reason, int
>         u32 start = jiffies;
>
>         do {
> -               ret = _issue_deauth(padapter, da, reason, wait_ms > 0 ? true : false);
> +               ret = _issue_deauth(padapter, da, reason, wait_ms > 0);
>
>                 i++;
>
> --
> 1.8.3.1
>
>

Not had time to buildest/run this, but it looks ok to me. Many thanks.

Acked-by: Phillip Potter <phil@philpotter.co.uk>

Regards,
Phil

  parent reply	other threads:[~2021-08-24 22:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24  6:34 [PATCH linux-next] r8188eu: remove unneeded conversions to bool CGEL
2021-08-24  8:00 ` Pavel Skripkin
2021-08-24 10:40 ` Michael Straube
2021-08-24 22:02 ` Phillip Potter [this message]
2021-08-24 22:02   ` Phillip Potter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA=Fs0=yWZ58j7T_vE4SjT3Fv35Zxb2rohQF4V9F7sF78LTR8w@mail.gmail.com' \
    --to=phil@philpotter.co.uk \
    --cc=Larry.Finger@lwfinger.net \
    --cc=cgel.zte@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jing.yangyang@zte.com.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=straube.linux@gmail.com \
    --cc=zealci@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.