* [PATCH] staging: r8188eu: remove unused function Hal_ProSetCrystalCap()
@ 2021-09-07 21:09 Michael Straube
2021-09-07 22:29 ` Phillip Potter
0 siblings, 1 reply; 3+ messages in thread
From: Michael Straube @ 2021-09-07 21:09 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, phil, martin, fmdefrancesco, linux-staging,
linux-kernel, Michael Straube
Remove unused function Hal_ProSetCrystalCap().
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/core/rtw_mp.c | 9 ---------
drivers/staging/r8188eu/include/rtw_mp.h | 1 -
2 files changed, 10 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mp.c b/drivers/staging/r8188eu/core/rtw_mp.c
index dabdd0406f30..82268f754da0 100644
--- a/drivers/staging/r8188eu/core/rtw_mp.c
+++ b/drivers/staging/r8188eu/core/rtw_mp.c
@@ -924,12 +924,3 @@ void _rtw_mp_xmit_priv(struct xmit_priv *pxmitpriv)
exit:
;
}
-
-void Hal_ProSetCrystalCap(struct adapter *pAdapter, u32 CrystalCapVal)
-{
- CrystalCapVal = CrystalCapVal & 0x3F;
-
- // write 0x24[16:11] = 0x24[22:17] = CrystalCap
- PHY_SetBBReg(pAdapter, REG_AFE_XTAL_CTRL, 0x7FF800,
- (CrystalCapVal | (CrystalCapVal << 6)));
-}
diff --git a/drivers/staging/r8188eu/include/rtw_mp.h b/drivers/staging/r8188eu/include/rtw_mp.h
index b2befe09d944..73fb6974d076 100644
--- a/drivers/staging/r8188eu/include/rtw_mp.h
+++ b/drivers/staging/r8188eu/include/rtw_mp.h
@@ -466,7 +466,6 @@ void Hal_TriggerRFThermalMeter(struct adapter *pAdapter);
u8 Hal_ReadRFThermalMeter(struct adapter *pAdapter);
void Hal_SetCCKContinuousTx(struct adapter *pAdapter, u8 bStart);
void Hal_SetOFDMContinuousTx(struct adapter *pAdapter, u8 bStart);
-void Hal_ProSetCrystalCap (struct adapter *pAdapter , u32 CrystalCapVal);
void _rtw_mp_xmit_priv(struct xmit_priv *pxmitpriv);
void MP_PHY_SetRFPathSwitch(struct adapter *pAdapter ,bool bMain);
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: r8188eu: remove unused function Hal_ProSetCrystalCap()
2021-09-07 21:09 [PATCH] staging: r8188eu: remove unused function Hal_ProSetCrystalCap() Michael Straube
@ 2021-09-07 22:29 ` Phillip Potter
0 siblings, 0 replies; 3+ messages in thread
From: Phillip Potter @ 2021-09-07 22:29 UTC (permalink / raw)
To: Michael Straube
Cc: Greg KH, Larry Finger, Martin Kaiser, Fabio M. De Francesco,
open list:STAGING SUBSYSTEM, Linux Kernel Mailing List
On Tue, 7 Sept 2021 at 22:09, Michael Straube <straube.linux@gmail.com> wrote:
>
> Remove unused function Hal_ProSetCrystalCap().
>
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
> drivers/staging/r8188eu/core/rtw_mp.c | 9 ---------
> drivers/staging/r8188eu/include/rtw_mp.h | 1 -
> 2 files changed, 10 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mp.c b/drivers/staging/r8188eu/core/rtw_mp.c
> index dabdd0406f30..82268f754da0 100644
> --- a/drivers/staging/r8188eu/core/rtw_mp.c
> +++ b/drivers/staging/r8188eu/core/rtw_mp.c
> @@ -924,12 +924,3 @@ void _rtw_mp_xmit_priv(struct xmit_priv *pxmitpriv)
> exit:
> ;
> }
> -
> -void Hal_ProSetCrystalCap(struct adapter *pAdapter, u32 CrystalCapVal)
> -{
> - CrystalCapVal = CrystalCapVal & 0x3F;
> -
> - // write 0x24[16:11] = 0x24[22:17] = CrystalCap
> - PHY_SetBBReg(pAdapter, REG_AFE_XTAL_CTRL, 0x7FF800,
> - (CrystalCapVal | (CrystalCapVal << 6)));
> -}
> diff --git a/drivers/staging/r8188eu/include/rtw_mp.h b/drivers/staging/r8188eu/include/rtw_mp.h
> index b2befe09d944..73fb6974d076 100644
> --- a/drivers/staging/r8188eu/include/rtw_mp.h
> +++ b/drivers/staging/r8188eu/include/rtw_mp.h
> @@ -466,7 +466,6 @@ void Hal_TriggerRFThermalMeter(struct adapter *pAdapter);
> u8 Hal_ReadRFThermalMeter(struct adapter *pAdapter);
> void Hal_SetCCKContinuousTx(struct adapter *pAdapter, u8 bStart);
> void Hal_SetOFDMContinuousTx(struct adapter *pAdapter, u8 bStart);
> -void Hal_ProSetCrystalCap (struct adapter *pAdapter , u32 CrystalCapVal);
> void _rtw_mp_xmit_priv(struct xmit_priv *pxmitpriv);
> void MP_PHY_SetRFPathSwitch(struct adapter *pAdapter ,bool bMain);
>
> --
> 2.33.0
>
Looks good Michael, many thanks.
Acked-by: Phillip Potter <phil@philpotter.co.uk>
Regards,
Phil
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: r8188eu: remove unused function Hal_ProSetCrystalCap()
@ 2021-09-07 22:29 ` Phillip Potter
0 siblings, 0 replies; 3+ messages in thread
From: Phillip Potter @ 2021-09-07 22:29 UTC (permalink / raw)
To: Michael Straube
Cc: Greg KH, Larry Finger, Martin Kaiser, Fabio M. De Francesco,
open list:STAGING SUBSYSTEM, Linux Kernel Mailing List
On Tue, 7 Sept 2021 at 22:09, Michael Straube <straube.linux@gmail.com> wrote:
>
> Remove unused function Hal_ProSetCrystalCap().
>
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
> drivers/staging/r8188eu/core/rtw_mp.c | 9 ---------
> drivers/staging/r8188eu/include/rtw_mp.h | 1 -
> 2 files changed, 10 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mp.c b/drivers/staging/r8188eu/core/rtw_mp.c
> index dabdd0406f30..82268f754da0 100644
> --- a/drivers/staging/r8188eu/core/rtw_mp.c
> +++ b/drivers/staging/r8188eu/core/rtw_mp.c
> @@ -924,12 +924,3 @@ void _rtw_mp_xmit_priv(struct xmit_priv *pxmitpriv)
> exit:
> ;
> }
> -
> -void Hal_ProSetCrystalCap(struct adapter *pAdapter, u32 CrystalCapVal)
> -{
> - CrystalCapVal = CrystalCapVal & 0x3F;
> -
> - // write 0x24[16:11] = 0x24[22:17] = CrystalCap
> - PHY_SetBBReg(pAdapter, REG_AFE_XTAL_CTRL, 0x7FF800,
> - (CrystalCapVal | (CrystalCapVal << 6)));
> -}
> diff --git a/drivers/staging/r8188eu/include/rtw_mp.h b/drivers/staging/r8188eu/include/rtw_mp.h
> index b2befe09d944..73fb6974d076 100644
> --- a/drivers/staging/r8188eu/include/rtw_mp.h
> +++ b/drivers/staging/r8188eu/include/rtw_mp.h
> @@ -466,7 +466,6 @@ void Hal_TriggerRFThermalMeter(struct adapter *pAdapter);
> u8 Hal_ReadRFThermalMeter(struct adapter *pAdapter);
> void Hal_SetCCKContinuousTx(struct adapter *pAdapter, u8 bStart);
> void Hal_SetOFDMContinuousTx(struct adapter *pAdapter, u8 bStart);
> -void Hal_ProSetCrystalCap (struct adapter *pAdapter , u32 CrystalCapVal);
> void _rtw_mp_xmit_priv(struct xmit_priv *pxmitpriv);
> void MP_PHY_SetRFPathSwitch(struct adapter *pAdapter ,bool bMain);
>
> --
> 2.33.0
>
Looks good Michael, many thanks.
Acked-by: Phillip Potter <phil@philpotter.co.uk>
Regards,
Phil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-07 22:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 21:09 [PATCH] staging: r8188eu: remove unused function Hal_ProSetCrystalCap() Michael Straube
2021-09-07 22:29 ` Phillip Potter
2021-09-07 22:29 ` Phillip Potter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.