* FS: EXT4: should we sync error info in __ext4_grp_locked_error?
@ 2017-12-14 7:13 Zhouyi Zhou
2017-12-14 16:48 ` Theodore Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Zhouyi Zhou @ 2017-12-14 7:13 UTC (permalink / raw)
To: linux-ext4, tytso, linux-kernel, inux-fsdevel
Hi,
In function __ext4_grp_locked_error, __save_error_info(sb, function, line)
is called to save error info in super block block, but does not sync
that information
to disk to info the subsequence fsck after reboot. The reason, I guess
maybe it is
in locked state.
My question is why not make a call ext4_commit_super(sb, 1) after
ext4_unlock_group(sb, grp) and ext4_handle_error(sb), so that subsequence fsck
after reboot is sure to be well informed.
Forgive my naiveness.
Thanks a lot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: FS: EXT4: should we sync error info in __ext4_grp_locked_error?
2017-12-14 7:13 FS: EXT4: should we sync error info in __ext4_grp_locked_error? Zhouyi Zhou
@ 2017-12-14 16:48 ` Theodore Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2017-12-14 16:48 UTC (permalink / raw)
To: Zhouyi Zhou; +Cc: linux-ext4, linux-kernel, inux-fsdevel
On Thu, Dec 14, 2017 at 03:13:15PM +0800, Zhouyi Zhou wrote:
> Hi,
> In function __ext4_grp_locked_error, __save_error_info(sb, function, line)
> is called to save error info in super block block, but does not sync
> that information
> to disk to info the subsequence fsck after reboot. The reason, I guess
> maybe it is
> in locked state.
> My question is why not make a call ext4_commit_super(sb, 1) after
> ext4_unlock_group(sb, grp) and ext4_handle_error(sb), so that subsequence fsck
> after reboot is sure to be well informed.
Adding ext4_commit_super(sb, 1) between the calls to
ext4_unlock_group() and ext4_handle_error() is a good idea; it's not a
naive suggestion at all.
Cheers,
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
* FS: EXT4: should we sync error info in __ext4_grp_locked_error?
@ 2017-12-14 7:26 Zhouyi Zhou
0 siblings, 0 replies; 3+ messages in thread
From: Zhouyi Zhou @ 2017-12-14 7:26 UTC (permalink / raw)
To: linux-fsdevel
Hi,
In function __ext4_grp_locked_error, __save_error_info(sb, function, line)
is called to save error info in super block block, but does not sync
that information
to disk to info the subsequence fsck after reboot. The reason, I guess
maybe it is
in locked state.
My question is why not make a call ext4_commit_super(sb, 1) after
ext4_unlock_group(sb, grp) and ext4_handle_error(sb), so that subsequence fsck
after reboot is sure to be well informed.
Forgive my naiveness.
Thanks a lot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-14 16:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-14 7:13 FS: EXT4: should we sync error info in __ext4_grp_locked_error? Zhouyi Zhou
2017-12-14 16:48 ` Theodore Ts'o
2017-12-14 7:26 Zhouyi Zhou
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.