* [PATCH 1/2] btf: Fix required space error
@ 2022-06-29 17:14 Jules Irenge
2022-06-29 19:21 ` Alexei Starovoitov
0 siblings, 1 reply; 3+ messages in thread
From: Jules Irenge @ 2022-06-29 17:14 UTC (permalink / raw)
To: linux-kernel
Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, netdev, bpf
This patch fixes error reported ny Checkpatch at bpf_log()
ERROR: space required after that , ctx:VxV
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
kernel/bpf/btf.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
index 2e2066d6af94..1bc496162572 100644
--- a/kernel/bpf/btf.c
+++ b/kernel/bpf/btf.c
@@ -5454,7 +5454,9 @@ bool btf_ctx_access(int off, int size, enum bpf_access_type type,
if (ctx_arg_info->offset == off) {
if (!ctx_arg_info->btf_id) {
- bpf_log(log,"invalid btf_id for context argument offset %u\n", off);
+ bpf_log(log,
+ "invalid btf_id for context argument offset %u\n",
+ off);
return false;
}
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] btf: Fix required space error
2022-06-29 17:14 [PATCH 1/2] btf: Fix required space error Jules Irenge
@ 2022-06-29 19:21 ` Alexei Starovoitov
2022-07-01 19:56 ` Jules Irenge
0 siblings, 1 reply; 3+ messages in thread
From: Alexei Starovoitov @ 2022-06-29 19:21 UTC (permalink / raw)
To: Jules Irenge
Cc: LKML, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Network Development, bpf
On Wed, Jun 29, 2022 at 10:14 AM Jules Irenge <jbi.octave@gmail.com> wrote:
>
> This patch fixes error reported ny Checkpatch at bpf_log()
Please do not send patches suggested by checkpatch.
checkpatch is not an authoritative tool.
It's merely suggesting things.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] btf: Fix required space error
2022-06-29 19:21 ` Alexei Starovoitov
@ 2022-07-01 19:56 ` Jules Irenge
0 siblings, 0 replies; 3+ messages in thread
From: Jules Irenge @ 2022-07-01 19:56 UTC (permalink / raw)
To: Alexei Starovoitov; +Cc: bpf
On Wed, Jun 29, 2022 at 12:21:44PM -0700, Alexei Starovoitov wrote:
> On Wed, Jun 29, 2022 at 10:14 AM Jules Irenge <jbi.octave@gmail.com> wrote:
> >
> > This patch fixes error reported ny Checkpatch at bpf_log()
>
> Please do not send patches suggested by checkpatch.
> checkpatch is not an authoritative tool.
> It's merely suggesting things.
Thanks, I take good note. I will try with better tools with less false
positive.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-01 19:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29 17:14 [PATCH 1/2] btf: Fix required space error Jules Irenge
2022-06-29 19:21 ` Alexei Starovoitov
2022-07-01 19:56 ` Jules Irenge
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.