* [PATCH bpf-next] libbpf: remove compile time warning from libbpf_util.h
@ 2019-04-18 7:21 Magnus Karlsson
2019-04-18 20:58 ` Y Song
2019-04-18 23:07 ` Alexei Starovoitov
0 siblings, 2 replies; 3+ messages in thread
From: Magnus Karlsson @ 2019-04-18 7:21 UTC (permalink / raw)
To: magnus.karlsson, bjorn.topel, ast, daniel, netdev, bpf
Having a helpful compile time warning in libbpf_util.h is not a good
idea since all warnings are treated as errors. Change this into a
comment in the code instead.
Fixes: b7e3a28019c9 ("libbpf: remove dependency on barrier.h in xsk.h")
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
---
tools/lib/bpf/libbpf_util.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/libbpf_util.h b/tools/lib/bpf/libbpf_util.h
index 172b707e..da94c4c 100644
--- a/tools/lib/bpf/libbpf_util.h
+++ b/tools/lib/bpf/libbpf_util.h
@@ -46,7 +46,7 @@ do { \
# define libbpf_smp_mb() asm volatile("dmb ish" : : : "memory")
# define libbpf_smp_rwmb() libbpf_smp_mb()
#else
-# warning Architecture missing native barrier functions in libbpf_util.h.
+/* Architecture missing native barrier functions. */
# define libbpf_smp_rmb() __sync_synchronize()
# define libbpf_smp_wmb() __sync_synchronize()
# define libbpf_smp_mb() __sync_synchronize()
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] libbpf: remove compile time warning from libbpf_util.h
2019-04-18 7:21 [PATCH bpf-next] libbpf: remove compile time warning from libbpf_util.h Magnus Karlsson
@ 2019-04-18 20:58 ` Y Song
2019-04-18 23:07 ` Alexei Starovoitov
1 sibling, 0 replies; 3+ messages in thread
From: Y Song @ 2019-04-18 20:58 UTC (permalink / raw)
To: Magnus Karlsson
Cc: Björn Töpel, Alexei Starovoitov, Daniel Borkmann, netdev, bpf
On Thu, Apr 18, 2019 at 12:23 AM Magnus Karlsson
<magnus.karlsson@intel.com> wrote:
>
> Having a helpful compile time warning in libbpf_util.h is not a good
> idea since all warnings are treated as errors. Change this into a
> comment in the code instead.
>
> Fixes: b7e3a28019c9 ("libbpf: remove dependency on barrier.h in xsk.h")
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Acked-by: Yonghong Song <yhs@fb.com>
> ---
> tools/lib/bpf/libbpf_util.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/libbpf_util.h b/tools/lib/bpf/libbpf_util.h
> index 172b707e..da94c4c 100644
> --- a/tools/lib/bpf/libbpf_util.h
> +++ b/tools/lib/bpf/libbpf_util.h
> @@ -46,7 +46,7 @@ do { \
> # define libbpf_smp_mb() asm volatile("dmb ish" : : : "memory")
> # define libbpf_smp_rwmb() libbpf_smp_mb()
> #else
> -# warning Architecture missing native barrier functions in libbpf_util.h.
> +/* Architecture missing native barrier functions. */
> # define libbpf_smp_rmb() __sync_synchronize()
> # define libbpf_smp_wmb() __sync_synchronize()
> # define libbpf_smp_mb() __sync_synchronize()
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] libbpf: remove compile time warning from libbpf_util.h
2019-04-18 7:21 [PATCH bpf-next] libbpf: remove compile time warning from libbpf_util.h Magnus Karlsson
2019-04-18 20:58 ` Y Song
@ 2019-04-18 23:07 ` Alexei Starovoitov
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2019-04-18 23:07 UTC (permalink / raw)
To: Magnus Karlsson
Cc: Björn Töpel, Alexei Starovoitov, Daniel Borkmann,
Network Development, bpf
On Thu, Apr 18, 2019 at 12:21 AM Magnus Karlsson
<magnus.karlsson@intel.com> wrote:
>
> Having a helpful compile time warning in libbpf_util.h is not a good
> idea since all warnings are treated as errors. Change this into a
> comment in the code instead.
>
> Fixes: b7e3a28019c9 ("libbpf: remove dependency on barrier.h in xsk.h")
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Applied. Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-18 23:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-18 7:21 [PATCH bpf-next] libbpf: remove compile time warning from libbpf_util.h Magnus Karlsson
2019-04-18 20:58 ` Y Song
2019-04-18 23:07 ` Alexei Starovoitov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.