* [PATCH bpf-next] bpf: Fix bpf-next builds without CONFIG_BPF_EVENTS
@ 2021-08-26 1:48 Daniel Xu
2021-08-26 2:45 ` Alexei Starovoitov
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Xu @ 2021-08-26 1:48 UTC (permalink / raw)
To: bpf, ast; +Cc: Daniel Xu, kernel-team, linux-kernel, kernel test robot
This commit fixes linker errors along the lines of:
s390-linux-ld: task_iter.c:(.init.text+0xa4): undefined reference to `btf_task_struct_ids'`
Fix by defining btf_task_struct_ids unconditionally in kernel/bpf/btf.c
since there exists code that unconditionally uses btf_task_struct_ids.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
---
include/linux/btf_ids.h | 1 +
kernel/bpf/btf.c | 2 ++
kernel/trace/bpf_trace.c | 2 --
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h
index 93d881ab0d48..47d9abfbdb55 100644
--- a/include/linux/btf_ids.h
+++ b/include/linux/btf_ids.h
@@ -151,6 +151,7 @@ extern struct btf_id_set name;
#define BTF_ID_UNUSED
#define BTF_ID_LIST_GLOBAL(name) u32 name[1];
#define BTF_ID_LIST_SINGLE(name, prefix, typename) static u32 name[1];
+#define BTF_ID_LIST_GLOBAL_SINGLE(name, prefix, typename) u32 name[1];
#define BTF_SET_START(name) static struct btf_id_set name = { 0 };
#define BTF_SET_START_GLOBAL(name) static struct btf_id_set name = { 0 };
#define BTF_SET_END(name)
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
index c395024610ed..dfe61df4f974 100644
--- a/kernel/bpf/btf.c
+++ b/kernel/bpf/btf.c
@@ -6213,3 +6213,5 @@ const struct bpf_func_proto bpf_btf_find_by_name_kind_proto = {
.arg3_type = ARG_ANYTHING,
.arg4_type = ARG_ANYTHING,
};
+
+BTF_ID_LIST_GLOBAL_SINGLE(btf_task_struct_ids, struct, task_struct)
diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
index 580e14ee7ff9..8e2eb950aa82 100644
--- a/kernel/trace/bpf_trace.c
+++ b/kernel/trace/bpf_trace.c
@@ -714,8 +714,6 @@ BPF_CALL_0(bpf_get_current_task_btf)
return (unsigned long) current;
}
-BTF_ID_LIST_GLOBAL_SINGLE(btf_task_struct_ids, struct, task_struct)
-
const struct bpf_func_proto bpf_get_current_task_btf_proto = {
.func = bpf_get_current_task_btf,
.gpl_only = true,
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] bpf: Fix bpf-next builds without CONFIG_BPF_EVENTS
2021-08-26 1:48 [PATCH bpf-next] bpf: Fix bpf-next builds without CONFIG_BPF_EVENTS Daniel Xu
@ 2021-08-26 2:45 ` Alexei Starovoitov
0 siblings, 0 replies; 2+ messages in thread
From: Alexei Starovoitov @ 2021-08-26 2:45 UTC (permalink / raw)
To: Daniel Xu; +Cc: bpf, Alexei Starovoitov, Kernel Team, LKML, kernel test robot
On Wed, Aug 25, 2021 at 6:48 PM Daniel Xu <dxu@dxuuu.xyz> wrote:
>
> This commit fixes linker errors along the lines of:
>
> s390-linux-ld: task_iter.c:(.init.text+0xa4): undefined reference to `btf_task_struct_ids'`
>
> Fix by defining btf_task_struct_ids unconditionally in kernel/bpf/btf.c
> since there exists code that unconditionally uses btf_task_struct_ids.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
Applied. Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-26 2:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-26 1:48 [PATCH bpf-next] bpf: Fix bpf-next builds without CONFIG_BPF_EVENTS Daniel Xu
2021-08-26 2:45 ` Alexei Starovoitov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.