[PATCH bpf-next] libbpf: reduce log level for custom section names

[PATCH bpf-next] libbpf: reduce log level for custom section names

[Andrii Nakryiko]

Libbpf is trying to recognize BPF program type based on its section name
during bpf_object__open() phase. This is not strictly enforced and user code
has ability to specify/override correct BPF program type after open.  But if
BPF program is using custom section name, libbpf will still emit warnings,
which can be quite annoying to users. This patch reduces log level of
information messages emitted by libbpf if section name is not canonical. User
can still get a list of all supported section names as debug-level message.

Signed-off-by: Andrii Nakryiko <andriin@fb.com>
---
 tools/lib/bpf/libbpf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 3fe42d6b0c2f..906bbbf7b2e4 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -5883,7 +5883,7 @@ int libbpf_prog_type_by_name(const char *name, enum bpf_prog_type *prog_type,
 		return 0;
 	}
 
-	pr_warn("failed to guess program type from ELF section '%s'\n", name);
+	pr_debug("failed to guess program type from ELF section '%s'\n", name);
 	type_names = libbpf_get_type_names(false);
 	if (type_names != NULL) {
 		pr_debug("supported section(type) names are:%s\n", type_names);
@@ -6001,10 +6001,10 @@ int libbpf_attach_type_by_name(const char *name,
 		*attach_type = section_defs[i].attach_type;
 		return 0;
 	}
-	pr_warn("failed to guess attach type based on ELF section name '%s'\n", name);
+	pr_debug("failed to guess attach type based on ELF section name '%s'\n", name);
 	type_names = libbpf_get_type_names(true);
 	if (type_names != NULL) {
-		pr_info("attachable section(type) names are:%s\n", type_names);
+		pr_debug("attachable section(type) names are:%s\n", type_names);
 		free(type_names);
 	}
 
-- 
2.17.1

Re: [PATCH bpf-next] libbpf: reduce log level for custom section names

[Alexei Starovoitov]

On Tue, Dec 17, 2019 at 3:42 PM Andrii Nakryiko <andriin@fb.com> wrote:
>
> Libbpf is trying to recognize BPF program type based on its section name
> during bpf_object__open() phase. This is not strictly enforced and user code
> has ability to specify/override correct BPF program type after open.  But if
> BPF program is using custom section name, libbpf will still emit warnings,
> which can be quite annoying to users. This patch reduces log level of
> information messages emitted by libbpf if section name is not canonical. User
> can still get a list of all supported section names as debug-level message.
>
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>

Applied. Thanks

selftests/bpf/ build looks very nice now.