Re: [PATCH 6/9] media: sum4i-csi: Do not zero reserved fields

[Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>]

Hi Ricardo,

Thanks a lot for doing this media-wide cleanup.

Aside from a silly typo here in the commit title, s/sum4i-csi/sun4i-csi,
all the patches seem fine.

Thanks,
Ezequiel

On Mon, 11 Jan 2021 at 11:56, Ricardo Ribalda <ribalda@chromium.org> wrote:
>
> Core code already clears reserved fields of struct
> v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero
> v4l2_plane_pix_format reserved fields").
>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c
> index 1a2f65d83a6c..4785faddf630 100644
> --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c
> +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c
> @@ -113,8 +113,6 @@ static void _sun4i_csi_try_fmt(struct sun4i_csi *csi,
>         pix->num_planes = _fmt->num_planes;
>         pix->pixelformat = _fmt->fourcc;
>
> -       memset(pix->reserved, 0, sizeof(pix->reserved));
> -
>         /* Align the width and height on the subsampling */
>         width = ALIGN(pix->width, _fmt->hsub);
>         height = ALIGN(pix->height, _fmt->vsub);
> @@ -131,8 +129,6 @@ static void _sun4i_csi_try_fmt(struct sun4i_csi *csi,
>                 bpl = pix->width / hsub * _fmt->bpp[i] / 8;
>                 pix->plane_fmt[i].bytesperline = bpl;
>                 pix->plane_fmt[i].sizeimage = bpl * pix->height / vsub;
> -               memset(pix->plane_fmt[i].reserved, 0,
> -                      sizeof(pix->plane_fmt[i].reserved));
>         }
>  }
>
> --
> 2.30.0.284.gd98b1dd5eaa7-goog
>