From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> To: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: linux-leds@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Richard Purdie <rpurdie@rpsys.net>, Jacek Anaszewski <j.anaszewski@samsung.com>, Rob Herring <robh@kernel.org> Subject: Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Date: Wed, 6 Apr 2016 01:39:31 -0300 [thread overview] Message-ID: <CAAEAJfCqgiuf2uLbqA8K3fuAkiriodxL2wG4bnLeHWpsU2ULbQ@mail.gmail.com> (raw) In-Reply-To: <5704301D.7040300@gmail.com> On 5 April 2016 at 18:37, Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote: > Hi Ezequiel, > > On 04/04/2016 10:22 PM, Ezequiel Garcia wrote: >> >> It's desirable to specify which LEDs are to be blinked on a kernel >> panic. Therefore, introduce a devicetree boolean property to mark >> which LEDs should be treated this way. >> >> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> >> --- >> Documentation/devicetree/bindings/leds/common.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/leds/common.txt >> b/Documentation/devicetree/bindings/leds/common.txt >> index 68419843e32f..dd409df9203a 100644 >> --- a/Documentation/devicetree/bindings/leds/common.txt >> +++ b/Documentation/devicetree/bindings/leds/common.txt >> @@ -37,6 +37,8 @@ Optional properties for child nodes: >> property is mandatory for the LEDs in the non-flash >> modes >> (e.g. torch or indicator). >> >> +- panic-blink : Mark this LED to be used by the panic LED trigger. > > > I'd say that 'panic-indicator' would be more informative. > Sure, that looks much better. > Please next time cc also devicetree list and maintainers. > Will do. Thanks for the reviews! -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar
WARNING: multiple messages have this Message-ID (diff)
From: ezequiel@vanguardiasur.com.ar (Ezequiel Garcia) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Date: Wed, 6 Apr 2016 01:39:31 -0300 [thread overview] Message-ID: <CAAEAJfCqgiuf2uLbqA8K3fuAkiriodxL2wG4bnLeHWpsU2ULbQ@mail.gmail.com> (raw) In-Reply-To: <5704301D.7040300@gmail.com> On 5 April 2016 at 18:37, Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote: > Hi Ezequiel, > > On 04/04/2016 10:22 PM, Ezequiel Garcia wrote: >> >> It's desirable to specify which LEDs are to be blinked on a kernel >> panic. Therefore, introduce a devicetree boolean property to mark >> which LEDs should be treated this way. >> >> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> >> --- >> Documentation/devicetree/bindings/leds/common.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/leds/common.txt >> b/Documentation/devicetree/bindings/leds/common.txt >> index 68419843e32f..dd409df9203a 100644 >> --- a/Documentation/devicetree/bindings/leds/common.txt >> +++ b/Documentation/devicetree/bindings/leds/common.txt >> @@ -37,6 +37,8 @@ Optional properties for child nodes: >> property is mandatory for the LEDs in the non-flash >> modes >> (e.g. torch or indicator). >> >> +- panic-blink : Mark this LED to be used by the panic LED trigger. > > > I'd say that 'panic-indicator' would be more informative. > Sure, that looks much better. > Please next time cc also devicetree list and maintainers. > Will do. Thanks for the reviews! -- Ezequiel Garc?a, VanguardiaSur www.vanguardiasur.com.ar
next prev parent reply other threads:[~2016-04-06 4:39 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-04 20:22 [PATCH 0/5] Extend the LED panic trigger Ezequiel Garcia 2016-04-04 20:22 ` Ezequiel Garcia 2016-04-04 20:22 ` Ezequiel Garcia 2016-04-04 20:22 ` [PATCH 1/5] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic Ezequiel Garcia 2016-04-04 20:22 ` Ezequiel Garcia 2016-04-04 20:22 ` Ezequiel Garcia 2016-04-05 21:36 ` Jacek Anaszewski 2016-04-05 21:36 ` Jacek Anaszewski 2016-04-24 9:25 ` Pavel Machek 2016-04-24 9:25 ` Pavel Machek 2016-04-24 9:29 ` Pavel Machek 2016-04-24 9:29 ` Pavel Machek 2016-04-25 6:56 ` Jacek Anaszewski 2016-04-25 6:56 ` Jacek Anaszewski 2016-04-25 16:27 ` Ezequiel Garcia 2016-04-25 16:27 ` Ezequiel Garcia 2016-04-26 7:15 ` Jacek Anaszewski 2016-04-26 7:15 ` Jacek Anaszewski 2016-04-27 20:10 ` Ezequiel Garcia 2016-04-27 20:10 ` Ezequiel Garcia 2016-05-02 7:06 ` Pavel Machek 2016-05-02 7:06 ` Pavel Machek 2016-04-04 20:22 ` [PATCH 2/5] leds: triggers: Add a led_trigger_event_nosleep API Ezequiel Garcia 2016-04-04 20:22 ` Ezequiel Garcia 2016-04-04 20:22 ` Ezequiel Garcia 2016-04-05 21:36 ` Jacek Anaszewski 2016-04-05 21:36 ` Jacek Anaszewski 2016-04-06 4:38 ` Ezequiel Garcia 2016-04-06 4:38 ` Ezequiel Garcia 2016-04-06 6:12 ` Jacek Anaszewski 2016-04-06 6:12 ` Jacek Anaszewski 2016-04-04 20:22 ` [PATCH 3/5] leds: trigger: panic: Use led_trigger_event_nosleep Ezequiel Garcia 2016-04-04 20:22 ` Ezequiel Garcia 2016-04-04 20:22 ` Ezequiel Garcia 2016-04-04 20:22 ` [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Ezequiel Garcia 2016-04-04 20:22 ` Ezequiel Garcia 2016-04-04 20:22 ` Ezequiel Garcia 2016-04-05 21:37 ` Jacek Anaszewski 2016-04-05 21:37 ` Jacek Anaszewski 2016-04-06 4:39 ` Ezequiel Garcia [this message] 2016-04-06 4:39 ` Ezequiel Garcia 2016-04-06 15:12 ` Rob Herring 2016-04-06 15:12 ` Rob Herring 2016-04-06 15:12 ` Rob Herring 2016-04-06 16:13 ` Ezequiel Garcia 2016-04-06 16:13 ` Ezequiel Garcia 2016-04-06 16:13 ` Ezequiel Garcia 2016-04-04 20:22 ` [PATCH 5/5] leds: gpio: Support the panic-blink firmware property Ezequiel Garcia 2016-04-04 20:22 ` Ezequiel Garcia 2016-04-04 20:22 ` Ezequiel Garcia
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAAEAJfCqgiuf2uLbqA8K3fuAkiriodxL2wG4bnLeHWpsU2ULbQ@mail.gmail.com \ --to=ezequiel@vanguardiasur.com.ar \ --cc=j.anaszewski@samsung.com \ --cc=jacek.anaszewski@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=robh@kernel.org \ --cc=rpurdie@rpsys.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.