* [PATCH] mtd: nand: jz4780: fixup, device structure assigned at probe
@ 2016-03-24 1:53 Jorge Ramirez-Ortiz
2016-03-24 14:54 ` Ezequiel Garcia
2016-03-30 14:34 ` Boris Brezillon
0 siblings, 2 replies; 6+ messages in thread
From: Jorge Ramirez-Ortiz @ 2016-03-24 1:53 UTC (permalink / raw)
To: jorge.ramirez-ortiz, boris.brezillon, alex, harvey.hunt
Cc: dwmw2, computersforpeace, linux-mtd
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
---
drivers/mtd/nand/jz4780_bch.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/jz4780_bch.c b/drivers/mtd/nand/jz4780_bch.c
index 755499c..d74f4ba 100644
--- a/drivers/mtd/nand/jz4780_bch.c
+++ b/drivers/mtd/nand/jz4780_bch.c
@@ -287,7 +287,6 @@ static struct jz4780_bch *jz4780_bch_get(struct device_node *np)
bch = platform_get_drvdata(pdev);
clk_prepare_enable(bch->clk);
- bch->dev = &pdev->dev;
return bch;
}
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: nand: jz4780: fixup, device structure assigned at probe
2016-03-24 1:53 [PATCH] mtd: nand: jz4780: fixup, device structure assigned at probe Jorge Ramirez-Ortiz
@ 2016-03-24 14:54 ` Ezequiel Garcia
2016-03-30 14:34 ` Boris Brezillon
1 sibling, 0 replies; 6+ messages in thread
From: Ezequiel Garcia @ 2016-03-24 14:54 UTC (permalink / raw)
To: Jorge Ramirez-Ortiz
Cc: Boris Brezillon, Alex Smith, Harvey Hunt, linux-mtd,
Brian Norris, David Woodhouse
Hi Jorge,
On 23 March 2016 at 22:53, Jorge Ramirez-Ortiz
<jorge.ramirez-ortiz@linaro.org> wrote:
Can you re-submit, with some proper commit log explaining the patch?
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> ---
> drivers/mtd/nand/jz4780_bch.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/jz4780_bch.c b/drivers/mtd/nand/jz4780_bch.c
> index 755499c..d74f4ba 100644
> --- a/drivers/mtd/nand/jz4780_bch.c
> +++ b/drivers/mtd/nand/jz4780_bch.c
> @@ -287,7 +287,6 @@ static struct jz4780_bch *jz4780_bch_get(struct device_node *np)
> bch = platform_get_drvdata(pdev);
> clk_prepare_enable(bch->clk);
>
> - bch->dev = &pdev->dev;
> return bch;
> }
>
> --
> 2.5.0
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
Thanks,
--
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: nand: jz4780: fixup, device structure assigned at probe
2016-03-24 1:53 [PATCH] mtd: nand: jz4780: fixup, device structure assigned at probe Jorge Ramirez-Ortiz
2016-03-24 14:54 ` Ezequiel Garcia
@ 2016-03-30 14:34 ` Boris Brezillon
2016-03-30 14:36 ` Harvey Hunt
2016-03-30 14:37 ` Jorge Ramirez-Ortiz
1 sibling, 2 replies; 6+ messages in thread
From: Boris Brezillon @ 2016-03-30 14:34 UTC (permalink / raw)
To: Jorge Ramirez-Ortiz
Cc: alex, harvey.hunt, linux-mtd, computersforpeace, dwmw2, Ezequiel Garcia
On Wed, 23 Mar 2016 21:53:27 -0400
Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> wrote:
How about adding the following message:
"
bch->dev is already assigned to &pdev->dev in the probe function.
Remove the duplicate assignment done in jz4780_bch_get().
"
If you agree I'll add this commit message while applying (no need to
resend).
Harvey, can I have your ack on this patch?
Thanks,
Boris
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> ---
> drivers/mtd/nand/jz4780_bch.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/jz4780_bch.c b/drivers/mtd/nand/jz4780_bch.c
> index 755499c..d74f4ba 100644
> --- a/drivers/mtd/nand/jz4780_bch.c
> +++ b/drivers/mtd/nand/jz4780_bch.c
> @@ -287,7 +287,6 @@ static struct jz4780_bch *jz4780_bch_get(struct device_node *np)
> bch = platform_get_drvdata(pdev);
> clk_prepare_enable(bch->clk);
>
> - bch->dev = &pdev->dev;
> return bch;
> }
>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: nand: jz4780: fixup, device structure assigned at probe
2016-03-30 14:34 ` Boris Brezillon
@ 2016-03-30 14:36 ` Harvey Hunt
2016-03-30 15:01 ` Boris Brezillon
2016-03-30 14:37 ` Jorge Ramirez-Ortiz
1 sibling, 1 reply; 6+ messages in thread
From: Harvey Hunt @ 2016-03-30 14:36 UTC (permalink / raw)
To: Boris Brezillon, Jorge Ramirez-Ortiz
Cc: alex, linux-mtd, computersforpeace, dwmw2, Ezequiel Garcia
Hi,
On 30/03/16 15:34, Boris Brezillon wrote:
> On Wed, 23 Mar 2016 21:53:27 -0400
> Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> wrote:
>
> How about adding the following message:
>
> "
> bch->dev is already assigned to &pdev->dev in the probe function.
> Remove the duplicate assignment done in jz4780_bch_get().
> "
>
> If you agree I'll add this commit message while applying (no need to
> resend).
That sounds good to me. Congrats on the maintainership btw. :-)
>
> Harvey, can I have your ack on this patch?
Acked-by: Harvey Hunt <harvey.hunt@imgtec.com>
>
> Thanks,
>
> Boris
>
Thanks,
Harvey
>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>> ---
>> drivers/mtd/nand/jz4780_bch.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/jz4780_bch.c b/drivers/mtd/nand/jz4780_bch.c
>> index 755499c..d74f4ba 100644
>> --- a/drivers/mtd/nand/jz4780_bch.c
>> +++ b/drivers/mtd/nand/jz4780_bch.c
>> @@ -287,7 +287,6 @@ static struct jz4780_bch *jz4780_bch_get(struct device_node *np)
>> bch = platform_get_drvdata(pdev);
>> clk_prepare_enable(bch->clk);
>>
>> - bch->dev = &pdev->dev;
>> return bch;
>> }
>>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: nand: jz4780: fixup, device structure assigned at probe
2016-03-30 14:34 ` Boris Brezillon
2016-03-30 14:36 ` Harvey Hunt
@ 2016-03-30 14:37 ` Jorge Ramirez-Ortiz
1 sibling, 0 replies; 6+ messages in thread
From: Jorge Ramirez-Ortiz @ 2016-03-30 14:37 UTC (permalink / raw)
To: Boris Brezillon
Cc: alex, harvey.hunt, linux-mtd, computersforpeace, dwmw2, Ezequiel Garcia
On 03/30/2016 10:34 AM, Boris Brezillon wrote:
> On Wed, 23 Mar 2016 21:53:27 -0400
> Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> wrote:
>
> How about adding the following message:
>
> "
> bch->dev is already assigned to &pdev->dev in the probe function.
> Remove the duplicate assignment done in jz4780_bch_get().
> "
>
> If you agree I'll add this commit message while applying (no need to
> resend).
I am so sorry - got side tracked I should have followed up.
yes that is what I tried (seems like I failed miserably) to indicated in the
commit title.
>
> Harvey, can I have your ack on this patch?
>
> Thanks,
>
> Boris
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: nand: jz4780: fixup, device structure assigned at probe
2016-03-30 14:36 ` Harvey Hunt
@ 2016-03-30 15:01 ` Boris Brezillon
0 siblings, 0 replies; 6+ messages in thread
From: Boris Brezillon @ 2016-03-30 15:01 UTC (permalink / raw)
To: Harvey Hunt
Cc: Jorge Ramirez-Ortiz, alex, linux-mtd, computersforpeace, dwmw2,
Ezequiel Garcia
On Wed, 30 Mar 2016 15:36:51 +0100
Harvey Hunt <harvey.hunt@imgtec.com> wrote:
> Hi,
>
> On 30/03/16 15:34, Boris Brezillon wrote:
> > On Wed, 23 Mar 2016 21:53:27 -0400
> > Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> wrote:
> >
> > How about adding the following message:
> >
> > "
> > bch->dev is already assigned to &pdev->dev in the probe function.
> > Remove the duplicate assignment done in jz4780_bch_get().
> > "
> >
> > If you agree I'll add this commit message while applying (no need to
> > resend).
>
> That sounds good to me. Congrats on the maintainership btw. :-)
Thanks.
>
> >
> > Harvey, can I have your ack on this patch?
>
> Acked-by: Harvey Hunt <harvey.hunt@imgtec.com>
Applied to nand/next.
Thanks,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-30 15:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-24 1:53 [PATCH] mtd: nand: jz4780: fixup, device structure assigned at probe Jorge Ramirez-Ortiz
2016-03-24 14:54 ` Ezequiel Garcia
2016-03-30 14:34 ` Boris Brezillon
2016-03-30 14:36 ` Harvey Hunt
2016-03-30 15:01 ` Boris Brezillon
2016-03-30 14:37 ` Jorge Ramirez-Ortiz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.