From: Stephen Rust <srust@blockbridge.com> To: Sagi Grimberg <sagi@grimberg.me> Cc: Ming Lei <ming.lei@redhat.com>, Rob Townley <rob.townley@gmail.com>, Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, target-devel@vger.kernel.org, Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>, Max Gurtovoy <maxg@mellanox.com> Subject: Re: Data corruption in kernel 5.1+ with iSER attached ramdisk Date: Mon, 30 Mar 2020 13:08:37 -0400 [thread overview] Message-ID: <CAAFE1bdAbKfqbf05pKBcMUj+58fijDMT-8WBSuwiKk2Bmm4v2w@mail.gmail.com> (raw) In-Reply-To: <d2f633f1-57ef-4618-c3a6-c5ff0afead5b@grimberg.me> Sagi, > Sorry for the late reply, lost track of this. No problem! > Can you try attached patch and see if it solves your issue? > WARNING: very lightly tested... I have run our tests against this patch and it is working well for our "basic" testing as well. The test case that previously failed, now passes with this patch. So that's encouraging! Thanks for the quick response and quick patch. One question we had is regarding the hard coded header length: What happens if the initiator sends an extended CDB, like a WRITE32? Are there any concerns with an additional header segment (AHS)? Thanks again, Steve
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rust <srust@blockbridge.com> To: Sagi Grimberg <sagi@grimberg.me> Cc: Ming Lei <ming.lei@redhat.com>, Rob Townley <rob.townley@gmail.com>, Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, target-devel@vger.kernel.org, Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>, Max Gurtovoy <maxg@mellanox.com> Subject: Re: Data corruption in kernel 5.1+ with iSER attached ramdisk Date: Mon, 30 Mar 2020 17:08:37 +0000 [thread overview] Message-ID: <CAAFE1bdAbKfqbf05pKBcMUj+58fijDMT-8WBSuwiKk2Bmm4v2w@mail.gmail.com> (raw) In-Reply-To: <d2f633f1-57ef-4618-c3a6-c5ff0afead5b@grimberg.me> Sagi, > Sorry for the late reply, lost track of this. No problem! > Can you try attached patch and see if it solves your issue? > WARNING: very lightly tested... I have run our tests against this patch and it is working well for our "basic" testing as well. The test case that previously failed, now passes with this patch. So that's encouraging! Thanks for the quick response and quick patch. One question we had is regarding the hard coded header length: What happens if the initiator sends an extended CDB, like a WRITE32? Are there any concerns with an additional header segment (AHS)? Thanks again, Steve
next prev parent reply other threads:[~2020-03-30 17:08 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CAAFE1bd9wuuobpe4VK7Ty175j7mWT+kRmHCNhVD+6R8MWEAqmw@mail.gmail.com> 2019-11-28 1:57 ` Data corruption in kernel 5.1+ with iSER attached ramdisk Ming Lei 2019-11-28 1:57 ` Ming Lei [not found] ` <CA+VdTb_-CGaPjKUQteKVFSGqDz-5o-tuRRkJYqt8B9iOQypiwQ@mail.gmail.com> 2019-11-28 2:58 ` Ming Lei 2019-11-28 2:58 ` Ming Lei [not found] ` <CAAFE1bfsXsKGyw7SU_z4NanT+wmtuJT=XejBYbHHMCDQwm73sw@mail.gmail.com> 2019-11-28 4:25 ` Stephen Rust 2019-11-28 4:25 ` Stephen Rust 2019-11-28 5:51 ` Rob Townley 2019-11-28 5:51 ` Rob Townley 2019-11-28 9:12 ` Ming Lei 2019-11-28 9:12 ` Ming Lei 2019-12-02 18:42 ` Stephen Rust 2019-12-02 18:42 ` Stephen Rust 2019-12-03 0:58 ` Ming Lei 2019-12-03 0:58 ` Ming Lei 2019-12-03 3:04 ` Stephen Rust 2019-12-03 3:04 ` Stephen Rust 2019-12-03 3:14 ` Ming Lei 2019-12-03 3:14 ` Ming Lei 2019-12-03 3:26 ` Stephen Rust 2019-12-03 3:26 ` Stephen Rust 2019-12-03 3:50 ` Stephen Rust 2019-12-03 3:50 ` Stephen Rust 2019-12-03 12:45 ` Ming Lei 2019-12-03 12:45 ` Ming Lei 2019-12-03 19:56 ` Stephen Rust 2019-12-03 19:56 ` Stephen Rust 2019-12-04 1:05 ` Ming Lei 2019-12-04 1:05 ` Ming Lei 2019-12-04 17:23 ` Stephen Rust 2019-12-04 17:23 ` Stephen Rust 2019-12-04 23:02 ` Ming Lei 2019-12-04 23:02 ` Ming Lei 2019-12-05 0:16 ` Bart Van Assche 2019-12-05 0:16 ` Bart Van Assche 2019-12-05 14:44 ` Stephen Rust 2019-12-05 14:44 ` Stephen Rust 2019-12-05 2:28 ` Stephen Rust 2019-12-05 2:28 ` Stephen Rust 2019-12-05 3:05 ` Ming Lei 2019-12-05 3:05 ` Ming Lei 2019-12-05 9:17 ` Sagi Grimberg 2019-12-05 9:17 ` Sagi Grimberg 2019-12-05 14:36 ` Stephen Rust 2019-12-05 14:36 ` Stephen Rust [not found] ` <CAAFE1beqFBQS_zVYEXFTD2qu8PAF9hBSW4j1k9ZD6MhU_gWg5Q@mail.gmail.com> 2020-03-25 0:15 ` Sagi Grimberg 2020-03-25 0:15 ` Sagi Grimberg 2020-03-30 17:08 ` Stephen Rust [this message] 2020-03-30 17:08 ` Stephen Rust 2020-03-31 1:07 ` Sagi Grimberg 2020-03-31 1:07 ` Sagi Grimberg 2020-04-01 0:38 ` Sagi Grimberg 2020-04-01 0:38 ` Sagi Grimberg 2020-04-02 20:03 ` Stephen Rust 2020-04-02 20:03 ` Stephen Rust 2020-04-02 22:16 ` Sagi Grimberg 2020-04-02 22:16 ` Sagi Grimberg 2019-12-04 2:39 ` Ming Lei 2019-12-04 2:39 ` Ming Lei 2019-12-03 4:15 ` Ming Lei 2019-12-03 4:15 ` Ming Lei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAAFE1bdAbKfqbf05pKBcMUj+58fijDMT-8WBSuwiKk2Bmm4v2w@mail.gmail.com \ --to=srust@blockbridge.com \ --cc=axboe@kernel.dk \ --cc=dledford@redhat.com \ --cc=hch@lst.de \ --cc=jgg@ziepe.ca \ --cc=linux-block@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=maxg@mellanox.com \ --cc=ming.lei@redhat.com \ --cc=rob.townley@gmail.com \ --cc=sagi@grimberg.me \ --cc=target-devel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.