All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Vlastimil Babka <vbabka@suse.cz>, linux-mm <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Minchan Kim <minchan@kernel.org>,
	Sasha Levin <sasha.levin@oracle.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@suse.cz>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	metag <linux-metag@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] mm, printk: introduce new format string for flags
Date: Thu, 10 Dec 2015 12:26:53 +0000	[thread overview]
Message-ID: <CAAG0J98vnEBq-vXtJcS6p9dvcsnyJpgR25zom238b8a20BKTEg@mail.gmail.com> (raw)
In-Reply-To: <9558837.lN284KClUg@wuerfel>

On 9 December 2015 at 11:29, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 04 December 2015 16:16:33 Vlastimil Babka wrote:
>> --- a/include/linux/mmdebug.h
>> +++ b/include/linux/mmdebug.h
>> @@ -2,15 +2,20 @@
>>  #define LINUX_MM_DEBUG_H 1
>>
>>  #include <linux/stringify.h>
>> +#include <linux/types.h>
>> +#include <linux/tracepoint.h>
>
> 8<-----
> Subject: mm: fix generated/bounds.h
>
> The inclusion of linux/tracepoint.h is causing build errors for me in ARM
> randconfig:
>
> In file included from /git/arm-soc/include/linux/ktime.h:25:0,
>                  from /git/arm-soc/include/linux/rcupdate.h:47,
>                  from /git/arm-soc/include/linux/tracepoint.h:19,
>                  from /git/arm-soc/include/linux/mmdebug.h:6,
>                  from /git/arm-soc/include/linux/page-flags.h:10,
>                  from /git/arm-soc/kernel/bounds.c:9:
> /git/arm-soc/include/linux/jiffies.h:10:33: fatal error: generated/timeconst.h: No such file or directory
> compilation terminated.
>
> To work around this, we can stop including linux/mmdebug.h from linux/page_flags.h
> while generating bounds.h, as we do for mm_types.h already.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 8c0d593d0f8f ("mm, printk: introduce new format string for flags")
>
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 19724e6ebd26..4efad0578a28 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -7,8 +7,8 @@
>
>  #include <linux/types.h>
>  #include <linux/bug.h>
> -#include <linux/mmdebug.h>
>  #ifndef __GENERATING_BOUNDS_H
> +#include <linux/mmdebug.h>
>  #include <linux/mm_types.h>
>  #include <generated/bounds.h>
>  #endif /* !__GENERATING_BOUNDS_H */

Same build issue observed for metag too.
Tested-by: James Hogan <james.hogan@imgtec.com>

Cheers
James

WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Vlastimil Babka <vbabka@suse.cz>, linux-mm <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Minchan Kim <minchan@kernel.org>,
	Sasha Levin <sasha.levin@oracle.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@suse.cz>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	metag <linux-metag@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] mm, printk: introduce new format string for flags
Date: Thu, 10 Dec 2015 12:26:53 +0000	[thread overview]
Message-ID: <CAAG0J98vnEBq-vXtJcS6p9dvcsnyJpgR25zom238b8a20BKTEg@mail.gmail.com> (raw)
In-Reply-To: <9558837.lN284KClUg@wuerfel>

On 9 December 2015 at 11:29, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 04 December 2015 16:16:33 Vlastimil Babka wrote:
>> --- a/include/linux/mmdebug.h
>> +++ b/include/linux/mmdebug.h
>> @@ -2,15 +2,20 @@
>>  #define LINUX_MM_DEBUG_H 1
>>
>>  #include <linux/stringify.h>
>> +#include <linux/types.h>
>> +#include <linux/tracepoint.h>
>
> 8<-----
> Subject: mm: fix generated/bounds.h
>
> The inclusion of linux/tracepoint.h is causing build errors for me in ARM
> randconfig:
>
> In file included from /git/arm-soc/include/linux/ktime.h:25:0,
>                  from /git/arm-soc/include/linux/rcupdate.h:47,
>                  from /git/arm-soc/include/linux/tracepoint.h:19,
>                  from /git/arm-soc/include/linux/mmdebug.h:6,
>                  from /git/arm-soc/include/linux/page-flags.h:10,
>                  from /git/arm-soc/kernel/bounds.c:9:
> /git/arm-soc/include/linux/jiffies.h:10:33: fatal error: generated/timeconst.h: No such file or directory
> compilation terminated.
>
> To work around this, we can stop including linux/mmdebug.h from linux/page_flags.h
> while generating bounds.h, as we do for mm_types.h already.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 8c0d593d0f8f ("mm, printk: introduce new format string for flags")
>
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 19724e6ebd26..4efad0578a28 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -7,8 +7,8 @@
>
>  #include <linux/types.h>
>  #include <linux/bug.h>
> -#include <linux/mmdebug.h>
>  #ifndef __GENERATING_BOUNDS_H
> +#include <linux/mmdebug.h>
>  #include <linux/mm_types.h>
>  #include <generated/bounds.h>
>  #endif /* !__GENERATING_BOUNDS_H */

Same build issue observed for metag too.
Tested-by: James Hogan <james.hogan@imgtec.com>

Cheers
James

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Vlastimil Babka <vbabka-AlSwsSmVLrQ@public.gmane.org>,
	linux-mm <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Joonsoo Kim <iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org>,
	Minchan Kim <minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Sasha Levin <sasha.levin-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	"Kirill A. Shutemov"
	<kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Mel Gorman <mgorman-l3A5Bk7waGM@public.gmane.org>,
	Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
	Rasmus Villemoes
	<linux-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>,
	metag <linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 1/3] mm, printk: introduce new format string for flags
Date: Thu, 10 Dec 2015 12:26:53 +0000	[thread overview]
Message-ID: <CAAG0J98vnEBq-vXtJcS6p9dvcsnyJpgR25zom238b8a20BKTEg@mail.gmail.com> (raw)
In-Reply-To: <9558837.lN284KClUg@wuerfel>

On 9 December 2015 at 11:29, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
> On Friday 04 December 2015 16:16:33 Vlastimil Babka wrote:
>> --- a/include/linux/mmdebug.h
>> +++ b/include/linux/mmdebug.h
>> @@ -2,15 +2,20 @@
>>  #define LINUX_MM_DEBUG_H 1
>>
>>  #include <linux/stringify.h>
>> +#include <linux/types.h>
>> +#include <linux/tracepoint.h>
>
> 8<-----
> Subject: mm: fix generated/bounds.h
>
> The inclusion of linux/tracepoint.h is causing build errors for me in ARM
> randconfig:
>
> In file included from /git/arm-soc/include/linux/ktime.h:25:0,
>                  from /git/arm-soc/include/linux/rcupdate.h:47,
>                  from /git/arm-soc/include/linux/tracepoint.h:19,
>                  from /git/arm-soc/include/linux/mmdebug.h:6,
>                  from /git/arm-soc/include/linux/page-flags.h:10,
>                  from /git/arm-soc/kernel/bounds.c:9:
> /git/arm-soc/include/linux/jiffies.h:10:33: fatal error: generated/timeconst.h: No such file or directory
> compilation terminated.
>
> To work around this, we can stop including linux/mmdebug.h from linux/page_flags.h
> while generating bounds.h, as we do for mm_types.h already.
>
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> Fixes: 8c0d593d0f8f ("mm, printk: introduce new format string for flags")
>
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 19724e6ebd26..4efad0578a28 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -7,8 +7,8 @@
>
>  #include <linux/types.h>
>  #include <linux/bug.h>
> -#include <linux/mmdebug.h>
>  #ifndef __GENERATING_BOUNDS_H
> +#include <linux/mmdebug.h>
>  #include <linux/mm_types.h>
>  #include <generated/bounds.h>
>  #endif /* !__GENERATING_BOUNDS_H */

Same build issue observed for metag too.
Tested-by: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>

Cheers
James

  parent reply	other threads:[~2015-12-10 12:26 UTC|newest]

Thread overview: 115+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24 12:36 [PATCH v2 0/9] page_owner improvements for debugging Vlastimil Babka
2015-11-24 12:36 ` Vlastimil Babka
2015-11-24 12:36 ` [PATCH v2 1/9] mm, debug: fix wrongly filtered flags in dump_vma() Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-27  9:52   ` Vlastimil Babka
2015-11-27  9:52     ` Vlastimil Babka
2015-11-24 12:36 ` [PATCH v2 2/9] mm, page_owner: print symbolic migratetype of both page and pageblock Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-25  8:11   ` Joonsoo Kim
2015-11-25  8:11     ` Joonsoo Kim
2015-11-24 12:36 ` [PATCH v2 3/9] mm, page_owner: convert page_owner_inited to static key Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-25 14:52   ` Michal Hocko
2015-11-25 14:52     ` Michal Hocko
2015-11-25 15:08     ` Vlastimil Babka
2015-11-25 15:08       ` Vlastimil Babka
2015-11-25 15:25       ` Peter Zijlstra
2015-11-25 15:25         ` Peter Zijlstra
2015-11-25 15:46         ` Michal Hocko
2015-11-25 15:46           ` Michal Hocko
2015-11-24 12:36 ` [PATCH v2 4/9] mm, page_owner: copy page owner info during migration Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-24 12:36 ` [PATCH v2 5/9] mm, page_owner: track and print last migrate reason Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-25  8:13   ` Joonsoo Kim
2015-11-25  8:13     ` Joonsoo Kim
2015-11-26 10:39     ` Vlastimil Babka
2015-11-26 10:39       ` Vlastimil Babka
2015-11-24 12:36 ` [PATCH v2 6/9] mm, debug: introduce dump_gfpflag_names() for symbolic printing of gfp_flags Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-25  8:16   ` Joonsoo Kim
2015-11-25  8:16     ` Joonsoo Kim
2015-11-25 10:28     ` Vlastimil Babka
2015-11-25 10:28       ` Vlastimil Babka
2015-11-27  3:40       ` yalin wang
2015-11-27  3:40         ` yalin wang
2015-11-24 12:36 ` [PATCH v2 7/9] mm, page_owner: dump page owner info from dump_page() Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-25 14:58   ` Michal Hocko
2015-11-25 14:58     ` Michal Hocko
2015-11-26 10:43     ` Vlastimil Babka
2015-11-26 10:43       ` Vlastimil Babka
2015-11-24 12:36 ` [PATCH v2 8/9] mm, page_alloc: print symbolic gfp_flags on allocation failure Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-25 14:33   ` Michal Hocko
2015-11-25 14:33     ` Michal Hocko
2015-11-24 12:36 ` [PATCH v2 9/9] mm, oom: print symbolic gfp_flags in oom warning Vlastimil Babka
2015-11-24 12:36   ` Vlastimil Babka
2015-11-25 14:31   ` Michal Hocko
2015-11-25 14:31     ` Michal Hocko
2016-01-07 21:29   ` David Rientjes
2016-01-07 21:29     ` David Rientjes
2016-01-08 11:34     ` Vlastimil Babka
2016-01-08 11:34       ` Vlastimil Babka
2015-11-25 14:30 ` [PATCH v2 0/9] page_owner improvements for debugging Michal Hocko
2015-11-25 14:30   ` Michal Hocko
2015-11-30 16:10   ` [PATCH 1/2] mm, printk: introduce new format string for flags Vlastimil Babka
2015-11-30 16:10     ` Vlastimil Babka
2015-11-30 16:10     ` [PATCH 2/2] mm, page_owner: provide symbolic page flags and gfp_flags Vlastimil Babka
2015-11-30 16:10       ` Vlastimil Babka
2015-12-02 11:01     ` [PATCH 1/2] mm, printk: introduce new format string for flags Rasmus Villemoes
2015-12-02 11:01       ` Rasmus Villemoes
2015-12-02 20:34       ` Vlastimil Babka
2015-12-02 20:34         ` Vlastimil Babka
2015-12-03 12:37         ` Rasmus Villemoes
2015-12-03 12:37           ` Rasmus Villemoes
2015-12-03 13:46           ` Vlastimil Babka
2015-12-03 13:46             ` Vlastimil Babka
2015-12-04 15:16       ` [PATCH v2 1/3] " Vlastimil Babka
2015-12-04 15:16         ` Vlastimil Babka
2015-12-04 15:16         ` [PATCH v2 2/3] mm, page_owner: provide symbolic page flags and gfp_flags Vlastimil Babka
2015-12-04 15:16           ` Vlastimil Babka
2015-12-04 15:16         ` [PATCH v2 3/3] mm, debug: move bad flags printing to bad_page() Vlastimil Babka
2015-12-04 15:16           ` Vlastimil Babka
2015-12-05 20:00         ` [PATCH v2 1/3] mm, printk: introduce new format string for flags Rasmus Villemoes
2015-12-05 20:00           ` Rasmus Villemoes
2015-12-09 11:29         ` Arnd Bergmann
2015-12-09 11:29           ` Arnd Bergmann
2015-12-09 20:48           ` Vlastimil Babka
2015-12-09 20:48             ` Vlastimil Babka
2015-12-10 12:26           ` James Hogan [this message]
2015-12-10 12:26             ` James Hogan
2015-12-10 12:26             ` James Hogan
2015-12-10  2:59         ` Joonsoo Kim
2015-12-10  2:59           ` Joonsoo Kim
2015-12-10  4:04           ` Steven Rostedt
2015-12-10  4:04             ` Steven Rostedt
2015-12-10  4:12             ` Joonsoo Kim
2015-12-10  4:12               ` Joonsoo Kim
2015-12-10  8:41             ` Rasmus Villemoes
2015-12-10  8:41               ` Rasmus Villemoes
2015-12-10 10:03             ` Vlastimil Babka
2015-12-10 10:03               ` Vlastimil Babka
2015-12-14  3:03               ` Joonsoo Kim
2015-12-14  3:03                 ` Joonsoo Kim
2015-12-10  3:51         ` Steven Rostedt
2015-12-10  3:51           ` Steven Rostedt
2015-12-10  9:51           ` Vlastimil Babka
2015-12-10  9:51             ` Vlastimil Babka
2015-12-02 17:40     ` [PATCH 1/2] " yalin wang
2015-12-02 17:40       ` yalin wang
2015-12-02 21:04       ` Vlastimil Babka
2015-12-02 21:04         ` Vlastimil Babka
2015-12-03  0:11         ` yalin wang
2015-12-03  0:11           ` yalin wang
2015-12-03  8:03           ` Rasmus Villemoes
2015-12-03  8:03             ` Rasmus Villemoes
2015-12-03 18:38             ` yalin wang
2015-12-03 18:38               ` yalin wang
2015-12-04  1:04               ` yalin wang
2015-12-04  1:04                 ` yalin wang
2015-12-04 14:15               ` Vlastimil Babka
2015-12-04 14:15                 ` Vlastimil Babka
2015-12-10  4:03                 ` Steven Rostedt
2015-12-10  4:03                   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAG0J98vnEBq-vXtJcS6p9dvcsnyJpgR25zom238b8a20BKTEg@mail.gmail.com \
    --to=james.hogan@imgtec.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-metag@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=minchan@kernel.org \
    --cc=sasha.levin@oracle.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.