From: "Yan, Zheng" <ukernel@gmail.com>
To: Xiubo Li <xiubli@redhat.com>
Cc: Jeff Layton <jlayton@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
Venky Shankar <vshankar@redhat.com>,
Patrick Donnelly <pdonnell@redhat.com>,
Luis Henriques <lhenriques@suse.de>,
ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] ceph: switch to 4KB block size if quota size is not aligned to 4MB
Date: Thu, 30 Jun 2022 11:30:41 +0800 [thread overview]
Message-ID: <CAAM7YAkBiMyYW8uZo8JB9Yn_8N4DH0H7Yr2013Yb4oQ7btss0w@mail.gmail.com> (raw)
In-Reply-To: <04405a13-5d9e-232a-58fe-ef22783f4881@redhat.com>
On Thu, Jun 30, 2022 at 11:05 AM Xiubo Li <xiubli@redhat.com> wrote:
>
>
> On 6/30/22 10:39 AM, Yan, Zheng wrote:
> > NACK, this change will significantly increase mds load. Inaccuracy is
> > inherent in current quota design.
>
> Yeah, I was also thinking could we just allow the quota size to be
> aligned to 4KB if it < 4MB, or must be aligned to 4MB ?
>
> Any idea ?
make sense
>
> - Xiubo
>
>
> > On Mon, Jun 27, 2022 at 10:06 AM <xiubli@redhat.com> wrote:
> >> From: Xiubo Li <xiubli@redhat.com>
> >>
> >> V2:
> >> - Switched to IS_ALIGNED() macro
> >> - Added CEPH_4K_BLOCK_SIZE macro
> >> - Rename CEPH_BLOCK to CEPH_BLOCK_SIZE
> >>
> >> Xiubo Li (3):
> >> ceph: make f_bsize always equal to f_frsize
> >> ceph: switch to use CEPH_4K_BLOCK_SHIFT macro
> >> ceph: switch to 4KB block size if quota size is not aligned to 4MB
> >>
> >> fs/ceph/quota.c | 32 ++++++++++++++++++++------------
> >> fs/ceph/super.c | 28 ++++++++++++++--------------
> >> fs/ceph/super.h | 5 +++--
> >> 3 files changed, 37 insertions(+), 28 deletions(-)
> >>
> >> --
> >> 2.36.0.rc1
> >>
>
next prev parent reply other threads:[~2022-06-30 3:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 2:02 [PATCH v2 0/2] ceph: switch to 4KB block size if quota size is not aligned to 4MB xiubli
2022-06-27 2:02 ` [PATCH v2 1/3] ceph: make f_bsize always equal to f_frsize xiubli
2022-06-27 2:02 ` [PATCH v2 2/3] ceph: switch to use CEPH_4K_BLOCK_SHIFT macro xiubli
2022-06-27 2:02 ` [PATCH v2 3/3] ceph: switch to 4KB block size if quota size is not aligned to 4MB xiubli
2022-06-27 12:17 ` [PATCH v2 0/2] " Jeff Layton
2022-06-30 2:39 ` Yan, Zheng
2022-06-30 3:05 ` Xiubo Li
2022-06-30 3:30 ` Yan, Zheng [this message]
2022-06-30 3:33 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAM7YAkBiMyYW8uZo8JB9Yn_8N4DH0H7Yr2013Yb4oQ7btss0w@mail.gmail.com \
--to=ukernel@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=lhenriques@suse.de \
--cc=pdonnell@redhat.com \
--cc=vshankar@redhat.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.