* [PATCH v2] drm/mediatek: add AAL output size configuration @ 2021-08-10 2:55 ` jason-jh.lin 0 siblings, 0 replies; 7+ messages in thread From: jason-jh.lin @ 2021-08-10 2:55 UTC (permalink / raw) To: Rob Herring, Matthias Brugger, Chun-Kuang Hu, Philipp Zabel, Enric Balletbo i Serra, fshao Cc: David Airlie, Daniel Vetter, Fabien Parent, hsinyi, jason-jh . lin, Yongqiang Niu, nancy.lin, singo.chang, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, dri-devel To avoid the output width and height is incorrect, AAL_OUTPUT_SIZE configuration should be set. Fixes: 0664d1392c26 ("drm/mediatek: Add AAL engine basic function") Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> --- Change in v2: - fix to one line --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index 75bc00e17fc4..50d20562e612 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c @@ -34,6 +34,7 @@ #define DISP_AAL_EN 0x0000 #define DISP_AAL_SIZE 0x0030 +#define DISP_AAL_OUTPUT_SIZE 0x04d8 #define DISP_DITHER_EN 0x0000 #define DITHER_EN BIT(0) @@ -197,6 +198,7 @@ static void mtk_aal_config(struct device *dev, unsigned int w, struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev); mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE); + mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_OUTPUT_SIZE); } static void mtk_aal_gamma_set(struct device *dev, struct drm_crtc_state *state) -- 2.18.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2] drm/mediatek: add AAL output size configuration @ 2021-08-10 2:55 ` jason-jh.lin 0 siblings, 0 replies; 7+ messages in thread From: jason-jh.lin @ 2021-08-10 2:55 UTC (permalink / raw) To: Rob Herring, Matthias Brugger, Chun-Kuang Hu, Philipp Zabel, Enric Balletbo i Serra, fshao Cc: David Airlie, Daniel Vetter, Fabien Parent, hsinyi, jason-jh . lin, Yongqiang Niu, nancy.lin, singo.chang, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, dri-devel To avoid the output width and height is incorrect, AAL_OUTPUT_SIZE configuration should be set. Fixes: 0664d1392c26 ("drm/mediatek: Add AAL engine basic function") Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> --- Change in v2: - fix to one line --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index 75bc00e17fc4..50d20562e612 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c @@ -34,6 +34,7 @@ #define DISP_AAL_EN 0x0000 #define DISP_AAL_SIZE 0x0030 +#define DISP_AAL_OUTPUT_SIZE 0x04d8 #define DISP_DITHER_EN 0x0000 #define DITHER_EN BIT(0) @@ -197,6 +198,7 @@ static void mtk_aal_config(struct device *dev, unsigned int w, struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev); mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE); + mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_OUTPUT_SIZE); } static void mtk_aal_gamma_set(struct device *dev, struct drm_crtc_state *state) -- 2.18.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2] drm/mediatek: add AAL output size configuration @ 2021-08-10 2:55 ` jason-jh.lin 0 siblings, 0 replies; 7+ messages in thread From: jason-jh.lin @ 2021-08-10 2:55 UTC (permalink / raw) To: Rob Herring, Matthias Brugger, Chun-Kuang Hu, Philipp Zabel, Enric Balletbo i Serra, fshao Cc: David Airlie, Daniel Vetter, Fabien Parent, hsinyi, jason-jh . lin, Yongqiang Niu, nancy.lin, singo.chang, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, dri-devel To avoid the output width and height is incorrect, AAL_OUTPUT_SIZE configuration should be set. Fixes: 0664d1392c26 ("drm/mediatek: Add AAL engine basic function") Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> --- Change in v2: - fix to one line --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index 75bc00e17fc4..50d20562e612 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c @@ -34,6 +34,7 @@ #define DISP_AAL_EN 0x0000 #define DISP_AAL_SIZE 0x0030 +#define DISP_AAL_OUTPUT_SIZE 0x04d8 #define DISP_DITHER_EN 0x0000 #define DITHER_EN BIT(0) @@ -197,6 +198,7 @@ static void mtk_aal_config(struct device *dev, unsigned int w, struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev); mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE); + mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_OUTPUT_SIZE); } static void mtk_aal_gamma_set(struct device *dev, struct drm_crtc_state *state) -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/mediatek: add AAL output size configuration 2021-08-10 2:55 ` jason-jh.lin (?) (?) @ 2021-08-11 23:05 ` Chun-Kuang Hu -1 siblings, 0 replies; 7+ messages in thread From: Chun-Kuang Hu @ 2021-08-11 23:05 UTC (permalink / raw) To: jason-jh.lin Cc: Rob Herring, Matthias Brugger, Chun-Kuang Hu, Philipp Zabel, Enric Balletbo i Serra, fshao, David Airlie, Daniel Vetter, Fabien Parent, Hsin-Yi Wang, Yongqiang Niu, Nancy Lin, singo.chang, DTML, Linux ARM, moderated list:ARM/Mediatek SoC support, linux-kernel, DRI Development Hi, Jason: jason-jh.lin <jason-jh.lin@mediatek.com> 於 2021年8月10日 週二 上午10:55寫道: > > To avoid the output width and height is incorrect, > AAL_OUTPUT_SIZE configuration should be set. Applied to mediatek-drm-fixes [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes Regards, Chun-Kuang. > > Fixes: 0664d1392c26 ("drm/mediatek: Add AAL engine basic function") > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > --- > Change in v2: > - fix to one line > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > index 75bc00e17fc4..50d20562e612 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > @@ -34,6 +34,7 @@ > > #define DISP_AAL_EN 0x0000 > #define DISP_AAL_SIZE 0x0030 > +#define DISP_AAL_OUTPUT_SIZE 0x04d8 > > #define DISP_DITHER_EN 0x0000 > #define DITHER_EN BIT(0) > @@ -197,6 +198,7 @@ static void mtk_aal_config(struct device *dev, unsigned int w, > struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev); > > mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE); > + mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_OUTPUT_SIZE); > } > > static void mtk_aal_gamma_set(struct device *dev, struct drm_crtc_state *state) > -- > 2.18.0 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/mediatek: add AAL output size configuration @ 2021-08-11 23:05 ` Chun-Kuang Hu 0 siblings, 0 replies; 7+ messages in thread From: Chun-Kuang Hu @ 2021-08-11 23:05 UTC (permalink / raw) To: jason-jh.lin Cc: Rob Herring, Matthias Brugger, Chun-Kuang Hu, Philipp Zabel, Enric Balletbo i Serra, fshao, David Airlie, Daniel Vetter, Fabien Parent, Hsin-Yi Wang, Yongqiang Niu, Nancy Lin, singo.chang, DTML, Linux ARM, moderated list:ARM/Mediatek SoC support, linux-kernel, DRI Development Hi, Jason: jason-jh.lin <jason-jh.lin@mediatek.com> 於 2021年8月10日 週二 上午10:55寫道: > > To avoid the output width and height is incorrect, > AAL_OUTPUT_SIZE configuration should be set. Applied to mediatek-drm-fixes [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes Regards, Chun-Kuang. > > Fixes: 0664d1392c26 ("drm/mediatek: Add AAL engine basic function") > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > --- > Change in v2: > - fix to one line > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > index 75bc00e17fc4..50d20562e612 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > @@ -34,6 +34,7 @@ > > #define DISP_AAL_EN 0x0000 > #define DISP_AAL_SIZE 0x0030 > +#define DISP_AAL_OUTPUT_SIZE 0x04d8 > > #define DISP_DITHER_EN 0x0000 > #define DITHER_EN BIT(0) > @@ -197,6 +198,7 @@ static void mtk_aal_config(struct device *dev, unsigned int w, > struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev); > > mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE); > + mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_OUTPUT_SIZE); > } > > static void mtk_aal_gamma_set(struct device *dev, struct drm_crtc_state *state) > -- > 2.18.0 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/mediatek: add AAL output size configuration @ 2021-08-11 23:05 ` Chun-Kuang Hu 0 siblings, 0 replies; 7+ messages in thread From: Chun-Kuang Hu @ 2021-08-11 23:05 UTC (permalink / raw) To: jason-jh.lin Cc: Rob Herring, Matthias Brugger, Chun-Kuang Hu, Philipp Zabel, Enric Balletbo i Serra, fshao, David Airlie, Daniel Vetter, Fabien Parent, Hsin-Yi Wang, Yongqiang Niu, Nancy Lin, singo.chang, DTML, Linux ARM, moderated list:ARM/Mediatek SoC support, linux-kernel, DRI Development Hi, Jason: jason-jh.lin <jason-jh.lin@mediatek.com> 於 2021年8月10日 週二 上午10:55寫道: > > To avoid the output width and height is incorrect, > AAL_OUTPUT_SIZE configuration should be set. Applied to mediatek-drm-fixes [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes Regards, Chun-Kuang. > > Fixes: 0664d1392c26 ("drm/mediatek: Add AAL engine basic function") > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > --- > Change in v2: > - fix to one line > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > index 75bc00e17fc4..50d20562e612 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > @@ -34,6 +34,7 @@ > > #define DISP_AAL_EN 0x0000 > #define DISP_AAL_SIZE 0x0030 > +#define DISP_AAL_OUTPUT_SIZE 0x04d8 > > #define DISP_DITHER_EN 0x0000 > #define DITHER_EN BIT(0) > @@ -197,6 +198,7 @@ static void mtk_aal_config(struct device *dev, unsigned int w, > struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev); > > mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE); > + mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_OUTPUT_SIZE); > } > > static void mtk_aal_gamma_set(struct device *dev, struct drm_crtc_state *state) > -- > 2.18.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/mediatek: add AAL output size configuration @ 2021-08-11 23:05 ` Chun-Kuang Hu 0 siblings, 0 replies; 7+ messages in thread From: Chun-Kuang Hu @ 2021-08-11 23:05 UTC (permalink / raw) To: jason-jh.lin Cc: Rob Herring, Matthias Brugger, Chun-Kuang Hu, Philipp Zabel, Enric Balletbo i Serra, fshao, David Airlie, Daniel Vetter, Fabien Parent, Hsin-Yi Wang, Yongqiang Niu, Nancy Lin, singo.chang, DTML, Linux ARM, moderated list:ARM/Mediatek SoC support, linux-kernel, DRI Development Hi, Jason: jason-jh.lin <jason-jh.lin@mediatek.com> 於 2021年8月10日 週二 上午10:55寫道: > > To avoid the output width and height is incorrect, > AAL_OUTPUT_SIZE configuration should be set. Applied to mediatek-drm-fixes [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes Regards, Chun-Kuang. > > Fixes: 0664d1392c26 ("drm/mediatek: Add AAL engine basic function") > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > --- > Change in v2: > - fix to one line > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > index 75bc00e17fc4..50d20562e612 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > @@ -34,6 +34,7 @@ > > #define DISP_AAL_EN 0x0000 > #define DISP_AAL_SIZE 0x0030 > +#define DISP_AAL_OUTPUT_SIZE 0x04d8 > > #define DISP_DITHER_EN 0x0000 > #define DITHER_EN BIT(0) > @@ -197,6 +198,7 @@ static void mtk_aal_config(struct device *dev, unsigned int w, > struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev); > > mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE); > + mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_OUTPUT_SIZE); > } > > static void mtk_aal_gamma_set(struct device *dev, struct drm_crtc_state *state) > -- > 2.18.0 > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-08-11 23:08 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-08-10 2:55 [PATCH v2] drm/mediatek: add AAL output size configuration jason-jh.lin 2021-08-10 2:55 ` jason-jh.lin 2021-08-10 2:55 ` jason-jh.lin 2021-08-11 23:05 ` Chun-Kuang Hu 2021-08-11 23:05 ` Chun-Kuang Hu 2021-08-11 23:05 ` Chun-Kuang Hu 2021-08-11 23:05 ` Chun-Kuang Hu
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.