* [PATCH v6 0/1] force hsa hbp hfp packets multiple of lanenum to avoid screen shift
@ 2021-08-08 13:41 ` Jitao Shi
0 siblings, 0 replies; 10+ messages in thread
From: Jitao Shi @ 2021-08-08 13:41 UTC (permalink / raw)
To: Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, Daniel Vetter,
David Airlie, dri-devel, linux-kernel
Cc: linux-mediatek, linux-arm-kernel, ck.hu, stonea168, huijuan.xie,
rex-bc.chen, shuijing.li, robh+dt, devicetree, Jitao Shi
Changes since v5:
- Remvoe the anx7625 devicetree change. Use the compatible string intead.
Changes since v4:
- Move "dt-bindings: drm/bridge: anx7625: add force_dsi_end_without_null" before
"drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid".
- Retitle "dt-bindings: drm/bridge: anx7625: add force_dsi_end_without_null".
Jitao Shi (1):
drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid
screen shift
drivers/gpu/drm/mediatek/mtk_dsi.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v6 0/1] force hsa hbp hfp packets multiple of lanenum to avoid screen shift @ 2021-08-08 13:41 ` Jitao Shi 0 siblings, 0 replies; 10+ messages in thread From: Jitao Shi @ 2021-08-08 13:41 UTC (permalink / raw) To: Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, Daniel Vetter, David Airlie, dri-devel, linux-kernel Cc: linux-mediatek, linux-arm-kernel, ck.hu, stonea168, huijuan.xie, rex-bc.chen, shuijing.li, robh+dt, devicetree, Jitao Shi Changes since v5: - Remvoe the anx7625 devicetree change. Use the compatible string intead. Changes since v4: - Move "dt-bindings: drm/bridge: anx7625: add force_dsi_end_without_null" before "drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid". - Retitle "dt-bindings: drm/bridge: anx7625: add force_dsi_end_without_null". Jitao Shi (1): drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid screen shift drivers/gpu/drm/mediatek/mtk_dsi.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v6 0/1] force hsa hbp hfp packets multiple of lanenum to avoid screen shift @ 2021-08-08 13:41 ` Jitao Shi 0 siblings, 0 replies; 10+ messages in thread From: Jitao Shi @ 2021-08-08 13:41 UTC (permalink / raw) To: Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, Daniel Vetter, David Airlie, dri-devel, linux-kernel Cc: linux-mediatek, linux-arm-kernel, ck.hu, stonea168, huijuan.xie, rex-bc.chen, shuijing.li, robh+dt, devicetree, Jitao Shi Changes since v5: - Remvoe the anx7625 devicetree change. Use the compatible string intead. Changes since v4: - Move "dt-bindings: drm/bridge: anx7625: add force_dsi_end_without_null" before "drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid". - Retitle "dt-bindings: drm/bridge: anx7625: add force_dsi_end_without_null". Jitao Shi (1): drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid screen shift drivers/gpu/drm/mediatek/mtk_dsi.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) -- 2.25.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v6 1/1] drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid screen shift 2021-08-08 13:41 ` Jitao Shi (?) @ 2021-08-08 13:41 ` Jitao Shi -1 siblings, 0 replies; 10+ messages in thread From: Jitao Shi @ 2021-08-08 13:41 UTC (permalink / raw) To: Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, Daniel Vetter, David Airlie, dri-devel, linux-kernel Cc: linux-mediatek, linux-arm-kernel, ck.hu, stonea168, huijuan.xie, rex-bc.chen, shuijing.li, robh+dt, devicetree, Jitao Shi The bridge chip ANX7625 requires the packets on lanes aligned at the end, or ANX7625 will shift the screen. Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index ae403c67cbd9..033234d51e86 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -194,6 +194,8 @@ struct mtk_dsi { struct clk *hs_clk; u32 data_rate; + /* force dsi line end without dsi_null data */ + bool force_dsi_end_without_null; unsigned long mode_flags; enum mipi_dsi_pixel_format format; @@ -499,6 +501,13 @@ static void mtk_dsi_config_vdo_timing(struct mtk_dsi *dsi) DRM_WARN("HFP + HBP less than d-phy, FPS will under 60Hz\n"); } + if (dsi->force_dsi_end_without_null) { + horizontal_sync_active_byte = roundup(horizontal_sync_active_byte, dsi->lanes) - 2; + horizontal_frontporch_byte = roundup(horizontal_frontporch_byte, dsi->lanes) - 2; + horizontal_backporch_byte = roundup(horizontal_backporch_byte, dsi->lanes) - 2; + horizontal_backporch_byte -= (vm->hactive * dsi_tmp_buf_bpp + 2) % dsi->lanes; + } + writel(horizontal_sync_active_byte, dsi->regs + DSI_HSA_WC); writel(horizontal_backporch_byte, dsi->regs + DSI_HBP_WC); writel(horizontal_frontporch_byte, dsi->regs + DSI_HFP_WC); @@ -1095,6 +1104,10 @@ static int mtk_dsi_probe(struct platform_device *pdev) dsi->bridge.of_node = dev->of_node; dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; + if (dsi->next_bridge) + dsi->force_dsi_end_without_null = of_device_is_compatible(dsi->next_bridge->of_node, + "analogix,anx7625"); + drm_bridge_add(&dsi->bridge); ret = component_add(&pdev->dev, &mtk_dsi_component_ops); -- 2.25.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v6 1/1] drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid screen shift @ 2021-08-08 13:41 ` Jitao Shi 0 siblings, 0 replies; 10+ messages in thread From: Jitao Shi @ 2021-08-08 13:41 UTC (permalink / raw) To: Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, Daniel Vetter, David Airlie, dri-devel, linux-kernel Cc: linux-mediatek, linux-arm-kernel, ck.hu, stonea168, huijuan.xie, rex-bc.chen, shuijing.li, robh+dt, devicetree, Jitao Shi The bridge chip ANX7625 requires the packets on lanes aligned at the end, or ANX7625 will shift the screen. Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index ae403c67cbd9..033234d51e86 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -194,6 +194,8 @@ struct mtk_dsi { struct clk *hs_clk; u32 data_rate; + /* force dsi line end without dsi_null data */ + bool force_dsi_end_without_null; unsigned long mode_flags; enum mipi_dsi_pixel_format format; @@ -499,6 +501,13 @@ static void mtk_dsi_config_vdo_timing(struct mtk_dsi *dsi) DRM_WARN("HFP + HBP less than d-phy, FPS will under 60Hz\n"); } + if (dsi->force_dsi_end_without_null) { + horizontal_sync_active_byte = roundup(horizontal_sync_active_byte, dsi->lanes) - 2; + horizontal_frontporch_byte = roundup(horizontal_frontporch_byte, dsi->lanes) - 2; + horizontal_backporch_byte = roundup(horizontal_backporch_byte, dsi->lanes) - 2; + horizontal_backporch_byte -= (vm->hactive * dsi_tmp_buf_bpp + 2) % dsi->lanes; + } + writel(horizontal_sync_active_byte, dsi->regs + DSI_HSA_WC); writel(horizontal_backporch_byte, dsi->regs + DSI_HBP_WC); writel(horizontal_frontporch_byte, dsi->regs + DSI_HFP_WC); @@ -1095,6 +1104,10 @@ static int mtk_dsi_probe(struct platform_device *pdev) dsi->bridge.of_node = dev->of_node; dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; + if (dsi->next_bridge) + dsi->force_dsi_end_without_null = of_device_is_compatible(dsi->next_bridge->of_node, + "analogix,anx7625"); + drm_bridge_add(&dsi->bridge); ret = component_add(&pdev->dev, &mtk_dsi_component_ops); -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v6 1/1] drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid screen shift @ 2021-08-08 13:41 ` Jitao Shi 0 siblings, 0 replies; 10+ messages in thread From: Jitao Shi @ 2021-08-08 13:41 UTC (permalink / raw) To: Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, Daniel Vetter, David Airlie, dri-devel, linux-kernel Cc: linux-mediatek, linux-arm-kernel, ck.hu, stonea168, huijuan.xie, rex-bc.chen, shuijing.li, robh+dt, devicetree, Jitao Shi The bridge chip ANX7625 requires the packets on lanes aligned at the end, or ANX7625 will shift the screen. Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index ae403c67cbd9..033234d51e86 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -194,6 +194,8 @@ struct mtk_dsi { struct clk *hs_clk; u32 data_rate; + /* force dsi line end without dsi_null data */ + bool force_dsi_end_without_null; unsigned long mode_flags; enum mipi_dsi_pixel_format format; @@ -499,6 +501,13 @@ static void mtk_dsi_config_vdo_timing(struct mtk_dsi *dsi) DRM_WARN("HFP + HBP less than d-phy, FPS will under 60Hz\n"); } + if (dsi->force_dsi_end_without_null) { + horizontal_sync_active_byte = roundup(horizontal_sync_active_byte, dsi->lanes) - 2; + horizontal_frontporch_byte = roundup(horizontal_frontporch_byte, dsi->lanes) - 2; + horizontal_backporch_byte = roundup(horizontal_backporch_byte, dsi->lanes) - 2; + horizontal_backporch_byte -= (vm->hactive * dsi_tmp_buf_bpp + 2) % dsi->lanes; + } + writel(horizontal_sync_active_byte, dsi->regs + DSI_HSA_WC); writel(horizontal_backporch_byte, dsi->regs + DSI_HBP_WC); writel(horizontal_frontporch_byte, dsi->regs + DSI_HFP_WC); @@ -1095,6 +1104,10 @@ static int mtk_dsi_probe(struct platform_device *pdev) dsi->bridge.of_node = dev->of_node; dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; + if (dsi->next_bridge) + dsi->force_dsi_end_without_null = of_device_is_compatible(dsi->next_bridge->of_node, + "analogix,anx7625"); + drm_bridge_add(&dsi->bridge); ret = component_add(&pdev->dev, &mtk_dsi_component_ops); -- 2.25.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v6 1/1] drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid screen shift 2021-08-08 13:41 ` Jitao Shi (?) (?) @ 2021-08-09 14:44 ` Chun-Kuang Hu -1 siblings, 0 replies; 10+ messages in thread From: Chun-Kuang Hu @ 2021-08-09 14:44 UTC (permalink / raw) To: Jitao Shi Cc: Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, Daniel Vetter, David Airlie, DRI Development, linux-kernel, moderated list:ARM/Mediatek SoC support, Linux ARM, CK Hu, stonea168, huijuan.xie, Rex-BC Chen, shuijing.li, Rob Herring, DTML Hi, Jitao: Jitao Shi <jitao.shi@mediatek.com> 於 2021年8月8日 週日 下午9:41寫道： > > The bridge chip ANX7625 requires the packets on lanes aligned at the end, > or ANX7625 will shift the screen. In anx7625_attach_dsi(), it call mipi_dsi_attach(), and it call into mtk_dsi_host_attach(). I would like to pass this information from anx7623 driver to mtk_dsi driver when attach. Regards, Chun-Kuang. > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index ae403c67cbd9..033234d51e86 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -194,6 +194,8 @@ struct mtk_dsi { > struct clk *hs_clk; > > u32 data_rate; > + /* force dsi line end without dsi_null data */ > + bool force_dsi_end_without_null; > > unsigned long mode_flags; > enum mipi_dsi_pixel_format format; > @@ -499,6 +501,13 @@ static void mtk_dsi_config_vdo_timing(struct mtk_dsi *dsi) > DRM_WARN("HFP + HBP less than d-phy, FPS will under 60Hz\n"); > } > > + if (dsi->force_dsi_end_without_null) { > + horizontal_sync_active_byte = roundup(horizontal_sync_active_byte, dsi->lanes) - 2; > + horizontal_frontporch_byte = roundup(horizontal_frontporch_byte, dsi->lanes) - 2; > + horizontal_backporch_byte = roundup(horizontal_backporch_byte, dsi->lanes) - 2; > + horizontal_backporch_byte -= (vm->hactive * dsi_tmp_buf_bpp + 2) % dsi->lanes; > + } > + > writel(horizontal_sync_active_byte, dsi->regs + DSI_HSA_WC); > writel(horizontal_backporch_byte, dsi->regs + DSI_HBP_WC); > writel(horizontal_frontporch_byte, dsi->regs + DSI_HFP_WC); > @@ -1095,6 +1104,10 @@ static int mtk_dsi_probe(struct platform_device *pdev) > dsi->bridge.of_node = dev->of_node; > dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; > > + if (dsi->next_bridge) > + dsi->force_dsi_end_without_null = of_device_is_compatible(dsi->next_bridge->of_node, > + "analogix,anx7625"); > + > drm_bridge_add(&dsi->bridge); > > ret = component_add(&pdev->dev, &mtk_dsi_component_ops); > -- > 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v6 1/1] drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid screen shift @ 2021-08-09 14:44 ` Chun-Kuang Hu 0 siblings, 0 replies; 10+ messages in thread From: Chun-Kuang Hu @ 2021-08-09 14:44 UTC (permalink / raw) To: Jitao Shi Cc: Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, Daniel Vetter, David Airlie, DRI Development, linux-kernel, moderated list:ARM/Mediatek SoC support, Linux ARM, CK Hu, stonea168, huijuan.xie, Rex-BC Chen, shuijing.li, Rob Herring, DTML Hi, Jitao: Jitao Shi <jitao.shi@mediatek.com> 於 2021年8月8日 週日 下午9:41寫道： > > The bridge chip ANX7625 requires the packets on lanes aligned at the end, > or ANX7625 will shift the screen. In anx7625_attach_dsi(), it call mipi_dsi_attach(), and it call into mtk_dsi_host_attach(). I would like to pass this information from anx7623 driver to mtk_dsi driver when attach. Regards, Chun-Kuang. > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index ae403c67cbd9..033234d51e86 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -194,6 +194,8 @@ struct mtk_dsi { > struct clk *hs_clk; > > u32 data_rate; > + /* force dsi line end without dsi_null data */ > + bool force_dsi_end_without_null; > > unsigned long mode_flags; > enum mipi_dsi_pixel_format format; > @@ -499,6 +501,13 @@ static void mtk_dsi_config_vdo_timing(struct mtk_dsi *dsi) > DRM_WARN("HFP + HBP less than d-phy, FPS will under 60Hz\n"); > } > > + if (dsi->force_dsi_end_without_null) { > + horizontal_sync_active_byte = roundup(horizontal_sync_active_byte, dsi->lanes) - 2; > + horizontal_frontporch_byte = roundup(horizontal_frontporch_byte, dsi->lanes) - 2; > + horizontal_backporch_byte = roundup(horizontal_backporch_byte, dsi->lanes) - 2; > + horizontal_backporch_byte -= (vm->hactive * dsi_tmp_buf_bpp + 2) % dsi->lanes; > + } > + > writel(horizontal_sync_active_byte, dsi->regs + DSI_HSA_WC); > writel(horizontal_backporch_byte, dsi->regs + DSI_HBP_WC); > writel(horizontal_frontporch_byte, dsi->regs + DSI_HFP_WC); > @@ -1095,6 +1104,10 @@ static int mtk_dsi_probe(struct platform_device *pdev) > dsi->bridge.of_node = dev->of_node; > dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; > > + if (dsi->next_bridge) > + dsi->force_dsi_end_without_null = of_device_is_compatible(dsi->next_bridge->of_node, > + "analogix,anx7625"); > + > drm_bridge_add(&dsi->bridge); > > ret = component_add(&pdev->dev, &mtk_dsi_component_ops); > -- > 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v6 1/1] drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid screen shift @ 2021-08-09 14:44 ` Chun-Kuang Hu 0 siblings, 0 replies; 10+ messages in thread From: Chun-Kuang Hu @ 2021-08-09 14:44 UTC (permalink / raw) To: Jitao Shi Cc: Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, Daniel Vetter, David Airlie, DRI Development, linux-kernel, moderated list:ARM/Mediatek SoC support, Linux ARM, CK Hu, stonea168, huijuan.xie, Rex-BC Chen, shuijing.li, Rob Herring, DTML Hi, Jitao: Jitao Shi <jitao.shi@mediatek.com> 於 2021年8月8日 週日 下午9:41寫道： > > The bridge chip ANX7625 requires the packets on lanes aligned at the end, > or ANX7625 will shift the screen. In anx7625_attach_dsi(), it call mipi_dsi_attach(), and it call into mtk_dsi_host_attach(). I would like to pass this information from anx7623 driver to mtk_dsi driver when attach. Regards, Chun-Kuang. > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index ae403c67cbd9..033234d51e86 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -194,6 +194,8 @@ struct mtk_dsi { > struct clk *hs_clk; > > u32 data_rate; > + /* force dsi line end without dsi_null data */ > + bool force_dsi_end_without_null; > > unsigned long mode_flags; > enum mipi_dsi_pixel_format format; > @@ -499,6 +501,13 @@ static void mtk_dsi_config_vdo_timing(struct mtk_dsi *dsi) > DRM_WARN("HFP + HBP less than d-phy, FPS will under 60Hz\n"); > } > > + if (dsi->force_dsi_end_without_null) { > + horizontal_sync_active_byte = roundup(horizontal_sync_active_byte, dsi->lanes) - 2; > + horizontal_frontporch_byte = roundup(horizontal_frontporch_byte, dsi->lanes) - 2; > + horizontal_backporch_byte = roundup(horizontal_backporch_byte, dsi->lanes) - 2; > + horizontal_backporch_byte -= (vm->hactive * dsi_tmp_buf_bpp + 2) % dsi->lanes; > + } > + > writel(horizontal_sync_active_byte, dsi->regs + DSI_HSA_WC); > writel(horizontal_backporch_byte, dsi->regs + DSI_HBP_WC); > writel(horizontal_frontporch_byte, dsi->regs + DSI_HFP_WC); > @@ -1095,6 +1104,10 @@ static int mtk_dsi_probe(struct platform_device *pdev) > dsi->bridge.of_node = dev->of_node; > dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; > > + if (dsi->next_bridge) > + dsi->force_dsi_end_without_null = of_device_is_compatible(dsi->next_bridge->of_node, > + "analogix,anx7625"); > + > drm_bridge_add(&dsi->bridge); > > ret = component_add(&pdev->dev, &mtk_dsi_component_ops); > -- > 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v6 1/1] drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid screen shift @ 2021-08-09 14:44 ` Chun-Kuang Hu 0 siblings, 0 replies; 10+ messages in thread From: Chun-Kuang Hu @ 2021-08-09 14:44 UTC (permalink / raw) To: Jitao Shi Cc: Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, Daniel Vetter, David Airlie, DRI Development, linux-kernel, moderated list:ARM/Mediatek SoC support, Linux ARM, CK Hu, stonea168, huijuan.xie, Rex-BC Chen, shuijing.li, Rob Herring, DTML Hi, Jitao: Jitao Shi <jitao.shi@mediatek.com> 於 2021年8月8日 週日 下午9:41寫道： > > The bridge chip ANX7625 requires the packets on lanes aligned at the end, > or ANX7625 will shift the screen. In anx7625_attach_dsi(), it call mipi_dsi_attach(), and it call into mtk_dsi_host_attach(). I would like to pass this information from anx7623 driver to mtk_dsi driver when attach. Regards, Chun-Kuang. > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index ae403c67cbd9..033234d51e86 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -194,6 +194,8 @@ struct mtk_dsi { > struct clk *hs_clk; > > u32 data_rate; > + /* force dsi line end without dsi_null data */ > + bool force_dsi_end_without_null; > > unsigned long mode_flags; > enum mipi_dsi_pixel_format format; > @@ -499,6 +501,13 @@ static void mtk_dsi_config_vdo_timing(struct mtk_dsi *dsi) > DRM_WARN("HFP + HBP less than d-phy, FPS will under 60Hz\n"); > } > > + if (dsi->force_dsi_end_without_null) { > + horizontal_sync_active_byte = roundup(horizontal_sync_active_byte, dsi->lanes) - 2; > + horizontal_frontporch_byte = roundup(horizontal_frontporch_byte, dsi->lanes) - 2; > + horizontal_backporch_byte = roundup(horizontal_backporch_byte, dsi->lanes) - 2; > + horizontal_backporch_byte -= (vm->hactive * dsi_tmp_buf_bpp + 2) % dsi->lanes; > + } > + > writel(horizontal_sync_active_byte, dsi->regs + DSI_HSA_WC); > writel(horizontal_backporch_byte, dsi->regs + DSI_HBP_WC); > writel(horizontal_frontporch_byte, dsi->regs + DSI_HFP_WC); > @@ -1095,6 +1104,10 @@ static int mtk_dsi_probe(struct platform_device *pdev) > dsi->bridge.of_node = dev->of_node; > dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; > > + if (dsi->next_bridge) > + dsi->force_dsi_end_without_null = of_device_is_compatible(dsi->next_bridge->of_node, > + "analogix,anx7625"); > + > drm_bridge_add(&dsi->bridge); > > ret = component_add(&pdev->dev, &mtk_dsi_component_ops); > -- > 2.25.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-08-09 14:47 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-08-08 13:41 [PATCH v6 0/1] force hsa hbp hfp packets multiple of lanenum to avoid screen shift Jitao Shi 2021-08-08 13:41 ` Jitao Shi 2021-08-08 13:41 ` Jitao Shi 2021-08-08 13:41 ` [PATCH v6 1/1] drm/mediatek: " Jitao Shi 2021-08-08 13:41 ` Jitao Shi 2021-08-08 13:41 ` Jitao Shi 2021-08-09 14:44 ` Chun-Kuang Hu 2021-08-09 14:44 ` Chun-Kuang Hu 2021-08-09 14:44 ` Chun-Kuang Hu 2021-08-09 14:44 ` Chun-Kuang Hu
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.