* [PATCH] drm/mediatek: Remove dependency on GEM DMA helper
@ 2023-01-19 22:40 ` Rob Clark
0 siblings, 0 replies; 9+ messages in thread
From: Rob Clark @ 2023-01-19 22:40 UTC (permalink / raw)
To: dri-devel
Cc: Rob Clark, Chun-Kuang Hu, Philipp Zabel, David Airlie,
Daniel Vetter, Matthias Brugger,
moderated list:DRM DRIVERS FOR MEDIATEK, open list,
moderated list:ARM/Mediatek SoC support
From: Rob Clark <robdclark@chromium.org>
It appears that the dependency on the DMA helpers was only for
drm_gem_dma_vm_ops.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/mediatek/Kconfig | 1 -
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 7 ++++++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
index 369e495d0c3e..b451dee64d34 100644
--- a/drivers/gpu/drm/mediatek/Kconfig
+++ b/drivers/gpu/drm/mediatek/Kconfig
@@ -7,7 +7,6 @@ config DRM_MEDIATEK
depends on HAVE_ARM_SMCCC
depends on OF
depends on MTK_MMSYS
- select DRM_GEM_DMA_HELPER
select DRM_KMS_HELPER
select DRM_MIPI_DSI
select DRM_PANEL
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index 47e96b0289f9..9b3d15d3a983 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -16,13 +16,18 @@
static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
+static const struct vm_operations_struct vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
static const struct drm_gem_object_funcs mtk_drm_gem_object_funcs = {
.free = mtk_drm_gem_free_object,
.get_sg_table = mtk_gem_prime_get_sg_table,
.vmap = mtk_drm_gem_prime_vmap,
.vunmap = mtk_drm_gem_prime_vunmap,
.mmap = mtk_drm_gem_object_mmap,
- .vm_ops = &drm_gem_dma_vm_ops,
+ .vm_ops = &vm_ops,
};
static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
--
2.38.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] drm/mediatek: Remove dependency on GEM DMA helper
@ 2023-01-19 22:40 ` Rob Clark
0 siblings, 0 replies; 9+ messages in thread
From: Rob Clark @ 2023-01-19 22:40 UTC (permalink / raw)
To: dri-devel
Cc: Rob Clark, Chun-Kuang Hu, open list,
moderated list:DRM DRIVERS FOR MEDIATEK, Matthias Brugger,
moderated list:ARM/Mediatek SoC support
From: Rob Clark <robdclark@chromium.org>
It appears that the dependency on the DMA helpers was only for
drm_gem_dma_vm_ops.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/mediatek/Kconfig | 1 -
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 7 ++++++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
index 369e495d0c3e..b451dee64d34 100644
--- a/drivers/gpu/drm/mediatek/Kconfig
+++ b/drivers/gpu/drm/mediatek/Kconfig
@@ -7,7 +7,6 @@ config DRM_MEDIATEK
depends on HAVE_ARM_SMCCC
depends on OF
depends on MTK_MMSYS
- select DRM_GEM_DMA_HELPER
select DRM_KMS_HELPER
select DRM_MIPI_DSI
select DRM_PANEL
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index 47e96b0289f9..9b3d15d3a983 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -16,13 +16,18 @@
static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
+static const struct vm_operations_struct vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
static const struct drm_gem_object_funcs mtk_drm_gem_object_funcs = {
.free = mtk_drm_gem_free_object,
.get_sg_table = mtk_gem_prime_get_sg_table,
.vmap = mtk_drm_gem_prime_vmap,
.vunmap = mtk_drm_gem_prime_vunmap,
.mmap = mtk_drm_gem_object_mmap,
- .vm_ops = &drm_gem_dma_vm_ops,
+ .vm_ops = &vm_ops,
};
static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
--
2.38.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] drm/mediatek: Remove dependency on GEM DMA helper
@ 2023-01-19 22:40 ` Rob Clark
0 siblings, 0 replies; 9+ messages in thread
From: Rob Clark @ 2023-01-19 22:40 UTC (permalink / raw)
To: dri-devel
Cc: Rob Clark, Chun-Kuang Hu, Philipp Zabel, David Airlie,
Daniel Vetter, Matthias Brugger,
moderated list:DRM DRIVERS FOR MEDIATEK, open list,
moderated list:ARM/Mediatek SoC support
From: Rob Clark <robdclark@chromium.org>
It appears that the dependency on the DMA helpers was only for
drm_gem_dma_vm_ops.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/mediatek/Kconfig | 1 -
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 7 ++++++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
index 369e495d0c3e..b451dee64d34 100644
--- a/drivers/gpu/drm/mediatek/Kconfig
+++ b/drivers/gpu/drm/mediatek/Kconfig
@@ -7,7 +7,6 @@ config DRM_MEDIATEK
depends on HAVE_ARM_SMCCC
depends on OF
depends on MTK_MMSYS
- select DRM_GEM_DMA_HELPER
select DRM_KMS_HELPER
select DRM_MIPI_DSI
select DRM_PANEL
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index 47e96b0289f9..9b3d15d3a983 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -16,13 +16,18 @@
static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
+static const struct vm_operations_struct vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
static const struct drm_gem_object_funcs mtk_drm_gem_object_funcs = {
.free = mtk_drm_gem_free_object,
.get_sg_table = mtk_gem_prime_get_sg_table,
.vmap = mtk_drm_gem_prime_vmap,
.vunmap = mtk_drm_gem_prime_vunmap,
.mmap = mtk_drm_gem_object_mmap,
- .vm_ops = &drm_gem_dma_vm_ops,
+ .vm_ops = &vm_ops,
};
static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
--
2.38.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/mediatek: Remove dependency on GEM DMA helper
2023-01-19 22:40 ` Rob Clark
(?)
@ 2023-01-27 3:04 ` Chun-Kuang Hu
-1 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2023-01-27 3:04 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, Rob Clark, Chun-Kuang Hu, Philipp Zabel, David Airlie,
Daniel Vetter, Matthias Brugger,
moderated list:DRM DRIVERS FOR MEDIATEK, open list,
moderated list:ARM/Mediatek SoC support
Hi, Rob:
Rob Clark <robdclark@gmail.com> 於 2023年1月20日 週五 上午6:40寫道:
>
> From: Rob Clark <robdclark@chromium.org>
>
> It appears that the dependency on the DMA helpers was only for
> drm_gem_dma_vm_ops.
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
Chun-Kuang.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/mediatek/Kconfig | 1 -
> drivers/gpu/drm/mediatek/mtk_drm_gem.c | 7 ++++++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> index 369e495d0c3e..b451dee64d34 100644
> --- a/drivers/gpu/drm/mediatek/Kconfig
> +++ b/drivers/gpu/drm/mediatek/Kconfig
> @@ -7,7 +7,6 @@ config DRM_MEDIATEK
> depends on HAVE_ARM_SMCCC
> depends on OF
> depends on MTK_MMSYS
> - select DRM_GEM_DMA_HELPER
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select DRM_PANEL
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index 47e96b0289f9..9b3d15d3a983 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -16,13 +16,18 @@
>
> static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
>
> +static const struct vm_operations_struct vm_ops = {
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> static const struct drm_gem_object_funcs mtk_drm_gem_object_funcs = {
> .free = mtk_drm_gem_free_object,
> .get_sg_table = mtk_gem_prime_get_sg_table,
> .vmap = mtk_drm_gem_prime_vmap,
> .vunmap = mtk_drm_gem_prime_vunmap,
> .mmap = mtk_drm_gem_object_mmap,
> - .vm_ops = &drm_gem_dma_vm_ops,
> + .vm_ops = &vm_ops,
> };
>
> static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
> --
> 2.38.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/mediatek: Remove dependency on GEM DMA helper
@ 2023-01-27 3:04 ` Chun-Kuang Hu
0 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2023-01-27 3:04 UTC (permalink / raw)
To: Rob Clark
Cc: Rob Clark, Chun-Kuang Hu, open list, dri-devel,
moderated list:DRM DRIVERS FOR MEDIATEK, Matthias Brugger,
moderated list:ARM/Mediatek SoC support
Hi, Rob:
Rob Clark <robdclark@gmail.com> 於 2023年1月20日 週五 上午6:40寫道:
>
> From: Rob Clark <robdclark@chromium.org>
>
> It appears that the dependency on the DMA helpers was only for
> drm_gem_dma_vm_ops.
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
Chun-Kuang.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/mediatek/Kconfig | 1 -
> drivers/gpu/drm/mediatek/mtk_drm_gem.c | 7 ++++++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> index 369e495d0c3e..b451dee64d34 100644
> --- a/drivers/gpu/drm/mediatek/Kconfig
> +++ b/drivers/gpu/drm/mediatek/Kconfig
> @@ -7,7 +7,6 @@ config DRM_MEDIATEK
> depends on HAVE_ARM_SMCCC
> depends on OF
> depends on MTK_MMSYS
> - select DRM_GEM_DMA_HELPER
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select DRM_PANEL
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index 47e96b0289f9..9b3d15d3a983 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -16,13 +16,18 @@
>
> static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
>
> +static const struct vm_operations_struct vm_ops = {
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> static const struct drm_gem_object_funcs mtk_drm_gem_object_funcs = {
> .free = mtk_drm_gem_free_object,
> .get_sg_table = mtk_gem_prime_get_sg_table,
> .vmap = mtk_drm_gem_prime_vmap,
> .vunmap = mtk_drm_gem_prime_vunmap,
> .mmap = mtk_drm_gem_object_mmap,
> - .vm_ops = &drm_gem_dma_vm_ops,
> + .vm_ops = &vm_ops,
> };
>
> static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
> --
> 2.38.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/mediatek: Remove dependency on GEM DMA helper
@ 2023-01-27 3:04 ` Chun-Kuang Hu
0 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2023-01-27 3:04 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, Rob Clark, Chun-Kuang Hu, Philipp Zabel, David Airlie,
Daniel Vetter, Matthias Brugger,
moderated list:DRM DRIVERS FOR MEDIATEK, open list,
moderated list:ARM/Mediatek SoC support
Hi, Rob:
Rob Clark <robdclark@gmail.com> 於 2023年1月20日 週五 上午6:40寫道:
>
> From: Rob Clark <robdclark@chromium.org>
>
> It appears that the dependency on the DMA helpers was only for
> drm_gem_dma_vm_ops.
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
Chun-Kuang.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/mediatek/Kconfig | 1 -
> drivers/gpu/drm/mediatek/mtk_drm_gem.c | 7 ++++++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> index 369e495d0c3e..b451dee64d34 100644
> --- a/drivers/gpu/drm/mediatek/Kconfig
> +++ b/drivers/gpu/drm/mediatek/Kconfig
> @@ -7,7 +7,6 @@ config DRM_MEDIATEK
> depends on HAVE_ARM_SMCCC
> depends on OF
> depends on MTK_MMSYS
> - select DRM_GEM_DMA_HELPER
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select DRM_PANEL
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index 47e96b0289f9..9b3d15d3a983 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -16,13 +16,18 @@
>
> static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
>
> +static const struct vm_operations_struct vm_ops = {
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> static const struct drm_gem_object_funcs mtk_drm_gem_object_funcs = {
> .free = mtk_drm_gem_free_object,
> .get_sg_table = mtk_gem_prime_get_sg_table,
> .vmap = mtk_drm_gem_prime_vmap,
> .vunmap = mtk_drm_gem_prime_vunmap,
> .mmap = mtk_drm_gem_object_mmap,
> - .vm_ops = &drm_gem_dma_vm_ops,
> + .vm_ops = &vm_ops,
> };
>
> static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
> --
> 2.38.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/mediatek: Remove dependency on GEM DMA helper
2023-01-19 22:40 ` Rob Clark
(?)
@ 2023-01-27 15:58 ` Doug Anderson
-1 siblings, 0 replies; 9+ messages in thread
From: Doug Anderson @ 2023-01-27 15:58 UTC (permalink / raw)
To: Rob Clark
Cc: Rob Clark, Chun-Kuang Hu, open list, dri-devel,
moderated list:DRM DRIVERS FOR MEDIATEK, Matthias Brugger,
moderated list:ARM/Mediatek SoC support
Hi,
On Thu, Jan 19, 2023 at 2:40 PM Rob Clark <robdclark@gmail.com> wrote:
>
> From: Rob Clark <robdclark@chromium.org>
>
> It appears that the dependency on the DMA helpers was only for
> drm_gem_dma_vm_ops.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/mediatek/Kconfig | 1 -
> drivers/gpu/drm/mediatek/mtk_drm_gem.c | 7 ++++++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
Drive-by comment: can you post a follow-up patch that also removes the
"#include <drm/drm_gem_dma_helper.h>" from "mtk_drm_gem.c", assuming
that still compiles? If it doesn't compile, that might be a bad sign
that we missed something. ;-)
-Doug
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/mediatek: Remove dependency on GEM DMA helper
@ 2023-01-27 15:58 ` Doug Anderson
0 siblings, 0 replies; 9+ messages in thread
From: Doug Anderson @ 2023-01-27 15:58 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, Rob Clark, Chun-Kuang Hu, open list,
moderated list:DRM DRIVERS FOR MEDIATEK, Matthias Brugger,
moderated list:ARM/Mediatek SoC support
Hi,
On Thu, Jan 19, 2023 at 2:40 PM Rob Clark <robdclark@gmail.com> wrote:
>
> From: Rob Clark <robdclark@chromium.org>
>
> It appears that the dependency on the DMA helpers was only for
> drm_gem_dma_vm_ops.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/mediatek/Kconfig | 1 -
> drivers/gpu/drm/mediatek/mtk_drm_gem.c | 7 ++++++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
Drive-by comment: can you post a follow-up patch that also removes the
"#include <drm/drm_gem_dma_helper.h>" from "mtk_drm_gem.c", assuming
that still compiles? If it doesn't compile, that might be a bad sign
that we missed something. ;-)
-Doug
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/mediatek: Remove dependency on GEM DMA helper
@ 2023-01-27 15:58 ` Doug Anderson
0 siblings, 0 replies; 9+ messages in thread
From: Doug Anderson @ 2023-01-27 15:58 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, Rob Clark, Chun-Kuang Hu, open list,
moderated list:DRM DRIVERS FOR MEDIATEK, Matthias Brugger,
moderated list:ARM/Mediatek SoC support
Hi,
On Thu, Jan 19, 2023 at 2:40 PM Rob Clark <robdclark@gmail.com> wrote:
>
> From: Rob Clark <robdclark@chromium.org>
>
> It appears that the dependency on the DMA helpers was only for
> drm_gem_dma_vm_ops.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/mediatek/Kconfig | 1 -
> drivers/gpu/drm/mediatek/mtk_drm_gem.c | 7 ++++++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
Drive-by comment: can you post a follow-up patch that also removes the
"#include <drm/drm_gem_dma_helper.h>" from "mtk_drm_gem.c", assuming
that still compiles? If it doesn't compile, that might be a bad sign
that we missed something. ;-)
-Doug
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-01-27 15:59 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-19 22:40 [PATCH] drm/mediatek: Remove dependency on GEM DMA helper Rob Clark
2023-01-19 22:40 ` Rob Clark
2023-01-19 22:40 ` Rob Clark
2023-01-27 3:04 ` Chun-Kuang Hu
2023-01-27 3:04 ` Chun-Kuang Hu
2023-01-27 3:04 ` Chun-Kuang Hu
2023-01-27 15:58 ` Doug Anderson
2023-01-27 15:58 ` Doug Anderson
2023-01-27 15:58 ` Doug Anderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.