All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomeu Vizoso <tomeu.vizoso@collabora.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: open list <linux-kernel@vger.kernel.org>,
	Felipe Balbi <felipe.balbi@linux.intel.com>,
	Amelie Delaunay <amelie.delaunay@st.com>,
	Minas Harutyunyan <hminas@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check
Date: Wed, 4 Apr 2018 15:33:13 +0200	[thread overview]
Message-ID: <CAAObsKDAGC86EeQCQ5WzCi=VQmKe1Fs_Zhsaqf698d2tg9-fCw@mail.gmail.com> (raw)
In-Reply-To: <2158461.zz8sS7CZ86@diego>

Could this patch be picked up, please?

Thanks,

Tomeu

On 26 March 2018 at 13:51, Heiko Stübner <heiko@sntech.de> wrote:
> Am Montag, 26. März 2018, 11:00:01 CEST schrieb Tomeu Vizoso:
>> devm_regulator_get_optional returns -ENODEV if the regulator isn't
>> there, so if that's the case we have to make sure not to leave -ENODEV
>> in the regulator pointer.
>>
>> Also, make sure we return 0 in that case, but correctly propagate any
>> other errors. Also propagate the error from _dwc2_hcd_start.
>>
>> Fixes: 531ef5ebea96 ("usb: dwc2: add support for host mode external vbus
>> supply") Cc: Amelie Delaunay <amelie.delaunay@st.com>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>

WARNING: multiple messages have this Message-ID (diff)
From: Tomeu Vizoso <tomeu.vizoso@collabora.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: open list <linux-kernel@vger.kernel.org>,
	Felipe Balbi <felipe.balbi@linux.intel.com>,
	Amelie Delaunay <amelie.delaunay@st.com>,
	Minas Harutyunyan <hminas@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org
Subject: [v4] usb: dwc2: dwc2_vbus_supply_init: fix error check
Date: Wed, 4 Apr 2018 15:33:13 +0200	[thread overview]
Message-ID: <CAAObsKDAGC86EeQCQ5WzCi=VQmKe1Fs_Zhsaqf698d2tg9-fCw@mail.gmail.com> (raw)

Could this patch be picked up, please?

Thanks,

Tomeu

On 26 March 2018 at 13:51, Heiko Stübner <heiko@sntech.de> wrote:
> Am Montag, 26. März 2018, 11:00:01 CEST schrieb Tomeu Vizoso:
>> devm_regulator_get_optional returns -ENODEV if the regulator isn't
>> there, so if that's the case we have to make sure not to leave -ENODEV
>> in the regulator pointer.
>>
>> Also, make sure we return 0 in that case, but correctly propagate any
>> other errors. Also propagate the error from _dwc2_hcd_start.
>>
>> Fixes: 531ef5ebea96 ("usb: dwc2: add support for host mode external vbus
>> supply") Cc: Amelie Delaunay <amelie.delaunay@st.com>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-04-04 13:33 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22  9:39 [PATCH] usb: dwc2: dwc2_vbus_supply_init: fix error check Tomeu Vizoso
2018-03-22  9:39 ` Tomeu Vizoso
2018-03-22 11:39 ` [PATCH] " Heiko Stübner
2018-03-22 11:39   ` Heiko Stuebner
2018-03-22 11:41   ` [PATCH] " Heiko Stübner
2018-03-22 11:41     ` Heiko Stuebner
2018-03-22 12:21     ` [PATCH] " Amelie DELAUNAY
2018-03-22 12:21       ` Amelie Delaunay
2018-03-22 13:06 ` [PATCH v2] " Tomeu Vizoso
2018-03-22 13:06   ` Tomeu Vizoso
2018-03-22 13:06   ` [v2] " Tomeu Vizoso
2018-03-22 13:14 ` [PATCH v3] " Tomeu Vizoso
2018-03-22 13:14   ` [v3] " Tomeu Vizoso
2018-03-22 13:26   ` [PATCH v3] " Heiko Stübner
2018-03-22 13:26     ` [v3] " Heiko Stuebner
2018-03-22 13:34     ` [PATCH v3] " Tomeu Vizoso
2018-03-22 13:34       ` [v3] " Tomeu Vizoso
2018-03-24  0:24   ` [PATCH v3] " kbuild test robot
2018-03-24  0:24     ` [v3] " kbuild test robot
2018-03-26  9:00 ` [PATCH v4] " Tomeu Vizoso
2018-03-26  9:00   ` [v4] " Tomeu Vizoso
2018-03-26 10:56   ` [PATCH v4] " Amelie DELAUNAY
2018-03-26 10:56     ` [v4] " Amelie Delaunay
2018-03-26 11:51   ` [PATCH v4] " Heiko Stübner
2018-03-26 11:51     ` [v4] " Heiko Stuebner
2018-04-04 13:33     ` Tomeu Vizoso [this message]
2018-04-04 13:33       ` Tomeu Vizoso
2018-04-05  7:54   ` [PATCH v4] " Minas Harutyunyan
2018-04-05  7:54     ` [v4] " Minas Harutyunyan
2018-04-05  8:10     ` [PATCH v4] " Tomeu Vizoso
2018-04-05  8:10       ` [v4] " Tomeu Vizoso
2018-04-05  9:02       ` [PATCH v4] " Grigor Tovmasyan
2018-04-05  9:02         ` [v4] " Grigor Tovmasyan
2018-04-05  8:58   ` [PATCH v4] " Grigor Tovmasyan
2018-04-05  8:58     ` [v4] " Grigor Tovmasyan
2018-04-05  9:51     ` [PATCH v4] " Minas Harutyunyan
2018-04-05  9:51       ` [v4] " Minas Harutyunyan
2018-04-10 12:28   ` [PATCH v4] " Heiko Stuebner
2018-04-10 12:28     ` [v4] " Heiko Stuebner
2018-04-10 13:52     ` [PATCH v4] " Minas Harutyunyan
2018-04-10 13:52       ` [v4] " Minas Harutyunyan
2018-04-10 15:37       ` [PATCH v4] " Heiko Stübner
2018-04-10 15:37         ` [v4] " Heiko Stuebner
2018-04-11  6:50         ` [PATCH v4] " Minas Harutyunyan
2018-04-11  6:50           ` [v4] " Minas Harutyunyan
2018-04-23 13:24           ` [PATCH v4] " Tomeu Vizoso
2018-04-23 13:24             ` [v4] " Tomeu Vizoso
2018-04-24  8:58             ` [PATCH v4] " Heiko Stübner
2018-04-24  8:58               ` [v4] " Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAObsKDAGC86EeQCQ5WzCi=VQmKe1Fs_Zhsaqf698d2tg9-fCw@mail.gmail.com' \
    --to=tomeu.vizoso@collabora.com \
    --cc=amelie.delaunay@st.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=hminas@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.