All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] modem-manager: bump to version 1.12.2
@ 2019-12-12  9:33 Aleksander Morgado
  2019-12-12 10:39 ` Carlos Santos
  0 siblings, 1 reply; 7+ messages in thread
From: Aleksander Morgado @ 2019-12-12  9:33 UTC (permalink / raw)
  To: buildroot

Also include a patch that solves build issues detected in 1.12.0, e.g.:
http://lists.busybox.net/pipermail/buildroot/2019-December/268817.html
http://autobuild.buildroot.net/results/5ac390b2a813cadb4cb180d61bb05f6fe4407155/build-end.log

Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
---

Hey!

This version bump to 1.12.2 also includes a patch required to build correctly when using strict library link ordering. Adding this patch requires triggering autoreconf. The patch is already included in the upstream MM repo, so the next 1.12.4 release will also include it (whenever that is, not scheduled yet).

Cheers!

---
 ...ix-order-of-linked-libs-in-test-apps.patch | 40 +++++++++++++++++++
 package/modem-manager/modem-manager.hash      |  2 +-
 package/modem-manager/modem-manager.mk        |  5 ++-
 3 files changed, 45 insertions(+), 2 deletions(-)
 create mode 100644 package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch

diff --git a/package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch b/package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch
new file mode 100644
index 0000000000..d58960ce57
--- /dev/null
+++ b/package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch
@@ -0,0 +1,40 @@
+From 52cfd6788e4d12f3c2ea302e66bcc80c5efd80ee Mon Sep 17 00:00:00 2001
+From: Aleksander Morgado <aleksander@aleksander.es>
+Date: Wed, 11 Dec 2019 16:09:25 +0100
+Subject: [PATCH] build: fix order of linked libs in test apps
+
+Solving build issues with truly strict linkers, as in:
+http://lists.busybox.net/pipermail/buildroot/2019-December/268817.html
+
+Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
+---
+ test/Makefile.am | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/test/Makefile.am b/test/Makefile.am
+index ba737bc5..20e2a068 100644
+--- a/test/Makefile.am
++++ b/test/Makefile.am
+@@ -87,8 +87,8 @@ mmsmspdu_CPPFLAGS = \
+
+ mmsmspdu_LDADD = \
+ 	$(MM_LIBS) \
+-	$(top_builddir)/src/libhelpers.la \
+ 	$(top_builddir)/libmm-glib/libmm-glib.la \
++	$(top_builddir)/src/libhelpers.la \
+ 	$(NULL)
+
+ ################################################################################
+@@ -112,8 +112,8 @@ mmsmsmonitor_CPPFLAGS = \
+
+ mmsmsmonitor_LDADD = \
+ 	$(MM_LIBS) \
+-	$(top_builddir)/src/libhelpers.la \
+ 	$(top_builddir)/libmm-glib/libmm-glib.la \
++	$(top_builddir)/src/libhelpers.la \
+ 	$(NULL)
+
+ ################################################################################
+--
+2.24.0
+
diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
index b1fef98fe2..a3925bb4a2 100644
--- a/package/modem-manager/modem-manager.hash
+++ b/package/modem-manager/modem-manager.hash
@@ -1,4 +1,4 @@
 # Locally computed
-sha256  3daca86164145fffb589939433f596c13fa077c9a187c0d5820fdd5b4e4a6424  ModemManager-1.12.0.tar.xz
+sha256  4f76d2bdd0ed6780837cdde886eaf535f9770f9daa1ff92e63658d06aa5d25ea  ModemManager-1.12.2.tar.xz
 sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
 sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
index b5aa7914f6..8aa9f36766 100644
--- a/package/modem-manager/modem-manager.mk
+++ b/package/modem-manager/modem-manager.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################

-MODEM_MANAGER_VERSION = 1.12.0
+MODEM_MANAGER_VERSION = 1.12.2
 MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
 MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
 MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
@@ -13,6 +13,9 @@ MODEM_MANAGER_DEPENDENCIES = host-pkgconf libglib2 $(TARGET_NLS_DEPENDENCIES)
 MODEM_MANAGER_INSTALL_STAGING = YES
 MODEM_MANAGER_CONF_OPTS = --disable-more-warnings

+# 0001-build-fix-order-of-linked-libs-in-test-apps.patch
+MODEM_MANAGER_AUTORECONF = YES
+
 ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
 MODEM_MANAGER_DEPENDENCIES += libqmi
 MODEM_MANAGER_CONF_OPTS += --with-qmi
--
2.24.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] modem-manager: bump to version 1.12.2
  2019-12-12  9:33 [Buildroot] [PATCH] modem-manager: bump to version 1.12.2 Aleksander Morgado
@ 2019-12-12 10:39 ` Carlos Santos
  2019-12-12 10:50   ` Aleksander Morgado
  0 siblings, 1 reply; 7+ messages in thread
From: Carlos Santos @ 2019-12-12 10:39 UTC (permalink / raw)
  To: buildroot

On Thu, Dec 12, 2019 at 6:33 AM Aleksander Morgado
<aleksander@aleksander.es> wrote:
>
> Also include a patch that solves build issues detected in 1.12.0, e.g.:
> http://lists.busybox.net/pipermail/buildroot/2019-December/268817.html
> http://autobuild.buildroot.net/results/5ac390b2a813cadb4cb180d61bb05f6fe4407155/build-end.log
>
> Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> ---
>
> Hey!
>
> This version bump to 1.12.2 also includes a patch required to build correctly when using strict library link ordering. Adding this patch requires triggering autoreconf. The patch is already included in the upstream MM repo, so the next 1.12.4 release will also include it (whenever that is, not scheduled yet).
>
> Cheers!
>
> ---
>  ...ix-order-of-linked-libs-in-test-apps.patch | 40 +++++++++++++++++++
>  package/modem-manager/modem-manager.hash      |  2 +-
>  package/modem-manager/modem-manager.mk        |  5 ++-
>  3 files changed, 45 insertions(+), 2 deletions(-)
>  create mode 100644 package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch
>
> diff --git a/package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch b/package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch
> new file mode 100644
> index 0000000000..d58960ce57
> --- /dev/null
> +++ b/package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch
> @@ -0,0 +1,40 @@
> +From 52cfd6788e4d12f3c2ea302e66bcc80c5efd80ee Mon Sep 17 00:00:00 2001
> +From: Aleksander Morgado <aleksander@aleksander.es>
> +Date: Wed, 11 Dec 2019 16:09:25 +0100
> +Subject: [PATCH] build: fix order of linked libs in test apps
> +
> +Solving build issues with truly strict linkers, as in:
> +http://lists.busybox.net/pipermail/buildroot/2019-December/268817.html
> +
> +Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> +---
> + test/Makefile.am | 4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/test/Makefile.am b/test/Makefile.am
> +index ba737bc5..20e2a068 100644
> +--- a/test/Makefile.am
> ++++ b/test/Makefile.am
> +@@ -87,8 +87,8 @@ mmsmspdu_CPPFLAGS = \
> +
> + mmsmspdu_LDADD = \
> +       $(MM_LIBS) \
> +-      $(top_builddir)/src/libhelpers.la \
> +       $(top_builddir)/libmm-glib/libmm-glib.la \
> ++      $(top_builddir)/src/libhelpers.la \
> +       $(NULL)
> +
> + ################################################################################
> +@@ -112,8 +112,8 @@ mmsmsmonitor_CPPFLAGS = \
> +
> + mmsmsmonitor_LDADD = \
> +       $(MM_LIBS) \
> +-      $(top_builddir)/src/libhelpers.la \
> +       $(top_builddir)/libmm-glib/libmm-glib.la \
> ++      $(top_builddir)/src/libhelpers.la \
> +       $(NULL)
> +
> + ################################################################################
> +--
> +2.24.0
> +
> diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
> index b1fef98fe2..a3925bb4a2 100644
> --- a/package/modem-manager/modem-manager.hash
> +++ b/package/modem-manager/modem-manager.hash
> @@ -1,4 +1,4 @@
>  # Locally computed
> -sha256  3daca86164145fffb589939433f596c13fa077c9a187c0d5820fdd5b4e4a6424  ModemManager-1.12.0.tar.xz
> +sha256  4f76d2bdd0ed6780837cdde886eaf535f9770f9daa1ff92e63658d06aa5d25ea  ModemManager-1.12.2.tar.xz
>  sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
>  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
> diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> index b5aa7914f6..8aa9f36766 100644
> --- a/package/modem-manager/modem-manager.mk
> +++ b/package/modem-manager/modem-manager.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>
> -MODEM_MANAGER_VERSION = 1.12.0
> +MODEM_MANAGER_VERSION = 1.12.2
>  MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
>  MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
>  MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
> @@ -13,6 +13,9 @@ MODEM_MANAGER_DEPENDENCIES = host-pkgconf libglib2 $(TARGET_NLS_DEPENDENCIES)
>  MODEM_MANAGER_INSTALL_STAGING = YES
>  MODEM_MANAGER_CONF_OPTS = --disable-more-warnings
>
> +# 0001-build-fix-order-of-linked-libs-in-test-apps.patch
> +MODEM_MANAGER_AUTORECONF = YES
> +
>  ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
>  MODEM_MANAGER_DEPENDENCIES += libqmi
>  MODEM_MANAGER_CONF_OPTS += --with-qmi
> --
> 2.24.0

I still see an error similar to the one in
http://autobuild.buildroot.net/results/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/
in a clean build after applying the patch to bump libqmi o 1.24.2 and
this one:

$ make clean; make modem-manager || make modem-manager BR2_JLEVEL=1
2019-12-12T07:31:36 CCLD     mmsmspdu
2019-12-12T07:31:37
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
../src/.libs/libhelpers.a(mm-modem-helpers.o): in function
`mm_3gpp_cesq_response_to_signal_info':
2019-12-12T07:31:37 mm-modem-helpers.c:(.text+0x3e38): undefined
reference to `mm_signal_new'
2019-12-12T07:31:37
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3e44): undefined reference to
`mm_signal_set_rssi'
2019-12-12T07:31:37
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3e5c): undefined reference to
`mm_signal_new'
2019-12-12T07:31:37
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3e68): undefined reference to
`mm_signal_set_rscp'
2019-12-12T07:31:37
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3e88): undefined reference to
`mm_signal_new'
2019-12-12T07:31:37
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3e98): undefined reference to
`mm_signal_set_ecio'
2019-12-12T07:31:37
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3eb0): undefined reference to
`mm_signal_new'
2019-12-12T07:31:37
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3ebc): undefined reference to
`mm_signal_set_rsrq'
2019-12-12T07:31:37
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3edc): undefined reference to
`mm_signal_new'
2019-12-12T07:31:37
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3eec): undefined reference to
`mm_signal_set_rsrp'
2019-12-12T07:31:37
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
../src/.libs/libhelpers.a(mm-modem-helpers.o): in function
`mm_parse_cclk_response':
2019-12-12T07:31:37 mm-modem-helpers.c:(.text+0x7484): undefined
reference to `mm_network_timezone_new'
2019-12-12T07:31:37
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x7494): undefined reference to
`mm_network_timezone_set_offset'
2019-12-12T07:31:37 collect2: error: ld returned 1 exit status
2019-12-12T07:31:37 make[4]: *** [Makefile:530: mmsmspdu] Error 1
2019-12-12T07:31:37 make[3]: *** [Makefile:502: all-recursive] Error 1
2019-12-12T07:31:37 make[2]: *** [Makefile:434: all] Error 2
2019-12-12T07:31:37 make[1]: *** [package/pkg-generic.mk:260:
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/build/modem-manager-1.12.2/.stamp_built]
Error 2
2019-12-12T07:31:37 make: *** [Makefile:23: _all] Error 2

-- 
Carlos Santos <unixmania@gmail.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] modem-manager: bump to version 1.12.2
  2019-12-12 10:39 ` Carlos Santos
@ 2019-12-12 10:50   ` Aleksander Morgado
  2019-12-12 12:58     ` Carlos Santos
  0 siblings, 1 reply; 7+ messages in thread
From: Aleksander Morgado @ 2019-12-12 10:50 UTC (permalink / raw)
  To: buildroot

Hey!

> >
> > Also include a patch that solves build issues detected in 1.12.0, e.g.:
> > http://lists.busybox.net/pipermail/buildroot/2019-December/268817.html
> > http://autobuild.buildroot.net/results/5ac390b2a813cadb4cb180d61bb05f6fe4407155/build-end.log
> >
> > Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> > ---
> >
> > Hey!
> >
> > This version bump to 1.12.2 also includes a patch required to build correctly when using strict library link ordering. Adding this patch requires triggering autoreconf. The patch is already included in the upstream MM repo, so the next 1.12.4 release will also include it (whenever that is, not scheduled yet).
> >
> > Cheers!
> >
> > ---
> >  ...ix-order-of-linked-libs-in-test-apps.patch | 40 +++++++++++++++++++
> >  package/modem-manager/modem-manager.hash      |  2 +-
> >  package/modem-manager/modem-manager.mk        |  5 ++-
> >  3 files changed, 45 insertions(+), 2 deletions(-)
> >  create mode 100644 package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch
> >
> > diff --git a/package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch b/package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch
> > new file mode 100644
> > index 0000000000..d58960ce57
> > --- /dev/null
> > +++ b/package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch
> > @@ -0,0 +1,40 @@
> > +From 52cfd6788e4d12f3c2ea302e66bcc80c5efd80ee Mon Sep 17 00:00:00 2001
> > +From: Aleksander Morgado <aleksander@aleksander.es>
> > +Date: Wed, 11 Dec 2019 16:09:25 +0100
> > +Subject: [PATCH] build: fix order of linked libs in test apps
> > +
> > +Solving build issues with truly strict linkers, as in:
> > +http://lists.busybox.net/pipermail/buildroot/2019-December/268817.html
> > +
> > +Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> > +---
> > + test/Makefile.am | 4 ++--
> > + 1 file changed, 2 insertions(+), 2 deletions(-)
> > +
> > +diff --git a/test/Makefile.am b/test/Makefile.am
> > +index ba737bc5..20e2a068 100644
> > +--- a/test/Makefile.am
> > ++++ b/test/Makefile.am
> > +@@ -87,8 +87,8 @@ mmsmspdu_CPPFLAGS = \
> > +
> > + mmsmspdu_LDADD = \
> > +       $(MM_LIBS) \
> > +-      $(top_builddir)/src/libhelpers.la \
> > +       $(top_builddir)/libmm-glib/libmm-glib.la \
> > ++      $(top_builddir)/src/libhelpers.la \
> > +       $(NULL)
> > +
> > + ################################################################################
> > +@@ -112,8 +112,8 @@ mmsmsmonitor_CPPFLAGS = \
> > +
> > + mmsmsmonitor_LDADD = \
> > +       $(MM_LIBS) \
> > +-      $(top_builddir)/src/libhelpers.la \
> > +       $(top_builddir)/libmm-glib/libmm-glib.la \
> > ++      $(top_builddir)/src/libhelpers.la \
> > +       $(NULL)
> > +
> > + ################################################################################
> > +--
> > +2.24.0
> > +
> > diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
> > index b1fef98fe2..a3925bb4a2 100644
> > --- a/package/modem-manager/modem-manager.hash
> > +++ b/package/modem-manager/modem-manager.hash
> > @@ -1,4 +1,4 @@
> >  # Locally computed
> > -sha256  3daca86164145fffb589939433f596c13fa077c9a187c0d5820fdd5b4e4a6424  ModemManager-1.12.0.tar.xz
> > +sha256  4f76d2bdd0ed6780837cdde886eaf535f9770f9daa1ff92e63658d06aa5d25ea  ModemManager-1.12.2.tar.xz
> >  sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
> >  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
> > diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> > index b5aa7914f6..8aa9f36766 100644
> > --- a/package/modem-manager/modem-manager.mk
> > +++ b/package/modem-manager/modem-manager.mk
> > @@ -4,7 +4,7 @@
> >  #
> >  ################################################################################
> >
> > -MODEM_MANAGER_VERSION = 1.12.0
> > +MODEM_MANAGER_VERSION = 1.12.2
> >  MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
> >  MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
> >  MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
> > @@ -13,6 +13,9 @@ MODEM_MANAGER_DEPENDENCIES = host-pkgconf libglib2 $(TARGET_NLS_DEPENDENCIES)
> >  MODEM_MANAGER_INSTALL_STAGING = YES
> >  MODEM_MANAGER_CONF_OPTS = --disable-more-warnings
> >
> > +# 0001-build-fix-order-of-linked-libs-in-test-apps.patch
> > +MODEM_MANAGER_AUTORECONF = YES
> > +
> >  ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
> >  MODEM_MANAGER_DEPENDENCIES += libqmi
> >  MODEM_MANAGER_CONF_OPTS += --with-qmi
> > --
> > 2.24.0
>
> I still see an error similar to the one in
> http://autobuild.buildroot.net/results/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/
> in a clean build after applying the patch to bump libqmi o 1.24.2 and
> this one:
>

Did you run autoreconf in srcdir after applying the patch manually?
Not sure how that would be done when rebuilding using the
br-reproduce-build setup.

Can you tell me what's the value of mmsmspdu_DEPENDENCIES in the
"test/Makefile" file you have in your build? It should be something
like this:
mmsmspdu_DEPENDENCIES = $(am__DEPENDENCIES_1) \
        $(top_builddir)/libmm-glib/libmm-glib.la \
        $(top_builddir)/src/libhelpers.la


(i.e. libmm-glib.la listed before libhelpers.la)


--
Aleksander
https://aleksander.es

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] modem-manager: bump to version 1.12.2
  2019-12-12 10:50   ` Aleksander Morgado
@ 2019-12-12 12:58     ` Carlos Santos
  2019-12-12 13:14       ` Aleksander Morgado
  0 siblings, 1 reply; 7+ messages in thread
From: Carlos Santos @ 2019-12-12 12:58 UTC (permalink / raw)
  To: buildroot

On Thu, Dec 12, 2019 at 7:50 AM Aleksander Morgado
<aleksander@aleksander.es> wrote:
>
> Hey!
>
> > >
> > > Also include a patch that solves build issues detected in 1.12.0, e.g.:
> > > http://lists.busybox.net/pipermail/buildroot/2019-December/268817.html
> > > http://autobuild.buildroot.net/results/5ac390b2a813cadb4cb180d61bb05f6fe4407155/build-end.log
> > >
> > > Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> > > ---
> > >
> > > Hey!
> > >
> > > This version bump to 1.12.2 also includes a patch required to build correctly when using strict library link ordering. Adding this patch requires triggering autoreconf. The patch is already included in the upstream MM repo, so the next 1.12.4 release will also include it (whenever that is, not scheduled yet).
> > >
> > > Cheers!
> > >
> > > ---
> > >  ...ix-order-of-linked-libs-in-test-apps.patch | 40 +++++++++++++++++++
> > >  package/modem-manager/modem-manager.hash      |  2 +-
> > >  package/modem-manager/modem-manager.mk        |  5 ++-
> > >  3 files changed, 45 insertions(+), 2 deletions(-)
> > >  create mode 100644 package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch
> > >
> > > diff --git a/package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch b/package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch
> > > new file mode 100644
> > > index 0000000000..d58960ce57
> > > --- /dev/null
> > > +++ b/package/modem-manager/0001-build-fix-order-of-linked-libs-in-test-apps.patch
> > > @@ -0,0 +1,40 @@
> > > +From 52cfd6788e4d12f3c2ea302e66bcc80c5efd80ee Mon Sep 17 00:00:00 2001
> > > +From: Aleksander Morgado <aleksander@aleksander.es>
> > > +Date: Wed, 11 Dec 2019 16:09:25 +0100
> > > +Subject: [PATCH] build: fix order of linked libs in test apps
> > > +
> > > +Solving build issues with truly strict linkers, as in:
> > > +http://lists.busybox.net/pipermail/buildroot/2019-December/268817.html
> > > +
> > > +Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> > > +---
> > > + test/Makefile.am | 4 ++--
> > > + 1 file changed, 2 insertions(+), 2 deletions(-)
> > > +
> > > +diff --git a/test/Makefile.am b/test/Makefile.am
> > > +index ba737bc5..20e2a068 100644
> > > +--- a/test/Makefile.am
> > > ++++ b/test/Makefile.am
> > > +@@ -87,8 +87,8 @@ mmsmspdu_CPPFLAGS = \
> > > +
> > > + mmsmspdu_LDADD = \
> > > +       $(MM_LIBS) \
> > > +-      $(top_builddir)/src/libhelpers.la \
> > > +       $(top_builddir)/libmm-glib/libmm-glib.la \
> > > ++      $(top_builddir)/src/libhelpers.la \
> > > +       $(NULL)
> > > +
> > > + ################################################################################
> > > +@@ -112,8 +112,8 @@ mmsmsmonitor_CPPFLAGS = \
> > > +
> > > + mmsmsmonitor_LDADD = \
> > > +       $(MM_LIBS) \
> > > +-      $(top_builddir)/src/libhelpers.la \
> > > +       $(top_builddir)/libmm-glib/libmm-glib.la \
> > > ++      $(top_builddir)/src/libhelpers.la \
> > > +       $(NULL)
> > > +
> > > + ################################################################################
> > > +--
> > > +2.24.0
> > > +
> > > diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
> > > index b1fef98fe2..a3925bb4a2 100644
> > > --- a/package/modem-manager/modem-manager.hash
> > > +++ b/package/modem-manager/modem-manager.hash
> > > @@ -1,4 +1,4 @@
> > >  # Locally computed
> > > -sha256  3daca86164145fffb589939433f596c13fa077c9a187c0d5820fdd5b4e4a6424  ModemManager-1.12.0.tar.xz
> > > +sha256  4f76d2bdd0ed6780837cdde886eaf535f9770f9daa1ff92e63658d06aa5d25ea  ModemManager-1.12.2.tar.xz
> > >  sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
> > >  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
> > > diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> > > index b5aa7914f6..8aa9f36766 100644
> > > --- a/package/modem-manager/modem-manager.mk
> > > +++ b/package/modem-manager/modem-manager.mk
> > > @@ -4,7 +4,7 @@
> > >  #
> > >  ################################################################################
> > >
> > > -MODEM_MANAGER_VERSION = 1.12.0
> > > +MODEM_MANAGER_VERSION = 1.12.2
> > >  MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
> > >  MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
> > >  MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
> > > @@ -13,6 +13,9 @@ MODEM_MANAGER_DEPENDENCIES = host-pkgconf libglib2 $(TARGET_NLS_DEPENDENCIES)
> > >  MODEM_MANAGER_INSTALL_STAGING = YES
> > >  MODEM_MANAGER_CONF_OPTS = --disable-more-warnings
> > >
> > > +# 0001-build-fix-order-of-linked-libs-in-test-apps.patch
> > > +MODEM_MANAGER_AUTORECONF = YES
> > > +
> > >  ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
> > >  MODEM_MANAGER_DEPENDENCIES += libqmi
> > >  MODEM_MANAGER_CONF_OPTS += --with-qmi
> > > --
> > > 2.24.0
> >
> > I still see an error similar to the one in
> > http://autobuild.buildroot.net/results/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/
> > in a clean build after applying the patch to bump libqmi o 1.24.2 and
> > this one:
> >
>
> Did you run autoreconf in srcdir after applying the patch manually?

2019-12-12T07:30:18 Applying
0001-build-fix-order-of-linked-libs-in-test-apps.patch using patch:
2019-12-12T07:30:18 patching file test/Makefile.am
2019-12-12T07:30:18 >>> modem-manager 1.12.2 Updating config.sub and
config.guess
2019-12-12T07:30:18 for file in config.guess config.sub; do for i in
$(find /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/build/modem-manager-1.12.2
-name $file); do cp support/gnuconfig/$file $i; done; done
2019-12-12T07:30:18 >>> modem-manager 1.12.2 Configuring
2019-12-12T07:30:18 >>> modem-manager 1.12.2 Autoreconfiguring

> Not sure how that would be done when rebuilding using the
> br-reproduce-build setup.

I don't use br-reproduce-build setup. I just applied the patches on
buildroot using git am ran a build using the same defconfig of build
0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a.

> Can you tell me what's the value of mmsmspdu_DEPENDENCIES in the
> "test/Makefile" file you have in your build? It should be something
> like this:
> mmsmspdu_DEPENDENCIES = $(am__DEPENDENCIES_1) \
>         $(top_builddir)/libmm-glib/libmm-glib.la \
>         $(top_builddir)/src/libhelpers.la
>
>
> (i.e. libmm-glib.la listed before libhelpers.la)

mmsmspdu_DEPENDENCIES = $(am__DEPENDENCIES_1) \
        $(top_builddir)/libmm-glib/libmm-glib.la \
        $(top_builddir)/src/libhelpers.la

-- 
Carlos Santos <unixmania@gmail.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] modem-manager: bump to version 1.12.2
  2019-12-12 12:58     ` Carlos Santos
@ 2019-12-12 13:14       ` Aleksander Morgado
  2019-12-12 13:25         ` Carlos Santos
  0 siblings, 1 reply; 7+ messages in thread
From: Aleksander Morgado @ 2019-12-12 13:14 UTC (permalink / raw)
  To: buildroot

> > >
> > > I still see an error similar to the one in
> > > http://autobuild.buildroot.net/results/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/
> > > in a clean build after applying the patch to bump libqmi o 1.24.2 and
> > > this one:
> > >
> >
> > Did you run autoreconf in srcdir after applying the patch manually?
>
> 2019-12-12T07:30:18 Applying
> 0001-build-fix-order-of-linked-libs-in-test-apps.patch using patch:
> 2019-12-12T07:30:18 patching file test/Makefile.am
> 2019-12-12T07:30:18 >>> modem-manager 1.12.2 Updating config.sub and
> config.guess
> 2019-12-12T07:30:18 for file in config.guess config.sub; do for i in
> $(find /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/build/modem-manager-1.12.2
> -name $file); do cp support/gnuconfig/$file $i; done; done
> 2019-12-12T07:30:18 >>> modem-manager 1.12.2 Configuring
> 2019-12-12T07:30:18 >>> modem-manager 1.12.2 Autoreconfiguring
>
> > Not sure how that would be done when rebuilding using the
> > br-reproduce-build setup.
>
> I don't use br-reproduce-build setup. I just applied the patches on
> buildroot using git am ran a build using the same defconfig of build
> 0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a.
>
> > Can you tell me what's the value of mmsmspdu_DEPENDENCIES in the
> > "test/Makefile" file you have in your build? It should be something
> > like this:
> > mmsmspdu_DEPENDENCIES = $(am__DEPENDENCIES_1) \
> >         $(top_builddir)/libmm-glib/libmm-glib.la \
> >         $(top_builddir)/src/libhelpers.la
> >
> >
> > (i.e. libmm-glib.la listed before libhelpers.la)
>
> mmsmspdu_DEPENDENCIES = $(am__DEPENDENCIES_1) \
>         $(top_builddir)/libmm-glib/libmm-glib.la \
>         $(top_builddir)/src/libhelpers.la
>

Oh, this is very strange then. Could you run the build with V=s to see
the full compilation commands?

-- 
Aleksander
https://aleksander.es

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] modem-manager: bump to version 1.12.2
  2019-12-12 13:14       ` Aleksander Morgado
@ 2019-12-12 13:25         ` Carlos Santos
  2019-12-12 13:52           ` Aleksander Morgado
  0 siblings, 1 reply; 7+ messages in thread
From: Carlos Santos @ 2019-12-12 13:25 UTC (permalink / raw)
  To: buildroot

On Thu, Dec 12, 2019 at 10:14 AM Aleksander Morgado
<aleksander@aleksander.es> wrote:
>
> > > >
> > > > I still see an error similar to the one in
> > > > http://autobuild.buildroot.net/results/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/
> > > > in a clean build after applying the patch to bump libqmi o 1.24.2 and
> > > > this one:
> > > >
> > >
> > > Did you run autoreconf in srcdir after applying the patch manually?
> >
> > 2019-12-12T07:30:18 Applying
> > 0001-build-fix-order-of-linked-libs-in-test-apps.patch using patch:
> > 2019-12-12T07:30:18 patching file test/Makefile.am
> > 2019-12-12T07:30:18 >>> modem-manager 1.12.2 Updating config.sub and
> > config.guess
> > 2019-12-12T07:30:18 for file in config.guess config.sub; do for i in
> > $(find /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/build/modem-manager-1.12.2
> > -name $file); do cp support/gnuconfig/$file $i; done; done
> > 2019-12-12T07:30:18 >>> modem-manager 1.12.2 Configuring
> > 2019-12-12T07:30:18 >>> modem-manager 1.12.2 Autoreconfiguring
> >
> > > Not sure how that would be done when rebuilding using the
> > > br-reproduce-build setup.
> >
> > I don't use br-reproduce-build setup. I just applied the patches on
> > buildroot using git am ran a build using the same defconfig of build
> > 0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a.
> >
> > > Can you tell me what's the value of mmsmspdu_DEPENDENCIES in the
> > > "test/Makefile" file you have in your build? It should be something
> > > like this:
> > > mmsmspdu_DEPENDENCIES = $(am__DEPENDENCIES_1) \
> > >         $(top_builddir)/libmm-glib/libmm-glib.la \
> > >         $(top_builddir)/src/libhelpers.la
> > >
> > >
> > > (i.e. libmm-glib.la listed before libhelpers.la)
> >
> > mmsmspdu_DEPENDENCIES = $(am__DEPENDENCIES_1) \
> >         $(top_builddir)/libmm-glib/libmm-glib.la \
> >         $(top_builddir)/src/libhelpers.la
> >
>
> Oh, this is very strange then. Could you run the build with V=s to see
> the full compilation commands?
>
> --
> Aleksander
> https://aleksander.es

2019-12-12T10:25:19 Making all in test
2019-12-12T10:25:19 /bin/sh ../libtool  --tag=CC   --mode=link
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/bin/arm-linux-gcc
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os
 -static  -static -o mmsmspdu mmsmspdu-mmsmspdu.o -Wl,--export-dynamic
-lgmodule-2.0 -lblkid -lgio-2.0 -lgobject-2.0 -lffi -lgmodule-2.0
-lglib-2.0 -pthread -lm -lpcre -lz -lmount -lblkid
../libmm-glib/libmm-glib.la ../src/libhelpers.la
2019-12-12T10:25:19 libtool: link:
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/bin/arm-linux-gcc
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os
-static -static -o mmsmspdu mmsmspdu-mmsmspdu.o -Wl,--export-dynamic
-pthread  ../libmm-glib/.libs/libmm-glib.a ../src/.libs/libhelpers.a
-lqmi-glib -lmbim-glib -lgio-2.0 -lgobject-2.0 -lffi -lgmodule-2.0
-lglib-2.0 -lm -lpcre -lz -lmount -lblkid -pthread
2019-12-12T10:25:20
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
../src/.libs/libhelpers.a(mm-modem-helpers.o): in function
`mm_3gpp_cesq_response_to_signal_info':
2019-12-12T10:25:20 mm-modem-helpers.c:(.text+0x3e38): undefined
reference to `mm_signal_new'
2019-12-12T10:25:20
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3e44): undefined reference to
`mm_signal_set_rssi'
2019-12-12T10:25:20
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3e5c): undefined reference to
`mm_signal_new'
2019-12-12T10:25:20
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3e68): undefined reference to
`mm_signal_set_rscp'
2019-12-12T10:25:20
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3e88): undefined reference to
`mm_signal_new'
2019-12-12T10:25:20
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3e98): undefined reference to
`mm_signal_set_ecio'
2019-12-12T10:25:20
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3eb0): undefined reference to
`mm_signal_new'
2019-12-12T10:25:20
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3ebc): undefined reference to
`mm_signal_set_rsrq'
2019-12-12T10:25:20
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3edc): undefined reference to
`mm_signal_new'
2019-12-12T10:25:20
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x3eec): undefined reference to
`mm_signal_set_rsrp'
2019-12-12T10:25:20
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
../src/.libs/libhelpers.a(mm-modem-helpers.o): in function
`mm_parse_cclk_response':
2019-12-12T10:25:20 mm-modem-helpers.c:(.text+0x7484): undefined
reference to `mm_network_timezone_new'
2019-12-12T10:25:20
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
mm-modem-helpers.c:(.text+0x7494): undefined reference to
`mm_network_timezone_set_offset'
2019-12-12T10:25:20 collect2: error: ld returned 1 exit status
2019-12-12T10:25:20 make[4]: *** [Makefile:530: mmsmspdu] Error 1
2019-12-12T10:25:20 make[3]: *** [Makefile:502: all-recursive] Error 1
2019-12-12T10:25:20 make[2]: *** [Makefile:434: all] Error 2
2019-12-12T10:25:20 make[1]: *** [package/pkg-generic.mk:260:
/work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/build/modem-manager-1.12.2/.stamp_built]
Error 2
2019-12-12T10:25:20 make: *** [Makefile:23: _all] Error 2


-- 
Carlos Santos <unixmania@gmail.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] modem-manager: bump to version 1.12.2
  2019-12-12 13:25         ` Carlos Santos
@ 2019-12-12 13:52           ` Aleksander Morgado
  0 siblings, 0 replies; 7+ messages in thread
From: Aleksander Morgado @ 2019-12-12 13:52 UTC (permalink / raw)
  To: buildroot

Hey!

On Thu, Dec 12, 2019 at 2:26 PM Carlos Santos <unixmania@gmail.com> wrote:
>
> On Thu, Dec 12, 2019 at 10:14 AM Aleksander Morgado
> <aleksander@aleksander.es> wrote:
> >
> > > > >
> > > > > I still see an error similar to the one in
> > > > > http://autobuild.buildroot.net/results/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/
> > > > > in a clean build after applying the patch to bump libqmi o 1.24.2 and
> > > > > this one:
> > > > >
> > > >
> > > > Did you run autoreconf in srcdir after applying the patch manually?
> > >
> > > 2019-12-12T07:30:18 Applying
> > > 0001-build-fix-order-of-linked-libs-in-test-apps.patch using patch:
> > > 2019-12-12T07:30:18 patching file test/Makefile.am
> > > 2019-12-12T07:30:18 >>> modem-manager 1.12.2 Updating config.sub and
> > > config.guess
> > > 2019-12-12T07:30:18 for file in config.guess config.sub; do for i in
> > > $(find /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/build/modem-manager-1.12.2
> > > -name $file); do cp support/gnuconfig/$file $i; done; done
> > > 2019-12-12T07:30:18 >>> modem-manager 1.12.2 Configuring
> > > 2019-12-12T07:30:18 >>> modem-manager 1.12.2 Autoreconfiguring
> > >
> > > > Not sure how that would be done when rebuilding using the
> > > > br-reproduce-build setup.
> > >
> > > I don't use br-reproduce-build setup. I just applied the patches on
> > > buildroot using git am ran a build using the same defconfig of build
> > > 0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a.
> > >
> > > > Can you tell me what's the value of mmsmspdu_DEPENDENCIES in the
> > > > "test/Makefile" file you have in your build? It should be something
> > > > like this:
> > > > mmsmspdu_DEPENDENCIES = $(am__DEPENDENCIES_1) \
> > > >         $(top_builddir)/libmm-glib/libmm-glib.la \
> > > >         $(top_builddir)/src/libhelpers.la
> > > >
> > > >
> > > > (i.e. libmm-glib.la listed before libhelpers.la)
> > >
> > > mmsmspdu_DEPENDENCIES = $(am__DEPENDENCIES_1) \
> > >         $(top_builddir)/libmm-glib/libmm-glib.la \
> > >         $(top_builddir)/src/libhelpers.la
> > >
> >
> > Oh, this is very strange then. Could you run the build with V=s to see
> > the full compilation commands?
> >
> > --
> > Aleksander
> > https://aleksander.es
>
> 2019-12-12T10:25:19 Making all in test
> 2019-12-12T10:25:19 /bin/sh ../libtool  --tag=CC   --mode=link
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/bin/arm-linux-gcc
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os
>  -static  -static -o mmsmspdu mmsmspdu-mmsmspdu.o -Wl,--export-dynamic
> -lgmodule-2.0 -lblkid -lgio-2.0 -lgobject-2.0 -lffi -lgmodule-2.0
> -lglib-2.0 -pthread -lm -lpcre -lz -lmount -lblkid
> ../libmm-glib/libmm-glib.la ../src/libhelpers.la
> 2019-12-12T10:25:19 libtool: link:
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/bin/arm-linux-gcc
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os
> -static -static -o mmsmspdu mmsmspdu-mmsmspdu.o -Wl,--export-dynamic
> -pthread  ../libmm-glib/.libs/libmm-glib.a ../src/.libs/libhelpers.a
> -lqmi-glib -lmbim-glib -lgio-2.0 -lgobject-2.0 -lffi -lgmodule-2.0
> -lglib-2.0 -lm -lpcre -lz -lmount -lblkid -pthread
> 2019-12-12T10:25:20
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
> ../src/.libs/libhelpers.a(mm-modem-helpers.o): in function
> `mm_3gpp_cesq_response_to_signal_info':
> 2019-12-12T10:25:20 mm-modem-helpers.c:(.text+0x3e38): undefined
> reference to `mm_signal_new'
> 2019-12-12T10:25:20
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
> mm-modem-helpers.c:(.text+0x3e44): undefined reference to
> `mm_signal_set_rssi'
> 2019-12-12T10:25:20
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
> mm-modem-helpers.c:(.text+0x3e5c): undefined reference to
> `mm_signal_new'
> 2019-12-12T10:25:20
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
> mm-modem-helpers.c:(.text+0x3e68): undefined reference to
> `mm_signal_set_rscp'
> 2019-12-12T10:25:20
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
> mm-modem-helpers.c:(.text+0x3e88): undefined reference to
> `mm_signal_new'
> 2019-12-12T10:25:20
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
> mm-modem-helpers.c:(.text+0x3e98): undefined reference to
> `mm_signal_set_ecio'
> 2019-12-12T10:25:20
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
> mm-modem-helpers.c:(.text+0x3eb0): undefined reference to
> `mm_signal_new'
> 2019-12-12T10:25:20
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
> mm-modem-helpers.c:(.text+0x3ebc): undefined reference to
> `mm_signal_set_rsrq'
> 2019-12-12T10:25:20
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
> mm-modem-helpers.c:(.text+0x3edc): undefined reference to
> `mm_signal_new'
> 2019-12-12T10:25:20
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
> mm-modem-helpers.c:(.text+0x3eec): undefined reference to
> `mm_signal_set_rsrp'
> 2019-12-12T10:25:20
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
> ../src/.libs/libhelpers.a(mm-modem-helpers.o): in function
> `mm_parse_cclk_response':
> 2019-12-12T10:25:20 mm-modem-helpers.c:(.text+0x7484): undefined
> reference to `mm_network_timezone_new'
> 2019-12-12T10:25:20
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/7.4.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
> mm-modem-helpers.c:(.text+0x7494): undefined reference to
> `mm_network_timezone_set_offset'
> 2019-12-12T10:25:20 collect2: error: ld returned 1 exit status
> 2019-12-12T10:25:20 make[4]: *** [Makefile:530: mmsmspdu] Error 1
> 2019-12-12T10:25:20 make[3]: *** [Makefile:502: all-recursive] Error 1
> 2019-12-12T10:25:20 make[2]: *** [Makefile:434: all] Error 2
> 2019-12-12T10:25:20 make[1]: *** [package/pkg-generic.mk:260:
> /work/0ae6ca0b278ca1903057ff6ac31b1b70e8638b9a/build/modem-manager-1.12.2/.stamp_built]
> Error 2
> 2019-12-12T10:25:20 make: *** [Makefile:23: _all] Error 2
>

What a mess.

So, I already fixed the build order in 1.12.x a while ago, and that
was already included in 1.12.2. If you build 1.12.2 without any
additional patch, the build will work.

The patch I wrote on top of 1.12.2 actually *makes the build break
again*, as it reverts what was already fixed in 1.12.2... I have to
fix that in upstream, and I will repush a v2 patch updating to 1.12.2
without any additional patch.

Thanks for looking at this Carlos, hopefully I won't break it more...

-- 
Aleksander
https://aleksander.es

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-12 13:52 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12  9:33 [Buildroot] [PATCH] modem-manager: bump to version 1.12.2 Aleksander Morgado
2019-12-12 10:39 ` Carlos Santos
2019-12-12 10:50   ` Aleksander Morgado
2019-12-12 12:58     ` Carlos Santos
2019-12-12 13:14       ` Aleksander Morgado
2019-12-12 13:25         ` Carlos Santos
2019-12-12 13:52           ` Aleksander Morgado

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.