All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/modem-manager: bump to version 1.18.2
@ 2021-09-18 20:30 yegorslists--- via buildroot
  2021-09-19  7:33 ` Yann E. MORIN
  0 siblings, 1 reply; 4+ messages in thread
From: yegorslists--- via buildroot @ 2021-09-18 20:30 UTC (permalink / raw)
  To: buildroot; +Cc: Eric Le Bihan, Aleksander Morgado

From: Yegor Yefremov <yegorslists@googlemail.com>

This release introduces meson build system support.

As meson files are only available in git, switch the location to
https://gitlab.freedesktop.org.

Add support for bash-completion.

dbus is now a build-time dependency.

Also add support for systemd and polkit and disable the manpage
generation.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/modem-manager/Config.in          |  2 +-
 package/modem-manager/modem-manager.hash |  2 +-
 package/modem-manager/modem-manager.mk   | 50 +++++++++++++++++-------
 3 files changed, 38 insertions(+), 16 deletions(-)

diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
index c4c723776d..d211d68ee1 100644
--- a/package/modem-manager/Config.in
+++ b/package/modem-manager/Config.in
@@ -3,7 +3,7 @@ config BR2_PACKAGE_MODEM_MANAGER
 	depends on BR2_USE_WCHAR # libglib2 and gnutls
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
 	depends on BR2_USE_MMU # dbus
-	select BR2_PACKAGE_DBUS # runtime dependency
+	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_LIBGUDEV if BR2_PACKAGE_HAS_UDEV
 	help
diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
index 14597215df..fb0ddec4a5 100644
--- a/package/modem-manager/modem-manager.hash
+++ b/package/modem-manager/modem-manager.hash
@@ -1,4 +1,4 @@
 # Locally computed
-sha256  2ccf1f716c2d121e8e6709bcf8af29ee86971a90adacca2e8d6288b30278862e  ModemManager-1.16.10.tar.xz
+sha256  79e83f7082d02e72a5c5e7fdf9b67bd3dd71da0da3d02607dee76ae06b9d4aa9  ModemManager-1.18.2.tar.bz2
 sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
 sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
index a881edc272..7a7bd3bb4c 100644
--- a/package/modem-manager/modem-manager.mk
+++ b/package/modem-manager/modem-manager.mk
@@ -4,42 +4,64 @@
 #
 ################################################################################
 
-MODEM_MANAGER_VERSION = 1.16.10
-MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
-MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
+MODEM_MANAGER_VERSION = 1.18.2
+MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.bz2
+MODEM_MANAGER_SITE = https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/archive/$(MODEM_MANAGER_VERSION)
 MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
 MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
 MODEM_MANAGER_SELINUX_MODULES = modemmanager
-MODEM_MANAGER_DEPENDENCIES = host-pkgconf libglib2 $(TARGET_NLS_DEPENDENCIES)
+MODEM_MANAGER_DEPENDENCIES = host-pkgconf libglib2 dbus $(TARGET_NLS_DEPENDENCIES)
 MODEM_MANAGER_INSTALL_STAGING = YES
-MODEM_MANAGER_CONF_OPTS = --disable-more-warnings
+
+MODEM_MANAGER_CONF_OPTS = -Dman=false
 
 ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
 MODEM_MANAGER_DEPENDENCIES += libqmi
-MODEM_MANAGER_CONF_OPTS += --with-qmi
+MODEM_MANAGER_CONF_OPTS += -Dqmi=enabled
+else
+MODEM_MANAGER_CONF_OPTS += -Dqmi=disabled
+endif
+
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+MODEM_MANAGER_DEPENDENCIES += systemd
+MODEM_MANAGER_CONF_OPTS += -Dsystemd_suspend_resume=true -Dsystemd_journal=true
+else
+MODEM_MANAGER_CONF_OPTS += -Dsystemdsystemunitdir=no -Dsystemd_suspend_resume=false -Dsystemd_journal=false
+endif
+
+ifeq ($(BR2_PACKAGE_POLKIT),y)
+MODEM_MANAGER_DEPENDENCIES += polkit
+MODEM_MANAGER_CONF_OPTS += -Dpolkit=strict
 else
-MODEM_MANAGER_CONF_OPTS += --without-qmi
+MODEM_MANAGER_CONF_OPTS += -Dpolkit=no
 endif
 
 ifeq ($(BR2_PACKAGE_LIBGUDEV),y)
 MODEM_MANAGER_DEPENDENCIES += libgudev
-MODEM_MANAGER_CONF_OPTS += --with-udev
+MODEM_MANAGER_CONF_OPTS += -Dudev=enabled
 else
-MODEM_MANAGER_CONF_OPTS += --without-udev
+MODEM_MANAGER_CONF_OPTS += -Dudev=disabled
 endif
 
 ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBMBIM),y)
 MODEM_MANAGER_DEPENDENCIES += libmbim
-MODEM_MANAGER_CONF_OPTS += --with-mbim
+MODEM_MANAGER_CONF_OPTS += -Dmbim=enabled
 else
-MODEM_MANAGER_CONF_OPTS += --without-mbim
+MODEM_MANAGER_CONF_OPTS += -Dmbim=disabled
 endif
 
 ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
 MODEM_MANAGER_DEPENDENCIES += gobject-introspection
-MODEM_MANAGER_CONF_OPTS += --enable-introspection
+MODEM_MANAGER_CONF_OPTS += -Dintrospection=enabled
+else
+MODEM_MANAGER_CONF_OPTS += -Dintrospection=disabled
+endif
+
+ifeq ($(BR2_PACKAGE_BASH_COMPLETION),y)
+MODEM_MANAGER_DEPENDENCIES += bash-completion
+MODEM_MANAGER_CONF_OPTS += -Dbash_completion=true
 else
-MODEM_MANAGER_CONF_OPTS += --disable-introspection
+MODEM_MANAGER_CONF_OPTS += -Dbash_completion=false
 endif
 
 define MODEM_MANAGER_INSTALL_INIT_SYSV
@@ -47,4 +69,4 @@ define MODEM_MANAGER_INSTALL_INIT_SYSV
 		$(TARGET_DIR)/etc/init.d/S44modem-manager
 endef
 
-$(eval $(autotools-package))
+$(eval $(meson-package))
-- 
2.17.0

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/modem-manager: bump to version 1.18.2
  2021-09-18 20:30 [Buildroot] [PATCH] package/modem-manager: bump to version 1.18.2 yegorslists--- via buildroot
@ 2021-09-19  7:33 ` Yann E. MORIN
  2021-09-19  8:22   ` Alexander Dahl
  0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2021-09-19  7:33 UTC (permalink / raw)
  To: yegorslists; +Cc: Eric Le Bihan, Aleksander Morgado, buildroot

Yegor, All,

On 2021-09-18 22:30 +0200, yegorslists--- via buildroot spake thusly:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> This release introduces meson build system support.

No, the release itself does not introduce meson buildsystem support:

> As meson files are only available in git, switch the location to
> https://gitlab.freedesktop.org.

as you say, the support for meson is only in git, and not part of the
released tarball. As such, I don't think it should be considered usable,
so we should not use ir.

When upstream does an actual release that contains the meson stuff, then
we can consider switching over. Until then, I think we should stick to
using the buildsystem in the released tarball, autotools.

Regards,
Yann E. MORIN.

> Add support for bash-completion.
> 
> dbus is now a build-time dependency.
> 
> Also add support for systemd and polkit and disable the manpage
> generation.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  package/modem-manager/Config.in          |  2 +-
>  package/modem-manager/modem-manager.hash |  2 +-
>  package/modem-manager/modem-manager.mk   | 50 +++++++++++++++++-------
>  3 files changed, 38 insertions(+), 16 deletions(-)
> 
> diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> index c4c723776d..d211d68ee1 100644
> --- a/package/modem-manager/Config.in
> +++ b/package/modem-manager/Config.in
> @@ -3,7 +3,7 @@ config BR2_PACKAGE_MODEM_MANAGER
>  	depends on BR2_USE_WCHAR # libglib2 and gnutls
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
>  	depends on BR2_USE_MMU # dbus
> -	select BR2_PACKAGE_DBUS # runtime dependency
> +	select BR2_PACKAGE_DBUS
>  	select BR2_PACKAGE_LIBGLIB2
>  	select BR2_PACKAGE_LIBGUDEV if BR2_PACKAGE_HAS_UDEV
>  	help
> diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
> index 14597215df..fb0ddec4a5 100644
> --- a/package/modem-manager/modem-manager.hash
> +++ b/package/modem-manager/modem-manager.hash
> @@ -1,4 +1,4 @@
>  # Locally computed
> -sha256  2ccf1f716c2d121e8e6709bcf8af29ee86971a90adacca2e8d6288b30278862e  ModemManager-1.16.10.tar.xz
> +sha256  79e83f7082d02e72a5c5e7fdf9b67bd3dd71da0da3d02607dee76ae06b9d4aa9  ModemManager-1.18.2.tar.bz2
>  sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
>  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
> diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> index a881edc272..7a7bd3bb4c 100644
> --- a/package/modem-manager/modem-manager.mk
> +++ b/package/modem-manager/modem-manager.mk
> @@ -4,42 +4,64 @@
>  #
>  ################################################################################
>  
> -MODEM_MANAGER_VERSION = 1.16.10
> -MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
> -MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
> +MODEM_MANAGER_VERSION = 1.18.2
> +MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.bz2
> +MODEM_MANAGER_SITE = https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/archive/$(MODEM_MANAGER_VERSION)
>  MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
>  MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
>  MODEM_MANAGER_SELINUX_MODULES = modemmanager
> -MODEM_MANAGER_DEPENDENCIES = host-pkgconf libglib2 $(TARGET_NLS_DEPENDENCIES)
> +MODEM_MANAGER_DEPENDENCIES = host-pkgconf libglib2 dbus $(TARGET_NLS_DEPENDENCIES)
>  MODEM_MANAGER_INSTALL_STAGING = YES
> -MODEM_MANAGER_CONF_OPTS = --disable-more-warnings
> +
> +MODEM_MANAGER_CONF_OPTS = -Dman=false
>  
>  ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
>  MODEM_MANAGER_DEPENDENCIES += libqmi
> -MODEM_MANAGER_CONF_OPTS += --with-qmi
> +MODEM_MANAGER_CONF_OPTS += -Dqmi=enabled
> +else
> +MODEM_MANAGER_CONF_OPTS += -Dqmi=disabled
> +endif
> +
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +MODEM_MANAGER_DEPENDENCIES += systemd
> +MODEM_MANAGER_CONF_OPTS += -Dsystemd_suspend_resume=true -Dsystemd_journal=true
> +else
> +MODEM_MANAGER_CONF_OPTS += -Dsystemdsystemunitdir=no -Dsystemd_suspend_resume=false -Dsystemd_journal=false
> +endif
> +
> +ifeq ($(BR2_PACKAGE_POLKIT),y)
> +MODEM_MANAGER_DEPENDENCIES += polkit
> +MODEM_MANAGER_CONF_OPTS += -Dpolkit=strict
>  else
> -MODEM_MANAGER_CONF_OPTS += --without-qmi
> +MODEM_MANAGER_CONF_OPTS += -Dpolkit=no
>  endif
>  
>  ifeq ($(BR2_PACKAGE_LIBGUDEV),y)
>  MODEM_MANAGER_DEPENDENCIES += libgudev
> -MODEM_MANAGER_CONF_OPTS += --with-udev
> +MODEM_MANAGER_CONF_OPTS += -Dudev=enabled
>  else
> -MODEM_MANAGER_CONF_OPTS += --without-udev
> +MODEM_MANAGER_CONF_OPTS += -Dudev=disabled
>  endif
>  
>  ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBMBIM),y)
>  MODEM_MANAGER_DEPENDENCIES += libmbim
> -MODEM_MANAGER_CONF_OPTS += --with-mbim
> +MODEM_MANAGER_CONF_OPTS += -Dmbim=enabled
>  else
> -MODEM_MANAGER_CONF_OPTS += --without-mbim
> +MODEM_MANAGER_CONF_OPTS += -Dmbim=disabled
>  endif
>  
>  ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
>  MODEM_MANAGER_DEPENDENCIES += gobject-introspection
> -MODEM_MANAGER_CONF_OPTS += --enable-introspection
> +MODEM_MANAGER_CONF_OPTS += -Dintrospection=enabled
> +else
> +MODEM_MANAGER_CONF_OPTS += -Dintrospection=disabled
> +endif
> +
> +ifeq ($(BR2_PACKAGE_BASH_COMPLETION),y)
> +MODEM_MANAGER_DEPENDENCIES += bash-completion
> +MODEM_MANAGER_CONF_OPTS += -Dbash_completion=true
>  else
> -MODEM_MANAGER_CONF_OPTS += --disable-introspection
> +MODEM_MANAGER_CONF_OPTS += -Dbash_completion=false
>  endif
>  
>  define MODEM_MANAGER_INSTALL_INIT_SYSV
> @@ -47,4 +69,4 @@ define MODEM_MANAGER_INSTALL_INIT_SYSV
>  		$(TARGET_DIR)/etc/init.d/S44modem-manager
>  endef
>  
> -$(eval $(autotools-package))
> +$(eval $(meson-package))
> -- 
> 2.17.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/modem-manager: bump to version 1.18.2
  2021-09-19  7:33 ` Yann E. MORIN
@ 2021-09-19  8:22   ` Alexander Dahl
  2021-09-19  8:33     ` Aleksander Morgado
  0 siblings, 1 reply; 4+ messages in thread
From: Alexander Dahl @ 2021-09-19  8:22 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: Eric Le Bihan, buildroot, Aleksander Morgado


[-- Attachment #1.1: Type: text/plain, Size: 7668 bytes --]

Hei hei,

On Sun, Sep 19, 2021 at 09:33:19AM +0200, Yann E. MORIN wrote:
> Yegor, All,
> 
> On 2021-09-18 22:30 +0200, yegorslists--- via buildroot spake thusly:
> > From: Yegor Yefremov <yegorslists@googlemail.com>
> > 
> > This release introduces meson build system support.
> 
> No, the release itself does not introduce meson buildsystem support:
> 
> > As meson files are only available in git, switch the location to
> > https://gitlab.freedesktop.org.
> 
> as you say, the support for meson is only in git, and not part of the
> released tarball. As such, I don't think it should be considered usable,
> so we should not use ir.
> 
> When upstream does an actual release that contains the meson stuff, then
> we can consider switching over. Until then, I think we should stick to
> using the buildsystem in the released tarball, autotools.

Actually upstream wrote in the announcement meson support is not
complete (yet):
https://lists.freedesktop.org/archives/modemmanager-devel/2021-September/008826.html

Greets
Alex

> Regards,
> Yann E. MORIN.
> 
> > Add support for bash-completion.
> > 
> > dbus is now a build-time dependency.
> > 
> > Also add support for systemd and polkit and disable the manpage
> > generation.
> > 
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> > ---
> >  package/modem-manager/Config.in          |  2 +-
> >  package/modem-manager/modem-manager.hash |  2 +-
> >  package/modem-manager/modem-manager.mk   | 50 +++++++++++++++++-------
> >  3 files changed, 38 insertions(+), 16 deletions(-)
> > 
> > diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> > index c4c723776d..d211d68ee1 100644
> > --- a/package/modem-manager/Config.in
> > +++ b/package/modem-manager/Config.in
> > @@ -3,7 +3,7 @@ config BR2_PACKAGE_MODEM_MANAGER
> >  	depends on BR2_USE_WCHAR # libglib2 and gnutls
> >  	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
> >  	depends on BR2_USE_MMU # dbus
> > -	select BR2_PACKAGE_DBUS # runtime dependency
> > +	select BR2_PACKAGE_DBUS
> >  	select BR2_PACKAGE_LIBGLIB2
> >  	select BR2_PACKAGE_LIBGUDEV if BR2_PACKAGE_HAS_UDEV
> >  	help
> > diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
> > index 14597215df..fb0ddec4a5 100644
> > --- a/package/modem-manager/modem-manager.hash
> > +++ b/package/modem-manager/modem-manager.hash
> > @@ -1,4 +1,4 @@
> >  # Locally computed
> > -sha256  2ccf1f716c2d121e8e6709bcf8af29ee86971a90adacca2e8d6288b30278862e  ModemManager-1.16.10.tar.xz
> > +sha256  79e83f7082d02e72a5c5e7fdf9b67bd3dd71da0da3d02607dee76ae06b9d4aa9  ModemManager-1.18.2.tar.bz2
> >  sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
> >  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
> > diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> > index a881edc272..7a7bd3bb4c 100644
> > --- a/package/modem-manager/modem-manager.mk
> > +++ b/package/modem-manager/modem-manager.mk
> > @@ -4,42 +4,64 @@
> >  #
> >  ################################################################################
> >  
> > -MODEM_MANAGER_VERSION = 1.16.10
> > -MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
> > -MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
> > +MODEM_MANAGER_VERSION = 1.18.2
> > +MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.bz2
> > +MODEM_MANAGER_SITE = https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/archive/$(MODEM_MANAGER_VERSION)
> >  MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
> >  MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
> >  MODEM_MANAGER_SELINUX_MODULES = modemmanager
> > -MODEM_MANAGER_DEPENDENCIES = host-pkgconf libglib2 $(TARGET_NLS_DEPENDENCIES)
> > +MODEM_MANAGER_DEPENDENCIES = host-pkgconf libglib2 dbus $(TARGET_NLS_DEPENDENCIES)
> >  MODEM_MANAGER_INSTALL_STAGING = YES
> > -MODEM_MANAGER_CONF_OPTS = --disable-more-warnings
> > +
> > +MODEM_MANAGER_CONF_OPTS = -Dman=false
> >  
> >  ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
> >  MODEM_MANAGER_DEPENDENCIES += libqmi
> > -MODEM_MANAGER_CONF_OPTS += --with-qmi
> > +MODEM_MANAGER_CONF_OPTS += -Dqmi=enabled
> > +else
> > +MODEM_MANAGER_CONF_OPTS += -Dqmi=disabled
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> > +MODEM_MANAGER_DEPENDENCIES += systemd
> > +MODEM_MANAGER_CONF_OPTS += -Dsystemd_suspend_resume=true -Dsystemd_journal=true
> > +else
> > +MODEM_MANAGER_CONF_OPTS += -Dsystemdsystemunitdir=no -Dsystemd_suspend_resume=false -Dsystemd_journal=false
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_POLKIT),y)
> > +MODEM_MANAGER_DEPENDENCIES += polkit
> > +MODEM_MANAGER_CONF_OPTS += -Dpolkit=strict
> >  else
> > -MODEM_MANAGER_CONF_OPTS += --without-qmi
> > +MODEM_MANAGER_CONF_OPTS += -Dpolkit=no
> >  endif
> >  
> >  ifeq ($(BR2_PACKAGE_LIBGUDEV),y)
> >  MODEM_MANAGER_DEPENDENCIES += libgudev
> > -MODEM_MANAGER_CONF_OPTS += --with-udev
> > +MODEM_MANAGER_CONF_OPTS += -Dudev=enabled
> >  else
> > -MODEM_MANAGER_CONF_OPTS += --without-udev
> > +MODEM_MANAGER_CONF_OPTS += -Dudev=disabled
> >  endif
> >  
> >  ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBMBIM),y)
> >  MODEM_MANAGER_DEPENDENCIES += libmbim
> > -MODEM_MANAGER_CONF_OPTS += --with-mbim
> > +MODEM_MANAGER_CONF_OPTS += -Dmbim=enabled
> >  else
> > -MODEM_MANAGER_CONF_OPTS += --without-mbim
> > +MODEM_MANAGER_CONF_OPTS += -Dmbim=disabled
> >  endif
> >  
> >  ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
> >  MODEM_MANAGER_DEPENDENCIES += gobject-introspection
> > -MODEM_MANAGER_CONF_OPTS += --enable-introspection
> > +MODEM_MANAGER_CONF_OPTS += -Dintrospection=enabled
> > +else
> > +MODEM_MANAGER_CONF_OPTS += -Dintrospection=disabled
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_BASH_COMPLETION),y)
> > +MODEM_MANAGER_DEPENDENCIES += bash-completion
> > +MODEM_MANAGER_CONF_OPTS += -Dbash_completion=true
> >  else
> > -MODEM_MANAGER_CONF_OPTS += --disable-introspection
> > +MODEM_MANAGER_CONF_OPTS += -Dbash_completion=false
> >  endif
> >  
> >  define MODEM_MANAGER_INSTALL_INIT_SYSV
> > @@ -47,4 +69,4 @@ define MODEM_MANAGER_INSTALL_INIT_SYSV
> >  		$(TARGET_DIR)/etc/init.d/S44modem-manager
> >  endef
> >  
> > -$(eval $(autotools-package))
> > +$(eval $(meson-package))
> > -- 
> > 2.17.0
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@lists.buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/modem-manager: bump to version 1.18.2
  2021-09-19  8:22   ` Alexander Dahl
@ 2021-09-19  8:33     ` Aleksander Morgado
  0 siblings, 0 replies; 4+ messages in thread
From: Aleksander Morgado @ 2021-09-19  8:33 UTC (permalink / raw)
  To: Yann E. MORIN, Yegor Yefremov, Eric Le Bihan, Aleksander Morgado,
	buildroot

Hey all,

> > On 2021-09-18 22:30 +0200, yegorslists--- via buildroot spake thusly:
> > > From: Yegor Yefremov <yegorslists@googlemail.com>
> > >
> > > This release introduces meson build system support.
> >
> > No, the release itself does not introduce meson buildsystem support:
> >
> > > As meson files are only available in git, switch the location to
> > > https://gitlab.freedesktop.org.
> >
> > as you say, the support for meson is only in git, and not part of the
> > released tarball. As such, I don't think it should be considered usable,
> > so we should not use ir.
> >
> > When upstream does an actual release that contains the meson stuff, then
> > we can consider switching over. Until then, I think we should stick to
> > using the buildsystem in the released tarball, autotools.
>

The plan is, probably, to fully avoid doing release tarballs when
fully switched to meson and autotools removed. So, even if meson-only,
don't assume there will be a tarball.

> Actually upstream wrote in the announcement meson support is not
> complete (yet):
> https://lists.freedesktop.org/archives/modemmanager-devel/2021-September/008826.html
>

There are some missing things, yes. E.g. the ability to build and
select specific plugins instead of all is missing, and some unit tests
are failing; but don't think they apply to the buildroot build. For a
standard system build with just a few options, as in buildroot, 1.18.2
should be perfectly usable. Arch Linux fully switched to the meson
build as well.

So, really, up to you. Switching to meson in buildroot shouldn't be an issue.

-- 
Aleksander
https://aleksander.es
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-19  8:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-18 20:30 [Buildroot] [PATCH] package/modem-manager: bump to version 1.18.2 yegorslists--- via buildroot
2021-09-19  7:33 ` Yann E. MORIN
2021-09-19  8:22   ` Alexander Dahl
2021-09-19  8:33     ` Aleksander Morgado

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.