All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MXSFB: Fix driver registration
@ 2011-12-18  0:58 Marek Vasut
  2011-12-18  1:11 ` Axel Lin
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Marek Vasut @ 2011-12-18  0:58 UTC (permalink / raw)
  To: linux-kernel
  Cc: Marek Vasut, Wolfgang Denk, Stefano Babic, Shawn Guo,
	Huang Shijie, Axel Lin, Sascha Hauer

The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
This caused obvious null pointer dereference and crash.

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Huang Shijie <b32955@freescale.com>
Cc: Axel Lin <axel.lin@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/video/mxsfb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 18742c2..d29c7c0 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
 	},
 };
 
-module_platform_driver(mxsfb_devtype);
+module_platform_driver(mxsfb_driver);
 
 MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
 MODULE_AUTHOR("Sascha Hauer, Pengutronix");
-- 
1.7.6.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] MXSFB: Fix driver registration
  2011-12-18  0:58 [PATCH] MXSFB: Fix driver registration Marek Vasut
@ 2011-12-18  1:11 ` Axel Lin
  2011-12-19  8:00 ` Sascha Hauer
  2011-12-19 13:51   ` Shawn Guo
  2 siblings, 0 replies; 6+ messages in thread
From: Axel Lin @ 2011-12-18  1:11 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-kernel, Wolfgang Denk, Stefano Babic, Shawn Guo,
	Huang Shijie, Sascha Hauer, Florian Tobias Schandinat

2011/12/18 Marek Vasut <marek.vasut@gmail.com>:
> The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
> This caused obvious null pointer dereference and crash.

Acked-by: Axel Lin <axel.lin@gmail.com>

Also Cc: Florian Tobias Schandinat

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] MXSFB: Fix driver registration
  2011-12-18  0:58 [PATCH] MXSFB: Fix driver registration Marek Vasut
  2011-12-18  1:11 ` Axel Lin
@ 2011-12-19  8:00 ` Sascha Hauer
  2011-12-19 13:51   ` Shawn Guo
  2 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2011-12-19  8:00 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-kernel, Wolfgang Denk, Stefano Babic, Shawn Guo,
	Huang Shijie, Axel Lin

On Sun, Dec 18, 2011 at 01:58:07AM +0100, Marek Vasut wrote:
> The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
> This caused obvious null pointer dereference and crash.
> 
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Huang Shijie <b32955@freescale.com>
> Cc: Axel Lin <axel.lin@gmail.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

> ---
>  drivers/video/mxsfb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> index 18742c2..d29c7c0 100644
> --- a/drivers/video/mxsfb.c
> +++ b/drivers/video/mxsfb.c
> @@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
>  	},
>  };
>  
> -module_platform_driver(mxsfb_devtype);
> +module_platform_driver(mxsfb_driver);
>  
>  MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
>  MODULE_AUTHOR("Sascha Hauer, Pengutronix");
> -- 
> 1.7.6.4
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] MXSFB: Fix driver registration
  2011-12-18  0:58 [PATCH] MXSFB: Fix driver registration Marek Vasut
@ 2011-12-19 13:51   ` Shawn Guo
  2011-12-19  8:00 ` Sascha Hauer
  2011-12-19 13:51   ` Shawn Guo
  2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2011-12-19 13:51 UTC (permalink / raw)
  To: Marek Vasut, Florian Tobias Schandinat
  Cc: linux-kernel, Wolfgang Denk, Stefano Babic, Huang Shijie,
	Axel Lin, Sascha Hauer, linux-fbdev

Cc-ed Florian and linux-fbdev@vger.kernel.org, as I guess Florian is
the person who will take this patch.

-- Regards,Shawn
On 18 December 2011 08:58, Marek Vasut <marek.vasut@gmail.com> wrote:
> The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
> This caused obvious null pointer dereference and crash.
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Huang Shijie <b32955@freescale.com>
> Cc: Axel Lin <axel.lin@gmail.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  drivers/video/mxsfb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> index 18742c2..d29c7c0 100644
> --- a/drivers/video/mxsfb.c
> +++ b/drivers/video/mxsfb.c
> @@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
>        },
>  };
>
> -module_platform_driver(mxsfb_devtype);
> +module_platform_driver(mxsfb_driver);
>
>  MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
>  MODULE_AUTHOR("Sascha Hauer, Pengutronix");
> --
> 1.7.6.4
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] MXSFB: Fix driver registration
@ 2011-12-19 13:51   ` Shawn Guo
  0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2011-12-19 13:51 UTC (permalink / raw)
  To: Marek Vasut, Florian Tobias Schandinat
  Cc: linux-kernel, Wolfgang Denk, Stefano Babic, Huang Shijie,
	Axel Lin, Sascha Hauer, linux-fbdev

Cc-ed Florian and linux-fbdev@vger.kernel.org, as I guess Florian is
the person who will take this patch.

-- Regards,Shawn
On 18 December 2011 08:58, Marek Vasut <marek.vasut@gmail.com> wrote:
> The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
> This caused obvious null pointer dereference and crash.
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Huang Shijie <b32955@freescale.com>
> Cc: Axel Lin <axel.lin@gmail.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  drivers/video/mxsfb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> index 18742c2..d29c7c0 100644
> --- a/drivers/video/mxsfb.c
> +++ b/drivers/video/mxsfb.c
> @@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
>        },
>  };
>
> -module_platform_driver(mxsfb_devtype);
> +module_platform_driver(mxsfb_driver);
>
>  MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
>  MODULE_AUTHOR("Sascha Hauer, Pengutronix");
> --
> 1.7.6.4
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] MXSFB: Fix driver registration
  2011-12-19 13:51   ` Shawn Guo
  (?)
@ 2011-12-19 15:18   ` Florian Tobias Schandinat
  -1 siblings, 0 replies; 6+ messages in thread
From: Florian Tobias Schandinat @ 2011-12-19 15:18 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Marek Vasut, linux-kernel, Wolfgang Denk, Stefano Babic,
	Huang Shijie, Axel Lin, Sascha Hauer, linux-fbdev

Hi Marek,

can you please resend the patch to me and the fbdev mailing list, preferably
with all Ack's you received until now included.

On 12/19/2011 01:51 PM, Shawn Guo wrote:
> Cc-ed Florian and linux-fbdev@vger.kernel.org, as I guess Florian is
> the person who will take this patch.

Thanks, I will. I guess you wanted to Ack this patch?


Thanks,

Florian Tobias Schandinat

> 
> -- Regards,Shawn
> On 18 December 2011 08:58, Marek Vasut <marek.vasut@gmail.com> wrote:
>> The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
>> This caused obvious null pointer dereference and crash.
>>
>> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>> Cc: Wolfgang Denk <wd@denx.de>
>> Cc: Stefano Babic <sbabic@denx.de>
>> Cc: Shawn Guo <shawn.guo@linaro.org>
>> Cc: Huang Shijie <b32955@freescale.com>
>> Cc: Axel Lin <axel.lin@gmail.com>
>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>> ---
>>  drivers/video/mxsfb.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
>> index 18742c2..d29c7c0 100644
>> --- a/drivers/video/mxsfb.c
>> +++ b/drivers/video/mxsfb.c
>> @@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
>>        },
>>  };
>>
>> -module_platform_driver(mxsfb_devtype);
>> +module_platform_driver(mxsfb_driver);
>>
>>  MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
>>  MODULE_AUTHOR("Sascha Hauer, Pengutronix");
>> --
>> 1.7.6.4
>>
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-19 15:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-18  0:58 [PATCH] MXSFB: Fix driver registration Marek Vasut
2011-12-18  1:11 ` Axel Lin
2011-12-19  8:00 ` Sascha Hauer
2011-12-19 13:51 ` Shawn Guo
2011-12-19 13:51   ` Shawn Guo
2011-12-19 15:18   ` Florian Tobias Schandinat

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.