[poky][PATCH] kernel.bbclass: Fix kernel size checking

[poky][PATCH] kernel.bbclass: Fix kernel size checking

[Jaap de Jong]

 From 4d542a5a37210b4fc8c8e894554a75ba6b9be0af Mon Sep 17 00:00:00 2001
From: Jaap de Jong <jaap.dejong@nedap.com>
Date: Fri, 15 Dec 2017 08:58:09 +0100
Subject: [poky][PATCH] kernel.bbclass: Fix kernel size checking
To: yocto@yoctoproject.org

---
  meta/classes/kernel.bbclass | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 7ef4f47..f41c3e4 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -601,12 +601,12 @@ do_sizecheck() {
  	if [ ! -z "${KERNEL_IMAGE_MAXSIZE}" ]; then
  		invalid=`echo ${KERNEL_IMAGE_MAXSIZE} | sed 's/[0-9]//g'`
  		if [ -n "$invalid" ]; then
-			die "Invalid KERNEL_IMAGE_MAXSIZE: ${KERNEL_IMAGE_MAXSIZE}, should 
be an integerx (The unit is Kbytes)"
+			die "Invalid KERNEL_IMAGE_MAXSIZE: ${KERNEL_IMAGE_MAXSIZE}, should 
be an integer (The unit is Kbytes)"
  		fi
  		for type in ${KERNEL_IMAGETYPES} ; do
  			size=`du -ks ${B}/${KERNEL_OUTPUT_DIR}/$type | awk '{print $1}'`
  			if [ $size -ge ${KERNEL_IMAGE_MAXSIZE} ]; then
-				warn "This kernel $type (size=$size(K) > 
${KERNEL_IMAGE_MAXSIZE}(K)) is too big for your device. Please reduce 
the size of the kernel by making more of it modular."
+				die "This kernel $type (size=$size(K) > ${KERNEL_IMAGE_MAXSIZE}(K)) 
is too big for your device. Please reduce the size of the kernel by 
making more of it modular."
  			fi
  		done
  	fi
-- 
2.7.4

Re: [poky][PATCH] kernel.bbclass: Fix kernel size checking

[Andrea Adami]

On Fri, Dec 15, 2017 at 9:16 AM, Jaap de Jong <jaap.dejong@nedap.com> wrote:
> From 4d542a5a37210b4fc8c8e894554a75ba6b9be0af Mon Sep 17 00:00:00 2001
> From: Jaap de Jong <jaap.dejong@nedap.com>
> Date: Fri, 15 Dec 2017 08:58:09 +0100
> Subject: [poky][PATCH] kernel.bbclass: Fix kernel size checking
> To: yocto@yoctoproject.org
>
> ---
>  meta/classes/kernel.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 7ef4f47..f41c3e4 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -601,12 +601,12 @@ do_sizecheck() {
>         if [ ! -z "${KERNEL_IMAGE_MAXSIZE}" ]; then
>                 invalid=`echo ${KERNEL_IMAGE_MAXSIZE} | sed 's/[0-9]//g'`
>                 if [ -n "$invalid" ]; then
> -                       die "Invalid KERNEL_IMAGE_MAXSIZE:
> ${KERNEL_IMAGE_MAXSIZE}, should be an integerx (The unit is Kbytes)"
> +                       die "Invalid KERNEL_IMAGE_MAXSIZE:
> ${KERNEL_IMAGE_MAXSIZE}, should be an integer (The unit is Kbytes)"
>                 fi
>                 for type in ${KERNEL_IMAGETYPES} ; do
>                         size=`du -ks ${B}/${KERNEL_OUTPUT_DIR}/$type | awk
> '{print $1}'`
>                         if [ $size -ge ${KERNEL_IMAGE_MAXSIZE} ]; then
> -                               warn "This kernel $type (size=$size(K) >
> ${KERNEL_IMAGE_MAXSIZE}(K)) is too big for your device. Please reduce the
> size of the kernel by making more of it modular."
> +                               die "This kernel $type (size=$size(K) >
> ${KERNEL_IMAGE_MAXSIZE}(K)) is too big for your device. Please reduce the
> size of the kernel by making more of it modular."
>                         fi
>                 done
>         fi
> --
> 2.7.4
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

Hi,

there has been a discussion about do_sizecheck and there is already a
pending patch:

http://lists.openembedded.org/pipermail/openembedded-core/2017-December/145376.html

thanks
Andrea

Re: [poky][PATCH] kernel.bbclass: Fix kernel size checking

[Jaap de Jong]

> there has been a discussion about do_sizecheck and there is already a
> pending patch:
> 
> http://lists.openembedded.org/pipermail/openembedded-core/2017-December/145376.html
Ah! Apologies, totally missed that one