All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-initramfs][PATCH] kexec-tools-klibc: fix build for mipsel
@ 2018-12-17 18:15 Andrea Adami
  2018-12-17 19:22 ` Khem Raj
  0 siblings, 1 reply; 5+ messages in thread
From: Andrea Adami @ 2018-12-17 18:15 UTC (permalink / raw)
  To: openembedded-devel

Fix:
printf.c:2:10: fatal error: limits.h: No such file or directory
|  #include <limits.h>

Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
---
 meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb b/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
index e7553244d..872d79b93 100644
--- a/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
+++ b/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
@@ -66,6 +66,7 @@ CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i
 CFLAGS_arm_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
 CFLAGS_aarch64_append = "${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
 CFLAGS_mips_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
+CFLAGS_mipsel_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
 CFLAGS_mips64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
 CFLAGS_powerpc_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
 
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [meta-initramfs][PATCH] kexec-tools-klibc: fix build for mipsel
  2018-12-17 18:15 [meta-initramfs][PATCH] kexec-tools-klibc: fix build for mipsel Andrea Adami
@ 2018-12-17 19:22 ` Khem Raj
  2018-12-17 21:18   ` Andrea Adami
  0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2018-12-17 19:22 UTC (permalink / raw)
  To: Andrea Adami; +Cc: openembeded-devel

On Mon, Dec 17, 2018 at 10:15 AM Andrea Adami <andrea.adami@gmail.com> wrote:
>
> Fix:
> printf.c:2:10: fatal error: limits.h: No such file or directory
> |  #include <limits.h>
>
> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> ---
>  meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb b/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
> index e7553244d..872d79b93 100644
> --- a/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
> +++ b/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
> @@ -66,6 +66,7 @@ CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i
>  CFLAGS_arm_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
>  CFLAGS_aarch64_append = "${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
>  CFLAGS_mips_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
> +CFLAGS_mipsel_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
>  CFLAGS_mips64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"

I wonder if we just use use "mipsarch" override here once for all
mips kinds.

>  CFLAGS_powerpc_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
>
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-initramfs][PATCH] kexec-tools-klibc: fix build for mipsel
  2018-12-17 19:22 ` Khem Raj
@ 2018-12-17 21:18   ` Andrea Adami
  2018-12-17 21:28     ` Andrea Adami
  0 siblings, 1 reply; 5+ messages in thread
From: Andrea Adami @ 2018-12-17 21:18 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembeded-devel

On Mon, Dec 17, 2018 at 8:23 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Mon, Dec 17, 2018 at 10:15 AM Andrea Adami <andrea.adami@gmail.com> wrote:
> >
> > Fix:
> > printf.c:2:10: fatal error: limits.h: No such file or directory
> > |  #include <limits.h>
> >
> > Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> > ---
> >  meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb b/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
> > index e7553244d..872d79b93 100644
> > --- a/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
> > +++ b/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
> > @@ -66,6 +66,7 @@ CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i
> >  CFLAGS_arm_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
> >  CFLAGS_aarch64_append = "${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
> >  CFLAGS_mips_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
> > +CFLAGS_mipsel_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
> >  CFLAGS_mips64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
>
> I wonder if we just use use "mipsarch" override here once for all
> mips kinds.
>
> >  CFLAGS_powerpc_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
> >
I am also wondering how to do that in another way.
Maybe a patch to adjust the included headers?

Cheers
Andrea

> > --
> > 2.17.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-initramfs][PATCH] kexec-tools-klibc: fix build for mipsel
  2018-12-17 21:18   ` Andrea Adami
@ 2018-12-17 21:28     ` Andrea Adami
  2018-12-17 21:43       ` Andrea Adami
  0 siblings, 1 reply; 5+ messages in thread
From: Andrea Adami @ 2018-12-17 21:28 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembeded-devel

On Mon, Dec 17, 2018 at 10:18 PM Andrea Adami <andrea.adami@gmail.com> wrote:
>
> On Mon, Dec 17, 2018 at 8:23 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > On Mon, Dec 17, 2018 at 10:15 AM Andrea Adami <andrea.adami@gmail.com> wrote:
> > >
> > > Fix:
> > > printf.c:2:10: fatal error: limits.h: No such file or directory
> > > |  #include <limits.h>
> > >
> > > Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> > > ---
> > >  meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb b/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
> > > index e7553244d..872d79b93 100644
> > > --- a/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
> > > +++ b/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
> > > @@ -66,6 +66,7 @@ CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i
> > >  CFLAGS_arm_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
> > >  CFLAGS_aarch64_append = "${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
> > >  CFLAGS_mips_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
> > > +CFLAGS_mipsel_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
> > >  CFLAGS_mips64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
> >
> > I wonder if we just use use "mipsarch" override here once for all
> > mips kinds.

Note that there are different bitsizes...
Please merge this, we'll think how to refactor this later.
Cheers

Andrea
P.S. Unfortunately my poor 3.13.5 bcm-tainted drivers do not survive to kexec.
Will retry with a recent bmips for bcm7425


> >
> > >  CFLAGS_powerpc_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
> > >
> I am also wondering how to do that in another way.
> Maybe a patch to adjust the included headers?
>
> Cheers
> Andrea
>
> > > --
> > > 2.17.1
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-initramfs][PATCH] kexec-tools-klibc: fix build for mipsel
  2018-12-17 21:28     ` Andrea Adami
@ 2018-12-17 21:43       ` Andrea Adami
  0 siblings, 0 replies; 5+ messages in thread
From: Andrea Adami @ 2018-12-17 21:43 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembeded-devel

On Mon, Dec 17, 2018 at 10:28 PM Andrea Adami <andrea.adami@gmail.com> wrote:
>
> On Mon, Dec 17, 2018 at 10:18 PM Andrea Adami <andrea.adami@gmail.com> wrote:
> >
> > On Mon, Dec 17, 2018 at 8:23 PM Khem Raj <raj.khem@gmail.com> wrote:
> > >
> > > On Mon, Dec 17, 2018 at 10:15 AM Andrea Adami <andrea.adami@gmail.com> wrote:
> > > >
> > > > Fix:
> > > > printf.c:2:10: fatal error: limits.h: No such file or directory
> > > > |  #include <limits.h>
> > > >
> > > > Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> > > > ---
> > > >  meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb b/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
> > > > index e7553244d..872d79b93 100644
> > > > --- a/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
> > > > +++ b/meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb
> > > > @@ -66,6 +66,7 @@ CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i
> > > >  CFLAGS_arm_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
> > > >  CFLAGS_aarch64_append = "${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
> > > >  CFLAGS_mips_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
> > > > +CFLAGS_mipsel_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
> > > >  CFLAGS_mips64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
> > >
> > > I wonder if we just use use "mipsarch" override here once for all
> > > mips kinds.
>
> Note that there are different bitsizes...
> Please merge this, we'll think how to refactor this later.
> Cheers
>

ehm.. sorry for the noise, my git repo exploded...
This patch is already merged in master-next: archived as
not-applicable (anymore).

Cheers
Andrea


> Andrea
> P.S. Unfortunately my poor 3.13.5 bcm-tainted drivers do not survive to kexec.
> Will retry with a recent bmips for bcm7425
>
>
> > >
> > > >  CFLAGS_powerpc_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
> > > >
> > I am also wondering how to do that in another way.
> > Maybe a patch to adjust the included headers?
> >
> > Cheers
> > Andrea
> >
> > > > --
> > > > 2.17.1
> > > >
> > > > --
> > > > _______________________________________________
> > > > Openembedded-devel mailing list
> > > > Openembedded-devel@lists.openembedded.org
> > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-12-17 21:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-17 18:15 [meta-initramfs][PATCH] kexec-tools-klibc: fix build for mipsel Andrea Adami
2018-12-17 19:22 ` Khem Raj
2018-12-17 21:18   ` Andrea Adami
2018-12-17 21:28     ` Andrea Adami
2018-12-17 21:43       ` Andrea Adami

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.