[meta-openembedded][PATCH] mksh: add version 56

[meta-openembedded][PATCH] mksh: add version 56

[Eduardas Meile]

The MirBSD Korn Shell is a permissively licensed shell currently used
by Android.

Signed-off-by: Eduardas Meile <eduardas.m@fods.com>
---
 meta-oe/recipes-shells/mksh/mksh_56.bb | 34 ++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 meta-oe/recipes-shells/mksh/mksh_56.bb

diff --git a/meta-oe/recipes-shells/mksh/mksh_56.bb b/meta-oe/recipes-shells/mksh/mksh_56.bb
new file mode 100644
index 000000000..2ddcc6607
--- /dev/null
+++ b/meta-oe/recipes-shells/mksh/mksh_56.bb
@@ -0,0 +1,34 @@
+DESCRIPTION = "The MirBSD Korn Shell - an enhanced version of the public domain ksh"
+HOMEPAGE = "http://www.mirbsd.org/mksh.htm"
+SECTION = "base/shell"
+
+LICENSE = "MirOS & ISC"
+LIC_FILES_CHKSUM = "file://main.c;beginline=6;endline=25;md5=7204fec4d12912f2a13fe8745bc356f9 \
+                    file://strlcpy.c;beginline=1;endline=17;md5=d953f28f0c43ee29e238ec9bc15df2a0 \
+                   "
+
+SRC_URI = "http://www.mirbsd.org/MirOS/dist/mir/mksh/mksh-R56c.tgz"
+
+SRC_URI[md5sum] = "4799a9ac6d55871d79ba66713d928663"
+SRC_URI[sha256sum] = "dd86ebc421215a7b44095dc13b056921ba81e61b9f6f4cdab08ca135d02afb77"
+
+inherit autotools update-alternatives
+
+S = "${WORKDIR}/${PN}"
+
+ALTERNATIVE_${PN} = "sh"
+ALTERNATIVE_LINK_NAME[sh] = "${base_bindir}/sh"
+ALTERNATIVE_TARGET[sh] = "${base_bindir}/${BPN}"
+ALTERNATIVE_PRIORITY = "100"
+
+do_compile() {
+    chmod +x ${S}/Build.sh
+    ${S}/Build.sh
+}
+
+do_install() {
+    install -d ${D}${base_bindir}
+    install -m 0755 ${S}/mksh ${D}${base_bindir}/mksh
+}
+
+RPROVIDES_${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', '/bin/sh', '', d)}"
-- 
2.17.1

Re: [meta-openembedded][PATCH] mksh: add version 56

[Khem Raj]

Fails to build with musl - http://errors.yoctoproject.org/Errors/Details/203419/
On Tue, Dec 4, 2018 at 6:16 AM Eduardas Meile <eduardas.m@fods.com> wrote:
>
> The MirBSD Korn Shell is a permissively licensed shell currently used
> by Android.
>
> Signed-off-by: Eduardas Meile <eduardas.m@fods.com>
> ---
>  meta-oe/recipes-shells/mksh/mksh_56.bb | 34 ++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 meta-oe/recipes-shells/mksh/mksh_56.bb
>
> diff --git a/meta-oe/recipes-shells/mksh/mksh_56.bb b/meta-oe/recipes-shells/mksh/mksh_56.bb
> new file mode 100644
> index 000000000..2ddcc6607
> --- /dev/null
> +++ b/meta-oe/recipes-shells/mksh/mksh_56.bb
> @@ -0,0 +1,34 @@
> +DESCRIPTION = "The MirBSD Korn Shell - an enhanced version of the public domain ksh"
> +HOMEPAGE = "http://www.mirbsd.org/mksh.htm"
> +SECTION = "base/shell"
> +
> +LICENSE = "MirOS & ISC"
> +LIC_FILES_CHKSUM = "file://main.c;beginline=6;endline=25;md5=7204fec4d12912f2a13fe8745bc356f9 \
> +                    file://strlcpy.c;beginline=1;endline=17;md5=d953f28f0c43ee29e238ec9bc15df2a0 \
> +                   "
> +
> +SRC_URI = "http://www.mirbsd.org/MirOS/dist/mir/mksh/mksh-R56c.tgz"
> +
> +SRC_URI[md5sum] = "4799a9ac6d55871d79ba66713d928663"
> +SRC_URI[sha256sum] = "dd86ebc421215a7b44095dc13b056921ba81e61b9f6f4cdab08ca135d02afb77"
> +
> +inherit autotools update-alternatives
> +
> +S = "${WORKDIR}/${PN}"
> +
> +ALTERNATIVE_${PN} = "sh"
> +ALTERNATIVE_LINK_NAME[sh] = "${base_bindir}/sh"
> +ALTERNATIVE_TARGET[sh] = "${base_bindir}/${BPN}"
> +ALTERNATIVE_PRIORITY = "100"
> +
> +do_compile() {
> +    chmod +x ${S}/Build.sh
> +    ${S}/Build.sh
> +}
> +
> +do_install() {
> +    install -d ${D}${base_bindir}
> +    install -m 0755 ${S}/mksh ${D}${base_bindir}/mksh
> +}
> +
> +RPROVIDES_${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', '/bin/sh', '', d)}"
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-openembedded][PATCH] mksh: add version 56

[Andrea Adami]

I had not yet time to review and test-build the recipe but I pointed
it to the author, tg, the fellow helping with klibc.
Here his observations:

<ant_home> LICENSE = "MirOS & ISC"
<mira> ISC only if your libc doesn't have strlcpy
<mira> all but glibc have it
<mira> +    chmod +x ${S}/Build.sh
<mira> why?
<mira> just run sh ${S}/Build.sh instead
<mira> oh and add -r
<mira> saves time (-r disables automatic compilation of the manpage to
a catmanpage, BSD style)
<mira> inherit autotools   ← I doubt that ;)
<mira> you’ll also want to install an /etc/skel/.mkshrc or similar; in
FreeWRT, OpenWrt and OpenADK where root is the only user we install it
as /root/.mkshrc

Cheers
Andrea
On Wed, Dec 5, 2018 at 12:00 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> Fails to build with musl - http://errors.yoctoproject.org/Errors/Details/203419/
> On Tue, Dec 4, 2018 at 6:16 AM Eduardas Meile <eduardas.m@fods.com> wrote:
> >
> > The MirBSD Korn Shell is a permissively licensed shell currently used
> > by Android.
> >
> > Signed-off-by: Eduardas Meile <eduardas.m@fods.com>
> > ---
> >  meta-oe/recipes-shells/mksh/mksh_56.bb | 34 ++++++++++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> >  create mode 100644 meta-oe/recipes-shells/mksh/mksh_56.bb
> >
> > diff --git a/meta-oe/recipes-shells/mksh/mksh_56.bb b/meta-oe/recipes-shells/mksh/mksh_56.bb
> > new file mode 100644
> > index 000000000..2ddcc6607
> > --- /dev/null
> > +++ b/meta-oe/recipes-shells/mksh/mksh_56.bb
> > @@ -0,0 +1,34 @@
> > +DESCRIPTION = "The MirBSD Korn Shell - an enhanced version of the public domain ksh"
> > +HOMEPAGE = "http://www.mirbsd.org/mksh.htm"
> > +SECTION = "base/shell"
> > +
> > +LICENSE = "MirOS & ISC"
> > +LIC_FILES_CHKSUM = "file://main.c;beginline=6;endline=25;md5=7204fec4d12912f2a13fe8745bc356f9 \
> > +                    file://strlcpy.c;beginline=1;endline=17;md5=d953f28f0c43ee29e238ec9bc15df2a0 \
> > +                   "
> > +
> > +SRC_URI = "http://www.mirbsd.org/MirOS/dist/mir/mksh/mksh-R56c.tgz"
> > +
> > +SRC_URI[md5sum] = "4799a9ac6d55871d79ba66713d928663"
> > +SRC_URI[sha256sum] = "dd86ebc421215a7b44095dc13b056921ba81e61b9f6f4cdab08ca135d02afb77"
> > +
> > +inherit autotools update-alternatives
> > +
> > +S = "${WORKDIR}/${PN}"
> > +
> > +ALTERNATIVE_${PN} = "sh"
> > +ALTERNATIVE_LINK_NAME[sh] = "${base_bindir}/sh"
> > +ALTERNATIVE_TARGET[sh] = "${base_bindir}/${BPN}"
> > +ALTERNATIVE_PRIORITY = "100"
> > +
> > +do_compile() {
> > +    chmod +x ${S}/Build.sh
> > +    ${S}/Build.sh
> > +}
> > +
> > +do_install() {
> > +    install -d ${D}${base_bindir}
> > +    install -m 0755 ${S}/mksh ${D}${base_bindir}/mksh
> > +}
> > +
> > +RPROVIDES_${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', '/bin/sh', '', d)}"
> > --
> > 2.17.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-openembedded][PATCH] mksh: add version 56

[Eduardas Meile]

I have made a second version of the patch after feedback on the mailing 
list:

http://lists.openembedded.org/pipermail/openembedded-devel/2018-December/197814.html

I honestly have no idea why the install step failed for you.

Just in case I have tested the second version of the recipe using the 
yoe-distro yoe/mut branch.

Build tested for raspberrypi3 using musl:

Build Configuration:
BB_VERSION = "1.40.0"
BUILD_SYS = "x86_64-linux"
NATIVELSBSTRING = "universal"
TARGET_SYS = "arm-yoe-linux-musleabi"
MACHINE = "raspberrypi3"
DISTRO = "yoe"
DISTRO_VERSION = "2.6"
TUNE_FEATURES = "arm armv7ve vfp thumb neon vfpv4 callconvention-hard 
cortexa7"
TARGET_FPU = "hard"
meta-yoe = "HEAD:32a5f0c16165a1115a9f7b502f50e69dc1e8484c"
meta-qcom = "HEAD:a38028357962542f80a3075b7ec2e089fcc5d321"
meta-raspberrypi = "HEAD:c8a05f2fcf17ca2556f8a56086ea36da2e777d0f"
meta-96boards = "HEAD:10af9ab9265184ae90e0b62e9de0594119159922"
meta-odroid
meta-odroid-extras = "HEAD:986b43faf572a69fa889f5688cef4562257fcd38"
meta-freescale = "HEAD:15a354ee592866a61a893562760ef84bf8fe5e4d"
meta-freescale-3rdparty = "HEAD:6e2ad96fce82bb7a12bba506ac15511752c4f007"
meta-riscv = "HEAD:9fa432afcf4a09340cf0a3511b95e2b2360aaf8b"
meta-ti = "HEAD:53f0eecf8729c79b664a134a74659c515cb39c7a"
meta-browser = "HEAD:d59e2ff84e293e062b5812b63e617a0c5c543127"
meta-rust = "HEAD:4c9068bd0913633eafe7188147988e21f52fe31a"
meta-qt5 = "HEAD:f22750291b224a3ee68456f0319ba18d428e197a"
meta-filesystems
meta-gnome
meta-initramfs
meta-multimedia
meta-networking
meta-oe
meta-perl
meta-python
meta-webserver
meta-xfce = "HEAD:ebc7b9e20ac22f6f2ad373621917f53e8a9af81c"
meta = "HEAD:9f5f4b31df01a29fd07ce27efc7534b4ea29a778"

I can see the compiled binary and configuration file packaged properly 
in the .ipk

Note that Docker was not used (DOCKER_REPO=none).

This was done on an x86_64 machine running Kubuntu 18.04


Also, if possible could you explain the role of yoe-distro in the 
process of testing

recipes with meta-openembedded? Is this integrated into the main autobuilder

that Yocto project uses and the Yocto project release process? I am just

assuming this from the error report page. Honestly, this is the first 
time I have heard

of the Yoe Distribution.

If yoe-distro is a good way to test a recipe, what would be the recommended

configurations to test with before submitting? Should I use the yoe/mut 
branch

or a Yocto release related branch to test? Could be useful in the future.


On 2018-12-05 00:59, Khem Raj wrote:
> Fails to build with musl - http://errors.yoctoproject.org/Errors/Details/203419/
> On Tue, Dec 4, 2018 at 6:16 AM Eduardas Meile <eduardas.m@fods.com> wrote:
>> The MirBSD Korn Shell is a permissively licensed shell currently used
>> by Android.
>>
>> Signed-off-by: Eduardas Meile <eduardas.m@fods.com>
>> ---
>>   meta-oe/recipes-shells/mksh/mksh_56.bb | 34 ++++++++++++++++++++++++++
>>   1 file changed, 34 insertions(+)
>>   create mode 100644 meta-oe/recipes-shells/mksh/mksh_56.bb
>>
>> diff --git a/meta-oe/recipes-shells/mksh/mksh_56.bb b/meta-oe/recipes-shells/mksh/mksh_56.bb
>> new file mode 100644
>> index 000000000..2ddcc6607
>> --- /dev/null
>> +++ b/meta-oe/recipes-shells/mksh/mksh_56.bb
>> @@ -0,0 +1,34 @@
>> +DESCRIPTION = "The MirBSD Korn Shell - an enhanced version of the public domain ksh"
>> +HOMEPAGE = "http://www.mirbsd.org/mksh.htm"
>> +SECTION = "base/shell"
>> +
>> +LICENSE = "MirOS & ISC"
>> +LIC_FILES_CHKSUM = "file://main.c;beginline=6;endline=25;md5=7204fec4d12912f2a13fe8745bc356f9 \
>> +                    file://strlcpy.c;beginline=1;endline=17;md5=d953f28f0c43ee29e238ec9bc15df2a0 \
>> +                   "
>> +
>> +SRC_URI = "http://www.mirbsd.org/MirOS/dist/mir/mksh/mksh-R56c.tgz"
>> +
>> +SRC_URI[md5sum] = "4799a9ac6d55871d79ba66713d928663"
>> +SRC_URI[sha256sum] = "dd86ebc421215a7b44095dc13b056921ba81e61b9f6f4cdab08ca135d02afb77"
>> +
>> +inherit autotools update-alternatives
>> +
>> +S = "${WORKDIR}/${PN}"
>> +
>> +ALTERNATIVE_${PN} = "sh"
>> +ALTERNATIVE_LINK_NAME[sh] = "${base_bindir}/sh"
>> +ALTERNATIVE_TARGET[sh] = "${base_bindir}/${BPN}"
>> +ALTERNATIVE_PRIORITY = "100"
>> +
>> +do_compile() {
>> +    chmod +x ${S}/Build.sh
>> +    ${S}/Build.sh
>> +}
>> +
>> +do_install() {
>> +    install -d ${D}${base_bindir}
>> +    install -m 0755 ${S}/mksh ${D}${base_bindir}/mksh
>> +}
>> +
>> +RPROVIDES_${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', '/bin/sh', '', d)}"
>> --
>> 2.17.1
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel