[meta-oe][PATCH] googletest: move to release 1.10.0

[meta-oe][PATCH] googletest: move to release 1.10.0

[Lei YU]

The googletest recipe was using 1.8.1 tag, and in the recipe it was
using the git revision instead of the tag release.

Rename it to googletest_git.bb and use the 1.10.0 release revision to
get the latest release.

Signed-off-by: Lei YU <mine260309@gmail.com>
---
 meta-oe/recipes-test/googletest/googletest_1.8.1.bb | 21 ---------------------
 meta-oe/recipes-test/googletest/googletest_git.bb   | 21 +++++++++++++++++++++
 2 files changed, 21 insertions(+), 21 deletions(-)
 delete mode 100644 meta-oe/recipes-test/googletest/googletest_1.8.1.bb
 create mode 100644 meta-oe/recipes-test/googletest/googletest_git.bb

diff --git a/meta-oe/recipes-test/googletest/googletest_1.8.1.bb b/meta-oe/recipes-test/googletest/googletest_1.8.1.bb
deleted file mode 100644
index 362d69f..0000000
--- a/meta-oe/recipes-test/googletest/googletest_1.8.1.bb
+++ /dev/null
@@ -1,21 +0,0 @@
-DESCRIPTION = "Google's framework for writing C++ tests"
-HOMEPAGE = "https://github.com/google/googletest"
-SECTION = "libs"
-LICENSE = "BSD-3-Clause"
-LIC_FILES_CHKSUM = "file://googlemock/LICENSE;md5=cbbd27594afd089daa160d3a16dd515a \
-                    file://googletest/LICENSE;md5=cbbd27594afd089daa160d3a16dd515a"
-
-PROVIDES += "gmock gtest"
-
-S = "${WORKDIR}/git"
-SRCREV = "2fe3bd994b3189899d93f1d5a881e725e046fdc2"
-SRC_URI = "git://github.com/google/googletest.git"
-
-inherit cmake
-
-ALLOW_EMPTY_${PN} = "1"
-ALLOW_EMPTY_${PN}-dbg = "1"
-
-RDEPENDS_${PN}-dev += "${PN}-staticdev"
-
-BBCLASSEXTEND = "native nativesdk"
diff --git a/meta-oe/recipes-test/googletest/googletest_git.bb b/meta-oe/recipes-test/googletest/googletest_git.bb
new file mode 100644
index 0000000..e1df9b6
--- /dev/null
+++ b/meta-oe/recipes-test/googletest/googletest_git.bb
@@ -0,0 +1,21 @@
+DESCRIPTION = "Google's framework for writing C++ tests"
+HOMEPAGE = "https://github.com/google/googletest"
+SECTION = "libs"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://googlemock/LICENSE;md5=cbbd27594afd089daa160d3a16dd515a \
+                    file://googletest/LICENSE;md5=cbbd27594afd089daa160d3a16dd515a"
+
+PROVIDES += "gmock gtest"
+
+S = "${WORKDIR}/git"
+SRCREV = "703bd9caab50b139428cea1aaff9974ebee5742e"
+SRC_URI = "git://github.com/google/googletest.git"
+
+inherit cmake
+
+ALLOW_EMPTY_${PN} = "1"
+ALLOW_EMPTY_${PN}-dbg = "1"
+
+RDEPENDS_${PN}-dev += "${PN}-staticdev"
+
+BBCLASSEXTEND = "native nativesdk"
-- 
2.7.4

Re: [meta-oe][PATCH] googletest: move to release 1.10.0

[Adrian Bunk]

On Thu, Nov 21, 2019 at 01:45:33PM +0800, Lei YU wrote:
> The googletest recipe was using 1.8.1 tag, and in the recipe it was
> using the git revision instead of the tag release.
> 
> Rename it to googletest_git.bb and use the 1.10.0 release revision to
> get the latest release.
>...

When removing the version from the recipe name you have to set PV manually.

> --- /dev/null
> +++ b/meta-oe/recipes-test/googletest/googletest_git.bb
> @@ -0,0 +1,21 @@
> +DESCRIPTION = "Google's framework for writing C++ tests"
> +HOMEPAGE = "https://github.com/google/googletest"
> +SECTION = "libs"
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://googlemock/LICENSE;md5=cbbd27594afd089daa160d3a16dd515a \
> +                    file://googletest/LICENSE;md5=cbbd27594afd089daa160d3a16dd515a"
> +
> +PROVIDES += "gmock gtest"
> +
> +S = "${WORKDIR}/git"
> +SRCREV = "703bd9caab50b139428cea1aaff9974ebee5742e"
> +SRC_URI = "git://github.com/google/googletest.git"
> +
> +inherit cmake
> +
> +ALLOW_EMPTY_${PN} = "1"
> +ALLOW_EMPTY_${PN}-dbg = "1"
> +
> +RDEPENDS_${PN}-dev += "${PN}-staticdev"
> +
> +BBCLASSEXTEND = "native nativesdk"

cu
Adrian

Re: [meta-oe][PATCH] googletest: move to release 1.10.0

[Lei YU]

On Mon, Nov 25, 2019 at 11:08 AM Adrian Bunk <bunk@stusta.de> wrote:
>
> On Thu, Nov 21, 2019 at 01:45:33PM +0800, Lei YU wrote:
> > The googletest recipe was using 1.8.1 tag, and in the recipe it was
> > using the git revision instead of the tag release.
> >
> > Rename it to googletest_git.bb and use the 1.10.0 release revision to
> > get the latest release.
> >...
>
> When removing the version from the recipe name you have to set PV manually.

Fixed and sent v2 patch.
Thanks.

Re: [meta-oe][PATCH] googletest: move to release 1.10.0

[Khem Raj]

On Sun, Nov 24, 2019 at 7:41 PM Lei YU <mine260309@gmail.com> wrote:
>
> On Mon, Nov 25, 2019 at 11:08 AM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > On Thu, Nov 21, 2019 at 01:45:33PM +0800, Lei YU wrote:
> > > The googletest recipe was using 1.8.1 tag, and in the recipe it was
> > > using the git revision instead of the tag release.
> > >
> > > Rename it to googletest_git.bb and use the 1.10.0 release revision to
> > > get the latest release.
> > >...
> >
> > When removing the version from the recipe name you have to set PV manually.
>
> Fixed and sent v2 patch.

Thanks, I have rebased this one on top of v1, as v1 was already merged.

> Thanks.
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-oe][PATCH] googletest: move to release 1.10.0

[Peter Kjellerstedt]

> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org <openembedded-
> devel-bounces@lists.openembedded.org> On Behalf Of Khem Raj
> Sent: den 25 november 2019 06:03
> To: Lei YU <mine260309@gmail.com>
> Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>; Adrian
> Bunk <bunk@stusta.de>
> Subject: Re: [oe] [meta-oe][PATCH] googletest: move to release 1.10.0
> 
> On Sun, Nov 24, 2019 at 7:41 PM Lei YU <mine260309@gmail.com> wrote:
> >
> > On Mon, Nov 25, 2019 at 11:08 AM Adrian Bunk <bunk@stusta.de> wrote:
> > >
> > > On Thu, Nov 21, 2019 at 01:45:33PM +0800, Lei YU wrote:
> > > > The googletest recipe was using 1.8.1 tag, and in the recipe it was
> > > > using the git revision instead of the tag release.
> > > >
> > > > Rename it to googletest_git.bb and use the 1.10.0 release revision
> to
> > > > get the latest release.
> > > >...
> > >
> > > When removing the version from the recipe name you have to set PV
> manually.
> >
> > Fixed and sent v2 patch.
> 
> Thanks, I have rebased this one on top of v1, as v1 was already merged.
> 
> > Thanks.

Please move the version back to the file name rather than setting PV.
Since the SRCREV matches the 1.10.0 tag there is no reason to set PV 
in the recipe instead of having it in the file name.

Not having the version in the file name prevents having versioned 
bbappend files.

//Peter