All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ziping Chen <techping.chan@gmail.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: icenowy@aosc.io, Chen-Yu Tsai <wens@csie.org>,
	Rob Herring <robh@kernel.org>,
	mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [linux-sunxi] Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T
Date: Thu, 29 Jun 2017 20:19:14 +0800	[thread overview]
Message-ID: <CAAST=9zv8nqbR42kS99F5S6Nk6brZXE8ruOEapSf7sEjKBrD-A@mail.gmail.com> (raw)
In-Reply-To: <20170629075324.oflzdye3pi5ijzcr@flea>

2017-06-29 15:53 GMT+08:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> On Thu, Jun 29, 2017 at 12:45:51PM +0800, Ziping Chen wrote:
>> 2017-06-28 1:36 GMT+08:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
>> > Hi,
>> >
>> > On Tue, Jun 27, 2017 at 11:29:10PM +0800, icenowy@aosc.io wrote:
>> >> Maxime, here's another problem: if we have already a GP LRADC driver,
>> >> how can we tell the kernel to use it as IIO ADC rather than keys?
>> >
>> > The GPADC IIO driver is not for the LRADC driver, but the GPADC /
>> > temperature sensor.
>> >
>> > We used to have an LRADC IIO driver in the CHIP BSP written by Alex
>> > (in CC):
>> > https://github.com/NextThingCo/CHIP-linux/commit/8675b761c54be73dc7cc0113209f02e10cc63a27
>> >
>> > But he never mainlined it.
>> >
>> >> Should we introduce a new property for this once ready?
>> >
>> > We need to keep the current binding. We can just check for the
>> > presence or not of child nodes to see if it has some keys, and we'd
>> > need an IIO-to-input driver that is yet to be written.
>> >
>>
>> Yes, then we need an iio-to-input driver...
>> So...whether the driver(a83t lradc keys) can be applied now,
>> or we should wait for the iio-to-input driver.
>
> This is a long term discussion, it shouldn't hold the patches you
> sent.

OK, I get it.

And I will think about how to implement the iio-to-input driver.

Thanks,
Ziping

>
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Ziping Chen <techping.chan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: icenowy-h8G6r0blFSE@public.gmane.org,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Alexandre Belloni
	<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T
Date: Thu, 29 Jun 2017 20:19:14 +0800	[thread overview]
Message-ID: <CAAST=9zv8nqbR42kS99F5S6Nk6brZXE8ruOEapSf7sEjKBrD-A@mail.gmail.com> (raw)
In-Reply-To: <20170629075324.oflzdye3pi5ijzcr@flea>

2017-06-29 15:53 GMT+08:00 Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>:
> On Thu, Jun 29, 2017 at 12:45:51PM +0800, Ziping Chen wrote:
>> 2017-06-28 1:36 GMT+08:00 Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>:
>> > Hi,
>> >
>> > On Tue, Jun 27, 2017 at 11:29:10PM +0800, icenowy-h8G6r0blFSE@public.gmane.org wrote:
>> >> Maxime, here's another problem: if we have already a GP LRADC driver,
>> >> how can we tell the kernel to use it as IIO ADC rather than keys?
>> >
>> > The GPADC IIO driver is not for the LRADC driver, but the GPADC /
>> > temperature sensor.
>> >
>> > We used to have an LRADC IIO driver in the CHIP BSP written by Alex
>> > (in CC):
>> > https://github.com/NextThingCo/CHIP-linux/commit/8675b761c54be73dc7cc0113209f02e10cc63a27
>> >
>> > But he never mainlined it.
>> >
>> >> Should we introduce a new property for this once ready?
>> >
>> > We need to keep the current binding. We can just check for the
>> > presence or not of child nodes to see if it has some keys, and we'd
>> > need an IIO-to-input driver that is yet to be written.
>> >
>>
>> Yes, then we need an iio-to-input driver...
>> So...whether the driver(a83t lradc keys) can be applied now,
>> or we should wait for the iio-to-input driver.
>
> This is a long term discussion, it shouldn't hold the patches you
> sent.

OK, I get it.

And I will think about how to implement the iio-to-input driver.

Thanks,
Ziping

>
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: techping.chan@gmail.com (Ziping Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T
Date: Thu, 29 Jun 2017 20:19:14 +0800	[thread overview]
Message-ID: <CAAST=9zv8nqbR42kS99F5S6Nk6brZXE8ruOEapSf7sEjKBrD-A@mail.gmail.com> (raw)
In-Reply-To: <20170629075324.oflzdye3pi5ijzcr@flea>

2017-06-29 15:53 GMT+08:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> On Thu, Jun 29, 2017 at 12:45:51PM +0800, Ziping Chen wrote:
>> 2017-06-28 1:36 GMT+08:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
>> > Hi,
>> >
>> > On Tue, Jun 27, 2017 at 11:29:10PM +0800, icenowy at aosc.io wrote:
>> >> Maxime, here's another problem: if we have already a GP LRADC driver,
>> >> how can we tell the kernel to use it as IIO ADC rather than keys?
>> >
>> > The GPADC IIO driver is not for the LRADC driver, but the GPADC /
>> > temperature sensor.
>> >
>> > We used to have an LRADC IIO driver in the CHIP BSP written by Alex
>> > (in CC):
>> > https://github.com/NextThingCo/CHIP-linux/commit/8675b761c54be73dc7cc0113209f02e10cc63a27
>> >
>> > But he never mainlined it.
>> >
>> >> Should we introduce a new property for this once ready?
>> >
>> > We need to keep the current binding. We can just check for the
>> > presence or not of child nodes to see if it has some keys, and we'd
>> > need an IIO-to-input driver that is yet to be written.
>> >
>>
>> Yes, then we need an iio-to-input driver...
>> So...whether the driver(a83t lradc keys) can be applied now,
>> or we should wait for the iio-to-input driver.
>
> This is a long term discussion, it shouldn't hold the patches you
> sent.

OK, I get it.

And I will think about how to implement the iio-to-input driver.

Thanks,
Ziping

>
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

  reply	other threads:[~2017-06-29 12:19 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-24  2:45 [PATCH v3 0/3] Allwinner A83T R_LRADC support Ziping Chen
2017-06-24  2:45 ` Ziping Chen
2017-06-24  2:45 ` [PATCH v3 1/3] input: sun4i-a10-lradc-keys: Add support for A83T Ziping Chen
2017-06-26 17:13   ` Maxime Ripard
2017-06-26 17:13     ` Maxime Ripard
2017-06-26 17:13     ` Maxime Ripard
2019-03-26 20:26     ` [linux-sunxi] " Ondřej Jirman
2019-03-26 20:26       ` Ondřej Jirman
2019-03-26 20:26       ` 'Ondřej Jirman' via linux-sunxi
2017-06-24  2:45 ` [PATCH v3 2/3] dt-bindings: input: Add R_LRADC " Ziping Chen
2017-06-26 17:15   ` Maxime Ripard
2017-06-26 17:15     ` Maxime Ripard
2017-06-26 17:15     ` Maxime Ripard
2017-06-27 15:18     ` Ziping Chen
2017-06-27 15:18       ` Ziping Chen
2017-06-27 15:18       ` Ziping Chen
2017-06-27 15:29       ` [linux-sunxi] " icenowy
2017-06-27 15:29         ` icenowy at aosc.io
2017-06-27 15:29         ` icenowy-h8G6r0blFSE
2017-06-27 17:36         ` [linux-sunxi] " Maxime Ripard
2017-06-27 17:36           ` Maxime Ripard
2017-06-27 17:36           ` Maxime Ripard
2017-06-27 18:15           ` [linux-sunxi] " Alexandre Belloni
2017-06-27 18:15             ` Alexandre Belloni
2017-06-27 18:15             ` Alexandre Belloni
2017-06-29  4:45           ` Ziping Chen
2017-06-29  4:45             ` Ziping Chen
2017-06-29  4:45             ` Ziping Chen
2017-06-29  7:53             ` [linux-sunxi] " Maxime Ripard
2017-06-29  7:53               ` Maxime Ripard
2017-06-29  7:53               ` Maxime Ripard
2017-06-29 12:19               ` Ziping Chen [this message]
2017-06-29 12:19                 ` Ziping Chen
2017-06-29 12:19                 ` Ziping Chen
2017-06-27 17:31       ` Maxime Ripard
2017-06-27 17:31         ` Maxime Ripard
2017-06-27 17:31         ` Maxime Ripard
2017-06-29  4:35         ` Ziping Chen
2017-06-29  4:35           ` Ziping Chen
2017-06-29  4:35           ` Ziping Chen
2017-06-29  7:52           ` Maxime Ripard
2017-06-29  7:52             ` Maxime Ripard
2017-06-29  7:52             ` Maxime Ripard
2017-06-24  2:45 ` [PATCH v3 3/3] ARM: dts: sunxi: " Ziping Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAST=9zv8nqbR42kS99F5S6Nk6brZXE8ruOEapSf7sEjKBrD-A@mail.gmail.com' \
    --to=techping.chan@gmail.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=robh@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.