* [PATCH 2/2] spi/ath79: Fix checkpatch warnings
@ 2017-06-27 16:10 Aravind Thokala
2017-06-27 16:21 ` Aravind Thokala
2017-07-10 18:42 ` Applied "spi/ath79: Fix checkpatch warnings" to the spi tree Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Aravind Thokala @ 2017-06-27 16:10 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-spi, linux-kernel, Aravind Thokala
This patch fixes the checkpatch.pl warnings on the driver
file.
Signed-off-by: Aravind Thokala <aravind.thk@gmail.com>
---
drivers/spi/spi-ath79.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c
index b89cee1..0719bd4 100644
--- a/drivers/spi/spi-ath79.c
+++ b/drivers/spi/spi-ath79.c
@@ -39,15 +39,15 @@ struct ath79_spi {
u32 reg_ctrl;
void __iomem *base;
struct clk *clk;
- unsigned rrw_delay;
+ unsigned int rrw_delay;
};
-static inline u32 ath79_spi_rr(struct ath79_spi *sp, unsigned reg)
+static inline u32 ath79_spi_rr(struct ath79_spi *sp, unsigned int reg)
{
return ioread32(sp->base + reg);
}
-static inline void ath79_spi_wr(struct ath79_spi *sp, unsigned reg, u32 val)
+static inline void ath79_spi_wr(struct ath79_spi *sp, unsigned int reg, u32 val)
{
iowrite32(val, sp->base + reg);
}
@@ -57,7 +57,7 @@ static inline struct ath79_spi *ath79_spidev_to_sp(struct spi_device *spi)
return spi_master_get_devdata(spi->master);
}
-static inline void ath79_spi_delay(struct ath79_spi *sp, unsigned nsecs)
+static inline void ath79_spi_delay(struct ath79_spi *sp, unsigned int nsecs)
{
if (nsecs > sp->rrw_delay)
ndelay(nsecs - sp->rrw_delay);
@@ -148,9 +148,8 @@ static int ath79_spi_setup_cs(struct spi_device *spi)
static void ath79_spi_cleanup_cs(struct spi_device *spi)
{
- if (gpio_is_valid(spi->cs_gpio)) {
+ if (gpio_is_valid(spi->cs_gpio))
gpio_free(spi->cs_gpio);
- }
}
static int ath79_spi_setup(struct spi_device *spi)
@@ -176,7 +175,7 @@ static void ath79_spi_cleanup(struct spi_device *spi)
spi_bitbang_cleanup(spi);
}
-static u32 ath79_spi_txrx_mode0(struct spi_device *spi, unsigned nsecs,
+static u32 ath79_spi_txrx_mode0(struct spi_device *spi, unsigned int nsecs,
u32 word, u8 bits)
{
struct ath79_spi *sp = ath79_spidev_to_sp(spi);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] spi/ath79: Fix checkpatch warnings
@ 2017-06-27 16:21 ` Aravind Thokala
0 siblings, 0 replies; 4+ messages in thread
From: Aravind Thokala @ 2017-06-27 16:21 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-spi, linux-kernel, Aravind Thokala
Kindly ignore this patch: Mistakenly the patch subject contains [PATCH 2/2].
I will resend the patch.
On 27 June 2017 at 21:40, Aravind Thokala <aravind.thk@gmail.com> wrote:
> This patch fixes the checkpatch.pl warnings on the driver
> file.
>
> Signed-off-by: Aravind Thokala <aravind.thk@gmail.com>
> ---
> drivers/spi/spi-ath79.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c
> index b89cee1..0719bd4 100644
> --- a/drivers/spi/spi-ath79.c
> +++ b/drivers/spi/spi-ath79.c
> @@ -39,15 +39,15 @@ struct ath79_spi {
> u32 reg_ctrl;
> void __iomem *base;
> struct clk *clk;
> - unsigned rrw_delay;
> + unsigned int rrw_delay;
> };
>
> -static inline u32 ath79_spi_rr(struct ath79_spi *sp, unsigned reg)
> +static inline u32 ath79_spi_rr(struct ath79_spi *sp, unsigned int reg)
> {
> return ioread32(sp->base + reg);
> }
>
> -static inline void ath79_spi_wr(struct ath79_spi *sp, unsigned reg, u32 val)
> +static inline void ath79_spi_wr(struct ath79_spi *sp, unsigned int reg, u32 val)
> {
> iowrite32(val, sp->base + reg);
> }
> @@ -57,7 +57,7 @@ static inline struct ath79_spi *ath79_spidev_to_sp(struct spi_device *spi)
> return spi_master_get_devdata(spi->master);
> }
>
> -static inline void ath79_spi_delay(struct ath79_spi *sp, unsigned nsecs)
> +static inline void ath79_spi_delay(struct ath79_spi *sp, unsigned int nsecs)
> {
> if (nsecs > sp->rrw_delay)
> ndelay(nsecs - sp->rrw_delay);
> @@ -148,9 +148,8 @@ static int ath79_spi_setup_cs(struct spi_device *spi)
>
> static void ath79_spi_cleanup_cs(struct spi_device *spi)
> {
> - if (gpio_is_valid(spi->cs_gpio)) {
> + if (gpio_is_valid(spi->cs_gpio))
> gpio_free(spi->cs_gpio);
> - }
> }
>
> static int ath79_spi_setup(struct spi_device *spi)
> @@ -176,7 +175,7 @@ static void ath79_spi_cleanup(struct spi_device *spi)
> spi_bitbang_cleanup(spi);
> }
>
> -static u32 ath79_spi_txrx_mode0(struct spi_device *spi, unsigned nsecs,
> +static u32 ath79_spi_txrx_mode0(struct spi_device *spi, unsigned int nsecs,
> u32 word, u8 bits)
> {
> struct ath79_spi *sp = ath79_spidev_to_sp(spi);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] spi/ath79: Fix checkpatch warnings
@ 2017-06-27 16:21 ` Aravind Thokala
0 siblings, 0 replies; 4+ messages in thread
From: Aravind Thokala @ 2017-06-27 16:21 UTC (permalink / raw)
To: Mark Brown
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Aravind Thokala
Kindly ignore this patch: Mistakenly the patch subject contains [PATCH 2/2].
I will resend the patch.
On 27 June 2017 at 21:40, Aravind Thokala <aravind.thk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> This patch fixes the checkpatch.pl warnings on the driver
> file.
>
> Signed-off-by: Aravind Thokala <aravind.thk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/spi/spi-ath79.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c
> index b89cee1..0719bd4 100644
> --- a/drivers/spi/spi-ath79.c
> +++ b/drivers/spi/spi-ath79.c
> @@ -39,15 +39,15 @@ struct ath79_spi {
> u32 reg_ctrl;
> void __iomem *base;
> struct clk *clk;
> - unsigned rrw_delay;
> + unsigned int rrw_delay;
> };
>
> -static inline u32 ath79_spi_rr(struct ath79_spi *sp, unsigned reg)
> +static inline u32 ath79_spi_rr(struct ath79_spi *sp, unsigned int reg)
> {
> return ioread32(sp->base + reg);
> }
>
> -static inline void ath79_spi_wr(struct ath79_spi *sp, unsigned reg, u32 val)
> +static inline void ath79_spi_wr(struct ath79_spi *sp, unsigned int reg, u32 val)
> {
> iowrite32(val, sp->base + reg);
> }
> @@ -57,7 +57,7 @@ static inline struct ath79_spi *ath79_spidev_to_sp(struct spi_device *spi)
> return spi_master_get_devdata(spi->master);
> }
>
> -static inline void ath79_spi_delay(struct ath79_spi *sp, unsigned nsecs)
> +static inline void ath79_spi_delay(struct ath79_spi *sp, unsigned int nsecs)
> {
> if (nsecs > sp->rrw_delay)
> ndelay(nsecs - sp->rrw_delay);
> @@ -148,9 +148,8 @@ static int ath79_spi_setup_cs(struct spi_device *spi)
>
> static void ath79_spi_cleanup_cs(struct spi_device *spi)
> {
> - if (gpio_is_valid(spi->cs_gpio)) {
> + if (gpio_is_valid(spi->cs_gpio))
> gpio_free(spi->cs_gpio);
> - }
> }
>
> static int ath79_spi_setup(struct spi_device *spi)
> @@ -176,7 +175,7 @@ static void ath79_spi_cleanup(struct spi_device *spi)
> spi_bitbang_cleanup(spi);
> }
>
> -static u32 ath79_spi_txrx_mode0(struct spi_device *spi, unsigned nsecs,
> +static u32 ath79_spi_txrx_mode0(struct spi_device *spi, unsigned int nsecs,
> u32 word, u8 bits)
> {
> struct ath79_spi *sp = ath79_spidev_to_sp(spi);
> --
> 2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Applied "spi/ath79: Fix checkpatch warnings" to the spi tree
2017-06-27 16:10 [PATCH 2/2] spi/ath79: Fix checkpatch warnings Aravind Thokala
2017-06-27 16:21 ` Aravind Thokala
@ 2017-07-10 18:42 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2017-07-10 18:42 UTC (permalink / raw)
To: Aravind Thokala
Cc: Mark Brown, Mark Brown, linux-spi, linux-kernel, linux-spi
The patch
spi/ath79: Fix checkpatch warnings
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 5426ff7f89629f8c1368519d3a7835cc648e70fc Mon Sep 17 00:00:00 2001
From: Aravind Thokala <aravind.thk@gmail.com>
Date: Tue, 27 Jun 2017 22:01:11 +0530
Subject: [PATCH] spi/ath79: Fix checkpatch warnings
This patch fixes the checkpatch.pl warnings on the driver
file.
Signed-off-by: Aravind Thokala <aravind.thk@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-ath79.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c
index b89cee11f418..0719bd484891 100644
--- a/drivers/spi/spi-ath79.c
+++ b/drivers/spi/spi-ath79.c
@@ -39,15 +39,15 @@ struct ath79_spi {
u32 reg_ctrl;
void __iomem *base;
struct clk *clk;
- unsigned rrw_delay;
+ unsigned int rrw_delay;
};
-static inline u32 ath79_spi_rr(struct ath79_spi *sp, unsigned reg)
+static inline u32 ath79_spi_rr(struct ath79_spi *sp, unsigned int reg)
{
return ioread32(sp->base + reg);
}
-static inline void ath79_spi_wr(struct ath79_spi *sp, unsigned reg, u32 val)
+static inline void ath79_spi_wr(struct ath79_spi *sp, unsigned int reg, u32 val)
{
iowrite32(val, sp->base + reg);
}
@@ -57,7 +57,7 @@ static inline struct ath79_spi *ath79_spidev_to_sp(struct spi_device *spi)
return spi_master_get_devdata(spi->master);
}
-static inline void ath79_spi_delay(struct ath79_spi *sp, unsigned nsecs)
+static inline void ath79_spi_delay(struct ath79_spi *sp, unsigned int nsecs)
{
if (nsecs > sp->rrw_delay)
ndelay(nsecs - sp->rrw_delay);
@@ -148,9 +148,8 @@ static int ath79_spi_setup_cs(struct spi_device *spi)
static void ath79_spi_cleanup_cs(struct spi_device *spi)
{
- if (gpio_is_valid(spi->cs_gpio)) {
+ if (gpio_is_valid(spi->cs_gpio))
gpio_free(spi->cs_gpio);
- }
}
static int ath79_spi_setup(struct spi_device *spi)
@@ -176,7 +175,7 @@ static void ath79_spi_cleanup(struct spi_device *spi)
spi_bitbang_cleanup(spi);
}
-static u32 ath79_spi_txrx_mode0(struct spi_device *spi, unsigned nsecs,
+static u32 ath79_spi_txrx_mode0(struct spi_device *spi, unsigned int nsecs,
u32 word, u8 bits)
{
struct ath79_spi *sp = ath79_spidev_to_sp(spi);
--
2.13.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-10 18:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-27 16:10 [PATCH 2/2] spi/ath79: Fix checkpatch warnings Aravind Thokala
2017-06-27 16:21 ` Aravind Thokala
2017-06-27 16:21 ` Aravind Thokala
2017-07-10 18:42 ` Applied "spi/ath79: Fix checkpatch warnings" to the spi tree Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.