From: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>, "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" <nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, Emil Velikov <emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Linux Kernel Mailing List <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Roy Spliet <seven-FA6nBp6kBxZzu6KWmfFNGwC/G2K4zDHf@public.gmane.org> Subject: Re: [PATCH nouveau 09/11] drm: export some variable and functions to resue the PM functions Date: Mon, 5 Jan 2015 20:50:18 +0100 [thread overview] Message-ID: <CAAVeFuK-SgUbtHADX4-pXN5_ayzvEd+1KxJOBcRe2tmDfHaLEA@mail.gmail.com> (raw) In-Reply-To: <20150105153252.GI12010-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> On Mon, Jan 5, 2015 at 4:32 PM, Thierry Reding <thierry.reding@gmail.com> wrote: > On Tue, Dec 30, 2014 at 11:18:34AM +0800, Vince Hsu wrote: >> Hi Emil, >> >> On 12/30/2014 10:34 AM, Emil Velikov wrote: >> >On 23/12/14 10:40, Vince Hsu wrote: >> >>This patch adds some checks in the suspend/resume functions to distinguish >> >>the dGPU and mobile GPU and exports some variables/functions so that the >> >>nouveau platform device can reuse them. >> >> >> >Hi Vince, >> > >> >Afaiu one needs to export a symbol as it's used by another module or >> >subsystem. With the follow up two patches you are not doing either one, >> >so I'd assume that you can just omit the EXPORT_* changes. >> The nouveau platform device driver is built as another module - >> nouveau_platform.ko. :) > > I'd like to hear the opinion of the nouveau people and Alex, but I'd > very much prefer if nouveau_platform.o was simply linked into the > nouveau.ko module. I don't see any good reason to keep it separate. Yep, I agree. The decision to host platform support in a separate module looks misleaded if it results in additional exports that we would otherwise avoid. IIUC I did this to be able to use the module convenience macros to register the platform driver. > > Something like the attached patch (untested) ought to do it. This patch alone won't be enough for the reason I mentioned above. However, if Vince doesn't mind handling the platform driver registration manually in nouveau_drm_init/nouveau_drm_exit, I agree this would be the way to go. Cheers, Alex. _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Courbot <gnurou@gmail.com> To: Thierry Reding <thierry.reding@gmail.com> Cc: Vince Hsu <vinceh@nvidia.com>, Emil Velikov <emil.l.velikov@gmail.com>, Stephen Warren <swarren@wwwdotorg.org>, Ben Skeggs <bskeggs@redhat.com>, Martin Peres <martin.peres@free.fr>, Roy Spliet <seven@nimrod-online.com>, samuel.pitoiset@gmail.com, "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>, "nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [Nouveau] [PATCH nouveau 09/11] drm: export some variable and functions to resue the PM functions Date: Mon, 5 Jan 2015 20:50:18 +0100 [thread overview] Message-ID: <CAAVeFuK-SgUbtHADX4-pXN5_ayzvEd+1KxJOBcRe2tmDfHaLEA@mail.gmail.com> (raw) In-Reply-To: <20150105153252.GI12010@ulmo.nvidia.com> On Mon, Jan 5, 2015 at 4:32 PM, Thierry Reding <thierry.reding@gmail.com> wrote: > On Tue, Dec 30, 2014 at 11:18:34AM +0800, Vince Hsu wrote: >> Hi Emil, >> >> On 12/30/2014 10:34 AM, Emil Velikov wrote: >> >On 23/12/14 10:40, Vince Hsu wrote: >> >>This patch adds some checks in the suspend/resume functions to distinguish >> >>the dGPU and mobile GPU and exports some variables/functions so that the >> >>nouveau platform device can reuse them. >> >> >> >Hi Vince, >> > >> >Afaiu one needs to export a symbol as it's used by another module or >> >subsystem. With the follow up two patches you are not doing either one, >> >so I'd assume that you can just omit the EXPORT_* changes. >> The nouveau platform device driver is built as another module - >> nouveau_platform.ko. :) > > I'd like to hear the opinion of the nouveau people and Alex, but I'd > very much prefer if nouveau_platform.o was simply linked into the > nouveau.ko module. I don't see any good reason to keep it separate. Yep, I agree. The decision to host platform support in a separate module looks misleaded if it results in additional exports that we would otherwise avoid. IIUC I did this to be able to use the module convenience macros to register the platform driver. > > Something like the attached patch (untested) ought to do it. This patch alone won't be enough for the reason I mentioned above. However, if Vince doesn't mind handling the platform driver registration manually in nouveau_drm_init/nouveau_drm_exit, I agree this would be the way to go. Cheers, Alex.
next prev parent reply other threads:[~2015-01-05 19:50 UTC|newest] Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-23 10:39 [PATCH 0/11] Add suspend/resume support for GK20A Vince Hsu 2014-12-23 10:39 ` Vince Hsu [not found] ` <1419331204-26679-1-git-send-email-vinceh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-12-23 10:39 ` [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp Vince Hsu 2014-12-23 10:39 ` Vince Hsu [not found] ` <1419331204-26679-2-git-send-email-vinceh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-12-24 13:16 ` Lucas Stach 2014-12-24 13:16 ` Lucas Stach [not found] ` <1419426990.2179.7.camel-8ppwABl0HbeELgA04lAiVw@public.gmane.org> 2014-12-25 2:28 ` Vince Hsu 2014-12-25 2:28 ` Vince Hsu [not found] ` <549B7638.2010405-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-12-25 20:34 ` Lucas Stach 2014-12-25 20:34 ` Lucas Stach [not found] ` <1419539683.2165.6.camel-8ppwABl0HbeELgA04lAiVw@public.gmane.org> 2014-12-29 2:49 ` Vince Hsu 2014-12-29 2:49 ` Vince Hsu [not found] ` <54A0C148.6030400-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-12-30 16:42 ` Lucas Stach 2014-12-30 16:42 ` Lucas Stach [not found] ` <1419957752.4082.2.camel-8ppwABl0HbeELgA04lAiVw@public.gmane.org> 2015-01-05 6:55 ` Vince Hsu 2015-01-05 6:55 ` Vince Hsu 2015-01-05 15:09 ` Thierry Reding 2015-01-05 15:09 ` Thierry Reding [not found] ` <20150105150932.GG12010-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> 2015-01-06 2:11 ` Vince Hsu 2015-01-06 2:11 ` Vince Hsu [not found] ` <54AB445D.7010303-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2015-01-06 11:15 ` Thierry Reding 2015-01-06 11:15 ` Thierry Reding [not found] ` <20150106111538.GB31830-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> 2015-01-06 12:03 ` Vince Hsu 2015-01-06 12:03 ` Vince Hsu 2015-01-06 13:29 ` Thierry Reding 2015-01-06 13:51 ` Vince Hsu 2015-01-06 13:51 ` Vince Hsu [not found] ` <20150106135110.GA18076-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2015-01-06 14:23 ` Thierry Reding 2015-01-06 14:23 ` Thierry Reding 2015-01-07 10:19 ` Peter De Schrijver 2015-01-07 10:19 ` Peter De Schrijver [not found] ` <20150107101900.GP10073-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org> 2015-01-07 10:49 ` Vince Hsu 2015-01-07 10:49 ` Vince Hsu 2015-01-07 13:27 ` Thierry Reding 2015-01-07 14:08 ` Peter De Schrijver 2015-01-07 14:08 ` Peter De Schrijver 2015-01-07 14:28 ` Vince Hsu 2015-01-07 14:28 ` Vince Hsu [not found] ` <20150107142828.GB7392-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2015-01-07 14:48 ` Thierry Reding 2015-01-07 14:48 ` Thierry Reding 2015-01-08 4:25 ` Vince Hsu 2015-01-08 4:25 ` Vince Hsu [not found] ` <54AE06AE.8080603-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2015-01-08 8:03 ` Thierry Reding 2015-01-08 8:03 ` Thierry Reding 2015-01-07 14:12 ` Peter De Schrijver 2015-01-07 14:12 ` Peter De Schrijver 2015-01-07 14:19 ` Vince Hsu 2015-01-07 14:19 ` Vince Hsu 2015-01-07 15:12 ` Thierry Reding 2015-01-08 4:23 ` Vince Hsu 2015-01-08 4:23 ` Vince Hsu 2015-01-08 9:32 ` Peter De Schrijver 2015-01-08 9:32 ` Peter De Schrijver [not found] ` <20150108093205.GV10073-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org> 2015-01-08 11:41 ` Thierry Reding 2015-01-08 11:41 ` Thierry Reding [not found] ` <20150108114153.GL1987-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> 2015-01-08 12:41 ` Peter De Schrijver 2015-01-08 12:41 ` Peter De Schrijver 2015-01-08 9:39 ` Peter De Schrijver 2015-01-08 9:39 ` Peter De Schrijver [not found] ` <20150108093957.GW10073-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org> 2015-01-08 11:44 ` Thierry Reding 2015-01-08 11:44 ` Thierry Reding 2014-12-24 13:52 ` Dmitry Osipenko 2014-12-24 13:52 ` Dmitry Osipenko [not found] ` <549AC511.5040507-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-12-25 2:05 ` Vince Hsu 2014-12-25 2:05 ` Vince Hsu 2014-12-23 10:39 ` [PATCH 2/11] memory: tegra: add mc flush support Vince Hsu 2014-12-23 10:39 ` Vince Hsu 2015-01-06 14:18 ` Thierry Reding [not found] ` <20150106141821.GJ31830-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> 2015-01-07 10:08 ` Peter De Schrijver 2015-01-07 10:08 ` Peter De Schrijver [not found] ` <20150107100804.GO10073-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org> 2015-01-07 13:34 ` Thierry Reding 2015-01-07 13:34 ` Thierry Reding 2014-12-23 10:39 ` [PATCH 3/11] memory: tegra: add flush operation for Tegra124 memory clients Vince Hsu 2014-12-23 10:39 ` Vince Hsu 2015-01-06 14:30 ` Thierry Reding 2015-01-06 15:07 ` Vince Hsu 2015-01-06 15:07 ` Vince Hsu 2015-01-06 15:27 ` Thierry Reding [not found] ` <20150106152750.GR31830-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> 2015-01-06 15:53 ` Vince Hsu 2015-01-06 15:53 ` Vince Hsu 2014-12-23 10:39 ` [PATCH 4/11] ARM: tegra: add mc node for Tegra124 GPU Vince Hsu 2014-12-23 10:39 ` Vince Hsu 2014-12-23 10:39 ` [PATCH nouveau 05/11] platform: switch to the new gpu rail clamping function Vince Hsu 2014-12-23 10:39 ` Vince Hsu 2014-12-23 10:39 ` [PATCH nouveau 06/11] platform: complete the power up/down sequence Vince Hsu 2014-12-23 10:39 ` Vince Hsu [not found] ` <1419331204-26679-7-git-send-email-vinceh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-12-24 13:23 ` Lucas Stach 2014-12-24 13:23 ` Lucas Stach [not found] ` <1419427385.2179.13.camel-8ppwABl0HbeELgA04lAiVw@public.gmane.org> 2014-12-25 2:42 ` Vince Hsu 2014-12-25 2:42 ` Vince Hsu [not found] ` <549B79B2.6010301-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2015-01-05 15:25 ` Thierry Reding 2015-01-05 15:25 ` Thierry Reding [not found] ` <20150105152552.GH12010-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> 2015-01-06 9:34 ` Vince Hsu 2015-01-06 9:34 ` Vince Hsu 2015-01-06 11:36 ` Thierry Reding 2015-01-06 12:13 ` Vince Hsu 2015-01-06 12:13 ` Vince Hsu [not found] ` <54ABD14D.30003-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2015-01-06 13:55 ` Thierry Reding 2015-01-06 13:55 ` Thierry Reding 2015-01-06 14:19 ` Vince Hsu 2015-01-06 14:19 ` Vince Hsu [not found] ` <20150106141948.GA18598-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2015-01-06 14:24 ` Thierry Reding 2015-01-06 14:24 ` Thierry Reding 2014-12-23 10:40 ` [PATCH nouveau 07/11] instmem: make nv50_instmem_priv public Vince Hsu 2014-12-23 10:40 ` Vince Hsu 2014-12-23 10:40 ` [PATCH nouveau 08/11] instmem: add dummy support for GK20A Vince Hsu 2014-12-23 10:40 ` Vince Hsu [not found] ` <1419331204-26679-9-git-send-email-vinceh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-12-23 16:39 ` Ilia Mirkin 2014-12-23 16:39 ` [Nouveau] " Ilia Mirkin [not found] ` <CAKb7UvgCizkaK2aZeWp=mgH34Ur3hi0hSFghopkpkkBeuqzsoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2014-12-24 2:44 ` Vince Hsu 2014-12-24 2:44 ` [Nouveau] " Vince Hsu 2014-12-23 10:40 ` [PATCH nouveau 09/11] drm: export some variable and functions to resue the PM functions Vince Hsu 2014-12-23 10:40 ` Vince Hsu [not found] ` <1419331204-26679-10-git-send-email-vinceh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-12-30 2:34 ` Emil Velikov 2014-12-30 2:34 ` [Nouveau] " Emil Velikov [not found] ` <54A20F4D.4040100-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-12-30 3:18 ` Vince Hsu 2014-12-30 3:18 ` [Nouveau] " Vince Hsu [not found] ` <54A2198A.4000707-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2015-01-05 15:32 ` Thierry Reding 2015-01-05 15:32 ` [Nouveau] " Thierry Reding [not found] ` <20150105153252.GI12010-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> 2015-01-05 19:50 ` Alexandre Courbot [this message] 2015-01-05 19:50 ` Alexandre Courbot [not found] ` <CAAVeFuK-SgUbtHADX4-pXN5_ayzvEd+1KxJOBcRe2tmDfHaLEA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-01-06 9:36 ` Vince Hsu 2015-01-06 9:36 ` [Nouveau] " Vince Hsu 2015-01-06 11:49 ` Thierry Reding 2015-01-06 11:49 ` [Nouveau] " Thierry Reding 2015-01-06 12:27 ` Vince Hsu 2015-01-06 12:27 ` Vince Hsu [not found] ` <54ABD49A.6080501-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2015-01-06 14:37 ` Thierry Reding 2015-01-06 14:37 ` [Nouveau] " Thierry Reding 2015-01-06 14:44 ` Ilia Mirkin [not found] ` <CAKb7UvgomyQkiwfGTdyuU-muE-_pPxOSmeXh9uQ6-ri0HHxLrQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-01-06 14:50 ` Thierry Reding 2015-01-06 14:50 ` Thierry Reding [not found] ` <20150106145054.GO31830-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> 2015-01-06 15:03 ` Ilia Mirkin 2015-01-06 15:03 ` [Nouveau] " Ilia Mirkin 2015-01-06 15:35 ` Thierry Reding 2014-12-23 10:40 ` [PATCH nouveau 10/11] platform: add suspend/resume support Vince Hsu 2014-12-23 10:40 ` Vince Hsu 2014-12-23 10:40 ` [PATCH nouveau 11/11] platform: add PM runtime " Vince Hsu 2014-12-23 10:40 ` Vince Hsu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAAVeFuK-SgUbtHADX4-pXN5_ayzvEd+1KxJOBcRe2tmDfHaLEA@mail.gmail.com \ --to=gnurou-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=seven-FA6nBp6kBxZzu6KWmfFNGwC/G2K4zDHf@public.gmane.org \ --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \ --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.