From: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: David Airlie <airlied-cv59FeDIM0c@public.gmane.org>, "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" <nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, Linux Kernel Mailing List <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" <dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH 2/4] drm/ttm: introduce dma cache sync helpers Date: Fri, 23 May 2014 14:49:40 +0900 [thread overview] Message-ID: <CAAVeFuKCx677Uxcu3XNLkU+er-GBAxqdj_hUDUXHwUN+CS5EsA@mail.gmail.com> (raw) In-Reply-To: <20140519083355.GA7138@ulmo> On Mon, May 19, 2014 at 5:33 PM, Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > On Mon, May 19, 2014 at 04:10:56PM +0900, Alexandre Courbot wrote: >> From: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org> >> >> On arches with non-coherent PCI, > > I guess since this applies to gk20a > >> we need to flush caches ourselfes at > > "ourselves". Or perhaps even reword to something like: "..., caches need > to be flushed and invalidated explicitly", since dma_sync_for_cpu() does > invalidate rather than flush. Rephrased as "On arches for which access to GPU memory is non-coherent, caches need to be flushed and invalidated explicitly at the appropriate places." > >> the appropriate places. Introduce two small helpers to make things easy >> for TTM based drivers. >> >> Signed-off-by: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org> >> Signed-off-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> >> --- >> drivers/gpu/drm/ttm/ttm_tt.c | 25 +++++++++++++++++++++++++ >> include/drm/ttm/ttm_bo_driver.h | 28 ++++++++++++++++++++++++++++ >> 2 files changed, 53 insertions(+) >> >> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c > [...] >> +void ttm_dma_tt_cache_sync_for_device(struct ttm_dma_tt *ttm_dma, >> + struct device *dev) >> +{ >> + int i; > > This should probably be unsigned long to match the type of > ttm_dma->ttm.num_pages. Fixed. Thanks, Alex.
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Courbot <gnurou@gmail.com> To: Thierry Reding <thierry.reding@gmail.com> Cc: Alexandre Courbot <acourbot@nvidia.com>, David Airlie <airlied@linux.ie>, Ben Skeggs <bskeggs@redhat.com>, Lucas Stach <dev@lynxeye.de>, "nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 2/4] drm/ttm: introduce dma cache sync helpers Date: Fri, 23 May 2014 14:49:40 +0900 [thread overview] Message-ID: <CAAVeFuKCx677Uxcu3XNLkU+er-GBAxqdj_hUDUXHwUN+CS5EsA@mail.gmail.com> (raw) In-Reply-To: <20140519083355.GA7138@ulmo> On Mon, May 19, 2014 at 5:33 PM, Thierry Reding <thierry.reding@gmail.com> wrote: > On Mon, May 19, 2014 at 04:10:56PM +0900, Alexandre Courbot wrote: >> From: Lucas Stach <dev@lynxeye.de> >> >> On arches with non-coherent PCI, > > I guess since this applies to gk20a > >> we need to flush caches ourselfes at > > "ourselves". Or perhaps even reword to something like: "..., caches need > to be flushed and invalidated explicitly", since dma_sync_for_cpu() does > invalidate rather than flush. Rephrased as "On arches for which access to GPU memory is non-coherent, caches need to be flushed and invalidated explicitly at the appropriate places." > >> the appropriate places. Introduce two small helpers to make things easy >> for TTM based drivers. >> >> Signed-off-by: Lucas Stach <dev@lynxeye.de> >> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> >> --- >> drivers/gpu/drm/ttm/ttm_tt.c | 25 +++++++++++++++++++++++++ >> include/drm/ttm/ttm_bo_driver.h | 28 ++++++++++++++++++++++++++++ >> 2 files changed, 53 insertions(+) >> >> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c > [...] >> +void ttm_dma_tt_cache_sync_for_device(struct ttm_dma_tt *ttm_dma, >> + struct device *dev) >> +{ >> + int i; > > This should probably be unsigned long to match the type of > ttm_dma->ttm.num_pages. Fixed. Thanks, Alex.
next prev parent reply other threads:[~2014-05-23 5:49 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-05-19 7:10 [PATCH 0/4] drm/ttm: nouveau: memory coherency fixes for ARM Alexandre Courbot 2014-05-19 7:10 ` Alexandre Courbot 2014-05-19 7:10 ` [PATCH 1/4] drm/ttm: recognize ARM arch in ioprot handler Alexandre Courbot 2014-05-19 7:10 ` Alexandre Courbot 2014-05-19 7:10 ` [PATCH 3/4] drm/nouveau: hook up cache sync functions Alexandre Courbot 2014-05-19 7:10 ` Alexandre Courbot [not found] ` <1400483458-9648-4-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-05-19 8:46 ` Thierry Reding 2014-05-19 8:46 ` Thierry Reding 2014-05-19 9:44 ` Lucas Stach 2014-05-19 9:44 ` Lucas Stach 2014-05-23 6:00 ` Alexandre Courbot 2014-05-23 6:00 ` Alexandre Courbot 2014-05-19 9:31 ` Lucas Stach 2014-05-19 9:31 ` Lucas Stach [not found] ` <1400491887.8467.15.camel-WzVe3FnzCwFR6QfukMTsflXZhhPuCNm+@public.gmane.org> 2014-05-23 6:01 ` Alexandre Courbot 2014-05-23 6:01 ` Alexandre Courbot [not found] ` <1400483458-9648-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-05-19 7:10 ` [PATCH 2/4] drm/ttm: introduce dma cache sync helpers Alexandre Courbot 2014-05-19 7:10 ` Alexandre Courbot 2014-05-19 8:33 ` Thierry Reding 2014-05-19 8:33 ` Thierry Reding 2014-05-23 5:49 ` Alexandre Courbot [this message] 2014-05-23 5:49 ` Alexandre Courbot 2014-05-23 7:31 ` Thierry Reding 2014-05-23 7:31 ` Thierry Reding 2014-05-19 7:10 ` [PATCH 4/4] drm/nouveau: introduce CPU cache flushing macro Alexandre Courbot 2014-05-19 7:10 ` Alexandre Courbot [not found] ` <1400483458-9648-5-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-05-19 9:02 ` Thierry Reding 2014-05-19 9:02 ` Thierry Reding 2014-05-19 9:22 ` Lucas Stach 2014-05-19 9:22 ` Lucas Stach [not found] ` <1400491331.8467.8.camel-WzVe3FnzCwFR6QfukMTsflXZhhPuCNm+@public.gmane.org> 2014-05-19 10:03 ` Thierry Reding 2014-05-19 10:03 ` Thierry Reding 2014-05-19 10:27 ` Daniel Vetter 2014-05-19 10:27 ` [Nouveau] " Daniel Vetter 2014-05-23 6:58 ` Alexandre Courbot 2014-05-23 6:58 ` Alexandre Courbot 2014-06-09 10:41 ` Alexandre Courbot 2014-06-09 10:41 ` Alexandre Courbot [not found] ` <CAAVeFu+KZ9AqB5ji5-AA+qzEFDWd7y0=J1eSEPqQ-OyhmXufig-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2014-06-12 13:50 ` Alexandre Courbot 2014-06-12 13:50 ` Alexandre Courbot [not found] ` <CAAVeFuJYe5wVH_gTok80hT=4GbwhYq4C9c7S5No_V11qjs3brQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2014-06-12 18:15 ` Roy Spliet
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAAVeFuKCx677Uxcu3XNLkU+er-GBAxqdj_hUDUXHwUN+CS5EsA@mail.gmail.com \ --to=gnurou-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=airlied-cv59FeDIM0c@public.gmane.org \ --cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.