* [PATCH RESEND gpio] gpio-amd8111: check ioport_map return value
@ 2015-01-09 5:08 Varka Bhadram
2015-01-19 6:27 ` Alexandre Courbot
0 siblings, 1 reply; 4+ messages in thread
From: Varka Bhadram @ 2015-01-09 5:08 UTC (permalink / raw)
To: linux-gpio; +Cc: linus.walleij, Varka Bhadram, Varka Bhadram
From: Varka Bhadram <varkabhadram@gmail.com>
ioport_map() may fail. Its safe to check the return value.
Signed-off-by: Varka Bhadram <varkab@cdac.in>
---
drivers/gpio/gpio-amd8111.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpio/gpio-amd8111.c b/drivers/gpio/gpio-amd8111.c
index d3d2d10..2c4d9ab 100644
--- a/drivers/gpio/gpio-amd8111.c
+++ b/drivers/gpio/gpio-amd8111.c
@@ -213,6 +213,11 @@ found:
goto out;
}
gp.pm = ioport_map(gp.pmbase + PMBASE_OFFSET, PMBASE_SIZE);
+ if (!gp.pm) {
+ dev_err(&pdev->dev, "Couldn't map io port into io memory\n");
+ err = -ENOMEM;
+ goto out;
+ }
gp.pdev = pdev;
gp.chip.dev = &pdev->dev;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND gpio] gpio-amd8111: check ioport_map return value
2015-01-09 5:08 [PATCH RESEND gpio] gpio-amd8111: check ioport_map return value Varka Bhadram
@ 2015-01-19 6:27 ` Alexandre Courbot
2015-01-19 7:04 ` Varka Bhadram
0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Courbot @ 2015-01-19 6:27 UTC (permalink / raw)
To: Varka Bhadram; +Cc: linux-gpio, Linus Walleij, Varka Bhadram
On Fri, Jan 9, 2015 at 2:08 PM, Varka Bhadram <varkabhadram@gmail.com> wrote:
> From: Varka Bhadram <varkabhadram@gmail.com>
>
> ioport_map() may fail. Its safe to check the return value.
>
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
> drivers/gpio/gpio-amd8111.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpio/gpio-amd8111.c b/drivers/gpio/gpio-amd8111.c
> index d3d2d10..2c4d9ab 100644
> --- a/drivers/gpio/gpio-amd8111.c
> +++ b/drivers/gpio/gpio-amd8111.c
> @@ -213,6 +213,11 @@ found:
> goto out;
> }
> gp.pm = ioport_map(gp.pmbase + PMBASE_OFFSET, PMBASE_SIZE);
> + if (!gp.pm) {
> + dev_err(&pdev->dev, "Couldn't map io port into io memory\n");
> + err = -ENOMEM;
> + goto out;
You are not calling release_region() to free the region requested right above.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND gpio] gpio-amd8111: check ioport_map return value
2015-01-19 6:27 ` Alexandre Courbot
@ 2015-01-19 7:04 ` Varka Bhadram
2015-01-19 7:48 ` Alexandre Courbot
0 siblings, 1 reply; 4+ messages in thread
From: Varka Bhadram @ 2015-01-19 7:04 UTC (permalink / raw)
To: Alexandre Courbot; +Cc: linux-gpio, Linus Walleij, Varka Bhadram
On Mon, Jan 19, 2015 at 11:57 AM, Alexandre Courbot <gnurou@gmail.com> wrote:
> On Fri, Jan 9, 2015 at 2:08 PM, Varka Bhadram <varkabhadram@gmail.com> wrote:
>> From: Varka Bhadram <varkabhadram@gmail.com>
>>
>> ioport_map() may fail. Its safe to check the return value.
>>
>> Signed-off-by: Varka Bhadram <varkab@cdac.in>
>> ---
>> drivers/gpio/gpio-amd8111.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpio/gpio-amd8111.c b/drivers/gpio/gpio-amd8111.c
>> index d3d2d10..2c4d9ab 100644
>> --- a/drivers/gpio/gpio-amd8111.c
>> +++ b/drivers/gpio/gpio-amd8111.c
>> @@ -213,6 +213,11 @@ found:
>> goto out;
>> }
>> gp.pm = ioport_map(gp.pmbase + PMBASE_OFFSET, PMBASE_SIZE);
>> + if (!gp.pm) {
>> + dev_err(&pdev->dev, "Couldn't map io port into io memory\n");
>> + err = -ENOMEM;
>> + goto out;
>
> You are not calling release_region() to free the region requested right above.
Yes... You are correct. I will send the patch for this. Can i add
Reported-by tag of your..?
--
Thanks and Regards,
Varka Bhadram.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND gpio] gpio-amd8111: check ioport_map return value
2015-01-19 7:04 ` Varka Bhadram
@ 2015-01-19 7:48 ` Alexandre Courbot
0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Courbot @ 2015-01-19 7:48 UTC (permalink / raw)
To: Varka Bhadram; +Cc: linux-gpio, Linus Walleij, Varka Bhadram
On Mon, Jan 19, 2015 at 4:04 PM, Varka Bhadram <varkabhadram@gmail.com> wrote:
> On Mon, Jan 19, 2015 at 11:57 AM, Alexandre Courbot <gnurou@gmail.com> wrote:
>> On Fri, Jan 9, 2015 at 2:08 PM, Varka Bhadram <varkabhadram@gmail.com> wrote:
>>> From: Varka Bhadram <varkabhadram@gmail.com>
>>>
>>> ioport_map() may fail. Its safe to check the return value.
>>>
>>> Signed-off-by: Varka Bhadram <varkab@cdac.in>
>>> ---
>>> drivers/gpio/gpio-amd8111.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/gpio/gpio-amd8111.c b/drivers/gpio/gpio-amd8111.c
>>> index d3d2d10..2c4d9ab 100644
>>> --- a/drivers/gpio/gpio-amd8111.c
>>> +++ b/drivers/gpio/gpio-amd8111.c
>>> @@ -213,6 +213,11 @@ found:
>>> goto out;
>>> }
>>> gp.pm = ioport_map(gp.pmbase + PMBASE_OFFSET, PMBASE_SIZE);
>>> + if (!gp.pm) {
>>> + dev_err(&pdev->dev, "Couldn't map io port into io memory\n");
>>> + err = -ENOMEM;
>>> + goto out;
>>
>> You are not calling release_region() to free the region requested right above.
>
> Yes... You are correct. I will send the patch for this. Can i add
> Reported-by tag of your..?
Ah, I did not notice that Linus had already merged this. Sure, feel
free to do so.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-19 7:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-09 5:08 [PATCH RESEND gpio] gpio-amd8111: check ioport_map return value Varka Bhadram
2015-01-19 6:27 ` Alexandre Courbot
2015-01-19 7:04 ` Varka Bhadram
2015-01-19 7:48 ` Alexandre Courbot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.