* [PATCH] staging: gasket: Remove return variable
@ 2019-03-19 19:29 Nishka Dasgupta
2019-03-19 19:54 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Nishka Dasgupta @ 2019-03-19 19:29 UTC (permalink / raw)
To: rspringer, toddpoynor, benchan, gregkh, outreachy-kernel; +Cc: Nishka Dasgupta
Remove return variable and return the return value directly. Issue
suggested by ret.cocci.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
---
drivers/staging/gasket/apex_driver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c
index 0578bf1ba1e9..a5da9bbd8396 100644
--- a/drivers/staging/gasket/apex_driver.c
+++ b/drivers/staging/gasket/apex_driver.c
@@ -439,9 +439,7 @@ static int apex_reset(struct gasket_dev *gasket_dev)
if (ret)
return ret;
}
- ret = apex_quit_reset(gasket_dev);
-
- return ret;
+ return apex_quit_reset(gasket_dev);
}
/*
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: gasket: Remove return variable
2019-03-19 19:29 [PATCH] staging: gasket: Remove return variable Nishka Dasgupta
@ 2019-03-19 19:54 ` Julia Lawall
2019-03-24 19:31 ` Todd Poynor
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2019-03-19 19:54 UTC (permalink / raw)
To: Nishka Dasgupta; +Cc: rspringer, toddpoynor, benchan, gregkh, outreachy-kernel
On Wed, 20 Mar 2019, 'Nishka Dasgupta' via outreachy-kernel wrote:
> Remove return variable and return the return value directly. Issue
> suggested by ret.cocci.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/gasket/apex_driver.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c
> index 0578bf1ba1e9..a5da9bbd8396 100644
> --- a/drivers/staging/gasket/apex_driver.c
> +++ b/drivers/staging/gasket/apex_driver.c
> @@ -439,9 +439,7 @@ static int apex_reset(struct gasket_dev *gasket_dev)
> if (ret)
> return ret;
> }
> - ret = apex_quit_reset(gasket_dev);
> -
> - return ret;
> + return apex_quit_reset(gasket_dev);
> }
>
> /*
> --
> 2.19.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190319192911.8526-1-nishka.dasgupta%40yahoo.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: gasket: Remove return variable
2019-03-19 19:54 ` [Outreachy kernel] " Julia Lawall
@ 2019-03-24 19:31 ` Todd Poynor
0 siblings, 0 replies; 3+ messages in thread
From: Todd Poynor @ 2019-03-24 19:31 UTC (permalink / raw)
To: Julia Lawall
Cc: Nishka Dasgupta, Rob Springer, benchan, Greg KH, outreachy-kernel
On Tue, Mar 19, 2019 at 12:54 PM Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>
> On Wed, 20 Mar 2019, 'Nishka Dasgupta' via outreachy-kernel wrote:
>
> > Remove return variable and return the return value directly. Issue
> > suggested by ret.cocci.
> >
> > Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
>
> > ---
> > drivers/staging/gasket/apex_driver.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c
> > index 0578bf1ba1e9..a5da9bbd8396 100644
> > --- a/drivers/staging/gasket/apex_driver.c
> > +++ b/drivers/staging/gasket/apex_driver.c
> > @@ -439,9 +439,7 @@ static int apex_reset(struct gasket_dev *gasket_dev)
> > if (ret)
> > return ret;
> > }
> > - ret = apex_quit_reset(gasket_dev);
> > -
> > - return ret;
> > + return apex_quit_reset(gasket_dev);
> > }
> >
> > /*
> > --
> > 2.19.1
Acked-by: Todd Poynor <toddpoynor@google.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-24 19:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 19:29 [PATCH] staging: gasket: Remove return variable Nishka Dasgupta
2019-03-19 19:54 ` [Outreachy kernel] " Julia Lawall
2019-03-24 19:31 ` Todd Poynor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.