All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] [PATCH] usb_modeswitch: upgrade to 1.2.3
@ 2012-02-09 23:42 J.C. Woltz
  2012-02-10  7:29 ` Thomas De Schampheleire
  2012-02-11 16:30 ` Arnout Vandecappelle
  0 siblings, 2 replies; 6+ messages in thread
From: J.C. Woltz @ 2012-02-09 23:42 UTC (permalink / raw)
  To: buildroot

From: "J.C. Woltz" <jwoltz@gmail.com>

Signed-off-by: J.C. Woltz <jwoltz@gmail.com>
---
 package/usb_modeswitch/Config.in                   |    1 +
 .../usb_modeswitch/usb_modeswitch-makefile.patch   |   39 +++++++++-----------
 package/usb_modeswitch/usb_modeswitch.mk           |   10 +++---
 3 files changed, 24 insertions(+), 26 deletions(-)

diff --git a/package/usb_modeswitch/Config.in b/package/usb_modeswitch/Config.in
index ae10a55..1228293 100644
--- a/package/usb_modeswitch/Config.in
+++ b/package/usb_modeswitch/Config.in
@@ -7,3 +7,4 @@ config BR2_PACKAGE_USB_MODESWITCH
 	  Used to switch mode on multiple-function devices
 
 	  http://www.draisberghof.de/usb_modeswitch/
+
diff --git a/package/usb_modeswitch/usb_modeswitch-makefile.patch b/package/usb_modeswitch/usb_modeswitch-makefile.patch
index 918200b..1c4715c 100644
--- a/package/usb_modeswitch/usb_modeswitch-makefile.patch
+++ b/package/usb_modeswitch/usb_modeswitch-makefile.patch
@@ -1,23 +1,20 @@
-diff -Nura usb-modeswitch-1.1.2.orig/Makefile usb-modeswitch-1.1.2/Makefile
---- usb-modeswitch-1.1.2.orig/Makefile	2010-04-17 15:27:11.000000000 -0300
-+++ usb-modeswitch-1.1.2/Makefile	2010-04-22 15:05:32.363471807 -0300
-@@ -1,6 +1,6 @@
- PROG        = usb_modeswitch
- VERS        = 1.1.2
--CC          = gcc
-+CC          ?= gcc
- CFLAGS      += -Wall -l usb
- RM          = /bin/rm -f
- OBJS        = usb_modeswitch.c
-@@ -23,8 +23,9 @@
- install: all
- 	install -d $(SBINDIR)
- 	install --mode=755 usb_modeswitch $(SBINDIR)/usb_modeswitch
--	install --mode=755 usb_modeswitch.tcl $(UDEVDIR)/usb_modeswitch
--	install --mode=644 usb_modeswitch.conf $(ETCDIR)/usb_modeswitch.conf
-+	#install --mode=755 usb_modeswitch.tcl $(UDEVDIR)/usb_modeswitch
-+	#install --mode=644 usb_modeswitch.conf $(ETCDIR)/usb_modeswitch.conf
-+	install -d $(MANDIR)
- 	install --mode=644 usb_modeswitch.1 $(MANDIR)/usb_modeswitch.1
+--- usb_modeswitch-1.2.3.orig/Makefile.orig	2012-02-06 14:00:15.000000000 -0500
++++ usb_modeswitch-1.2.3/Makefile	2012-02-06 14:01:13.000000000 -0500
+@@ -46,7 +46,7 @@
+ 	cd jim && $(MAKE) distclean
  
+ install-common:
+-	install -D -s --mode=755 usb_modeswitch $(SBINDIR)/usb_modeswitch
++	install -D --mode=755 usb_modeswitch $(SBINDIR)/usb_modeswitch
+ 	install -D --mode=755 usb_modeswitch.sh $(UDEVDIR)/usb_modeswitch
+ 	install -D --mode=644 usb_modeswitch.conf $(ETCDIR)/usb_modeswitch.conf
+ 	install -D --mode=644 usb_modeswitch.1 $(MANDIR)/usb_modeswitch.1
+@@ -65,7 +65,7 @@
+ 	install -D --mode=755 usb_modeswitch_dispatcher $(SBINDIR)/usb_modeswitch_dispatcher
+ 
+ install-binary:
+-	install -D -s --mode=755 usb_modeswitch_dispatcher $(SBINDIR)/usb_modeswitch_dispatcher
++	install -D --mode=755 usb_modeswitch_dispatcher $(SBINDIR)/usb_modeswitch_dispatcher
+ 
+ install: all install-common install-script
  
diff --git a/package/usb_modeswitch/usb_modeswitch.mk b/package/usb_modeswitch/usb_modeswitch.mk
index 7b982d8..3d03888 100644
--- a/package/usb_modeswitch/usb_modeswitch.mk
+++ b/package/usb_modeswitch/usb_modeswitch.mk
@@ -4,22 +4,22 @@
 #
 #############################################################
 
-USB_MODESWITCH_VERSION = 1.1.2
+USB_MODESWITCH_VERSION = 1.2.3
 USB_MODESWITCH_SOURCE = usb-modeswitch-$(USB_MODESWITCH_VERSION).tar.bz2
 USB_MODESWITCH_SITE = http://www.draisberghof.de/usb_modeswitch
 USB_MODESWITCH_DEPENDENCIES = libusb-compat
 
 define USB_MODESWITCH_BUILD_CMDS
-	$(TARGET_CONFIGURE_OPTS) $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
+	$(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D)
 endef
 
 define USB_MODESWITCH_INSTALL_TARGET_CMDS
-	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
-	$(INSTALL) -D $(@D)/usb_modeswitch.setup -m 0644 \
-		$(TARGET_DIR)/etc/usb_modeswitch.setup
+	$(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
 endef
 
+
 define USB_MODESWITCH_CLEAN_CMDS
+	$(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) clean
 	rm -f $(TARGET_DIR)/usr/sbin/usb_modeswitch
 	rm -f $(TARGET_DIR)/etc/usb_modeswitch.setup
 	rm -f $(TARGET_DIR)/usr/share/man/man1/usb_modeswitch.1
-- 
1.7.5.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] [PATCH] usb_modeswitch: upgrade to 1.2.3
  2012-02-09 23:42 [Buildroot] [PATCH] [PATCH] usb_modeswitch: upgrade to 1.2.3 J.C. Woltz
@ 2012-02-10  7:29 ` Thomas De Schampheleire
  2012-02-10 14:28   ` J.C. Woltz
  2012-02-11 16:30 ` Arnout Vandecappelle
  1 sibling, 1 reply; 6+ messages in thread
From: Thomas De Schampheleire @ 2012-02-10  7:29 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri, Feb 10, 2012 at 12:42 AM, J.C. Woltz <jwoltz@gmail.com> wrote:
> From: "J.C. Woltz" <jwoltz@gmail.com>
>
> Signed-off-by: J.C. Woltz <jwoltz@gmail.com>

You shouldn't include a From: line. The Signed-off-by: is the one that
should be present.


> ---
> ?package/usb_modeswitch/Config.in ? ? ? ? ? ? ? ? ? | ? ?1 +
> ?.../usb_modeswitch/usb_modeswitch-makefile.patch ? | ? 39 +++++++++-----------
> ?package/usb_modeswitch/usb_modeswitch.mk ? ? ? ? ? | ? 10 +++---
> ?3 files changed, 24 insertions(+), 26 deletions(-)
>
> diff --git a/package/usb_modeswitch/Config.in b/package/usb_modeswitch/Config.in
> index ae10a55..1228293 100644
> --- a/package/usb_modeswitch/Config.in
> +++ b/package/usb_modeswitch/Config.in
> @@ -7,3 +7,4 @@ config BR2_PACKAGE_USB_MODESWITCH
> ? ? ? ? ?Used to switch mode on multiple-function devices
>
> ? ? ? ? ?http://www.draisberghof.de/usb_modeswitch/
> +

Why is this change needed? I think it should be removed from the patch.

> diff --git a/package/usb_modeswitch/usb_modeswitch-makefile.patch b/package/usb_modeswitch/usb_modeswitch-makefile.patch
> index 918200b..1c4715c 100644
> --- a/package/usb_modeswitch/usb_modeswitch-makefile.patch
> +++ b/package/usb_modeswitch/usb_modeswitch-makefile.patch
> @@ -1,23 +1,20 @@
> -diff -Nura usb-modeswitch-1.1.2.orig/Makefile usb-modeswitch-1.1.2/Makefile
> ---- usb-modeswitch-1.1.2.orig/Makefile 2010-04-17 15:27:11.000000000 -0300
> -+++ usb-modeswitch-1.1.2/Makefile ? ? ?2010-04-22 15:05:32.363471807 -0300
> -@@ -1,6 +1,6 @@
> - PROG ? ? ? ?= usb_modeswitch
> - VERS ? ? ? ?= 1.1.2
> --CC ? ? ? ? ?= gcc
> -+CC ? ? ? ? ??= gcc
> - CFLAGS ? ? ?+= -Wall -l usb
> - RM ? ? ? ? ?= /bin/rm -f
> - OBJS ? ? ? ?= usb_modeswitch.c
> -@@ -23,8 +23,9 @@
> - install: all
> - ? ? ? install -d $(SBINDIR)
> - ? ? ? install --mode=755 usb_modeswitch $(SBINDIR)/usb_modeswitch
> -- ? ? ?install --mode=755 usb_modeswitch.tcl $(UDEVDIR)/usb_modeswitch
> -- ? ? ?install --mode=644 usb_modeswitch.conf $(ETCDIR)/usb_modeswitch.conf
> -+ ? ? ?#install --mode=755 usb_modeswitch.tcl $(UDEVDIR)/usb_modeswitch
> -+ ? ? ?#install --mode=644 usb_modeswitch.conf $(ETCDIR)/usb_modeswitch.conf
> -+ ? ? ?install -d $(MANDIR)
> - ? ? ? install --mode=644 usb_modeswitch.1 $(MANDIR)/usb_modeswitch.1
> +--- usb_modeswitch-1.2.3.orig/Makefile.orig ? ?2012-02-06 14:00:15.000000000 -0500
> ++++ usb_modeswitch-1.2.3/Makefile ? ? ?2012-02-06 14:01:13.000000000 -0500
> +@@ -46,7 +46,7 @@
> + ? ? ? cd jim && $(MAKE) distclean
>
> + install-common:
> +- ? ? ?install -D -s --mode=755 usb_modeswitch $(SBINDIR)/usb_modeswitch
> ++ ? ? ?install -D --mode=755 usb_modeswitch $(SBINDIR)/usb_modeswitch
> + ? ? ? install -D --mode=755 usb_modeswitch.sh $(UDEVDIR)/usb_modeswitch
> + ? ? ? install -D --mode=644 usb_modeswitch.conf $(ETCDIR)/usb_modeswitch.conf
> + ? ? ? install -D --mode=644 usb_modeswitch.1 $(MANDIR)/usb_modeswitch.1
> +@@ -65,7 +65,7 @@
> + ? ? ? install -D --mode=755 usb_modeswitch_dispatcher $(SBINDIR)/usb_modeswitch_dispatcher
> +
> + install-binary:
> +- ? ? ?install -D -s --mode=755 usb_modeswitch_dispatcher $(SBINDIR)/usb_modeswitch_dispatcher
> ++ ? ? ?install -D --mode=755 usb_modeswitch_dispatcher $(SBINDIR)/usb_modeswitch_dispatcher
> +
> + install: all install-common install-script
>
> diff --git a/package/usb_modeswitch/usb_modeswitch.mk b/package/usb_modeswitch/usb_modeswitch.mk
> index 7b982d8..3d03888 100644
> --- a/package/usb_modeswitch/usb_modeswitch.mk
> +++ b/package/usb_modeswitch/usb_modeswitch.mk
> @@ -4,22 +4,22 @@
> ?#
> ?#############################################################
>
> -USB_MODESWITCH_VERSION = 1.1.2
> +USB_MODESWITCH_VERSION = 1.2.3
> ?USB_MODESWITCH_SOURCE = usb-modeswitch-$(USB_MODESWITCH_VERSION).tar.bz2
> ?USB_MODESWITCH_SITE = http://www.draisberghof.de/usb_modeswitch
> ?USB_MODESWITCH_DEPENDENCIES = libusb-compat
>
> ?define USB_MODESWITCH_BUILD_CMDS
> - ? ? ? $(TARGET_CONFIGURE_OPTS) $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
> + ? ? ? $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D)
> ?endef

Is there a particular reason why you changed this?

And to other buildroot developers: what is the policy regarding
directly specifying CC and LD, instead of using variables like
TARGET_CONFIGURE_OPTS ?

>
> ?define USB_MODESWITCH_INSTALL_TARGET_CMDS
> - ? ? ? $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
> - ? ? ? $(INSTALL) -D $(@D)/usb_modeswitch.setup -m 0644 \
> - ? ? ? ? ? ? ? $(TARGET_DIR)/etc/usb_modeswitch.setup
> + ? ? ? $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
> ?endef
>
> +
> ?define USB_MODESWITCH_CLEAN_CMDS
> + ? ? ? $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) clean
> ? ? ? ?rm -f $(TARGET_DIR)/usr/sbin/usb_modeswitch
> ? ? ? ?rm -f $(TARGET_DIR)/etc/usb_modeswitch.setup
> ? ? ? ?rm -f $(TARGET_DIR)/usr/share/man/man1/usb_modeswitch.1
> --

Best regards,
Thomas

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] [PATCH] usb_modeswitch: upgrade to 1.2.3
  2012-02-10  7:29 ` Thomas De Schampheleire
@ 2012-02-10 14:28   ` J.C. Woltz
  2012-02-10 16:41     ` Thomas De Schampheleire
  0 siblings, 1 reply; 6+ messages in thread
From: J.C. Woltz @ 2012-02-10 14:28 UTC (permalink / raw)
  To: buildroot

On Fri, Feb 10, 2012 at 2:29 AM, Thomas De Schampheleire <
patrickdepinguin+buildroot@gmail.com> wrote:

> Hello,
>
> On Fri, Feb 10, 2012 at 12:42 AM, J.C. Woltz <jwoltz@gmail.com> wrote:
> > From: "J.C. Woltz" <jwoltz@gmail.com>
> >
> > Signed-off-by: J.C. Woltz <jwoltz@gmail.com>
>
> You shouldn't include a From: line. The Signed-off-by: is the one that
> should be present.
>
>
Will fix.


>
> > --- a/package/usb_modeswitch/Config.in
> > +++ b/package/usb_modeswitch/Config.in
> > @@ -7,3 +7,4 @@ config BR2_PACKAGE_USB_MODESWITCH
> >          Used to switch mode on multiple-function devices
> >
> >          http://www.draisberghof.de/usb_modeswitch/
> > +
>
> Why is this change needed? I think it should be removed from the patch.
>
> Will remove, accidental change.


> > diff --git a/package/usb_modeswitch/usb_modeswitch.mkb/package/usb_modeswitch/
> usb_modeswitch.mk
> > index 7b982d8..3d03888 100644
> > --- a/package/usb_modeswitch/usb_modeswitch.mk
> > +++ b/package/usb_modeswitch/usb_modeswitch.mk
> > @@ -4,22 +4,22 @@
> >  #
> >  #############################################################
> >
> > -USB_MODESWITCH_VERSION = 1.1.2
> > +USB_MODESWITCH_VERSION = 1.2.3
> >  USB_MODESWITCH_SOURCE = usb-modeswitch-$(USB_MODESWITCH_VERSION).tar.bz2
> >  USB_MODESWITCH_SITE = http://www.draisberghof.de/usb_modeswitch
> >  USB_MODESWITCH_DEPENDENCIES = libusb-compat
> >
> >  define USB_MODESWITCH_BUILD_CMDS
> > -       $(TARGET_CONFIGURE_OPTS) $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
> > +       $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D)
> >  endef
>
> Is there a particular reason why you changed this?
>
> And to other buildroot developers: what is the policy regarding
> directly specifying CC and LD, instead of using variables like
> TARGET_CONFIGURE_OPTS ?
>
>
Yes, I changed that line since usb_modeswitch would not compile. I was
following the example from:
http://buildroot.uclibc.org/buildroot.html#generic-tutorial

Please let me know how or what you want changed, and I will re-submit.

Thank you,
J.C. Woltz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120210/a21eecc3/attachment.html>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] [PATCH] usb_modeswitch: upgrade to 1.2.3
  2012-02-10 14:28   ` J.C. Woltz
@ 2012-02-10 16:41     ` Thomas De Schampheleire
  2012-02-11 16:24       ` Arnout Vandecappelle
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas De Schampheleire @ 2012-02-10 16:41 UTC (permalink / raw)
  To: buildroot

On Fri, Feb 10, 2012 at 3:28 PM, J.C. Woltz <jwoltz@gmail.com> wrote:
>
> On Fri, Feb 10, 2012 at 2:29 AM, Thomas De Schampheleire
> <patrickdepinguin+buildroot@gmail.com> wrote:
>>
>> Hello,
>>
>> On Fri, Feb 10, 2012 at 12:42 AM, J.C. Woltz <jwoltz@gmail.com> wrote:
>> > From: "J.C. Woltz" <jwoltz@gmail.com>
>> >
>> > Signed-off-by: J.C. Woltz <jwoltz@gmail.com>
>>
>> You shouldn't include a From: line. The Signed-off-by: is the one that
>> should be present.
>>
>
> Will fix.
>
>>
>>
>> > --- a/package/usb_modeswitch/Config.in
>> > +++ b/package/usb_modeswitch/Config.in
>> > @@ -7,3 +7,4 @@ config BR2_PACKAGE_USB_MODESWITCH
>> > ? ? ? ? ?Used to switch mode on multiple-function devices
>> >
>> > ? ? ? ? ?http://www.draisberghof.de/usb_modeswitch/
>> > +
>>
>> Why is this change needed? I think it should be removed from the patch.
>>
> Will remove, accidental change.
>
>>
>> > diff --git a/package/usb_modeswitch/usb_modeswitch.mk
>> > b/package/usb_modeswitch/usb_modeswitch.mk
>> > index 7b982d8..3d03888 100644
>> > --- a/package/usb_modeswitch/usb_modeswitch.mk
>> > +++ b/package/usb_modeswitch/usb_modeswitch.mk
>> > @@ -4,22 +4,22 @@
>> > ?#
>> > ?#############################################################
>> >
>> > -USB_MODESWITCH_VERSION = 1.1.2
>> > +USB_MODESWITCH_VERSION = 1.2.3
>> > ?USB_MODESWITCH_SOURCE =
>> > usb-modeswitch-$(USB_MODESWITCH_VERSION).tar.bz2
>> > ?USB_MODESWITCH_SITE = http://www.draisberghof.de/usb_modeswitch
>> > ?USB_MODESWITCH_DEPENDENCIES = libusb-compat
>> >
>> > ?define USB_MODESWITCH_BUILD_CMDS
>> > - ? ? ? $(TARGET_CONFIGURE_OPTS) $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
>> > + ? ? ? $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D)
>> > ?endef
>>
>> Is there a particular reason why you changed this?
>>
>> And to other buildroot developers: what is the policy regarding
>> directly specifying CC and LD, instead of using variables like
>> TARGET_CONFIGURE_OPTS ?
>>
>
> Yes, I changed that line since usb_modeswitch would not compile. I was
> following the example from:
> http://buildroot.uclibc.org/buildroot.html#generic-tutorial
>
> Please let me know how or what you want changed, and I will re-submit.

I checked and this is caused because your Makefile patch removed the
CC ?= gcc
change.

Personally I don't mind your solution, as it is one less change to the
Makefile.
For me, you don't need to change it.

Best regards,
Thomas

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] [PATCH] usb_modeswitch: upgrade to 1.2.3
  2012-02-10 16:41     ` Thomas De Schampheleire
@ 2012-02-11 16:24       ` Arnout Vandecappelle
  0 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2012-02-11 16:24 UTC (permalink / raw)
  To: buildroot

On Friday 10 February 2012 17:41:04 Thomas De Schampheleire wrote:
> >> Is there a particular reason why you changed this?
> >>
> >> And to other buildroot developers: what is the policy regarding
> >> directly specifying CC and LD, instead of using variables like
> >> TARGET_CONFIGURE_OPTS ?
> >>
> >
> > Yes, I changed that line since usb_modeswitch would not compile. I was
> > following the example from:
> > http://buildroot.uclibc.org/buildroot.html#generic-tutorial
> >
> > Please let me know how or what you want changed, and I will re-submit.
> 
> I checked and this is caused because your Makefile patch removed the
> CC ?= gcc
> change.
> 
> Personally I don't mind your solution, as it is one less change to the
> Makefile.
> For me, you don't need to change it.

 J.C.'s solution is preferred, I would say.

- It doesn't require patching.

- It's how it is documented.

- TARGET_CONFIGURE_OPTIONS is meant for autoconf.

- This will be the way that the MAKETARGETS infrastructure will be 
implemented.


 Regards,
 Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] [PATCH] usb_modeswitch: upgrade to 1.2.3
  2012-02-09 23:42 [Buildroot] [PATCH] [PATCH] usb_modeswitch: upgrade to 1.2.3 J.C. Woltz
  2012-02-10  7:29 ` Thomas De Schampheleire
@ 2012-02-11 16:30 ` Arnout Vandecappelle
  1 sibling, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2012-02-11 16:30 UTC (permalink / raw)
  To: buildroot

On Friday 10 February 2012 00:42:36 J.C. Woltz wrote:
>  define USB_MODESWITCH_BUILD_CMDS
> -       $(TARGET_CONFIGURE_OPTS) $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
> +       $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D)
>  endef

 Don't remove TARGET_MAKE_ENV.  The CC= is good, however.

>  
>  define USB_MODESWITCH_INSTALL_TARGET_CMDS
> -       $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
> -       $(INSTALL) -D $(@D)/usb_modeswitch.setup -m 0644 \
> -               $(TARGET_DIR)/etc/usb_modeswitch.setup
> +       $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
>  endef

 Same here.


> +

 Redundant whitespace.

>  define USB_MODESWITCH_CLEAN_CMDS
> +       $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) clean
>         rm -f $(TARGET_DIR)/usr/sbin/usb_modeswitch
>         rm -f $(TARGET_DIR)/etc/usb_modeswitch.setup
>         rm -f $(TARGET_DIR)/usr/share/man/man1/usb_modeswitch.1

 Actually, the rm -f lines should be in UNINSTALL_CMDS.  And should use 
$(RM) instead of rm -f.


 Regards,
 Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-11 16:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-09 23:42 [Buildroot] [PATCH] [PATCH] usb_modeswitch: upgrade to 1.2.3 J.C. Woltz
2012-02-10  7:29 ` Thomas De Schampheleire
2012-02-10 14:28   ` J.C. Woltz
2012-02-10 16:41     ` Thomas De Schampheleire
2012-02-11 16:24       ` Arnout Vandecappelle
2012-02-11 16:30 ` Arnout Vandecappelle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.